Italo Nicola
cefa2e27da
pan/mdg: remove register prefixes
...
Signed-off-by: Italo Nicola <italonicola@collabora.com >
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9461 >
2021-04-27 07:04:08 +00:00
Italo Nicola
0ef3efb7fa
pan/mdg: improve mask decoding
...
Signed-off-by: Italo Nicola <italonicola@collabora.com >
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9461 >
2021-04-27 07:04:07 +00:00
Italo Nicola
7abeee1eff
pan/mdg: fix midgard.h indentation
...
Signed-off-by: Italo Nicola <italonicola@collabora.com >
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9461 >
2021-04-27 07:04:07 +00:00
Italo Nicola
cb7527a9ef
pan/mdg: stop using size disambiguation suffixes
...
Signed-off-by: Italo Nicola <italonicola@collabora.com >
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9461 >
2021-04-27 07:04:07 +00:00
Italo Nicola
ce445c0e47
pan/mdg: print input data type for ALU opcodes
...
Signed-off-by: Italo Nicola <italonicola@collabora.com >
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9461 >
2021-04-27 07:04:07 +00:00
Italo Nicola
5d8301977b
pan/mdg: stop querying datatype by reading opcode name
...
Signed-off-by: Italo Nicola <italonicola@collabora.com >
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9461 >
2021-04-27 07:04:07 +00:00
Italo Nicola
fdae70b807
pan/mdg: fix/change ALU opcodes descriptions and add some missing ops
...
Signed-off-by: Italo Nicola <italonicola@collabora.com >
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9461 >
2021-04-27 07:04:07 +00:00
Italo Nicola
94c03264d8
pan/mdg: improve swizzle decoding
...
Signed-off-by: Italo Nicola <italonicola@collabora.com >
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9461 >
2021-04-27 07:04:07 +00:00
Italo Nicola
7f0bf3d82d
pan/mdg: improve input modifier printing
...
Signed-off-by: Italo Nicola <italonicola@collabora.com >
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9461 >
2021-04-27 07:04:07 +00:00
Italo Nicola
baea01816a
pan/mdg: add midgard_src_expand_mode validation
...
Signed-off-by: Italo Nicola <italonicola@collabora.com >
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9461 >
2021-04-27 07:04:07 +00:00
Italo Nicola
b6c7da98be
pan/mdg: encode/decode expand_mode properly
...
Signed-off-by: Italo Nicola <italonicola@collabora.com >
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9461 >
2021-04-27 07:04:07 +00:00
Italo Nicola
f8a8dc1645
pan/mdg: add proper expand_mode enum
...
Signed-off-by: Italo Nicola <italonicola@collabora.com >
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9461 >
2021-04-27 07:04:07 +00:00
Italo Nicola
77e05b6a86
pan/mdg: refactor mir_pack_swizzle
...
This commit makes mir_pack_swizzle set rep_low, rep_high and half in a
more explicit way, helping in the transition to a unified expand_mode
enum in the following commit.
Signed-off-by: Italo Nicola <italonicola@collabora.com >
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9461 >
2021-04-27 07:04:07 +00:00
Italo Nicola
ea3115027e
pan/mdg: improve outmod printing
...
Signed-off-by: Italo Nicola <italonicola@collabora.com >
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9461 >
2021-04-27 07:04:07 +00:00
Italo Nicola
4cc7f2d84e
pan/mdg: rename dest_override to shrink_mode
...
Signed-off-by: Italo Nicola <italonicola@collabora.com >
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9461 >
2021-04-27 07:04:07 +00:00
Italo Nicola
eddb2a8988
pan/mdg: clean up redundant/unused variables in disassemble.c
...
Signed-off-by: Italo Nicola <italonicola@collabora.com >
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9461 >
2021-04-27 07:04:07 +00:00
Italo Nicola
8074a040e7
util: add util_sign_extend
...
This code is taken from src/freedreno/isa/decode.c.
Since we need a similar function in panfrost, it's probably good to move
it to utils.
Signed-off-by: Italo Nicola <italonicola@collabora.com >
Acked-by: Rob Clark <robclark@freedesktop.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9461 >
2021-04-27 07:04:07 +00:00
Samuel Pitoiset
a854a9fa62
radv: fix various CMASK regressions on GFX9
...
This fixes a bunch of MSAA related CTS regressions. This restores
previous behaviour on GFX9 but it should be fixed properly.
Cc: 21.1 mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10374 >
2021-04-27 06:51:26 +00:00
Iago Toral Quiroga
d636c5660c
v3dv: implement wsi hook to decide if we can present directly on device
...
This will prevent the driver to take the prime blit path for presentation
in scenarios where it can avoid it, which can substantially improve
performance, particularly at high resolutions.
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5917 >
2021-04-27 06:37:43 +00:00
Iago Toral Quiroga
0c0c1418ae
vulkan/wsi: give drivers the option to decide if they need to blit
...
Until now, the WSI code would rely on VK_EXT_pci_bus_info to check if the
WSI device matched the DRM device used for display. If they matched, then
it would allow direct presentation of the swapchain images, otherwise
it would fallback to a blit path through a linear buffer.
Unfortunately, this only works for PCI devices, so embedded GPUs would
always fail the test and fallback to the prime blit path, incurring in a
performance penalty due to the extra blit.
With this change driver backends have the possibility to attach a
callback to the WSI device to take control over that decision and have
freedom to make that choice according to their own platform particularities.
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5917 >
2021-04-27 06:37:43 +00:00
Tapani Pälli
e1f3770a5c
glx: fix compilation error when function name not found
...
Patch workarounds the problem like commit eec904d29c did, this fixes
compilation on older distributions that still use old header.
Fixes: 01ba8a8d02 ("glx: Implement GLX_EXT_no_config_context")
Signed-off-by: Tapani Pälli <tapani.palli@intel.com >
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10447 >
2021-04-27 06:06:56 +00:00
Corentin Noël
d42d7e0df4
ci: Use the caching proxy for Mesa artifacts
...
Allows to reduce the load and latency when getting artifacts.
Signed-off-by: Corentin Noël <corentin.noel@collabora.com >
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10285 >
2021-04-27 07:11:37 +02:00
Enrico Galli
3a3ab2f8ee
microsoft/compiler: zero out unused WebGPU system values
...
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10439 >
2021-04-27 01:53:16 +00:00
Yiwei Zhang
95844b0978
venus: use VK_EXT_image_drm_format_modifier
...
This commit contains a hack to retrieve extended buffer info, which will
be fixed by moving the logic into gralloc HAL implementation.
With this hack, the rendering result is correct.
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org >
Reviewed-by: Chia-I Wu <olvaffe@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10259 >
2021-04-27 00:15:39 +00:00
Yiwei Zhang
34f37fb780
venus: implement VK_ANDROID_native_buffer v7
...
1. Android native buffer import
2. vkGetSwapchainGrallocUsage2ANDROID
3. vkAcquireImageANDROID
4. vkQueueSignalReleaseImageANDROID
5. not advertise shared presentable image support
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org >
Reviewed-by: Chia-I Wu <olvaffe@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10259 >
2021-04-27 00:15:39 +00:00
Yiwei Zhang
c79909779a
venus: update venus-protocol headers
...
1. hide git hash from most generated files
2. fix VkImportMemoryResourceInfoMESA definition
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org >
Reviewed-by: Chia-I Wu <olvaffe@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10259 >
2021-04-27 00:15:39 +00:00
Yiwei Zhang
282e2c9496
venus: set bo->size to 0 for classic resource
...
bo->size is not used for classic resource since mapping is not allowed.
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org >
Reviewed-by: Chia-I Wu <olvaffe@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10259 >
2021-04-27 00:15:39 +00:00
Marek Olšák
6b18fcb38b
amd: addrlib update for April
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10445 >
2021-04-26 23:37:38 +00:00
Marek Olšák
804e292440
radeonsi: remove the separate DCC optimization for Stoney
...
This removes some complexity from the driver.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10343 >
2021-04-26 22:53:30 +00:00
Marek Olšák
1f8fa96412
radeonsi: make the gfx9 DCC MSAA clear shader depend on the number of samples
...
because different DCC equations are used.
Fixes: 3120113ee7 - radeonsi: implement DCC MSAA 4x/8x fast clear using DCC equations on gfx9
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10343 >
2021-04-26 22:53:30 +00:00
Marek Olšák
f3112c532b
ac/surface: document more meta equation dependencies
...
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10343 >
2021-04-26 22:53:30 +00:00
Mike Blumenkrantz
9712cd3186
zink: use non-atomic load/store ops if intrinsic is not actually coherent
...
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10475 >
2021-04-26 18:04:30 -04:00
Mike Blumenkrantz
c8dfed0c12
nir/gl_lower_buffers: set access for ssbo load/store instrs
...
this is the last place where the information is available, so set the info before
it gets lost
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10074 >
2021-04-26 21:31:44 +00:00
Mauro Rossi
a02328395d
android: amd/common: add nir include path
...
$(MESA_TOP)/src/compiler/nir include path is added
for both clarity and build errors preventive reasons
Cc: 21.0 21.1 <mesa-stable@lists.freedesktop.org >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10443 >
2021-04-26 23:14:56 +02:00
Mauro Rossi
e213bfd330
android: gallium/radeonsi: add nir include path
...
Since generated nir headers are included, it makes sense to include nir path
Fixes the following building error:
FAILED: out/target/product/x86_64/obj/STATIC_LIBRARIES/libmesa_pipe_radeonsi_intermediates/si_shader_nir.o
...
In file included from external/mesa/src/gallium/drivers/radeonsi/si_shader_nir.c:26:
external/mesa/src/amd/common/ac_nir.h:29:10: fatal error: 'nir.h' file not found
^~~~~~~
1 error generated.
Cc: 21.0 21.1 <mesa-stable@lists.freedesktop.org >
Fixes: 1c702a8239 ("ac: move ac_lower_indirect_derefs() outside of the LLVM dir")
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10443 >
2021-04-26 23:14:52 +02:00
Mike Blumenkrantz
7888ef8c48
zink: update docs
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10458 >
2021-04-26 20:19:48 +00:00
Mike Blumenkrantz
cd4637cf1f
zink: ci updates
...
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10458 >
2021-04-26 20:19:48 +00:00
Mike Blumenkrantz
bee38fba1b
zink: implement VK_EXT_provoking_vertex
...
this only needs to be set if the mode is LAST, otherwise the normal
pipeline state can be used and this one can be omitted
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10458 >
2021-04-26 20:19:48 +00:00
Mike Blumenkrantz
78232665db
zink: hook up VK_EXT_provoking_vertex
...
ideally we would want to require transformFeedbackPreservesTriangleFanProvokingVertex,
but as there is no fallback path, any amount of provoking vertex support
is still better than none, so tests related to this will continue to fail
for that hardware (intel)
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10458 >
2021-04-26 20:19:48 +00:00
Mike Blumenkrantz
0e439541a5
lavapipe: implement VK_EXT_provoking_vertex
...
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10458 >
2021-04-26 20:19:48 +00:00
Keith Packard
a60767ec26
vulkan/x11: Mark present complete using serial instead of MSC
...
Present operations do not necessarily complete after the requested
time; if the CRTC has been blanked, they will complete
immediately. This means we cannot use the MSC value to tell when a
present has finished.
Instead of using MSC, track whether each present is complete by serial
number, which is the low 32-bits of the SBC value. This value is
provided in the present_pixmap request and returned in the present
complete notify event.
Signed-off-by: Keith Packard <keithp@keithp.com >
Reviewed-by: Michel Dänzer <mdaenzer@redhat.com >
Reviewed-by: Adam Jackson <ajax@redhat.com >
2021-04-26 11:55:46 -07:00
Gert Wollny
ad853fc0e1
r600: update pipe_draw_info::restart_index only when primitive_restart is enabled
...
This avoids the use of uninitialized memory:
Conditional jump or move depends on uninitialised value(s)
at 0x5EDBF87: r600_draw_vbo (r600_state_common.c:2232)
by 0x5DEFA00: u_vbuf_draw_vbo (u_vbuf.c:1329)
by 0x5D990EF: cso_multi_draw (cso_context.c:1445)
by 0x59B7EF4: _mesa_draw_arrays (draw.c:1346)
Signed-off-by: Gert Wollny <gert.wollny@collabora.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10442 >
2021-04-26 17:32:20 +00:00
Gert Wollny
d42c9e4787
virgl: use pipe_draw_info::restart_index only when primitive_restart is enabled
...
Closes #5651
Signed-off-by: Gert Wollny <gert.wollny@collabora.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Reviewed-by: Chia-I Wu <olvaffe@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10442 >
2021-04-26 17:32:20 +00:00
Connor Abbott
a07ab4f914
freedreno: Don't lower indirects in GLSL IR
...
nir_lower_io_to_temporaries should generate better code.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7274 >
2021-04-26 17:07:02 +00:00
Connor Abbott
643f2cb8a3
ir3, tu: Cleanup indirect i/o lowering
...
Do all the necessary lowering in one place, during finalization, and
stop uselessly calling nir_lower_indirect_derefs in turnip. Splitting
i/o to elements should no longer be necessary since we use the i/o
semantics instead of variables now.
This has the side effect that we no longer generate enormous if-ladders
for tess/GS shaders with turnip.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7274 >
2021-04-26 17:07:02 +00:00
Connor Abbott
77fcb01f7f
nir/lower_clip_disable: Fix store writemask
...
We're storing into the array element, not the whole variable.
Fixes: fb2fe80 ("nir: add lowering pass for clip plane enabling")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7274 >
2021-04-26 17:07:02 +00:00
Connor Abbott
decfea2f4e
ir3: Prevent oob writes to inputs/outputs array
...
Don't setup inputs and outputs if we aren't using
load_input/store_output intrinsics. While it's mostly harmless, there
may be more outputs than expected which would lead to an oob write of
the outputs array when setting the register id to INVALID_REG.
Also be more paranoid with asserts to catch this.
Fixes: a6291b1 ("freedreno/ir3: rework setup_{input,output} to make struct varyings work")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7274 >
2021-04-26 17:07:02 +00:00
Erik Faye-Lund
b2b8b6c0e3
zink: enable required instance ext
...
VK_KHR_swapchain requires VK_KHR_surface in the instance to be enabled.
This fixes a validation-error.
Fixes: bbeee415ee ("zink: Learn about VK_KHR_swapchain")
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10461 >
2021-04-26 16:56:40 +00:00
Erik Faye-Lund
72eca47c66
docs: someome -> someone
...
A typo in the section about choice of language is a bit funny, but
let's fix it anyway ;)
Thanks to Ilia Mirkin for pointing this out.
Reviewed-by: Ilia Mirkin <imirkin@alum.mit.edu >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10464 >
2021-04-26 18:08:29 +02:00
Jason Ekstrand
3c8ac6a129
anv: Implement VK_EXT_provoking_vertex
...
Tested-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10460 >
2021-04-26 15:13:19 +00:00