Alyssa Rosenzweig
cdb4463b52
asahi,hk: fix ts allocation for more shader types
...
3c5c3d7819 ("hk: fix texture state count"), part 2.
Backport-to: 25.1
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Reviewed-by: Mary Guillemard <mary.guillemard@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35662 >
2025-06-20 21:38:10 +00:00
Marek Olšák
d4b742f934
radeonsi: fix printing asm for the first shader of merged shaders for ACO
...
When we print asm for merged VS+TCS, we need to record asm for VS
even when only TCS is being printed because they are printed together.
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35620 >
2025-06-20 21:21:27 +00:00
Marek Olšák
23c3646164
radeonsi: fix tess regression with latest LLVM git
...
The problem was that SGPRs returned from LS were treated as VGPRs by LLVM
because LS executes conditionally. The workaround is to use input SGPRs
initialized by the hw (i.e. parameters of the wrapper function) instead of
the ones returned by LS.
Fixes: 80236f2367 - ac/nir/tess: add if/endif for HS threads in NIR instead of ACO/LLVM
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35620 >
2025-06-20 21:21:27 +00:00
Eric Engestrom
b3ed7f7b63
radeonsi/ci: reduce coverage of radeonsi-vangogh-glcts
...
It currently takes 15min of test run time, which is higher than what
a merge-pipeline test is allowed.
Reduce it to 10min, and reduce the timeouts which were way too high.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35588 >
2025-06-20 20:24:59 +00:00
Eric Engestrom
fb8c2a6318
turnip/ci: document vkd3d regression
...
It started failing after a commit in the 2782fa2c...df55ea8c range.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35661 >
2025-06-20 20:08:57 +00:00
Emma Anholt
e9d75ce16b
ci/tu: Sync up a660's flakes with a618 where they seem to match up.
...
and generalize a couple more things into regexes. I noticed these after
enabling 660 flake reporting and starting to see them roll in on the CI
channel.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35659 >
2025-06-20 19:46:45 +00:00
Emma Anholt
8e22420187
ci/tu: Don't forget to report flakes on a660, too.
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35659 >
2025-06-20 19:46:45 +00:00
Emma Anholt
2919d64d98
ci/tu: Add some recent flakes and consolidate lists into regexes.
...
I was going to stability test an MR, and for that I want the flakes list
to be truthful.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35659 >
2025-06-20 19:46:45 +00:00
Eric Engestrom
6addaca3d4
hasvk: only run tests on x86 (32 & 64 bit)
...
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/13305
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35635 >
2025-06-20 19:32:18 +00:00
Danylo Piliaiev
9db945c3be
tu: Add info about usage to command buffers tracepoint
...
Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35637 >
2025-06-20 19:15:44 +00:00
Danylo Piliaiev
9f74fcffe4
tu: Add MESA_TRACE_FUNC to submit and BO alloc paths
...
Makes much easier to see how slow are submits and BO allocs,
which sometimes happen together.
Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35637 >
2025-06-20 19:15:44 +00:00
Danylo Piliaiev
6e5944ec4b
tu: Cache copy timestamp cs to avoid allocations on submit
...
For non-ONE_TIME_SUBMIT command buffers we have to create CS that
copies u_trace timestamps. Having cs pool allows us to avoid
allocations in most cases.
Together with previous commit, BO allocations on submit would be
rare during normal u_trace tracing.
Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35637 >
2025-06-20 19:15:44 +00:00
Danylo Piliaiev
a1b9aa3385
tu: Suballocate u_trace buffers to avoid allocations on submit
...
For non-ONE_TIME_SUBMIT command buffers we have to copy tracepoints
which leads to BO allocations. That adds overhead we don't want,
especially when there are many tiny submissions.
While suballocator for u_trace BOs is allocated only when needed,
it's not deallocated afterwards, since the point where it's not needed
is tricky to determine.
Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35637 >
2025-06-20 19:15:44 +00:00
Alyssa Rosenzweig
8ec4337c1f
hk: drop psiz writes with !largePoints
...
affects geom/tess mostly.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35658 >
2025-06-20 18:46:16 +00:00
Alyssa Rosenzweig
691aa581c3
hk: optimize !largePoints
...
should slightly help proton
requires reordering the uvs lowering to be after tes lowering since that can
insert psiz writes.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35658 >
2025-06-20 18:46:16 +00:00
Alyssa Rosenzweig
9d7301b2d1
hk: disable custom border for proton
...
zoom.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35658 >
2025-06-20 18:46:16 +00:00
Alyssa Rosenzweig
ba4bab0584
hk: make border colour lint quieter
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35658 >
2025-06-20 18:46:16 +00:00
Alyssa Rosenzweig
81e005c18b
hk: don't give DXVK fake min/max
...
no games use this, we want to be demoted to fl11 for dxvk for perf anyway.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35658 >
2025-06-20 18:46:16 +00:00
Alyssa Rosenzweig
b68f34e1f9
hk: stop uploading blend constants
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35658 >
2025-06-20 18:46:15 +00:00
Alyssa Rosenzweig
34b8ef8f7e
hk: stop reserving pile of uniform regs for literally no reason
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35658 >
2025-06-20 18:46:15 +00:00
Alyssa Rosenzweig
8fb891334f
hk: make image heap / root uniform dynamic
...
so we don't have to worst case alloc without disrupting gl.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35658 >
2025-06-20 18:46:15 +00:00
Alyssa Rosenzweig
f64ba2d2dc
hk: don't advertise b4g4r4a4 format
...
it is optional and broken with opaque_black
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35658 >
2025-06-20 18:46:14 +00:00
Alyssa Rosenzweig
3afd675310
hk: use #defines for uniforms
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35658 >
2025-06-20 18:46:14 +00:00
Alyssa Rosenzweig
53bbd850f5
asahi: use #defines for uniforms
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35658 >
2025-06-20 18:46:14 +00:00
Alyssa Rosenzweig
c3b449ff98
asahi: use #defines for prologs/epilogs
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35658 >
2025-06-20 18:46:14 +00:00
Alyssa Rosenzweig
733dd3ba4e
asahi: clean up fs prolog pass
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35658 >
2025-06-20 18:46:14 +00:00
Alyssa Rosenzweig
c4b3f8cf74
agx: add headers for uniform abi
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35658 >
2025-06-20 18:46:14 +00:00
Alyssa Rosenzweig
5795c8595f
nir: model dynamic uniform layout on hk
...
add some new intrinsics so we can defer lowering until we have the information.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35658 >
2025-06-20 18:46:13 +00:00
Yiwei Zhang
7b81c5bb78
vulkan/android: clean up u_gralloc_get_buffer_color_info handling
...
Reviewed-by: Roman Stratiienko <r.stratiienko@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35613 >
2025-06-20 18:13:36 +00:00
Yiwei Zhang
072223c11d
egl/android: clean up u_gralloc_get_buffer_color_info handling
...
No longer need the defaults, and can properly bail on real errors. The
behavior change of chroma sitting has been mentioned in the prior
commit, and doesn't affect gallium side.
Reviewed-by: Roman Stratiienko <r.stratiienko@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35613 >
2025-06-20 18:13:36 +00:00
Yiwei Zhang
4b68ed990b
u_gralloc: assign default u_gralloc_buffer_color_info
...
Gralloc is the central piece to align defaults and expectations across
different APIs. Doing so simplifies client side handling. To be noted,
midpoint chroma location is preferred as the default to skip the chroma
lowering pass. The same has been suggested by all Vulkan drivers with
AHB implemented and practiced for years under venus.
Reviewed-by: Roman Stratiienko <r.stratiienko@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35613 >
2025-06-20 18:13:36 +00:00
Yiwei Zhang
64d18f84b0
u_gralloc/mapper4: fill u_gralloc_buffer_color_info properly
...
Clients are expecting the color info to be fully filled when the api
exists. Give proper defaults for the metadata to stay aligned with
legacy backends.
Also amend the missing ChromaSiting cases.
Fixes: ee42e2166d ("android: Introduce the Android buffer info abstraction")
Reviewed-by: Roman Stratiienko <r.stratiienko@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35613 >
2025-06-20 18:13:36 +00:00
Yiwei Zhang
0ac1e05f65
u_gralloc/mapper5: fill u_gralloc_buffer_color_info properly
...
Clients are expecting the color info to be fully filled when the api
exists. Give proper defaults for the metadata to stay aligned with
legacy backends.
Fixes: 122fd46b15 ("Android15 support gralloc IMapper5")
Reviewed-by: Roman Stratiienko <r.stratiienko@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35613 >
2025-06-20 18:13:36 +00:00
Karol Herbst
de1ce0f75e
rusticl: allow packagers to enable freedreno by default
...
The msm driver hasn't yet passed conformance, so it's not part of the
auto set at this point in time. But this will allow distribution to
enable it by default, if they find it suitable.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35618 >
2025-06-20 17:46:32 +00:00
Job Noorman
bc10c812d6
ir3/legalize: apply initial GS/TCS sync in legalize
...
When applying the sync flags after legalize, we might run into the issue
of the first instruction not supporting (ss)/(sy). We cannot insert a
nop at that point anymore since jump targets have already been
calculated. Fix this by applying the sync flags during legalize, where
all other sync flags are also applied.
Signed-off-by: Job Noorman <jnoorman@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35653 >
2025-06-20 17:23:46 +00:00
Job Noorman
e51fa32aac
ir3/legalize: propagate force_ss/sy across blocks
...
Just like the other sync state, we might need to apply this at the start
of successor blocks.
Signed-off-by: Job Noorman <jnoorman@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35653 >
2025-06-20 17:23:46 +00:00
Job Noorman
a5355b5ffd
ir3/legalize: don't force (ss) after predt
...
This isn't necessary and since predt is a terminator and we (mistakenly)
didn't propagate force_ss across blocks, it wasn't actually applied.
Signed-off-by: Job Noorman <jnoorman@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35653 >
2025-06-20 17:23:46 +00:00
Mike Blumenkrantz
2e071cc66c
zink: actually use GENERAL image barrier functions
...
and fix a bunch of issues there
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35476 >
2025-06-20 17:08:32 +00:00
Mike Blumenkrantz
5c2344b6a6
zink: mimic buffer transfer dst noop barrier semantics with images
...
this should better guarantee sync with GENERAL
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35476 >
2025-06-20 17:08:32 +00:00
Mike Blumenkrantz
bbac75acd3
zink: always unset unordered access flags when executing an ordered barrier
...
this otherwise confuses the calculator
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35476 >
2025-06-20 17:08:31 +00:00
Mike Blumenkrantz
ea45f89ebe
zink: always pass through src access flags for buffer barriers
...
this is more accurate and avoids mixing/matching flags from different cmdbufs
probably won't affect anything at this exact moment
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35476 >
2025-06-20 17:08:31 +00:00
Mike Blumenkrantz
cb026adc4c
zink: don't use TRANSFER bit as default pipeline stage if no access is set
...
should be TOP_OF_PIPE
cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35476 >
2025-06-20 17:08:31 +00:00
Mike Blumenkrantz
5ff573d534
zink: skip sampler layout updates when using GENERAL layouts
...
these are always GENERAL
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35476 >
2025-06-20 17:08:30 +00:00
Mike Blumenkrantz
06be46c7a0
zink: add another aggressive sampler barrier after sequential image copies
...
this should better handle pipelined texture uploads
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35476 >
2025-06-20 17:08:30 +00:00
Mike Blumenkrantz
e5d1547f08
zink: break out the fb unbind sampler barrier
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35476 >
2025-06-20 17:08:30 +00:00
Mike Blumenkrantz
d8c1fdb644
zink: fix GENERAL image copy box resets on non-transfer barrier
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35476 >
2025-06-20 17:08:30 +00:00
Mike Blumenkrantz
43def9716b
zink: use GENERAL layout in zink_copy_image_buffer when possible
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35476 >
2025-06-20 17:08:30 +00:00
Mike Blumenkrantz
4f329fdc61
zink: local screen variable in zink_copy_image_buffer
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35476 >
2025-06-20 17:08:30 +00:00
Mike Blumenkrantz
d30008124d
zink: fix image transfer op batching with GENERAL layouts
...
this depends on the access, not the layout
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35476 >
2025-06-20 17:08:30 +00:00
Mike Blumenkrantz
3d073bb0b3
zink: delete barrier sync flag inferring
...
these are all explicit now
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35476 >
2025-06-20 17:08:30 +00:00