Jason Ekstrand
cc4f0e804e
vulkan,lavapipe: Move some enqueue helpers to common code
...
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15311 >
2022-03-10 15:52:10 +00:00
Boris Brezillon
b98cfe9cb4
lavapipe: Re-use auto-generated vk_cmd_enqueue entrypoints
...
Re-use auto-generated vk_cmd_enqueue entrypoints instead of generating
our own version doing the same thing. In order to effectively do this,
we also add an allow-list of which entrypoints lavapipe actually handles
to avoid issues where the autogenerated one stomps a vkCmdFoo2 wrapper.
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15311 >
2022-03-10 15:52:10 +00:00
Jason Ekstrand
66cb64c8ad
lavapipe: Reset the free_cmd_buffers list in TrimCommandPool
...
We delete all the command buffers but they're still in the list so
future allocations may try to re-use them post-free and another trim
will re-delete them.
Fixes: b38879f8c5 ("vallium: initial import of the vulkan frontend")
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15311 >
2022-03-10 15:52:10 +00:00
Jason Ekstrand
719b949575
vulkan/cmd_queue: Generate enqueue entrypoints
...
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15311 >
2022-03-10 15:52:10 +00:00
Boris Brezillon
47fc0b39c7
vulkan/cmd_queue: Properly deconstify array of pointers
...
When manipulating an array of pointers, what we want to desconstify is
the array, not the entry type.
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15311 >
2022-03-10 15:52:10 +00:00
Jason Ekstrand
0d5dc6ef6a
vulkan/cmd_queue: Stop generating enqueue helpers for INTEL perf queries
...
They don't return void and they're not used by anyone except the Intel
drivers so there's no point in supporting them.
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15311 >
2022-03-10 15:52:10 +00:00
Jason Ekstrand
cf8cf8a827
vulkan/cmd_queue: Re-flow MANUAL_COMMANDS
...
This just makes it all a bit easier to read.
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15311 >
2022-03-10 15:52:10 +00:00
Boris Brezillon
290e33ab20
vulkan/cmd_queue: Remove duplicate entries in MANUAL_COMMANDS
...
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15311 >
2022-03-10 15:52:10 +00:00
Louis-Francis Ratté-Boulianne
6bd8a3c7e4
vulkan/runtime: Add a vk_cmd_queue object to vk_command_buffer
...
This is paving the road for generic secondary command buffer support,
where commands are simply recorded in a software queue and replayed
on the primary command buffer when vkCmdExecuteCommands() is called.
Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15311 >
2022-03-10 15:52:10 +00:00
Louis-Francis Ratté-Boulianne
ad4d2da90a
vulkan/cmd_queue: Add an initializer for the vk_cmd_queue object
...
Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15311 >
2022-03-10 15:52:10 +00:00
Boris Brezillon
dd0f6cb45b
vulkan/cmd_queue: Constify vk_cmd_queue.alloc
...
The implementation shouldn't modify the allocator.
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15311 >
2022-03-10 15:52:10 +00:00
Mike Blumenkrantz
a3d096f4ba
lavapipe: add the full list of cts fails
...
easier to keep track this way
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15294 >
2022-03-10 10:03:16 -05:00
Akihiko Odaki
b70f14188d
virgl: Check texture multisample compatibility
...
v2: Support VIRGL_FORMAT_NONE (Gert Wollny)
Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com >
Suggested-by: Gert Wollny <gert.wollny@collabora.com >
Reviewed-by: Gert Wollny <gert.wollny@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15115 >
2022-03-10 10:34:12 +00:00
Akihiko Odaki
571c5e8fdc
virgl/ci: Uprev virglrenderer
...
Suggested-by: Gert Wollny <gert.wollny@collabora.com >
Reviewed-by: Gert Wollny <gert.wollny@collabora.com >
Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15115 >
2022-03-10 10:34:12 +00:00
Danylo Piliaiev
c4703cd846
tu: Implement VK_EXT_depth_clip_control
...
Since negativeOneToOne is a static property of the pipeline and
viewport state could be dynamic, we have to defer viewport state
emission until negativeOneToOne value is known.
See: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6070
Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14363 >
2022-03-10 11:08:50 +02:00
Iago Toral Quiroga
49b5431197
broadcom/compiler: remove unused functions
...
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15302 >
2022-03-10 07:25:37 +00:00
Dylan Baker
45770ac286
docs: add release notes for 22.0.0
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15312 >
2022-03-09 22:47:56 +00:00
Dylan Baker
8474817253
docs: Add calendar entries for 22.0 release.
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15312 >
2022-03-09 22:47:56 +00:00
Dylan Baker
b7e1df14f0
docs: update calendar and link releases notes for 22.0.0
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15312 >
2022-03-09 22:47:56 +00:00
Timur Kristóf
75a783ea73
ac: Query the amdgpu MEC firmware version.
...
MEC (Micro Engine Compute) is the firmware which is responsible for
the compute-only queues on AMD GPUs. It is present on GFX7 and newer.
This patch will query the version of this firmware and print it
among the others.
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15283 >
2022-03-09 21:31:48 +00:00
Rob Clark
f4ec900953
mesa: Fix discard_framebuffer for fbo vs winsys
...
GL is annoying when it comes to having different enums for winsys vs
fbo.
Note that the issue this closes was only accidentially exposed by a
change the resulted in sysmem vs GMEM path taken.
Fixes: db2ae51121 ("mesa: Skip partial InvalidateFramebuffer of packed depth/stencil.")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6103
Signed-off-by: Rob Clark <robdclark@chromium.org >
Reviewed-by: Matt Turner <mattst88@gmail.com >
Reviewed-by: Emma Anholt <emma@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15308 >
2022-03-09 20:40:53 +00:00
Emma Anholt
d5d8519cb5
docs/ci: Add docs for using a POE switch to control boards, like nouveau.
...
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15201 >
2022-03-09 19:47:04 +00:00
Emma Anholt
e8da28d5e8
docs/ci: Update some bare-metal CI docs.
...
We haven't been using initramfs in a long time, don't point people that
direction. Do point people at existing instances of these CI variants,
though.
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15201 >
2022-03-09 19:47:04 +00:00
Emma Anholt
5497d60639
ci/nouveau: Add a manual run for the Jetson Nano (GM20B).
...
The test suite is full of flakes around transform feedback, atomics, and
tess. But, I hope it can be useful for regression testing core Mesa
reworks.
This required updating the kernel to 5.16.12 to get a more stable boot
process. That kernel rebuild caused an update of the container with
piglit which that was missed in a previous MR, so we got new xfails in x86
swrast.
Acked-by: Ilia Mirkin <imirkin@alum.mit.edu > (nouveau)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15201 >
2022-03-09 19:47:04 +00:00
Emma Anholt
1b374f8c91
ci/nouveau: Add nouveau support to the rootfs.
...
This required updating the kernel to 5.16.12 to get a more stable boot
process. That kernel rebuild caused an update of the container with
piglit which that was missed in a previous MR, so we got new xfails in x86
swrast. Also, including modules on arm64 exposed a bug in v3d's
poe-powered.sh rsyncing of modules.
Acked-by: Tomeu Vizoso <tomeu.vizoso@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15201 >
2022-03-09 19:47:04 +00:00
Emma Anholt
a9e67738d6
ci: Stop xz-compressing firmware for ramdisks.
...
This ends up breaking nouveau because the renames break symlinks in the
firmware directory structure. We don't need it any more since we stopped
doing ramdisks.
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15201 >
2022-03-09 19:47:04 +00:00
Emma Anholt
9b918c4df2
ci/bare-metal: Increase maximum retry count for POE boots.
...
The manual jetson CI job I'm introducing has serious boot reliability
trouble, but also we've seen frequent intermittent failures on bcm where
at least 2 boots don't seem to be enough (#6041 ).
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15201 >
2022-03-09 19:47:04 +00:00
Emma Anholt
45b7648cb1
ci/bare-metal: Drop the BM_POE_USERNAME/PASSWORD env var checks.
...
They're unused since the transition to SNMP in the rpi test farm.
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15201 >
2022-03-09 19:47:04 +00:00
Mike Blumenkrantz
c24bca2d3a
zink: lower dmod on AMD hardware
...
this hardware won't return the correct value from dmod instructions,
so lower it to ensure that cts passes
nobody else will ever hit this, so perf isn't an issue and regular fmod
can be left alone
fixes (amd):
KHR-GL46.gpu_shader_fp64.builtin.mod_d*
Fixes: 5fae35fb17 ('zink: fix 64bit float shader ops ')
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15306 >
2022-03-09 19:13:02 +00:00
Mike Blumenkrantz
1845957a31
zink: add another radv fail
...
it looks like this one was erroneously excluded
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15307 >
2022-03-09 14:00:06 -05:00
Mike Blumenkrantz
e70b6be117
zink: update radv fails
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15307 >
2022-03-09 14:00:06 -05:00
Chia-I Wu
889d050739
venus: add VK_EXT_vertex_attribute_divisor
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15265 >
2022-03-09 17:24:49 +00:00
Chia-I Wu
4752429e36
venus: add VK_EXT_shader_stencil_export
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15265 >
2022-03-09 17:24:49 +00:00
Chia-I Wu
1ecd481bd7
venus: add VK_EXT_robustness2
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15265 >
2022-03-09 17:24:49 +00:00
Chia-I Wu
25795308ef
venus: add VK_EXT_depth_clip_enable
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15265 >
2022-03-09 17:24:49 +00:00
Chia-I Wu
bebe5e3925
venus: add VK_EXT_conservative_rasterization
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15265 >
2022-03-09 17:24:49 +00:00
Chia-I Wu
f0e0daf46b
venus: add VK_EXT_shader_demote_to_helper_invocation
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15265 >
2022-03-09 17:24:49 +00:00
Chia-I Wu
99473f610a
venus: update venus-protocol headers
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15265 >
2022-03-09 17:24:49 +00:00
Marcin Ślusarz
823cffbe1c
anv: include Primitive Header in mesh shader per-primitive output
...
Reviewed-by: Caio Oliveira <caio.oliveira@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15303 >
2022-03-09 16:52:59 +00:00
Marcin Ślusarz
f410c1142f
anv: set number of viewports in clip state (mesh)
...
Reviewed-by: Caio Oliveira <caio.oliveira@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15303 >
2022-03-09 16:52:59 +00:00
Marcin Ślusarz
81df66bfff
intel/compiler: mark some variables as per-primitive in FS if they come from MS
...
Reviewed-by: Caio Oliveira <caio.oliveira@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15303 >
2022-03-09 16:52:59 +00:00
Marcin Ślusarz
8c16ce53a9
intel/compiler: handle ViewportIndex, PrimitiveID and Layer in MUE setup
...
Reviewed-by: Caio Oliveira <caio.oliveira@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15303 >
2022-03-09 16:52:59 +00:00
Marcin Ślusarz
bc4f8c073a
intel/compiler: inject MUE initialization
...
Reviewed-by: Caio Oliveira <caio.oliveira@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15303 >
2022-03-09 16:52:59 +00:00
Marcin Ślusarz
333a490e32
intel/compiler: shift mesh urb read/write window when offset is too large
...
Reviewed-by: Caio Oliveira <caio.oliveira@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15303 >
2022-03-09 16:52:59 +00:00
Samuel Pitoiset
6c1c9067d9
aco: always emit vk_cvt_pkrtz_f16_f32 for nir_op_pack_half_2x16_split
...
From the VK_KHR_shader_float_controls extension:
"5) Do any of the “Pack” GLSL.std.450 instructions count as
conversion instructions and have the rounding mode applied?"
"RESOLVED: No, only instructions listed in “section 3.32.11.
Conversion Instructions” of the SPIR-V specification count as
conversion instructions."
This is also the same logic as the LLVM backend.
No fossils-db changes on Sienna Cichlid.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15301 >
2022-03-09 16:24:20 +00:00
Erik Faye-Lund
fa41bd0687
docs: improve language in zink article
...
Turns out, this was not proper use of language!
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15300 >
2022-03-09 16:19:16 +00:00
Erik Faye-Lund
e666134975
docs: fixup zink gl 4.3 requirements
...
The multiViewport feature isn't required for GL 4.3, it's required for
GL 4.1. Technically speaking, we could have just dropped it because we
already list the maxViewports requirement. But it seems better to be
very clear here to me.
Fixes: 29f8f21bff ("docs: document zink GL 4.3 requirements")
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15300 >
2022-03-09 16:19:16 +00:00
Iago Toral Quiroga
44feff93c2
broadcom/compiler: don't always assign r5 if available
...
Instead, only favor assigning r5 if we have first decided to
assign an accumulator. This helps with assining r5 to short
lived uniforms, favoring accumulator rotation to facilitate
QPU merges.
total instructions in shared programs: 12656164 -> 12628339 (-0.22%)
instructions in affected programs: 5368373 -> 5340548 (-0.52%)
helped: 17420
HURT: 9996
total uniforms in shared programs: 3704776 -> 3704863 (<.01%)
uniforms in affected programs: 12247 -> 12334 (0.71%)
helped: 23
HURT: 78
total max-temps in shared programs: 2153505 -> 2152684 (-0.04%)
max-temps in affected programs: 26468 -> 25647 (-3.10%)
helped: 569
HURT: 328
total fills in shared programs: 4656 -> 4657 (0.02%)
fills in affected programs: 43 -> 44 (2.33%)
helped: 0
HURT: 1
total sfu-stalls in shared programs: 34728 -> 34403 (-0.94%)
sfu-stalls in affected programs: 3411 -> 3086 (-9.53%)
helped: 842
HURT: 534
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15276 >
2022-03-09 15:53:04 +00:00
Iago Toral Quiroga
77f58b46d9
broadcom/compiler: add comment on why we don't use r5 with ldunifa
...
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15276 >
2022-03-09 15:53:04 +00:00
Iago Toral Quiroga
5b140428b0
broadcom/compiler: adjust register threshold for 2-thread compiles
...
We have twice the registers in this case so it makes sense to double
this as well. While this causes slight regressions in shader-db
stats (due to additional register pressure), it helps us hide latency
of memory reads better on 2-thread compiles, where the thread switch
mechanism will be less effective. This shows a ~3% performance
improvement on the UE4 SunTemple demo.
total instructions in shared programs: 12642413 -> 12656164 (0.11%)
instructions in affected programs: 2272652 -> 2286403 (0.61%)
helped: 2924
HURT: 3389
total uniforms in shared programs: 3703861 -> 3704776 (0.02%)
uniforms in affected programs: 213729 -> 214644 (0.43%)
helped: 823
HURT: 1272
total max-temps in shared programs: 2150686 -> 2153505 (0.13%)
max-temps in affected programs: 191332 -> 194151 (1.47%)
helped: 1900
HURT: 1891
total spills in shared programs: 3255 -> 3274 (0.58%)
spills in affected programs: 166 -> 185 (11.45%)
helped: 3
HURT: 6
total fills in shared programs: 4630 -> 4656 (0.56%)
fills in affected programs: 367 -> 393 (7.08%)
helped: 7
HURT: 15
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15276 >
2022-03-09 15:53:04 +00:00