Samuel Pitoiset
bb623b6144
amd/common: add a helper to set the third word of buffer descriptor
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29385 >
2024-05-27 08:17:58 +02:00
David Rosca
cc03f2ea5a
frontends/va: Fix leak when destroying VAEncCodedBufferType
...
Fixes: be4287c3aa ("pipe: Extend get_feedback with additional metadata")
Reviewed-by: Sil Vilerino <sivileri@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29217 >
2024-05-27 05:55:00 +00:00
David Heidelberg
19a875f7dc
ci/freedreno: document new failure after piglit update
...
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29407 >
2024-05-26 22:30:39 -07:00
Cong Liu
62b490fa92
nir: Fix out-of-bounds access in ntt_emit_store_output()
...
This patch resolves the problem by modifying the for loop condition
to ensure that it stays within the bounds of the array (i.e., i < 4)
Signed-off-by: Cong Liu <liucong2@kylinos.cn >
Reviewed-by: Gert Wollny <gert.wollny@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25446 >
2024-05-27 09:13:04 +08:00
Valentine Burley
d93d989e5d
wsi: Guard DRM-dependent function implementations with HAVE_LIBDRM
...
Adress an implicit function declaration error by ensuring that DRM-dependent
functions are only compiled when HAVE_LIBDRM is set.
Fixes: 59813ae468 ("wsi: Add common infrastructure for explicit sync")
Signed-off-by: Valentine Burley <valentine.burley@gmail.com >
Reviewed-by: Joshua Ashton <joshua@froggi.es >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29267 >
2024-05-26 19:48:16 +00:00
Rob Clark
930e4fa283
vulkan/android: Fix suggestedYcbcrModel with !mapper4
...
Only mapper4 supports u_gralloc_get_buffer_color_info(), other gralloc
implementations do not. So add a fallback, so that we aren't telling
the app that the suggestedYcbcrModel is RGB_IDENTITY. We only go down
this path for YUV formats.
Fixes android.graphics.cts.BasicVulkanGpuTest#testBasicBufferImportAndRenderingExternalFormat
Fixes: 8732a619f1 ("vulkan/android: Add common vkGetAndroidHardwareBufferPropertiesANDROID")
Signed-off-by: Rob Clark <robdclark@chromium.org >
Reviewed-by: Roman Stratiienko <r.stratiienko@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29391 >
2024-05-25 14:52:54 +00:00
Faith Ekstrand
67a3c81286
nak: Encode LDC directly
...
This instruction is so restricted that encode_alu() really isn't gaining
us much so we may as well just type it out. Also, the bindless version
is quite a bit different and doesn't follow the ALU patterns so it'll
make more sense to do it this way long-term.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29393 >
2024-05-25 13:26:38 +00:00
Faith Ekstrand
4366d4d181
nak: Don't emit a plop3 for immediate shift sources
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29393 >
2024-05-25 13:26:38 +00:00
Faith Ekstrand
d8b2d25052
nak: Add with -0 for fabs()
...
Adding with +0 is technically fine because the other source has abs()
applied and a non-negative value added to +0 is a no-op. However, copy
propagation won't detect that properly as of a43e6addca ("nak: Fix
fneg to do fadd(-0, x)")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29393 >
2024-05-25 13:26:38 +00:00
Faith Ekstrand
8061ed728a
nak: Emit !PT for carries on IADD3
...
They seem to be ignored by the hardware but the blob emits them.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29393 >
2024-05-25 13:26:38 +00:00
Valentine Burley
c1a4fcbb4a
freedreno/ci: Update expectations
...
Created by ci-collate from the following pipeline:
https://gitlab.freedesktop.org/Valentine/mesa/-/pipelines/1184168
Signed-off-by: Valentine Burley <valentine.burley@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29373 >
2024-05-25 09:05:40 +00:00
Martin Roukala (né Peres)
addeb5ca9a
radv/ci: add a bunch of flakes
...
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29381 >
2024-05-24 21:05:46 +00:00
Martin Roukala (né Peres)
9a7facc97d
radv+zink/ci: document recent flakes
...
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29381 >
2024-05-24 21:05:46 +00:00
Martin Roukala (né Peres)
946b1027ef
turnip+zink/ci: add more flakes to the expectations
...
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29381 >
2024-05-24 21:05:46 +00:00
Martin Roukala (né Peres)
fed03b9662
turnip/ci: bump the a750_vk timeout
...
We already managed to hit the timeout once, and since the job is manual
anyway, let's bump it generously so as to also allow for more tests
to be added without having to bump the timeout every time.
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29381 >
2024-05-24 21:05:46 +00:00
Martin Roukala (né Peres)
8b6ea47020
turnip/ci: document a missing flake from the a750_vk job
...
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29381 >
2024-05-24 21:05:46 +00:00
Martin Roukala (né Peres)
fb5096eb37
nvk+zink/ci: document more flakes in the ga106
...
It also has the benefit of being a shorter name than the original.
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29381 >
2024-05-24 21:05:46 +00:00
Martin Roukala (né Peres)
1d9092ad49
nvk+zink/ci/ga106: make the expectations codename-specific
...
CI expectations are definitely not portable across different gpu
families, so let's tag them as such to reduce confusion and be more
in line with the rest of the codebase.
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29381 >
2024-05-24 21:05:46 +00:00
Martin Roukala (né Peres)
d0d3924c60
nvk+zink/ci: rename the ga106 jobs to be more in line with RADV
...
It also has the benefit of being a shorter name than the original.
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29381 >
2024-05-24 21:05:46 +00:00
Eric R. Smith
43f9b3b986
glsl: make the xfb varying sort stable
...
qsort is not guaranteed to produce a stable sort, and indeed
in MSVC CRT does not. The xfb varying sort functions were
relying on undefined behavior (that qsort would be stable).
Signed-off-by: Eric R. Smith <eric.smith@collabora.com >
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29178 >
2024-05-24 17:36:39 +00:00
Eric R. Smith
5102a922e7
glsl: test both inputs when sorting varyings for xfb
...
In the sort functions used to sort varyings in gl_nir_link_varyings,
we were only checking the first input for whether or not it is xfb.
Check both inputs, and also provide a definite order for the xfb vs.
non-xfb varyings (the xfb come last, as the initial sort established).
This fixes a problem encountered on panfrost, where qsort could
mix xfb and non-xfb varyings which started out separate.
Note that the sort is still not stable. We probably should make it
stable, but that is a more extensive change that's handled in a later
commit.
Cc: mesa-stable
Signed-off-by: Eric R. Smith <eric.smith@collabora.com >
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29178 >
2024-05-24 17:36:39 +00:00
Samuel Pitoiset
003d49c0bc
ac,radv,radeonsi: add a function to translate texture data format
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29301 >
2024-05-24 17:04:54 +02:00
Samuel Pitoiset
e1997226da
radv: use PIPE_FORMAT in radv_translate_tex_dataformat()
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29301 >
2024-05-24 17:04:54 +02:00
Samuel Pitoiset
7785a63fc0
amd/common: add ac_gpu_info::has_etc_support
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29301 >
2024-05-24 17:04:54 +02:00
Marek Olšák
ae9331694b
radeonsi: lower NIR resource srcs to descriptors last
...
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29313 >
2024-05-24 13:48:28 +00:00
Marek Olšák
f493d6fb6f
radeonsi: don't lower UBO/SSBOs to descriptors if they are already lowered
...
The next change will depend on this.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29313 >
2024-05-24 13:48:28 +00:00
Marek Olšák
e1c65ce680
radeonsi/gfx12: fix a regression in si_init_depth_surface
...
si_htile_enabled has an assertion not expecting GFX12
Fixes: d0810d528c - radeonsi: use the common helper for initializing DS surfaces
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29313 >
2024-05-24 13:48:28 +00:00
Marek Olšák
321cb43c11
radeonsi/gfx12: fix depth bounds register values
...
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29313 >
2024-05-24 13:48:28 +00:00
Marek Olšák
59d7d06828
radeonsi/gfx12: fix a regression in si_set_mutable_tex_desc_fields
...
Fixes: 26cd3a1718 - ac,radv,radeonsi: add a helper to set mutable tex desc fields
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29313 >
2024-05-24 13:48:28 +00:00
Marek Olšák
a548ec7ad4
radeonsi/gfx12: disable CU1 instead of CU0 for GS due to SQTT
...
SQTT captures traces from CU0, so we need to keep it enabled.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29313 >
2024-05-24 13:48:28 +00:00
Marek Olšák
34be14d957
radeonsi/gfx12: fix incorrect condition for when to do clear_buffer via compute
...
It was missing the requirement that offset % 4 == 0.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29313 >
2024-05-24 13:48:28 +00:00
Marek Olšák
76b0ad33bc
radeonsi/gfx12: fix the alpha ref value
...
This was missed when the code was refactored.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29313 >
2024-05-24 13:48:28 +00:00
Marek Olšák
3ab0e18db4
radeonsi: vectorize loads/store after ABI lowering and optimizations
...
This results in slightly better code.
SGPRs: 3552 -> 3608 (1.58 %)
VGPRs: 1988 -> 2020 (1.61 %)
Code Size: 178036 -> 177664 (-0.21 %) bytes
Max Waves: 1136 -> 1136 (0.00 %)
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29313 >
2024-05-24 13:48:28 +00:00
Marek Olšák
35c5435eae
ac/llvm: fix incorrect parameter type in llvm.amdgcn.s.nop
...
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29313 >
2024-05-24 13:48:28 +00:00
Marek Olšák
ad07ea3162
amd: enable 32B minimum DCC block size for gfx1151
...
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29313 >
2024-05-24 13:48:28 +00:00
Marek Olšák
cf4eb41540
amd: add more gfx11 APUs
...
Acked-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29313 >
2024-05-24 13:48:28 +00:00
Marek Olšák
7650127040
amd: update addrlib
...
Acked-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29313 >
2024-05-24 13:48:28 +00:00
Natanael Copa
0274518615
nir/opt_varyings: reduce stack usage
...
Avoid put a huge struct on stack to fix a stack overflow on musl libc.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/10988
Fixes: c66967b5cb (nir: add nir_opt_varyings, new pass optimizing and compacting varyings)
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29375 >
2024-05-24 13:15:33 +00:00
Valentine Burley
f7a262cd6d
freedreno/devices: Fix indentation for Adreno A32
...
Adjust indentation to match other entries.
Fixes: cd7da3a807 ("freedreno/devices: Add support for Adreno A32 (G3x Gen 2)")
Signed-off-by: Valentine Burley <valentine.burley@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29347 >
2024-05-24 12:21:07 +00:00
Valentine Burley
674d5b54bf
tu: Expose VK_EXT_nested_command_buffer
...
Signed-off-by: Valentine Burley <valentine.burley@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29347 >
2024-05-24 12:21:07 +00:00
Samuel Pitoiset
cd5f980d51
ac,radv,radeonsi: move ZRANGE_PRECISION to mutable DS fields
...
The DS surfaces are now completely configured in common code.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29349 >
2024-05-24 11:48:32 +00:00
Samuel Pitoiset
332a06903d
ac,radv,radeonsi: a function that sets mutable DS surface fields
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29349 >
2024-05-24 11:48:32 +00:00
Samuel Pitoiset
1a08fa6150
ac,radv,radeonsi: add function to get the number of ZPLANES
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29349 >
2024-05-24 11:48:32 +00:00
Samuel Pitoiset
709452b9d1
radv: do not check image usage for ITERATE256 with TC-compat HTILE
...
This is redundant because TC-compat HTILE is only enabled for images
that are readable by shaders.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29349 >
2024-05-24 11:48:32 +00:00
Samuel Pitoiset
dcfa351af3
radv: only enable DB_STENCIL_INFO.ITERATE_FLUSH when necessary
...
When no HTILE for stencil this shouldn't be neessary.
This also matches RadeonSI.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29349 >
2024-05-24 11:48:32 +00:00
Constantine Shablia
2adf01fa61
panvk: enable KHR and EXT BDA
...
And get it tested by CI.
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29302 >
2024-05-24 13:07:26 +02:00
Boris Brezillon
deb9756e23
panvk: Lower global memory IOs
...
If we want to support KHR_buffer_device_address, we need to lower global
IOs.
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29302 >
2024-05-24 13:06:50 +02:00
Mary Guillemard
fe59b772b5
bi: Alloc replacement array once in opt_cse
...
This create an uneeded pressure otherwise.
Signed-off-by: Mary Guillemard <mary.guillemard@collabora.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29372 >
2024-05-24 11:16:31 +02:00
Mary Guillemard
01ea55b44c
midgard: Reformat code
...
Signed-off-by: Mary Guillemard <mary.guillemard@collabora.com >
Acked-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29372 >
2024-05-24 11:16:31 +02:00
Mary Guillemard
547308990d
bi: Reformat code
...
Had some broken formatting.
Signed-off-by: Mary Guillemard <mary.guillemard@collabora.com >
Acked-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29372 >
2024-05-24 11:16:03 +02:00