David Heidelberg
b970e25890
ci/panfrost: deduplicate gitlab-ci.yml
...
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com >
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19211 >
2022-10-24 21:24:46 +00:00
Pavel Ondračka
8a0c1dcbd6
r300: respect buffer offset in r300_set_constant_buffer
...
Fixes constants upload with nine.
Thanks to Marek Olšák for pointing this out.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7481
Cc: mesa-stable
Signed-off-by: Pavel Ondračka <pavel.ondracka@gmail.com >
Reviewed-by: Filip Gawin <filip@gawin.net >
Reviewed-by: Emma Anholt <emma@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19277 >
2022-10-24 21:15:37 +00:00
Timur Kristóf
a17e801a9c
aco: Add ACO_DEBUG=novalidateir option.
...
This disables IR validation in debug/debugoptimized builds.
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com >
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18103 >
2022-10-24 20:14:16 +00:00
Timur Kristóf
0cceab788e
aco: Move is_dead to aco_ir.h to allow it to get inlined.
...
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com >
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18103 >
2022-10-24 20:14:16 +00:00
Timur Kristóf
36bc3afb8b
aco/optimizer_postRA: Delete dead instructions more efficiently.
...
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com >
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18103 >
2022-10-24 20:14:16 +00:00
Timur Kristóf
7263a29794
aco/optimizer_postRA: Properly handle vccz/execz/scc in reset_block.
...
Fixes: a8dd07518c
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com >
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18103 >
2022-10-24 20:14:16 +00:00
Timur Kristóf
75967a4814
aco/optimizer_postRA: Speed up reset_block() with predecessors.
...
Copy the information from the first predecessor then check whether
it matches other predecessors and modify the data accordingly.
Marked for backporting to stable to make it possible to also
backport fixes based on this.
Cc: mesa-stable
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com >
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18103 >
2022-10-24 20:14:16 +00:00
Timur Kristóf
b542ab0243
aco/optimizer_postRA: Use unique_ptr + array for instruction indices.
...
According to perf, this roughly halves the impact of the post-RA
optimizer in ACO's compile times.
Measurement was taken using a debug optimized build using
NIR_DEBUG=novalidate RADV_DEBUG=nocache and replaying the Fossil DB
from the Doom Eternal shaders.
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com >
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18103 >
2022-10-24 20:14:16 +00:00
Giancarlo Devich
6f598fe4e3
mesa: Fix stack corruption for PIPE_QUERY_TIMESTAMP
...
get_query_result expects a pointer to a union pipe_query_result,
which is larger than GLuint64EXT, causing the memset it does to
overwrite the stack.
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19055 >
2022-10-24 19:43:03 +00:00
Georg Lehmann
a0c52ee827
radeonsi: Use available dot product instructions on gfx11.
...
Signed-off-by: Georg Lehmann <dadschoorse@gmail.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19114 >
2022-10-24 19:07:16 +00:00
Georg Lehmann
31c1cb06ad
radv: Use available dot product instructions on gfx11.
...
Signed-off-by: Georg Lehmann <dadschoorse@gmail.com >
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19114 >
2022-10-24 19:07:16 +00:00
Georg Lehmann
361b47b1f0
aco: Implement signed idot instructions on GFX11.
...
Signed-off-by: Georg Lehmann <dadschoorse@gmail.com >
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19114 >
2022-10-24 19:07:16 +00:00
Georg Lehmann
cea6723243
ac/llvm: Implement signed idot on GFX11.
...
Signed-off-by: Georg Lehmann <dadschoorse@gmail.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19114 >
2022-10-24 19:07:16 +00:00
Georg Lehmann
616d3908dc
aco: Don't use opsel for p_insert.
...
This doesn't make sense, opsel preserves the not selected half of the register,
p_insert zeros it.
No Foz-DB changes.
Signed-off-by: Georg Lehmann <dadschoorse@gmail.com >
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev >
Fixes: 54292e99c7 ("aco: optimize 32-bit extracts and inserts using SDWA")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19253 >
2022-10-24 18:40:40 +00:00
Georg Lehmann
79a8a7662b
aco: fmaak/fmamk can't use SDWA.
...
Found by inspection.
Signed-off-by: Georg Lehmann <dadschoorse@gmail.com >
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19255 >
2022-10-24 18:04:53 +00:00
Pedro J. Estébanez
413f8d0e9b
microsoft/spirv2dxil: Support pack_32_2x16 and pack_32_4x8
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19273 >
2022-10-24 17:39:59 +00:00
Yonggang Luo
224e501210
aco: Do not define NOMINMAX as it's already defined in pre_args now
...
It's a revert of fcd53bebe6 ("aco: Define NOMINMAX in Meson build file")
Because 852d91edcd ("windows: Always set NOMINMAX to remove min/max macros")
did the same thing
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19233 >
2022-10-24 17:00:58 +00:00
Erik Faye-Lund
0ebd6f52a2
zink: reuse rast_prim for line-rasterization check
...
The check_warn variable is true a bit too often; in realtity it's not
*either* of these conditions that makes things lines, it's the last one
in the pipeline. But we already have a state for this, so let's reuse
that instead of recomputing.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19048 >
2022-10-24 16:41:48 +00:00
Erik Faye-Lund
659c39fafb
zink: rework primitive rasterization type logic
...
There's a few things that depends on the primitive rasterization type,
like point-sprite lowering and polygon offset. The effective state is a
combination of several other states, and we currently kinda wing it a
bit sometimes.
This should improve the situation. In particular, we now go backwards
through the pipeline, checking one overriding state at the time.
The end result should be that we don't end up lowering point-coord
replacement when not rendering with points.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19048 >
2022-10-24 16:41:48 +00:00
Pedro J. Estébanez
811794f8d8
microsoft/spirv2dxil: Change spirv_to_dxil() to receive SM and validator versions
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19227 >
2022-10-24 16:15:31 +00:00
Pedro J. Estébanez
0bf5bbb3e4
microsoft/spirv2dxil: Refactor to make SM and validator versions public
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19227 >
2022-10-24 16:15:31 +00:00
Ella Stanforth
677def1d4e
vulkan: wsi: fix musl build
...
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19270 >
2022-10-24 15:39:06 +00:00
Konstantin Seurer
ac01f09d57
radv/rt: Load instance id and custom index on demand
...
Stats for Quae II RTX:
57fps -> 57fps
Totals from 7 (14.00% of 50) affected shaders:
VGPRs: 800 -> 784 (-2.00%)
CodeSize: 217868 -> 218308 (+0.20%)
MaxWaves: 62 -> 63 (+1.61%)
Instrs: 40384 -> 40420 (+0.09%); split: -0.01%, +0.10%
Latency: 866315 -> 870692 (+0.51%)
InvThroughput: 199189 -> 196595 (-1.30%); split: -1.75%, +0.45%
VClause: 1058 -> 1077 (+1.80%)
SClause: 1126 -> 1130 (+0.36%)
Copies: 5787 -> 5772 (-0.26%); split: -0.40%, +0.14%
PreVGPRs: 764 -> 750 (-1.83%)
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19159 >
2022-10-24 14:39:25 +00:00
Daniel Schürmann
6fcabb3b02
aco/ra: only rename fixed Operands if the copy-location matches
...
With epilogs, the same Operand can be fixed to multiple registers.
Fixes: 061b8bfd29 ('aco/ra: rework fixed operands')
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18485 >
2022-10-24 13:12:34 +00:00
Samuel Pitoiset
cf7ada973a
radv: disable shaderBufferFloat64AtomicMinMax on GFX11
...
buffer_atomic_{fmin,fmax}_x2 aren't supported on this GPU apparently.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19268 >
2022-10-24 12:40:33 +00:00
Samuel Pitoiset
7298bc1810
radv: disable {shader,sparse}ImageFloat32AtomicMinMax on GFX11
...
image_atomic_{fmin,fmax} aren't supported on this GPU apparently.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19268 >
2022-10-24 12:40:33 +00:00
Samuel Pitoiset
1ec5b6774d
ac: fix has_vrs_ds_export_bug for VanGogh
...
Missed it.
Fixes: 0a8a9d9d63 ("ac: add radeon_info::has_vrs_ds_export_bug")
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19272 >
2022-10-24 12:01:52 +00:00
Yonggang Luo
4aef5f8825
st: Remove struct st_api, st_gl_api_create and st_gl_api.h
...
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19197 >
2022-10-24 11:31:20 +00:00
Yonggang Luo
b990142e05
xlib: Implement xmesa_get_name by return literal "Mesa " PACKAGE_VERSION directly
...
This literal is consistence with st_api::name comes from global variable
st_gl_api that will be removed in following commits
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19197 >
2022-10-24 11:31:20 +00:00
Yonggang Luo
78a8350e8d
st: Turn st_api::query_versions to be direct accessed function st_api_query_versions
...
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19197 >
2022-10-24 11:31:20 +00:00
Yonggang Luo
7bd5ff3122
st: Turn st_api::create_context to be direct accessed function st_api_create_context
...
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19197 >
2022-10-24 11:31:20 +00:00
Yonggang Luo
562adc385d
st: Turn st_api::make_current to be direct accessed function st_api_make_current
...
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19197 >
2022-10-24 11:31:20 +00:00
Yonggang Luo
26b77dfeb2
st: Turn st_api::get_current to be direct accessed function st_api_get_current
...
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19197 >
2022-10-24 11:31:20 +00:00
Yonggang Luo
40e11ee509
st: Turn st_api::destroy_drawable to be direct accessed function st_api_destroy_drawable
...
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19197 >
2022-10-24 11:31:20 +00:00
Yonggang Luo
3f15ba7d68
st: Remove st_api::destroy
...
It's a global variable and have no need destroy
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19197 >
2022-10-24 11:31:20 +00:00
Yonggang Luo
23388be282
st: OpenVG are removed, remove st_api::feature_mask as it's constant
...
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19197 >
2022-10-24 11:31:20 +00:00
Yonggang Luo
44151acc95
st: OpenVG are removed, remove st_api::profile_mask as it's constant
...
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19197 >
2022-10-24 11:31:20 +00:00
Yonggang Luo
9d0d1e5295
st: move function st_visual_have_buffers into st_manager.c
...
As it's only accessed in st_manager.c, there is no need expose it
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19197 >
2022-10-24 11:31:20 +00:00
Yonggang Luo
5e85165a7b
hgl: Remove non-nused hgl_create_st_api
...
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19197 >
2022-10-24 11:31:20 +00:00
Rhys Perry
f32dde2902
aco: swap v_perm_b32 operands
...
I misread the ISA doc and got the order wrong.
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Fixes: dae1629778 ("aco: disable sdwa on gfx11")
Fixes: e68e6c75ca ("aco: use v_perm_b32 to copy 0xff00/0x00ff/0xff/0x00")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19223 >
2022-10-24 10:52:56 +00:00
Bas Nieuwenhuizen
514a9b3b75
radv: Use correct primgrp size for gfx11.
...
From radeonsi, found by inspection.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19222 >
2022-10-24 09:08:42 +00:00
Bas Nieuwenhuizen
9d782e5294
radv: Improve gfx11 clear colors for DCC.
...
When I wrote the function I did unorms wrong. Let's copy radeonsi
harder.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19222 >
2022-10-24 09:08:42 +00:00
Alejandro Piñeiro
8148e934a6
v3d: replace all TODO around for FIXME
...
Even if there is a slight difference of meaning between FIXME and
TODO, at some point we agreed to use just FIXME for all pending things
to do, just to make it easier to grepping for things that can be done.
And after all, one could argue that is there is something pending TO
DO, is that needs FIXING.
Acked-by: Iago Toral Quiroga <itoral@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19225 >
2022-10-24 08:33:44 +00:00
Pierre-Eric Pelloux-Prayer
434e74e658
radeonsi: zero init using the correct components count
...
This fixes the replay of the trace attached to
https://gitlab.freedesktop.org/mesa/mesa/-/issues/7530 which
would otherwise fail with an LLVM error:
"All operands to PHI node must be the same type as the PHI node!"
Fixes: ae4379d81e ("ac/nir: export some undef as zero")
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19189 >
2022-10-24 09:33:48 +02:00
Samuel Pitoiset
152b90efcd
aco,radv/llvm: do not export parameters on GFX11
...
They will be exported through the attribute ring instead.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19216 >
2022-10-24 07:55:06 +02:00
Samuel Pitoiset
c5bf63753d
ac/nir,radv/llvm: add support for the attribute ring
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19216 >
2022-10-24 07:55:06 +02:00
Samuel Pitoiset
fee5e379f4
radv/llvm: do not set COMPR for exports on GFX11
...
Use 0x3 channel mask instead.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19216 >
2022-10-24 07:53:59 +02:00
José Roberto de Souza
4096c15f4f
hasvk: Nuke code around local memory
...
None of the platforms supported by this driver supports local memory.
Signed-off-by: José Roberto de Souza <jose.souza@intel.com >
Reviewed-by: Ivan Briano <ivan.briano@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19240 >
2022-10-23 16:33:20 -07:00
António Monteiro
fdbb005984
freedreno: get timestamp from os_time_get_nano instead of os_time_get
...
Signed-off-by: António Monteiro <antonio.fmr.monteiro@gmail.com >
Reviewed-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19260 >
2022-10-23 22:20:02 +01:00
Yusuf Khan
851c6598bd
nouveau: get timestamp from os_time_get_nano instead of os_time_get
...
Signed-off-by: Yusuf Khan <yusisamerican@gmail.com >
Reviewed-by: Karol Herbst <kherbst@redhat.com >
Acked-by: Yonggang Luo <luoyonggang@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19249 >
2022-10-23 15:36:19 +00:00