AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
145,085 Commits 1 Branch 0 Tags
ae01d856de18b698bc94ff1e6f4bbd5ea18b230d
Commit Graph

145085 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Emma Anholt ae01d856de nir_to_tgsi: Remove the abs on fcsel's bool src. 
While the nir fcsel opcode specifies src0 != 0.0, as the comment says,
it's only ever used on bools-as-floats, so we know that src0 is
non-negative.  This saves an instruction per CMP on i915.

Reviewed-by: Zoltán Böszörményi <zboszor@gmail.com>
Reviewed-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12921>
 2021-09-20 20:20:54 +00:00
Emma Anholt 4b0975a8e1 ci/freedreno: Update restricted trace sha1s. 
Rendering changed slightly recently, but the diffs look fine.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12939>
 2021-09-20 19:55:55 +00:00
Emma Anholt 306a039472 ci/baremetal: Retry if our network device spontaneously fails. 
Seen in https://gitlab.freedesktop.org/mesa/mesa/-/jobs/13824132.  It's
unlikely that graphics would kill the network, so just assume it's not our
fault and keep going.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12939>
 2021-09-20 19:55:55 +00:00
Emma Anholt 9017bb0837 ci/freedreno: Add some cubearray piglit flakes on a630 I noticed. 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12939>
 2021-09-20 19:55:55 +00:00
Emma Anholt feb971fdee freedreno: Assert to check for the previous regression. 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12942>
 2021-09-20 19:34:57 +00:00
Emma Anholt b8c4ad378d freedreno: Fix autotune regression since batch-cache rework. 
I freed the key that autotune needed a little early.

Fixes: b2349a4671 ("freedreno: Move the batch cache to the context.")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12942>
 2021-09-20 19:34:57 +00:00
Rob Clark 27dd22cb62 turnip: Fix a6xx gen4 compute shaders 
Port of 74d1052537 freedreno/a6xx: ("Fix a6xx gen4 compute shaders")

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5354
Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12856>
 2021-09-20 19:13:25 +00:00
Rob Clark 4e05338d99 turnip: Rast updates for a6xx gen4 
Port of 219e12b7f3 ("freedreno/a6xx: Rast updates for a6xx gen3")

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12856>
 2021-09-20 19:13:25 +00:00
Rob Clark 6ac1d8dc4c turnip: Fix unitialized cs->device 
Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12856>
 2021-09-20 19:13:25 +00:00
Rob Clark 68d4d09b56 freedreno: Add info->a6xx.has_shading_rate 
@flto noticed these registers seem to be related to GL_QCOM_shading_rate

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12856>
 2021-09-20 19:13:25 +00:00
Danylo Piliaiev 4839f442e9 turnip: consider multiview_mask when clearing depth-stencil attachment 
Otherwise only first layer is being cleared.

Would fix several VK_EXT_multi_draw tests:
 dEQP-VK.draw.multi_draw.overlapping.normal.max_draws.*.vert_only.multiview.no_offset

Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12913>
 2021-09-20 18:41:23 +00:00
Timur Kristóf 872d21820f nir: Exclude non-generic patch variables from get_variable_io_mask. 
These are I/O variables which are not going to be removed anyway.
However, get_variable_io_mask handles their location incorrectly.

Found using the GCC undefined behavior sanitizer.
Fixes the following error:

runtime error:
shift exponent 4294967258 is too large
for 64-bit type 'long unsigned int'

Closes: #5319
Fixes: cf5f8f55c3
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12719>
 2021-09-20 18:08:16 +00:00
Timur Kristóf 13e467a147 ac/nir: Fix match_mask to work correctly for VS outputs. 
match_mask checks the intrinsic type and decides whether it's
per-patch or not. VS don't have per-patch outputs,
so this causes wrong behaviour there.

Found using the GCC undefined behavior sanitizer.
Fixes the following error:

runtime error:
shift exponent 18446744073709551584 is too large
for 64-bit type 'long unsigned int'

Closes: #5319
Fixes: bf966d1c1d
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12719>
 2021-09-20 18:08:16 +00:00
Emma Anholt 4474c46f5f mesa/st: Allow loops in GLSL when NIR is enabled, even if the HW can't. 
The jump lowering enabled by EmitNoLoops breaks GLSL's loop unrolling on
various obviously unrollable loops, resulting in a lot of deqp-gles2 and
piglit failures.  NIR will help unroll whatever GLSL doesn't, so we can
trust the driver to apply that after GLSL's unrolling, so no need to ask
GLSL to lower all loops.

Fixes: #4979
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Zoltán Böszörményi <zboszor@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12917>
 2021-09-20 17:41:24 +00:00
Emma Anholt 346a2950bb ci/i915g: Clarify failure happening in fbo-fragcoord2. 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12917>
 2021-09-20 17:41:24 +00:00
Philipp Zabel 4968313fe5 etnaviv: fix dirty bit check for baselod emission 
Since baselod is stored in sampler state, not sampler view, we should
check the ETNA_DIRTY_SAMPLERS bit instead of ETNA_DIRTY_SAMPLER_VIEWS.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12916>
 2021-09-20 17:03:14 +00:00
Zachary Michaels fc5ea6a054 X11: Ensure that VK_SUBOPTIMAL_KHR propagates to user code 
Commit 0245b825 switched from returning the error code VK_ERROR_OUT_OF_DATE_KHR
to returning the success code VK_SUBOPTIMAL_KHR. Prior to that commit, the error
code caused all code paths to fail immediately, but the success code does not.

Currently the success code is not recorded in some scenarios, resulting in a
result of VK_SUCCESS instead. This breaks applications that rely on the
result (per the spec) to trigger resizes.

This commit ensures that the proper VK_SUBOPTIMAL_KHR success code is set as a
sticky status (as comments indicate was intended), ensuring that it is
propagated to user code.

Fixes #5331

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Daniel Stone <daniels@collabora.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12782>
 2021-09-20 16:43:10 +00:00
Samuel Pitoiset 0be0ad102e radv: keep depth/stencil images compressed for TRANSFER_DST on compute 
Only if the image is TC-compat HTILE because it can be decompressed
on compute for partial copies.

This should remove few depth/stencil decompressions for RAGE2 and Red
Dead Redemption 2 because they declare all images as concurrent but
never use the compute queue for them.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12452>
 2021-09-20 15:17:42 +00:00
Samuel Pitoiset 2b805b8a6c radv: add support for copying compressed depth/stencil images on compute 
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12452>
 2021-09-20 15:17:42 +00:00
Samuel Pitoiset 0ac8731b6c radv: implement depth/stencil expand on compute 
This works as long as the image is TC-compatible HTILE.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12452>
 2021-09-20 15:17:42 +00:00
Samuel Pitoiset 966b780992 radv: rename radv_decompress_depth_stencil() 
To radv_expand_depth_stencil() for consistency.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12452>
 2021-09-20 15:17:42 +00:00
Boris Brezillon 4bc10578a5 panfrost/ci: Skip the indirect_draw+XFB tests 
We lack a dependency between the vertex job filling the indirect draw
buffers and the indirect draw compute job reading from these buffers,
leading to unreliable results (the tests pass if the vertex job is
done before the compute job starts, and fail otherwise). Let's disable
those tests until we sort it out.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12589>
 2021-09-20 14:58:02 +00:00
Boris Brezillon 3c2d7cb0d6 panfrost: Fix collision in the indirect draw shader table 
Min/max index search shaders are different for the !primitive_restart
and primitive_restart. We need to add entries for the primitive restart
cases otherwise we might retrieve a wrong shader from the cache.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12589>
 2021-09-20 14:58:02 +00:00
Boris Brezillon 43760a7b2f panfrost: Fix indirect draws when vertex or instance count is 0 
In that case we should just skip the vertex/tiler jobs as done in the
direct draw path.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Acked-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12589>
 2021-09-20 14:58:02 +00:00
Italo Nicola 7682a5de04 panfrost: fix null deref when no color buffer is attached 
Do not dereference color buffer #0 in the SFBD code path if no color buffer is
attached, as with depth-only attachments. Fixes a crash running glmark2 -b
shadow on Mali T720.

Signed-off-by: Italo Nicola <italonicola@collabora.com>
Fixes: c746747cb8 ("panfrost: fix GL_EXT_multisampled_render_to_texture regression")
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12927>
 2021-09-20 14:42:39 +00:00
Boris Brezillon bdb37c862f panfrost: Prepare shader helpers to per-gen XML 
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12935>
 2021-09-20 15:18:56 +02:00
Boris Brezillon 0d57a76458 panfrost: Prepare texture helpers to per-gen XML 
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12935>
 2021-09-20 15:18:56 +02:00
Boris Brezillon a865a4a789 panfrost: Prepare pan_encoder.h to per-gen XML 
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12935>
 2021-09-20 15:18:50 +02:00
Boris Brezillon f36fd4ac4c panfrost: Prepare scoreboard helpers to per-gen XML 
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12935>
 2021-09-20 15:12:33 +02:00
Boris Brezillon de13fdc251 panfrost: Prepare pandecode to per-gen XML 
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12935>
 2021-09-20 15:11:30 +02:00
Boris Brezillon 502b942944 panfrost: Move panfrost_major_version() to gen_macros.h 
So we can use this function in decode_common.c when transitioning to
per-gen XML. While at it rename the function pan_arch().

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12935>
 2021-09-20 15:10:10 +02:00
Boris Brezillon 5af3516f9e panfrost: Prepare pan_cs helpers to per-gen XML 
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12935>
 2021-09-20 15:10:00 +02:00
Boris Brezillon e145a5fdd4 panfrost: Prepare blend helpers to per-gen XML 
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12935>
 2021-09-20 15:09:19 +02:00
Boris Brezillon f68c9a575b panfrost: Prepare blitter helpers to per-gen XML 
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12935>
 2021-09-20 15:08:31 +02:00
Boris Brezillon 8805509fff panfrost: RGB332_UNORM is not a valid texture format on v6+ 
Cc: mesa-stable
Fixes: c6bdd976e6 ("panfrost: Split out v6/v7 format tables")
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12508>
 2021-09-20 11:21:29 +00:00
Boris Brezillon b1172540f3 panfrost: Drop the R and T flags on SCALED formats 
Sampling from SCALED textures / rendering to SCALED FBOs is a bit tricky
(requires extra int <-> float conversions in a few places).
mesa/st only use SCALED formats as vertex formats, and those formats
are optional in Vulkan, so let's drop the RENDER/TEXTURE flags to keep
things simple.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Suggested-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12508>
 2021-09-20 11:21:29 +00:00
Boris Brezillon bab84c62d5 panfrost: RGB10_A2_SNORM is not a valid texture format on v6+ 
Cc: mesa-stable
Fixes: c6bdd976e6 ("panfrost: Split out v6/v7 format tables")
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12508>
 2021-09-20 11:21:29 +00:00
Boris Brezillon 8651dfbeb4 panfrost: Fix the Z32_S8X24 and X32_S8X24 definitions 
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12508>
 2021-09-20 11:21:29 +00:00
Boris Brezillon eed57ada6e panfrost: Patch Z32_S8X24 format when creating a sampler view 
The gallium driver always stores Z32_S8X24 textures on 2 different
planes. Let's fix the create_sampler_view() logic so we can support
single-planar Z32_S8X24 in the vulkan driver.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12508>
 2021-09-20 11:21:29 +00:00
Timur Kristóf 75dbb40439 ac/nir: Remove byte permute from prefix sum of the repack sequence. 
The byte-permute instruction v_perm_b32 is not exposed by older
LLVM releases (only available on LLVM 13 and later), therefore a new
sequence is needed which we can use with these LLVM versions too.

The prefix sum is replaced by two alternatives:

1. For GPUs that support v_dot, we shift 0x01 to the wanted byte
positions and then use v_dot to sum the results.

2. For older GPUs (Navi 10), we simply shift out the unwanted bytes
and use v_sad_u8 to produce the sum.

Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Acked-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12786>
 2021-09-20 12:39:03 +02:00
Timur Kristóf 966cff9cfa aco/isel: Fix emit_vop2_instruction to apply 16/24-bit flags properly. 
Previously it used a builder function but didn't use the return
value from that function, so the flags were not applied.

Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12786>
 2021-09-20 12:39:03 +02:00
Timur Kristóf f2e41eda9e aco: Add ability to optimize v_lshl + v_sub into v_mad_i32_i24. 
Also change combine_add_lshl to use check_vop3_operands instead
of its own checks of the operands.

Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12786>
 2021-09-20 12:39:03 +02:00
Tapani Pälli 1a6c01a61b mesa: fix timestamp enum with EXT_disjoint_timer_query 
Extension implementation missed GL_TIMESTAMP_EXT for Get* functions,
commit 5d58fea660 added GetInteger64vEXT support but obviously we need
to support the enum as well ...

Cc: mesa-stable
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5361
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12890>
 2021-09-20 07:31:00 +03:00
Eric Engestrom 90c6eec0c1 bin/khronos-update.py: add upstream for vulkan_directfb.h & vulkan_screen.h 
Signed-off-by: Eric Engestrom <eric@engestrom.ch>
Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12877>
 2021-09-19 11:00:32 +01:00
Eric Engestrom 8e0b0ce3eb bin/khronos-update.py: update the branch name (s/master/main/) 
Signed-off-by: Eric Engestrom <eric@engestrom.ch>
Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12877>
 2021-09-19 11:00:22 +01:00
Qiang Yu 6f9f350622 radeonsi: fix ps SI_PARAM_LINE_STIPPLE_TEX arg 
This arg size should be 1 instead of 3. It does not affect functionality
because we does not enable it in SPI_PS_INPUT_ADDR. But it does affect
the VGPR number that LLVM produce when LLVM still count with all PS
function arguments.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12922>
 2021-09-19 01:24:21 +00:00
Rob Clark 2a0a9b189a freedreno/computerator/a4xx: Fix enum mismatch warning 
Fixes: fb5deb2b4a ("a4xx/computerator: add initial backend")
Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12923>
 2021-09-18 20:24:49 +00:00
Rob Clark b308ccf4fb freedreno/ir3: Fix generation check 
Fixes: fb5deb2b4a ("a4xx/computerator: add initial backend")
Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12923>
 2021-09-18 20:24:49 +00:00
Rob Clark 24326f25b9 freedreno/ir3: Cleanup liveness lifetime 
I'm going to want to use this in other passes, so lets let the
allocation hang off the pass's context.  Also, while we're at it,
fix the error path leak in ir3_ra().

Fixes: 0ffcb19b9d ("ir3: Rewrite register allocation")
Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12923>
 2021-09-18 20:24:49 +00:00
Rob Clark 344683c932 freedreno/ir3: Fix sched debug msgs 
Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12923>
 2021-09-18 20:24:49 +00:00