Sergi Blanch Torne
abb29959ee
ci: shellcheck requires better 'boolean or' syntax
...
Some merge requests are failing due to `.gitlab-ci/run-shellcheck.sh` failing
on the 'yaml-toml-shell-test' because an 'or', on an elif, in the meson's
build needs to be reformulated.
Fixes: afab416be4 ("ci: enable IPO/LTO only for nightly builds")
Signed-off-by: Sergi Blanch Torne <sergi.blanch.torne@collabora.com >
Acked-by: Guilherme Gallo <guilherme.gallo@collabora.com >
Reviewed-by: Pavel Ondračka <pavel.ondracka@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31627 >
2024-10-14 13:50:26 +00:00
Faith Ekstrand
f33e18ab39
vulkan/queue: Check for _mem_signal_temp before we submit
...
vk_queue_push_submit() takes ownership of the vk_queue_submit object and
potentially passes it to another thread. This fixes a race where, if
the other thread processes and deletes the vk_queue_submit before we get
to checking _mem_signal_temp, we may have a use-after-free.
Fixes: c95b646e23 ("vulkan/queue: Use _mem_signal_temp instead of signal_mem_sync")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11988
Reviewed-by: Juan A. Suarez <jasuarez@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31597 >
2024-10-14 13:13:15 +00:00
Christian Gmeiner
980d0e2d06
docs: Update the list of drivers with CPU tracepoints
...
v3d and vc4 gained support for this feature.
Signed-off-by: Christian Gmeiner <cgmeiner@igalia.com >
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31575 >
2024-10-14 12:21:51 +00:00
Christian Gmeiner
63f0a2f9a0
vc4: Add a few function traces
...
Sprinkle around a few traces that were useful in locating submit and
fence waits.
Signed-off-by: Christian Gmeiner <cgmeiner@igalia.com >
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31575 >
2024-10-14 12:21:51 +00:00
Christian Gmeiner
cf939334e6
v3d: Add a few function traces
...
Sprinkle around a few traces that were useful in locating submit and
fence waits.
Signed-off-by: Christian Gmeiner <cgmeiner@igalia.com >
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31575 >
2024-10-14 12:21:51 +00:00
Samuel Pitoiset
03b4477c8f
radv: fix returning non-zero captured address without binding
...
The Vulkan spec says:
"If the buffer was created with a non-zero value of
VkBufferOpaqueCaptureAddressCreateInfo::opaqueCaptureAddress or
VkBufferDeviceAddressCreateInfoEXT::deviceAddress, the return
value will be the same address that was returned at capture time."
My interpretation is that you can get the buffer device address before
binding if you passed a non-zero address during buffer creation. The
returned BDA would be similar if a memory object is bound to the
buffer later.
Cc: mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31145 >
2024-10-14 07:37:00 +00:00
Sergi Blanch Torne
98f2a55eda
ci: disable Collabora's farm due to maintenance
...
Planned downtime in the farm:
* Start: 2024-10-14 07:00 UTC
* End: 2024-10-14 13:00 UTC
Signed-off-by: Sergi Blanch Torne <sergi.blanch.torne@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31603 >
2024-10-14 05:59:01 +00:00
Rob Clark
c7b126f627
freedreno: Balance out u_blitter cb0 save/restore
...
Fixes: 5de33f3d3e ("freedreno: Implement stencil blit fallback")
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31569 >
2024-10-13 15:18:40 +00:00
Pavel Ondračka
cc14d40239
r300: remove gl_ClipVertex early
...
There is no HW support, but in some cases the shaders mostly work even
if we ignore it, and so far we have just done so. However since the
driver didn't know to what output position in the PVS we should
redirect it, it ended in the first slot. Importantly, if the
CLIP_VERTEX output would be written after position (which actually
belongs in the first slot) it would overwrite it and things blow up.
So just remove it early, and also improve the warning a bit, including
the part that we could use draw module to actually emulate the feature.
Signed-off-by: Pavel Ondračka <pavel.ondracka@gmail.com >
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11856
Fixes: 5dcef1e7b8
Reviewed-by: Filip Gawin <filip@gawin.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31547 >
2024-10-13 05:47:17 +00:00
GKraats
a2b97b7b56
i915g: fix GL_TEXTURE_BASE_LEVEL MAX_LEVEL MIN_LOD and MAX_LOD
...
Since opengl 1.4 i915g should support GL_TEXTURE_BASE_LEVEL,
GL_TEXTURE_MAX_LEVEL, GL_TEXTURE_MIN_LOD and GL_TEXTURE_MAX_LOD.
This MR fixes it.
See also check at tests/texturing/tex-miplevel-selection.c at piglit.
Signed-off-by: GKraats <vd.kraats@hccnet.nl >
Tested-by: Patrick Lerda <patrick9876@free.fr >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31073 >
2024-10-12 23:38:04 +00:00
David Heidelberg
3c0bf42381
util: add aarch64 fast half-float to float conversion
...
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com >
Signed-off-by: David Heidelberg <david@ixit.cz >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31564 >
2024-10-12 22:05:01 +00:00
Bas Nieuwenhuizen
c8c354d9c3
radv: Disable EXT BDA capture and replay.
...
Spec allows calling VkBufferGetDeviceAddressInfo without binding to memory:
VUID-VkBufferDeviceAddressInfo-buffer-02600
If buffer is non-sparse and was not created with the VK_BUFFER_CREATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT flag, then it must be bound completely and contiguously to a single VkDeviceMemory object
Which we can only do by making it sparse unconditionally, which feels very wrong to me for a capture & replay extension as that significantly impacts execution.
Current theory is that this was only intended for the EXT and not the core functionality. As such, let's disable capture using the EXT.
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31140 >
2024-10-11 22:17:33 +00:00
Ian Forbes
40557383dd
driconf: Re-enable GLX_EXT_buffer_age on vmwgfx
...
Now that distributions are no longer installing device specific Xorg
drivers by default we have to rely on the modesetting driver which
currently does not work with glXCopySubBuffer. Both kwin and mutter prefer
using glXSwapBuffers over glXCopySubBuffer if GLX_EXT_buffer_age is present.
Therefore we want to ensure that it is available in order to avoid using
the broken glXCopySubBuffer.
Signed-off-by: Ian Forbes <ian.forbes@broadcom.com >
Reviewed-by: Neha Bhende <neha.bhende@broadcom.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31565 >
2024-10-11 21:27:48 +00:00
Konstantin Seurer
d975d23cd8
radv/meta: Do not pass NULL to vk_texcompress_astc_finish
...
The pointer can be NULL if initialization fails.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11953
Fixes: f97b449 ("radv: integrate meta astc compute decoder to radv")
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31505 >
2024-10-11 20:56:21 +00:00
Vignesh Raman
8d5c67c937
ci: prepare-artifacts-python: copy if src dir exist
...
prepare-artifacts-python.sh fails in drm-ci, since
src directory is not present in linux. So copy files
only if src directory is present.
Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31586 >
2024-10-11 20:10:20 +00:00
Satadru Pramanik
fa9cd89a85
Update lp_bld_misc.cpp to support llvm-19+.
...
Fixes #11896 .
cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31533 >
2024-10-11 18:21:47 +00:00
Adam Jackson
605d6aaf13
vtn: Handle SPV_INTEL_optnone
...
We don't advertise this in rusticl (and probably shouldn't, at least
until we can honor the request) but DPC++ emits this regardless so we
may as well ignore it.
Reviewed-by: Caio Oliveira <caio.oliveira@intel.com >
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31592 >
2024-10-11 15:39:45 +00:00
Mike Blumenkrantz
f87072f5b0
gallium/sw: make llvmpipe the "default" sw driver
...
if GALLIUM_DRIVERS isn't set, this string can be "", which fails
to load any driver
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31546 >
2024-10-11 14:47:12 +00:00
David Rosca
6a598cccc3
radeonsi/vcn: Select layer for rate control
...
This makes the per-layer rate control work. Previously it would always
use rate control params for last configured layer.
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31148 >
2024-10-11 13:55:54 +00:00
David Rosca
d2ad188915
radeonsi/vcn: Implement per-layer rate control for HEVC
...
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31148 >
2024-10-11 13:55:54 +00:00
David Rosca
5b157d4ad0
frontends/va: Calculate VBV params for other layers relative to base layer
...
VAAPI only gives these parameters for base layer, but we need them for
other layers too.
Reviewed-By: Sil Vilerino <sivileri@microsoft.com >
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31148 >
2024-10-11 13:55:54 +00:00
David Rosca
c56fc312a8
frontends/va: Parse H264 prefix for temporal_id
...
Reviewed-By: Sil Vilerino <sivileri@microsoft.com >
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31148 >
2024-10-11 13:55:54 +00:00
David Rosca
ce2eedd13e
frontends/va: Fix parsing HEVC st_ref_pic_set
...
According to spec, the slice ref pic set is the last entry
in st_ref_pic_set[] array.
As such, the maximum number of st ref pic sets is 65.
Fixes: ef8ba75718 ("frontends/va: Parse HEVC slice packed header")
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31308 >
2024-10-11 10:46:49 +00:00
Lucas Stach
7db47af6dd
etnaviv: Update headers from rnndb
...
Update to rnndb commit 3e64c80ed98f.
This extends two fields related to vertex attribute and stream
configuration, so they work correctly with the limits exposed
by the GPU.
Signed-off-by: Lucas Stach <l.stach@pengutronix.de >
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31594 >
2024-10-11 09:33:03 +00:00
Caio Oliveira
b9787fcc80
intel/brw: Move emit_scan/emit_scan_step near its usage
...
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30496 >
2024-10-11 06:40:29 +00:00
Caio Oliveira
0ba1159b0a
intel/brw: Add SHADER_OPCODE_*_SCAN
...
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30496 >
2024-10-11 06:40:29 +00:00
Caio Oliveira
9537b62759
intel/brw: Add SHADER_OPCODE_REDUCE
...
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30496 >
2024-10-11 06:40:29 +00:00
Caio Oliveira
4361a08254
intel/brw: Reduce scope of has_source_and_destination_hazard
...
This predicate at the moment is only relevant during register
allocation, so move it there and the code can ignore virtual
instructions that were already lowered previously.
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30496 >
2024-10-11 06:40:29 +00:00
Caio Oliveira
bf9456753d
intel/brw: Validate some instructions exists only up until some phases
...
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30496 >
2024-10-11 06:40:29 +00:00
Caio Oliveira
affa7567c2
intel/brw: Add phases to backend
...
The general idea is to be able to validate that certain instructions
were lowered and certain restrictions were already handled. Passes can
now assert their expectations, i.e. if a pass is mean to run after
certain lowerings or not.
The actual phases are a initial stab and as we re-organized the passes,
we may remove/add phases.
This commit just add some phase steps, later commits will make use of
them.
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30496 >
2024-10-11 06:40:29 +00:00
Caio Oliveira
21f78454bf
intel/brw: Fix Gfx9 3-src validation to handle FIXED_GRF
...
Note this validation path is not being used at the moment, but will in a
later commit.
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30496 >
2024-10-11 06:40:29 +00:00
Caio Oliveira
3e8796b677
intel/brw: Print Non-SSA regs after NIR in debug output
...
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30496 >
2024-10-11 06:40:29 +00:00
Caio Oliveira
2811cb2923
intel: Add statistic for Non SSA registers after NIR to BRW
...
This is going to be useful while we convert the NIR to BRW to produce
SSA definitions.
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30496 >
2024-10-11 06:40:29 +00:00
Caio Oliveira
6db7d1af16
intel/compiler: Rename shader_stats structs
...
Add the `brw_` and `elk_` prefixes to the structs to avoid compilation
failure building with LTO ("violates the C++ One Definition Rule") when
the structs diverge.
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30496 >
2024-10-11 06:40:29 +00:00
Christian Gmeiner
babeba264b
etnaviv: Implement ARB_draw_indirect
...
Passes all relevant piglits with forced GLSL 330 and GL 3.1.
Signed-off-by: Christian Gmeiner <cgmeiner@igalia.com >
Reviewed-by: Lucas Stach <l.stach@pengutronix.de >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31535 >
2024-10-11 07:42:47 +02:00
Caio Oliveira
13d99979d2
intel/brw: Remove the remaining DO_SRC macro from EU validation
...
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31296 >
2024-10-11 04:13:48 +00:00
Caio Oliveira
f1036da345
intel/brw: Add vstride/width/hstride to brw_hw_decoded_inst
...
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31296 >
2024-10-11 04:13:48 +00:00
Caio Oliveira
2251748aad
intel/brw: Add dst/srcs register numbers to brw_hw_decoded_inst
...
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31296 >
2024-10-11 04:13:48 +00:00
Caio Oliveira
808b8b65b6
intel/brw: Add abs/negate to brw_hw_decoded_inst
...
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31296 >
2024-10-11 04:13:48 +00:00
Caio Oliveira
f6dbb72219
intel/brw: Add dst/src0 address_mode to brw_hw_decoded_inst
...
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31296 >
2024-10-11 04:13:48 +00:00
Caio Oliveira
e4440df2d8
intel/brw: Add pred/cmod/sat to brw_hw_decoded_inst
...
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31296 >
2024-10-11 04:13:48 +00:00
Caio Oliveira
be70d1f9b1
intel/brw: Add dst/srcs type to brw_hw_decoded_inst
...
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31296 >
2024-10-11 04:13:48 +00:00
Caio Oliveira
e0ba4ca166
intel/brw: Add dst/srcs reg file to brw_hw_decoded_inst
...
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31296 >
2024-10-11 04:13:48 +00:00
Caio Oliveira
3db1c3fc0e
intel/brw: Add access_mode to brw_hw_decoded_inst
...
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31296 >
2024-10-11 04:13:48 +00:00
Caio Oliveira
3dc1f64e51
intel/brw: Add exec_size to brw_hw_decoded_inst
...
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31296 >
2024-10-11 04:13:48 +00:00
Caio Oliveira
853fe03470
intel/brw: Add has_dst to brw_hw_decoded_inst
...
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31296 >
2024-10-11 04:13:48 +00:00
Caio Oliveira
c394eb3111
intel/brw: Add num_sources to brw_hw_decoded_inst
...
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31296 >
2024-10-11 04:13:48 +00:00
Caio Oliveira
9cdb90e787
intel/brw: Add opcode to brw_hw_decoded_inst
...
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31296 >
2024-10-11 04:13:48 +00:00
Caio Oliveira
76e177d87d
intel/brw: Create a struct to hold a decoded brw_inst in eu_validation
...
For now it contains only the "raw" brw_inst. Later patches will add
useful fields to it.
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31296 >
2024-10-11 04:13:48 +00:00
Caio Oliveira
382bd4ce36
intel/brw: Add ERROR helper variant that returns to EU validation
...
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31296 >
2024-10-11 04:13:48 +00:00