AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
135,414 Commits 1 Branch 0 Tags
ab42e49ea73caabc8d383de26852fd70117f0c8b
Commit Graph

135414 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Dave Airlie
ab42e49ea7 lavapipe: fix some void ptr arithmetic 
msvc disagrees with it, and they are trivial to fix.

Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9120>
 2021-02-19 02:27:15 +00:00
Dave Airlie
f3dd9529fa lavapipe/meson: drop megadrivers build req 
This just seems to be cut-n-paste, so lose it.

Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9120>
 2021-02-19 02:27:15 +00:00
Dave Airlie
c0c03f29e0 lavapipe: implement physical device group enumeration 
This was missing when I added physical device groups, and
was causing crashes on win32.

Fixes: 6af87193c ("lavapipe: add basic vulkan device group support.")
Acked-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9120>
 2021-02-19 02:27:15 +00:00
Mike Blumenkrantz
0fd58b4537 zink: be more explicit with image barriers for copy operations 
we know the access and pipeline stage here, so we can pass those along
to ensure synchronization

Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8945>
 2021-02-19 02:05:13 +00:00
Mike Blumenkrantz
466efcb247 zink: add general zink_resource_barrier() wrapper 
this simplifies a bit of code where we may want to be throwing in barriers
regardless of the resource type

Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8945>
 2021-02-19 02:05:13 +00:00
Mike Blumenkrantz
6cbd25c04b zink: zink_resource_barrier -> zink_resource_image_barrier 
need this namespace

Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8945>
 2021-02-19 02:05:13 +00:00
Mike Blumenkrantz
55a0eb6e0a zink: improve barrier usage for clear functions 
ensure that we're always using the right layout for images that are
being cleared

Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8945>
 2021-02-19 02:05:13 +00:00
Mike Blumenkrantz
77b0533d75 zink: add batch references for resources in clear functions 
need to make sure we track these writes

Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8945>
 2021-02-19 02:05:13 +00:00
Mike Blumenkrantz
7d6c90826d zink: add access info for update_descriptor image barriers 
this forces resources to transition where necessary to ensure that
data from previous ops have been made available (e.g., clear -> shader image)

we also switch needs_barrier over to a more accurate signature here since we
can now do it without breaking update_descriptors()

Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8945>
 2021-02-19 02:05:13 +00:00
Mike Blumenkrantz
ab3a2fa690 zink: add access param for image resource barriers 
we need more detail on some of these to ensure proper synchronization
and availability/visibility of image data between commands/stages

the signature for needs_barrier() is still funky here to avoid breaking
usage in update_descriptors()

Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8945>
 2021-02-19 02:05:13 +00:00
Mike Blumenkrantz
3f6d104ba8 zink: add barriers for index and draw param buffers 
need to ensure synchronization here too

Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8945>
 2021-02-19 02:05:13 +00:00
Mike Blumenkrantz
5d664166c8 zink: assert batch is not in a renderpass when emitting pipeline barrier 
this is only valid for subpasses which have self-dependencies set, and we
don't currently do that

Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8945>
 2021-02-19 02:05:13 +00:00
Mike Blumenkrantz
9df8c4ba96 zink: take struct zink_batch param instead of direct cmdbuf in barrier helpers 
this is weird and prevents us from verifying batch states

Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8945>
 2021-02-19 02:05:13 +00:00
Mike Blumenkrantz
9d3935a0b3 zink: combine resource barriers where possible during update_descriptors 
if we have a resource in the same state for multiple shader stages, we can
emit a single barrier for all the stage bits instead of multiple barriers

this also helps with detecting potentially redundant barriers when we go to
emit them later on

Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8945>
 2021-02-19 02:05:13 +00:00
Mike Blumenkrantz
4b2fb61831 zink: break out barrier transitioning in update_descriptors 
this hopefully makes the code a little more readable

Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8945>
 2021-02-19 02:05:13 +00:00
Mike Blumenkrantz
017dbd63fb zink: avoid emitting unnecessary pipeline barriers during update_descriptors 
if the current state of the resource matches the desired state, we don't need
to emit anything, and we can potentially avoid ending a renderpass

Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8945>
 2021-02-19 02:05:13 +00:00
Mike Blumenkrantz
5d7cb2495a zink: add generic wrapper for checking whether a resource needs a barrier 
handy to not need to check ahead of time

Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8945>
 2021-02-19 02:05:13 +00:00
Mike Blumenkrantz
4536607ea0 zink: use define for max descriptor array size 
this was getting a bit unwieldy

Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8945>
 2021-02-19 02:05:13 +00:00
Mike Blumenkrantz
03030f87a1 zink: add helper for image resource barriers and avoid unnecessary barriers 
same as buffer barriers now

Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8945>
 2021-02-19 02:05:13 +00:00
Mike Blumenkrantz
b00f407996 zink: add a VkPipelineStageFlags param to zink_resource_barrier() 
this matches the buffer variant in its flexibility now

Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8945>
 2021-02-19 02:05:13 +00:00
Mike Blumenkrantz
061e4e2293 zink: remove aspect param from zink_resource_barrier 
we have a helper function for this now that we can reuse

Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8945>
 2021-02-19 02:05:13 +00:00
Mike Blumenkrantz
73e84c33a2 zink: rework xfb barrier transitions when reusing as vertex inputs 
if we have proper barrier usage to start with, then we don't need to do
any kind of weird flushing upon changing vertex inputs and can also remove
a flag from zink_resource

Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8945>
 2021-02-19 02:05:13 +00:00
Mike Blumenkrantz
fb14793ebb zink: rework xfb counter resource barriers 
using the new helper functions, we can now more accurately determine
exactly which barriers we need/want and avoid setting unnecessary barriers
or ending a renderpass early

Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8945>
 2021-02-19 02:05:13 +00:00
Mike Blumenkrantz
dd858be011 zink: set buffer resource barriers for descriptor resources in update_descriptors() 
need to make sure these are properly synchronized

Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8945>
 2021-02-19 02:05:13 +00:00
Mike Blumenkrantz
69304052e3 zink: add helper function for getting pipeline stage from shader stage 
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8945>
 2021-02-19 02:05:13 +00:00
Alyssa Rosenzweig
cf6794eb8e panfrost/ci: Mark flaky test 
I cannot reproduce the issue in local runs.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9105>
 2021-02-18 21:48:22 +00:00
Alyssa Rosenzweig
2346a94de0 docs/features: Mark atomics/images done on Bifrost 
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9105>
 2021-02-18 21:48:22 +00:00
Alyssa Rosenzweig
10b9e3ca0a panfrost: Advertise FRAMEBUFFER_NO_ATTACHMENTS 
Passes dEQP-GLES31.functional.fbo.no_attachments.*, it doesn't look like
we need to do anything special.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9105>
 2021-02-18 21:48:22 +00:00
Alyssa Rosenzweig
91d2171902 panfrost: Comment on state of ARB_shader_clock 
Pending on kernel work.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9105>
 2021-02-18 21:48:22 +00:00
Alyssa Rosenzweig
ed29a2beb8 pan/bi: Use explicit move even for RT#0 of MRT 
Otherwise we get a bad RA if RT 0 = RT 3 (for example), fixes
dEQP-GLES31.functional.shaders.opaque_type_indexing.sampler.const_literal.fragment.sampler2d

Fixes: a6f1500bed ("pan/bi: Workaround BLEND precolour with explicit moves")
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9105>
 2021-02-18 21:48:22 +00:00
Alyssa Rosenzweig
02d68b9b83 pan/bi: Allow dynamically uniform tex indices 
Passes the relevant tests of
dEQP-GLES31.functional.shaders.opaque_type_indexing.sampler.*, a few
failures that seem to relate to MRT instead of this.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9105>
 2021-02-18 21:48:22 +00:00
Alyssa Rosenzweig
dfe309e707 pan/bi: Implement interpolateAtOffset 
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9105>
 2021-02-18 21:48:22 +00:00
Alyssa Rosenzweig
7ec9dc98d7 pan/bi: Add imm_f16 helper 
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9105>
 2021-02-18 21:48:22 +00:00
Alyssa Rosenzweig
e4ae458df8 pan/bi: Implement interpolateAtSample 
Passes dEQP-GLES31.functional.shaders.multisample_interpolation.interpolate_at_sample.*

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9105>
 2021-02-18 21:48:22 +00:00
Alyssa Rosenzweig
1f265ef6c1 pan/bi: Preload sample ID for sample shading 
Used in the LD_VAR_IMM. Wondering if preload requirements shouldn't
instead be pushed from the compiler based on actual usage instead of
guessing from the NIR...

Fixes dEQP-GLES31.functional.shaders.multisample_interpolation.sample_qualifier.*

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9105>
 2021-02-18 21:48:22 +00:00
Alyssa Rosenzweig
96ea2c3e9d pan/bi: Elucidate slot 6/7 operation 
Used to order fragments. With that clarified it's clear that we need to
wait on slot 7 for LD_TILE too (outside the limited context of a blend
shader).

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9105>
 2021-02-18 21:48:22 +00:00
Alyssa Rosenzweig
7f2d618867 pan/bi: Flesh out LD_TILE emit 
Needs to support non-blend shader operation (conversion descriptor
sourced from a sysval), as well as MRT. Fixes fbfetch on Bifrost.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9105>
 2021-02-18 21:48:22 +00:00
Alyssa Rosenzweig
cff5c40fc3 pan/bi: Fix blend shaders using LD_TILE with MRT 
Don't hardcode the RT to 0. Affects ES3.0 which already exposes MRT --
despite no dEQP coverage of this particular corner case, apps could hit
this in the wild on 21.0. Fixes

dEQP-GLES31.functional.draw_buffers_indexed.overwrite_indexed.common_blend_func_buffer_blend_func

Fixes: c7e1ef7c0c ("panfrost: Advertise ES3.0 on Bifrost")
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9105>
 2021-02-18 21:48:22 +00:00
Alyssa Rosenzweig
9151329fd2 pan/bi: Implement shader_clock intrinsic 
Trivial.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9105>
 2021-02-18 21:48:22 +00:00
Alyssa Rosenzweig
8081811f2e pan/bi: Implement image_atomic_comp_swap 
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9105>
 2021-02-18 21:48:22 +00:00
Alyssa Rosenzweig
078a84f474 pan/bi: Implement image_atomic_exchange 
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9105>
 2021-02-18 21:48:22 +00:00
Icecream95
afe4f0e6b1 pan/bi: nir_intrinsic_image_size support 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9105>
 2021-02-18 21:48:22 +00:00
Icecream95
075d9a1084 pan/bi: Implement image load/store 
v2 (Alyssa): Split out functions, support 3D/array

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9105>
 2021-02-18 21:48:22 +00:00
Alyssa Rosenzweig
1c495323ce pan/bi: Materialize *DTSEL_IMM in the scheduler 
We want to be able to set a descriptor table and have the instruction
pair "magically" come to be. To do so, we adjust the definition of
DTSEL_IMM (deviating a bit from the architectural definition but in
practice simplifying disassembly immensely) and add a scheduler
lowering. This ensures DTSEL is always paired correctly.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9105>
 2021-02-18 21:48:22 +00:00
Icecream95
71f849a292 pan/bi: Remove check for first_ubo_is_default_ubo 
It won't be set for OpenCL.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9105>
 2021-02-18 21:48:22 +00:00
Alyssa Rosenzweig
cd21f0e1c5 pan/bi: Handle computational atomics 
All the same formula: calculate an address, emit a pseudoinstruction for
the atomic, emit a postprocess that can be DCE'd if not needed.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Tested-by: Icecream95 <ixn@disroot.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9105>
 2021-02-18 21:48:22 +00:00
Alyssa Rosenzweig
8358321801 pan/bi: Add ATOM_C1 promotion check 
Optimizes atomic counters.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Tested-by: Icecream95 <ixn@disroot.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9105>
 2021-02-18 21:48:22 +00:00
Alyssa Rosenzweig
b9d277f644 pan/bi: Extract bi_atom_opc from NIR intrinsic 
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Tested-by: Icecream95 <ixn@disroot.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9105>
 2021-02-18 21:48:22 +00:00
Alyssa Rosenzweig
f1adbd5d33 pan/bi: Lower atomic pseudo-instructions 
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Tested-by: Icecream95 <ixn@disroot.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9105>
 2021-02-18 21:48:22 +00:00
Alyssa Rosenzweig
c51c3a8fe3 pan/bi: Add 32-bit atomic pseudoinstruction 
To enable scheduler lowering to an ATOM_CX pair.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Tested-by: Icecream95 <ixn@disroot.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9105>
 2021-02-18 21:48:22 +00:00