a693fbf64b
amdgpu/bo: update uses_secure_bos when importing buffers
...
Fixes: 90b98c0649marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11449 >
2022-08-09 14:38:06 +00:00
1d64308fe9
gallium/dri2: make protected buffer checks opt-in
...
This check is an infinite source of issues when testing protected
content, so make it opt-in (eg for developers of applications dealing
with protected content buffers).
On AMD and Intel importing a protected buffer as non-protected will cause
the display to be incorrect (= garbage).
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11449 >
2022-08-09 14:38:06 +00:00
1862923849
ci/windows: Disable Windows builds while the runner is offline again
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17958 >
2022-08-09 06:57:35 -07:00
3ea0ec4697
docs/ci: show how to run traces locally
...
Newcomers may want to test traces locally and understand how the replay
works.
Acked-by: Guilherme Gallo <guilherme.gallo@collabora.com >
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17347 >
2022-08-09 13:59:59 +02:00
8d00c55e9e
radv/ci: bump the console activity timeout of VanGogh to 3 minutes
...
It seems like VKCTS's startup time is close to the current console
activity timeout (2 minutes...) on the Steam Deck, leading to spurious
timeouts...
Let's bump the timeout by 50%!
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17829 >
2022-08-09 09:04:09 +03:00
1db0b56609
radv/ci: skip host_write_transfer_src.1048576 on renoir
...
The test can take a little longer than 60s, which leads to spurious
timeouts and thus unstable CI pipelines.
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17829 >
2022-08-09 09:04:09 +03:00
e091e56fc1
radv/ci: add more tests to the flake list of vega10
...
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17829 >
2022-08-09 09:04:09 +03:00
6bbe3c6d36
radv/ci: move some tests from the vega10 fail to its flake list
...
v2:
- Move the other 2 `sample_texture` tests to the flake list (Ishi)
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com >
Reviewed-by: Tatsuyuki Ishi <ishitatsuyuki@gmail.com >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17829 >
2022-08-09 09:04:09 +03:00
3f8a356bd3
radv/ci: document a recent regression
...
This regression may have been introduced by mesa/mesa!17652 or
mesa/mesa!17625 .
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17829 >
2022-08-09 09:04:09 +03:00
401d03e1e9
freedreno: Cap reported video memory by VA size
...
Don't report that we have more video memory than the GPU's virtual
address space size.
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17947 >
2022-08-08 22:10:24 +00:00
2bc1d08c48
freedreno/drm: Add FD_VA_SIZE param
...
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17947 >
2022-08-08 22:10:24 +00:00
32d0dfc462
dzn: Use D3D12 constants instead of naked numbers for device limits
...
Reviewed-by: Giancarlo Devich <gdevich@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17915 >
2022-08-08 21:49:42 +00:00
d48ce281f8
dzn: Disable extensions that require multi-view
...
Reviewed-by: Giancarlo Devich <gdevich@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17915 >
2022-08-08 21:49:42 +00:00
1a3b086b06
docs: fixup link to virgl docs
...
Fixes: 6897266ce0olvaffe@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17881 >
2022-08-08 20:04:56 +00:00
9efb1d7fbc
wgl: Release the context before deleting it in wglDeleteContext
...
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17848 >
2022-08-08 19:33:38 +00:00
7dafdb58b8
wgl: Always release local references in stw_make_current_by_handles
...
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17848 >
2022-08-08 19:33:38 +00:00
3fcd030979
wgl: Homogenize read framebuffer reference counting logic
...
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17848 >
2022-08-08 19:33:38 +00:00
a60181e8f2
radeonsi: use do..while loops and other cosmetic changes in display list path
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17933 >
2022-08-08 19:12:12 +00:00
e9a0cae1a1
radeonsi: use si_cp_dma_prefetch_inline for prefetching VBO descriptors
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17933 >
2022-08-08 19:12:12 +00:00
0e574c801c
radeonsi: remove temporary si_context::vb_descriptor_user_sgprs
...
We were writing descriptors into si_context and then copying them into
the command buffer. Just write them into the command buffer directly.
Also set the pointer to VBO descriptors right after them.
When we start a new command buffer or we finish blitting, we no longer
restore precomputed VBO descriptors. Instead, we just reupload them again.
It's a compromise to have the common path simpler and faster (maybe).
This removes a lot of stuff. Now the VBO descriptor upload path looks
very similar to the display list path.
There was an accidental hidden optimization that is now documented as
"last_const_upload_buffer".
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17933 >
2022-08-08 19:12:12 +00:00
a5d37e161d
radeonsi: remove vb_descriptors_gpu_list only used for debugging
...
While this is nice to have, it doesn't include VBO descriptors in user
SGPRs, and we need to remove it, so that we can simplify the VBO code.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17933 >
2022-08-08 19:12:12 +00:00
b4cef2487b
radeonsi: add vertex buffers into the BO list in set_vertex_buffers
...
This is more straightforward. Also, radeon_add_to_buffer_list makes
writing VBO descriptors into the command buffer slower after that code
is reordered in following commits. This seems to be the only way that
isn't slower.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17933 >
2022-08-08 19:12:12 +00:00
c4ffac8a17
radeonsi: merge both fail paths in si_set_vb_descriptor
...
I removed the assertion because apps are allowed to set an offset greater
than the size.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17933 >
2022-08-08 19:12:12 +00:00
a7e64ab63c
tu: Fix sysmem depth attachment clear flushing
...
We can't invalidate CCU if there is any dirty data that hasn't been
flushed yet. In the case where we clear depth, we know that the depth
attachment itself isn't dirty but there may be dirty data from other
renderpasses. Therefore we need to flush before invalidating depth.
Fixes: 487aa80Closes : #6987
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17940 >
2022-08-08 17:30:00 +00:00
de55058cbc
docs: document DRI_PRIME
...
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17298 >
2022-08-08 16:52:44 +00:00
903e99150f
vulkan/device_select: allow DRI_PRIME=vendor_id:device_id
...
To match the GL side.
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17298 >
2022-08-08 16:52:44 +00:00
a71b92fff8
vulkan/device_select: print the dri_prime warning only if needed
...
The next commit will allow a different DRI_PRIME syntax, so move
this printf in the right if block.
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17298 >
2022-08-08 16:52:44 +00:00
4005ba3ed4
loader: allow DRI_PRIME=vendor_id:device_id syntax
...
This syntax allows to select a specific GPU without depending on
the pci bus information.
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17298 >
2022-08-08 16:52:44 +00:00
6d50e4cdc1
loader: don't return empty string in loader_get_dri_config_device_id
...
The caller expects a NULL return value if the option isn't set.
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17298 >
2022-08-08 16:52:44 +00:00
6daf99fcb2
ci/windows: Re-enable Windows runners
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17942 >
2022-08-08 16:10:21 +00:00
d4b8abe511
radv: simplify radv_bind_dynamic_state() slightly
...
This adds RADV_CMP_COPY to compact copies. Based on ANV.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17649 >
2022-08-08 14:59:47 +00:00
18e9ba3e3b
radv: remove unused states parameter from some radv_emit_XXX() helpers
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17649 >
2022-08-08 14:59:47 +00:00
1f6e32ff7c
radv: simplify saving/restoring all dynamic states
...
Instead of copying every field individually, just use a whole memcpy.
This could be optimized but that's not the point here.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17649 >
2022-08-08 14:59:47 +00:00
1d82ec1b3f
radv: remove RADV_META_SAVE_SAMPLE_LOCATIONS
...
We already save/restore all other dynamic states unconditionally, it's
not really useful to make an exception for sample locations.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17649 >
2022-08-08 14:59:47 +00:00
bf0af80045
aco: improve VcmpxPermlaneHazard workaround
...
According to LLVM, we only need to care about VOPC which writes exec.
No fossil-db changes.
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com >
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17697 >
2022-08-08 13:59:17 +00:00
5912c7d3fa
aco: only add vscnt wait when visiting VMEM/DS
...
This prevents issues where we insert a s_waitcnt_vscnt(0) at the start of
a block or very end of the shader because we're joining two blocks (for
example, one with has_VMEM=true and the other with
has_branch_after_DS=true).
fossil-db (navi10):
Totals from 2441 (1.51% of 161220) affected shaders:
Instrs: 1383964 -> 1384094 (+0.01%); split: -0.07%, +0.08%
CodeSize: 7438212 -> 7438760 (+0.01%); split: -0.05%, +0.06%
Latency: 13780665 -> 13679664 (-0.73%); split: -1.53%, +0.80%
InvThroughput: 2950835 -> 2921511 (-0.99%); split: -1.06%, +0.07%
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com >
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17697 >
2022-08-08 13:59:17 +00:00
52156d6b26
aco: set has_VMEM,has_DS=false after a branch
...
fossil-db (navi10):
Totals from 161 (0.10% of 161220) affected shaders:
Instrs: 206726 -> 207179 (+0.22%); split: -0.02%, +0.24%
CodeSize: 1114152 -> 1116032 (+0.17%); split: -0.01%, +0.18%
Latency: 2119380 -> 2147403 (+1.32%); split: -0.16%, +1.48%
InvThroughput: 462960 -> 461922 (-0.22%); split: -0.42%, +0.19%
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com >
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17697 >
2022-08-08 13:59:17 +00:00
b17e59a03b
aco: fix LdsBranchVmemWARHazard with 2+ branch chains
...
For example, "DS -> branch -> VMEM -> branch -> DS".
fossil-db (navi10):
Totals from 639 (0.40% of 161220) affected shaders:
Instrs: 629090 -> 628254 (-0.13%); split: -0.19%, +0.06%
CodeSize: 3410164 -> 3406748 (-0.10%); split: -0.14%, +0.04%
Latency: 7834755 -> 7821011 (-0.18%); split: -0.70%, +0.52%
InvThroughput: 1369698 -> 1374495 (+0.35%); split: -0.12%, +0.47%
A lot of the fossil-db changes are noise.
threekingdoms.8db138826c386a62.1.foz/0b222ed175eebad0 is an example of a
shader that actually has this issue.
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com >
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com >
Fixes: c037ba1bb7https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17697 >
2022-08-08 13:59:17 +00:00
c7f52551a7
gallium/u_threaded: buffer subdata merging (v2)
...
In a scenario where a sequence of calls happens like:
* subdata(buffer_a, offset=0, size=64)
* subdata(buffer_a, offset=64, size=64)
* subdata(buffer_a, offset=128, size=64)
* subdata(buffer_a, offset=192, size=64)
and the buffer can't be directly mapped (e.g., because it has bindings), the
subdata calls will now be merged together into one larger subdata call.
This achieves a 3x perf gain in
KHR-GL46.CommonBugs.CommonBug_SparseBuffersWithCopyOps on radeonsi
Before:
real 0m1,923s
user 0m1,017s
sys 0m0,051s
After:
real 0m0,686s
user 0m0,502s
sys 0m0,071s
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17741 >
2022-08-08 13:27:36 +00:00
293298de65
tu: Flush depth on depth img transition from undef layout
...
Same logic as in tu_subpass_barrier.
Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17911 >
2022-08-08 13:01:28 +00:00
dccd6f495a
ac/nir/cull: Fix typo in bounding box culling.
...
Bounding box culling is only viable when the W of all
vertices are positive. Always accept triangles whose any
W is negative.
Fixes: 0d527bb1aahttps://gitlab.freedesktop.org/mesa/mesa/-/issues/7018
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Reviewed-by: Qiang Yu <yuq825@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17929 >
2022-08-08 11:16:04 +00:00
1fb12d2cce
radv: use ref counting for VS prologs and PS epilogs
...
With GPL, it will be possible to create VS prologs and PS epilogs
from libraries, so reference counting is useful here too.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-By: Tatsuyuki Ishi <ishitatsuyuki@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17628 >
2022-08-08 10:52:31 +00:00
a2b8a92c72
radv: rework shaders ref counting
...
Introduce helpers like for descriptor set layouts. This will also
help graphics pipeline libraries.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-By: Tatsuyuki Ishi <ishitatsuyuki@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17628 >
2022-08-08 10:52:31 +00:00
6f4b6b4d11
ci/radeonsi: Add zork jobs and rules
...
Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17835 >
2022-08-08 08:51:24 +00:00
6c22601048
ci/radeonsi: skqp: Add fail test files for raven
...
Lots of models are missing.
Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17835 >
2022-08-08 08:51:24 +00:00
d4338c9df0
ci/freedreno: skqp: run with new tests files
...
Settings as flakes tests that passed in the exhaustive run, to keep the
same state as it was before
Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17835 >
2022-08-08 08:51:24 +00:00
7801a17b54
ci/skqp: Add gitlab sections for uncluttering
...
skqp output is verbose, as we are running multiple backends at the same
job, normally the trace will surpass the Gitlab UI line limit.
This commit wraps every skqp execution in a Gitlab section and removes
some `set -xtrace` from skqp-runner.sh for a cleaner output.
Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17835 >
2022-08-08 08:51:24 +00:00
d4dcee7a8a
ci/skqp: Remove .baremetal-skqp-test in favor of .skqp-test
...
Both hidden jobs has the same content, let's reuse it.
Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17835 >
2022-08-08 08:51:24 +00:00
eece545d79
ci/skqp: Supress irrelevant shellcheck warnings
...
To fix some warnings, one should write a much complex bash code, such as
SC2086, so prefer to be simple and functional.
Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17835 >
2022-08-08 08:51:24 +00:00
57e7459377
ci/skqp: Put generated tests files in artifacts
...
Showing the resulting test file can help the developer to debug skqp
runs by coping this file locally.
Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17835 >
2022-08-08 08:51:24 +00:00
Pierre-Eric Pelloux-Prayer