AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
198,362 Commits 1 Branch 0 Tags
a648acc287450d00c93e0e464f29993c7ff514b0
Commit Graph

198362 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Marek Olšák a648acc287 nir/lower_clip: convert nir_lower_clip_gs to nir_shader_intrinsics_pass 
and add struct lower_clip_state to hold the state for both
nir_lower_clip_gs and nir_lower_clip_vs.

Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32363>
 2024-11-28 14:14:47 +00:00
Marek Olšák 3b8e4a71fe nir/lower_clip: set clip_distance_array_size outside of create_clipdist_vars 
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32363>
 2024-11-28 14:14:47 +00:00
Marek Olšák b4ef50bca8 nir/lower_clip: separate code for IO variables and intrinsics 
The code for IO variables was interleaved with code for IO intrinsics,
which was difficult to follow.

lower_clip_outputs is split and replaced by more accurate names:
lower_clip_vertex_var and lower_clip_vertex_intrin

Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32363>
 2024-11-28 14:14:47 +00:00
Marek Olšák 3e40c2010e nir/lower_clip: don't set cursor to fix crashes due to removed instructions 
The original builder already points at the end of the function impl.
Just use that.

Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32363>
 2024-11-28 14:14:47 +00:00
Job Noorman 1a0b4531d1 ir3: add workaround for predication hardware bug 
Predication instructions sometimes need extra nops to workaround what
seems to be a hardware bug: prede needs 6 nops and the second
predt/predf of a predt/predf pair needs 4 nops.

The prede workaround is enabled starting from a6xx gen3 and the
predf/predt workaround from a6xx gen4, following the blob.

Fixes rendering corruption in God of War (2018).

Signed-off-by: Job Noorman <job@noorman.info>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32366>
 2024-11-28 13:08:36 +00:00
Job Noorman c129547d9c ir3/isa: allow rpt6/rpt7 
The blob sometimes uses this for nop.

Signed-off-by: Job Noorman <job@noorman.info>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32366>
 2024-11-28 13:08:36 +00:00
Danylo Piliaiev 794a092693 tu: Handle cmdbuf and rp_blit flags of TU_DEBUG_STALE_REGS_FLAGS 
The flags handling was accidentally dropped before.

Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32352>
 2024-11-28 12:48:15 +00:00
Erik Faye-Lund 14bca200be panvk: widen type before multiplying 
This function returns an uint64_t, but returns the result of two
uint32_t values. If we don't widen at least one of them before
returning, the multiplication wraps large results.

So let's widen the type first, so we can preserve large offsets.

Fixes: d1934e44fc ("panvk: Implement occlusion queries for JM")
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Mary Guillemard <mary.guillemard@collabora.com>
CID: 1634943
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32380>
 2024-11-28 10:22:22 +00:00
Erik Faye-Lund 2c6bc9615d panvk: correct signedness of timestamps 
These functions returns signed values, so we shouldn't use an unsigned
variable to store one of them in.

Fixes: d1934e44fc ("panvk: Implement occlusion queries for JM")
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Mary Guillemard <mary.guillemard@collabora.com>
CID: 1635021
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32380>
 2024-11-28 10:22:22 +00:00
Erik Faye-Lund 22985caf3f panfrost: sanity-check alignment 
The page-alignment should always be a positive power of two. Let's
assert that, to avoid confusion.

Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Mary Guillemard <mary.guillemard@collabora.com>
CID: 1605086
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32380>
 2024-11-28 10:22:21 +00:00
Erik Faye-Lund 0d51248e5d lima: avoid memleak on error 
We should free this pointer, otherwise we're leaking it.

CID: 1521251
Reviewed-by: Vasily Khoruzhick <anarsoul@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32381>
 2024-11-28 09:59:51 +00:00
Erik Faye-Lund b8bb9e08bc lima: add assert to validate list-lenght 
If this could be zero, we'd end up with divisions by zero here, which
uh... would be bad? I don't think that can happen, so let's assert about
this, to make it clear what's going on.

CID: 1444660
Reviewed-by: Vasily Khoruzhick <anarsoul@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32381>
 2024-11-28 09:59:51 +00:00
Erik Faye-Lund e50f7fad86 lima: fixup typo 
Reviewed-by: Vasily Khoruzhick <anarsoul@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32381>
 2024-11-28 09:59:51 +00:00
Boris Brezillon 0109e012b8 panvk: Filter out input-attachment usage on non renderable formats 
Fixes dEQP-VK.api.info.unsupported_image_usage.*.input_attachment_*
failures.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Mary Guillemard <mary.guillemard@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32378>
 2024-11-28 09:28:14 +00:00
David Rosca 489ba819b0 radeonsi/vcn: Support tiling for JPEG decode 
Reviewed-by: Leo Liu <leo.liu@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32301>
 2024-11-28 08:52:37 +00:00
Caterina Shablia 7ca8c19246 Revert "nir: introduce instance_index system value" 
This reverts commit b9be1f1f20.

Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32332>
 2024-11-28 07:53:01 +00:00
Caterina Shablia 9d5ba87ca1 Revert "nir: lower INSTANCE_{ID,INDEX} to an offset load_instance_{index,id} respectively" 
This reverts commit a5bcf566a9.

Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32332>
 2024-11-28 07:53:01 +00:00
Samuel Pitoiset 9bae92f659 radv: add support for capturing RGP per-submit 
This is pretty basic but it can be enabled with MESA_VK_TRACE=rgp and
MESA_VK_TRACE_PER_SUBMIT=1.

Can be useful for compte-only workloads.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/12202
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32370>
 2024-11-28 07:03:21 +00:00
Samuel Pitoiset f3272f0044 radv: add new start/stop sqtt helpers for capturing with SQTT 
They will be also used for per-submit captures.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32370>
 2024-11-28 07:03:21 +00:00
Samuel Pitoiset df52c70b8a radv: finish tools after cleaning meta resources 
Otherwise, the number of registered RGP pipelines could be non-zero
and this will assert.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32370>
 2024-11-28 07:03:21 +00:00
Samuel Pitoiset 851a8a481b vulkan: add MESA_VK_TRACE_PER_SUBMIT 
To capture RGP per-submit for compute-only workloads. Other capture
tools like RMV are not covered here.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32370>
 2024-11-28 07:03:20 +00:00
Job Noorman 86465a3f2b ir3: add pass to select bitwise triops 
Signed-off-by: Job Noorman <jnoorman@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32181>
 2024-11-28 06:19:59 +00:00
Job Noorman faba4ca5f8 ir3: add codegen for bitwise triops 
Signed-off-by: Job Noorman <jnoorman@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32181>
 2024-11-28 06:19:59 +00:00
Job Noorman 5879e4470e ir3: fix backend support for bitwise triops 
- Immediates are not allowed in 2nd src.
- Immediates are 12 bits, not sign-extended.
- Only one of the first two sources can be shared when not scalar ALU.

Signed-off-by: Job Noorman <jnoorman@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32181>
 2024-11-28 06:19:59 +00:00
Job Noorman 1333af5d77 nir/search: add is_only_used_by_{iand,ior} helpers 
Signed-off-by: Job Noorman <jnoorman@igalia.com>
Reviewed-by: Rob Clark <robclark@freedesktop.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32181>
 2024-11-28 06:19:59 +00:00
Job Noorman a8c947df9a nir/search: make is_only_used_by_iadd reusable 
The algorithm is exactly the same for other opcodes so we don't have to
have to copy paste it.

Signed-off-by: Job Noorman <jnoorman@igalia.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Rob Clark <robclark@freedesktop.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32181>
 2024-11-28 06:19:59 +00:00
Job Noorman 22fc90a116 nir: add ir3-specific bitwise triop opcodes 
ir3 has a number of bitwise triops (e.g., shrm == (src0 >> src1) & src2)
that don't have NIR-equivalents. Doing instruction selection for them is
a lot more convenient using algebraic patterns than to have to manually
match for them. This patch add NIR opcodes for these instructions.

Signed-off-by: Job Noorman <jnoorman@igalia.com>
Reviewed-by: Rob Clark <robclark@freedesktop.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32181>
 2024-11-28 06:19:59 +00:00
Eric Engestrom c51378fa6c docs: add sha sum for 24.2.8 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32384>
 2024-11-28 01:32:32 +01:00
Eric Engestrom 955bdb82c3 docs: add release notes for 24.2.8 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32384>
 2024-11-28 01:32:32 +01:00
Eric Engestrom 4b0c600fa2 docs: update calendar for 24.2.8 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32384>
 2024-11-28 01:32:32 +01:00
Marek Olšák 1a7c54b840 Revert "gbm: mark surface buffers as explicit flushed" 
This reverts commit c49a71c03c.

It broke radeonsi.

GBM can't set __DRI_IMAGE_USE_BACKBUFFER if gbm itself doesn't use it as
a back buffer by rendering to it and calling SwapBuffers. If another
library uses it as a back buffer, that library should set
__DRI_IMAGE_USE_BACKBUFFER, not GBM. A different flag could be added
to indicate the behavior that the original commit expected.

Fixes: c49a71c03c - gbm: mark surface buffers as explicit flushed
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11996
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32345>
 2024-11-27 22:48:04 +00:00
Timothy Arceri 1f954a207b glsl: remove now unused ir reader 
This was used to parse glsl ir in string format and create real ir with
it. It was previously used for some really old test infrastructure which
has now been removed so lets burn this with fire also.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32364>
 2024-11-27 22:05:06 +00:00
Timothy Arceri 722f939614 glsl: drop last remaining lower jump test 
This test only tests that a redundant continue is removed. This test is
not very useful and there are hundreds of lines of supporting test
infrastructure that can be removed if we drop it.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32364>
 2024-11-27 22:05:06 +00:00
Timothy Arceri cf188a0efb glsl: remove return lowering from glsl ir 
We don't need it as nir does it for us anyway.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32364>
 2024-11-27 22:05:06 +00:00
Timothy Arceri 6c86b56c06 glsl: disable function return lowering in glsl ir 
We just let the nir lowering pass do it instead.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32364>
 2024-11-27 22:05:06 +00:00
Eric Engestrom a37d5dcd63 radv/ci: use deqp-vk-main in radv jobs 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28168>
 2024-11-27 20:38:05 +00:00
Eric Engestrom 596c58b582 ci: bump image tags 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28168>
 2024-11-27 20:38:05 +00:00
Eric Engestrom beab815670 ci/deqp: add a deqp-vk build on the main branch 
To be able to run new tests as soon as they are merged, instead of
having to wait for the next official CTS release

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28168>
 2024-11-27 20:38:05 +00:00
Eric Engestrom 328a3de7cc ci/lava: turn the $BUILD_VK check into a proper if block 
Allows us to simply add something in the block in the next commit.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28168>
 2024-11-27 20:38:05 +00:00
Eric Engestrom ec27d138cb ci/deqp: only print the commit list header when the list is not empty 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28168>
 2024-11-27 20:38:05 +00:00
Eric Engestrom 044cab6751 ci/deqp: mention the deqp api in the version string 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28168>
 2024-11-27 20:38:05 +00:00
Eric Engestrom ffb6c3e1de ci/deqp: simplify generating the version description file 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28168>
 2024-11-27 20:38:05 +00:00
Eric Engestrom 72a2b92e3e ci/deqp: support having commit backports and local patches for main too 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28168>
 2024-11-27 20:38:05 +00:00
Eric Engestrom 1634ad2782 ci/deqp: fix the "is this a build on main?" check 
Suggested-by: Antonio Ospite
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28168>
 2024-11-27 20:38:05 +00:00
Eric Engestrom 601088aebb ci/deqp: simplify paths since we are already in /deqp-$deqp_api/ 
Some commands used relative paths, while most used complex absolute
paths; let's just avoid unnecessary complexity.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28168>
 2024-11-27 20:38:05 +00:00
Antonio Ospite 3bdb77e378 ci/deqp: replace local android patches with upstream solution 
In commit a34982063 (Support standalone executable builds on Android,
2024-09-12) upstream VK-GL-CTS added support for building deqp as an
executable command for Android, this change is included in the vulkan
branch used by build-deqp.sh so the custom patches can be dropped for
the Vulkan CTS build.

After that and by passing -DDEQP_ANDROID_EXE=ON deqp can now be built
with DEQP_API=tools.

[Eric]
Note that the upstream solution seems to be broken on EGL, so GL & GLES
continue to use the local android patches; for more details, see:
https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28168#note_2676128

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28168>
 2024-11-27 20:38:05 +00:00
Alyssa Rosenzweig c2973765e2 nir: add nir_lower_constant_to_temp helper 
this comes up with clc.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Konstantin Seurer <konstantin.seurer@gmail.com>
Reviewed-by: Mary Guillemard <mary.guillemard@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32382>
 2024-11-27 20:02:05 +00:00
Alyssa Rosenzweig 12cc22af4c nir: add nir_remove_entrypoints helper 
opposite of nir_remove_non_entrypoint. this operation comes up with
precompiling.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Konstantin Seurer <konstantin.seurer@gmail.com>
Reviewed-by: Mary Guillemard <mary.guillemard@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32382>
 2024-11-27 20:02:05 +00:00
Alyssa Rosenzweig c076900360 nir: add nir_function::pass_flags 
convenience, asahi will stash stuff here.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Konstantin Seurer <konstantin.seurer@gmail.com>
Reviewed-by: Mary Guillemard <mary.guillemard@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32382>
 2024-11-27 20:02:05 +00:00
Alyssa Rosenzweig 7d6e923a4f vtn: gather workgroup size in libraries 
we have multiple kernels. that's fine, gather sizes for each.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
Reviewed-by: Konstantin Seurer <konstantin.seurer@gmail.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Mary Guillemard <mary.guillemard@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32382>
 2024-11-27 20:02:05 +00:00