Emma Anholt
9d1d2d7e43
panfrost: Disable flaky piglit job for now.
...
It's been getting intermittent failures on marge since being enabled, turn
it back off until it can get stabilized.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13180 >
2021-10-04 21:43:27 +00:00
Samuel Pitoiset
01155e97f5
ci: enable building RADV in debian-release
...
To build RADV without LLVM.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13117 >
2021-10-04 21:11:35 +00:00
Rob Clark
cd38b3ec54
Revert "freedreno: Move the batch cache to the context."
...
This reverts commit b2349a4671 .
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5441
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13159 >
2021-10-04 20:24:59 +00:00
Rob Clark
398a731af9
Revert "freedreno: Remove the submit lock locking."
...
This reverts commit 22486ffa51 .
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13159 >
2021-10-04 20:24:59 +00:00
Rob Clark
52a2253071
Revert "freedreno: Use a BO bitset for faster checks for resource referenced."
...
This reverts commit 3ade94df86 .
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13159 >
2021-10-04 20:24:59 +00:00
Rob Clark
fbf324ee6c
Revert "freedreno: Remove dead fd_batch_reset()."
...
This reverts commit 63cc1fe71f .
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13159 >
2021-10-04 20:24:59 +00:00
Rob Clark
93df18e889
Revert "freedreno: Fix autotune regression since batch-cache rework."
...
This reverts commit b8c4ad378d .
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13159 >
2021-10-04 20:24:59 +00:00
Rob Clark
53917ab403
zink: Disable TC syncs for get_device_reset_status()
...
zmike said it should work.
Signed-off-by: Rob Clark <robdclark@chromium.org >
Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13163 >
2021-10-04 19:45:28 +00:00
Rob Clark
5b7c81fd13
freedreno: Disable TC syncs for get_device_reset_status()
...
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13163 >
2021-10-04 19:45:28 +00:00
Rob Clark
75808934f8
gallium/u_threaded: Get reset status without sync
...
GPU hangs are asynchronous already, there should not be an expectation
that this is synchronized with driver thread.
Signed-off-by: Rob Clark <robdclark@chromium.org >
Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13163 >
2021-10-04 19:45:28 +00:00
Caio Marcelo de Oliveira Filho
1a20cfb7d6
anv: Identify code paths specific to graphics primitive pipeline
...
In preparation for adding support for the graphics mesh pipeline,
identify all the paths that are specific the primitive pipeline.
This shouldn't change any behavior since the code currently only
supports the primitive pipeline.
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13047 >
2021-10-04 18:55:56 +00:00
Caio Marcelo de Oliveira Filho
a63aa9ad41
anv: Move together primitive pipeline emit calls
...
Just moving code and the packet order, no functional change expected.
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13047 >
2021-10-04 18:55:56 +00:00
Marcin Ślusarz
1f1ad5a9b4
anv: Use input assembly state only when pipeline has vertex stage
...
Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13047 >
2021-10-04 18:55:56 +00:00
Marcin Ślusarz
d79c518a32
anv: Set graphics pipeline active_stages earlier
...
So that we can use the active_stages in copy_non_dynamic_state() later.
Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13047 >
2021-10-04 18:55:56 +00:00
Caio Marcelo de Oliveira Filho
bc2545fc57
anv: Validate vertex related states only when VS is present
...
Mesh pipeline doesn't use those states, so we can't assert them
unconditionally for a graphics pipeline.
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13047 >
2021-10-04 18:55:56 +00:00
Jesse Natalie
82c69c9a9d
compiler/clc: Preserve OCL kernel arg type metadata on LLVM13
...
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13177 >
2021-10-04 18:16:01 +00:00
Jesse Natalie
3a752256f5
compiler/clc: Null extensions should mean all supported, not all
...
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13177 >
2021-10-04 18:16:01 +00:00
Marcin Ślusarz
b8cafaa91d
lima: use nir_shader_instructions_pass in lima_nir_split_load_input
...
Changes:
- nir_metadata_preserve(..., nir_metadata_block_index | nir_metadata_dominance)
is called only when pass makes progress
- nir_metadata_preserve(..., nir_metadata_all) is called when pass doesn't
make progress
Signed-off-by: Marcin Ślusarz <marcin.slusarz@intel.com >
Reviewed-by: Vasily Khoruzhick <anarsoul@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13176 >
2021-10-04 15:54:06 +00:00
Adam Jackson
aa30e58600
wsi/x11: Fix a misunderstanding about how xcb_get_geometry works
...
The code here is well-intentioned, but the only way a GetGeometry
request can fail is if you name an invalid drawable. And if we did that,
either our internal state got corrupted, or - more likely - the user
destroyed the window. In either case there's nothing more we can do with
the surface, so report that it's been lost.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13104 >
2021-10-04 15:30:06 +00:00
Rob Clark
ac783acd74
freedreno: Handle PIPE_FORMAT_NONE buffers
...
Clover creates buffers with format=NONE.. which is not technically
incorrect. Just treat this as r8_unorm so we know width0 is the size
in bytes.
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13160 >
2021-10-04 15:10:07 +00:00
Rob Clark
9e74f458a8
freedreno: Handle cso==NULL in bind_sampler_states
...
This is a thing that comes up with clover.
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13160 >
2021-10-04 15:10:07 +00:00
Rob Clark
96b37b9546
freedreno/ir3: Remove used unused
...
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13160 >
2021-10-04 15:10:07 +00:00
Rob Clark
748583d808
freedreno: Fix some indentation
...
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13160 >
2021-10-04 15:10:07 +00:00
Rob Clark
6223f29a87
freedreno: Optimize no-op submits
...
In some cases we need to emit a no-op batch/submit, just to get a fence.
No need to emit all the boilerplate state-resture and flushing in this
case.
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13160 >
2021-10-04 15:10:07 +00:00
Rob Clark
383df59987
freedreno: Get shader variant msgs in perf debug output
...
We want FD_MESA_DEBUG=perf to also tell us about variants.
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13160 >
2021-10-04 15:10:07 +00:00
Icecream95
ad60fffd49
pan/mdg: Use the correct swizzle for condition moves
...
Fixes: 70072a20e0 ("pan/midgard: Refactor swizzles")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13173 >
2021-10-04 14:55:07 +00:00
Boris Brezillon
d34c1dc93d
panvk: Support clearing ZS attachments
...
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13137 >
2021-10-04 14:34:55 +02:00
Boris Brezillon
c3ebd8ddac
panvk: Allow clear_attachment of RTs > 0
...
It's just a matter of skipping unused BLEND descriptors and emitting
the one we want to clear.
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13137 >
2021-10-04 14:34:55 +02:00
Boris Brezillon
555e6626c2
panvk: Pass the render target index to panvk_meta_clear_attachment()
...
The attachment index and render target don't necessarily match. We need
to explicitly pass the render target index to
panvk_meta_clear_attachment() so it can select the correct shader and
emit a valid RSD.
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13136 >
2021-10-04 12:17:07 +00:00
Boris Brezillon
3ba34f6633
panvk: Fix wls_size retrieval
...
Fix a typo in wls_size assignment leading to a wrong wls_size.
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13136 >
2021-10-04 12:17:07 +00:00
Boris Brezillon
4692baacfb
panvk: Don't use panfrost_get_default_swizzle() on v7+
...
This helper produces invalid component order values on v7. Use the
MALI_RGB_COMPONENT_ORDER_xxx definitions instead.
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13136 >
2021-10-04 12:17:07 +00:00
Boris Brezillon
8acc8f6a0e
panvk: Fix allocation of BOs bigger than the slab size
...
We can pick a BO from the pool if the BO size exceeds the pool size. In
that case, allocate a BO and save it in a separate array so we can free
it when the memory pool is reset or released.
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13136 >
2021-10-04 12:17:07 +00:00
Joshua Ashton
4e58d30d98
radv: Add force_emulate_rt perftest option
...
Signed-off-by: Joshua Ashton <joshua@froggi.es >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12974 >
2021-10-04 11:52:40 +00:00
Joshua Ashton
26826a7d60
radv: Enable raytracing extensions on older generations
...
We have shader-based bvh traversal for this on older generations now.
Signed-off-by: Joshua Ashton <joshua@froggi.es >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12974 >
2021-10-04 11:52:40 +00:00
Joshua Ashton
548382de42
radv: Implement software emulation for intersect_ray
...
Signed-off-by: Joshua Ashton <joshua@froggi.es >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12974 >
2021-10-04 11:52:40 +00:00
Joshua Ashton
a0f51921a6
radv: Implement build_node_to_addr for GFX8 and below
...
Removes the nir_ prefix also given it no longer acts like a typical builder function.
Signed-off-by: Joshua Ashton <joshua@froggi.es >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12974 >
2021-10-04 11:52:40 +00:00
Joshua Ashton
ff087dd601
radv: Do not pass result to insert_traversal_aabb_case
...
This is unused as it performs the tests itself.
Signed-off-by: Joshua Ashton <joshua@froggi.es >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12974 >
2021-10-04 11:52:40 +00:00
Joshua Ashton
e30a714ad9
radv: Remove assert in radv_rt_bind_tables
...
Not necessary anymore.
Signed-off-by: Joshua Ashton <joshua@froggi.es >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12974 >
2021-10-04 11:52:40 +00:00
Samuel Pitoiset
87c732bfee
radv: determine the ES type (VS or TES) for GS earlier
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13170 >
2021-10-04 12:13:10 +02:00
Samuel Pitoiset
75e5795d41
radv: remove useless loads_dynamic_offsets when emitting push constants
...
It's always TRUE if loads_push_constants is TRUE.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13170 >
2021-10-04 12:13:10 +02:00
Samuel Pitoiset
f901294c0a
radv: remove redundant check of needs_multiview_view_index for PS
...
layer_input is always TRUE if needs_multiview_view_index is TRUE.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13170 >
2021-10-04 12:13:10 +02:00
Samuel Pitoiset
69e656dae4
radv: move use of NGG to the graphics pipeline key
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13099 >
2021-10-04 10:05:18 +00:00
Samuel Pitoiset
0fa431087c
radv: move forcing VRS rates to the graphics pipeline key
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13099 >
2021-10-04 10:05:18 +00:00
Samuel Pitoiset
5bacc668fa
radv: move forcing MRT output NaN fixup to the graphics pipeline key
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13099 >
2021-10-04 10:05:18 +00:00
Samuel Pitoiset
fb453d80a4
radv: move forcing invariant geometry to the graphics pipeline key
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13099 >
2021-10-04 10:05:18 +00:00
Samuel Pitoiset
421b5379df
radv: move forcing discard to demote to the graphics pipeline key
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13099 >
2021-10-04 10:05:18 +00:00
Samuel Pitoiset
38c34bf132
radv: constify radv_shader_info for radv_lower_{io_to_mem,ngg}()
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13134 >
2021-10-04 08:55:19 +00:00
Samuel Pitoiset
b52aaea630
radv: remove unnecessary ac_nir_ngg_config output struct
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13134 >
2021-10-04 08:55:19 +00:00
Samuel Pitoiset
52e91f7640
radv: move ngg passthrough determination earlier
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13134 >
2021-10-04 08:55:19 +00:00
Samuel Pitoiset
2ce78a30ff
move: move ngg lds bytes determination earlier
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13134 >
2021-10-04 08:55:19 +00:00