AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
196,979 Commits 1 Branch 0 Tags
8300378bf367609242fc6509e9a34325bcc075d1
Commit Graph

196979 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Samuel Pitoiset 8300378bf3 radv: advertise VK_EXT_device_generated_commands on GFX8+ 
GFX6-7 can't really support it and it's not worth the effort anyways.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31383>
 2024-10-28 16:27:35 +00:00
Samuel Pitoiset 9f8684359f radv: implement VK_EXT_device_generated_commands 
The major differences compared to the NV extensions are:
- support for the sequence index as push constants
- support for draw with count tokens (note that DrawID is zero for
  normal draws)
- support for raytracing
- support for IES (only compute is supported for now)
- improved preprocessing support with the state command buffer param

The NV DGC extensions were only enabled for vkd3d-proton and it will
maintain both paths for a while, so they can be replaced by the EXT.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31383>
 2024-10-28 16:27:35 +00:00
Semenov Herman (Семенов Герман) 637a4b849a radv: fix memleaks in radv_sqtt_reloc_graphics_shaders() 
Co-authored-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31607>
 2024-10-28 15:48:05 +01:00
Lucas Stach 6775524c69 etnaviv: set PE_COLOR_FORMAT_OVERWRITE when no color target is active 
When no color target is bound PE_COLOR_FORMAT_OVERWRITE must be set to
avoid GPU hangs.

Fixes: 07cd0f2306 ("etnaviv: blend: Add support for MRTs")
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31845>
 2024-10-28 13:23:29 +00:00
Samuel Pitoiset f7652de1f1 Revert "ac/surface: add RADEON_SURF_VIEW_3D_AS_2D_ARRAY for GFX9+" 
This reverts commit dc5ef90547.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31869>
 2024-10-28 12:47:38 +00:00
Samuel Pitoiset 0ae880c08c Revert "radv: implement 2D views of 3D images using 2D_ARRAY descriptors on GFX9+" 
Using view3dAs2dArray changes the tiling and it's slower (-7.5% in
Silent Hill 2 Remake) than using 3D tiling. The previous implementation
was the best one regarding performance (it's also what RadeonSI does).

Sadly it seems that sampler2DViewOf3D can't really be supported without
that but nobody really needs it apparently.

Also view3dAs2array is incompatible for 2D views of sparse 3D images
because sparse 3D images requires 3D tiling.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11997

This reverts commit f5805bcb8e.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31869>
 2024-10-28 12:47:38 +00:00
Samuel Pitoiset 742a1097a9 Revert "radv: advertise sampler2DViewOf3D" 
This feature has never been exposed in stable releases, so I think it's
fine to disable it.

This reverts commit 493d5910a3.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31869>
 2024-10-28 12:47:38 +00:00
Samuel Pitoiset b3a06daa72 radv: simplify determining if dual-source blending is enabled 
If blending is disabled or the color write mask is 0, dual-source
blending would be ignored, and this can be simplified a bit.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31681>
 2024-10-28 12:04:59 +00:00
Daniel Schürmann 10958d04d5 aco: Respect addressible SGPR limit in VS prologs 
On Tonga, the effective SGPR limit is 96, including VCC.

Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31859>
 2024-10-28 11:29:06 +00:00
Samuel Pitoiset dc5efa892f radv: remove useless check about gl_Position as PS inputs for NGGC 
gl_Position isn't part of the PS inputs read mask.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31830>
 2024-10-28 11:03:47 +00:00
Samuel Pitoiset 8e4d1965bd radv: fix considering NGG culling for depth-only rendering 
When the FS is unknown, this can happen with fast-link GPL or unlinked
ESO, rely on the number of VS/TES outputs which should be a good
approximation of the number of PS inputs.

This fixes a (huge?) performance regression from May 2023 because
for depth-only rendering, the FS is NULL and NGG culling wasn't
considered at all.

Cc: mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31830>
 2024-10-28 11:03:47 +00:00
Job Noorman 19c560da04 ir3: fix physical edges of predicated branches 
The algorithm for adding extra physical edges works by finding edges
that jump over reconvergence points. Since predicated branches don't
introduce reconvergence points, we wouldn't add a physical edge from the
true block to the false block. However, this physical edge is still
needed as control flow does fall though here. This patch fixes this by
manually adding the physical edge so that we don't need to insert a
reconvergence point for it.

Signed-off-by: Job Noorman <jnoorman@igalia.com>
Fixes: 39088571f0 ("ir3: add support for predication")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31733>
 2024-10-28 10:37:36 +00:00
Samuel Pitoiset 72871d8330 radv: set missing FMASK surface counters for MSAA MRTs 
This has been removed few years ago by mistake but it's important for
performance. This is mostly for addrlib to determine tile_swizzle which
is used to make memory access faster with multiple render targets.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31797>
 2024-10-28 08:21:12 +01:00
Samuel Pitoiset aa19bf3d93 amd/descriptors: set fmask_tile_swizzle for TC-compat CMASK images on GFX8 
This is required.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31797>
 2024-10-28 08:21:12 +01:00
Vignesh Raman c3531d5fea ci: rename FORCE_KERNEL_TAG to EXTERNAL_KERNEL_TAG 
FORCE_KERNEL_TAG allows testing kernel uprevs without rebuilding
containers by supplying an external kernel directly for booting on
hardware devices. Renaming it to EXTERNAL_KERNEL_TAG clarifies its
purpose, distinguishing it from KERNEL_TAG which rebuilds containers.

Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31795>
 2024-10-28 02:18:27 +00:00
Jose Maria Casanova Crespo f47c692d99 v3dv/ci: Add missing fails on RPi4/5 for uprev VKCTS to 1.3.10.0 
Fixes: 38d7492391 ("ci: uprev VKCTS to 1.3.10.0")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31866>
 2024-10-28 01:33:15 +00:00
Valentine Burley e18733300e anv/ci: Remove additive blending fails on ADL 
This was a VKCTS bug on earlier version of the CTS.

These tests have been actually passing since the VKCTS was uprevved to
1.3.9.0, which landed a bit before ADL testing in CI was turned on.

Signed-off-by: Valentine Burley <valentine.burley@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31862>
 2024-10-27 21:43:18 +00:00
Valentine Burley 3b5e49a7f8 intel/ci: Fix Alder Lake's configuration 
There's currently no GL or GLES testing on the iris gallium driver,
and the VKCTS expectations were erroneously listed under iris-*.txt.

Fix the rules set for anv-adl-full, change the GPU_VERSION to anv-adl
and move the expectations around accordingly.

Signed-off-by: Valentine Burley <valentine.burley@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31862>
 2024-10-27 21:43:18 +00:00
David Heidelberg 5b3f7de99f ci/freedreno: Introduce OpenCL testing for Adreno 618, 660, and 750 
Implement testing rusticl with piglit.

Piglit OpenCL support enablement already got merged.

Signed-off-by: David Heidelberg <david@ixit.cz>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30835>
 2024-10-27 14:04:41 +00:00
Dmitry Baryshkov 4f1adb71d6 rusticl: Enable on freedreno 
To really use the driver, specify the environment variable:

  export RUSTICL_ENABLE=msm

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30835>
 2024-10-27 14:04:41 +00:00
Rob Clark 63a5803433 freedreno/ir3: Do not propagate away a widening move 
A narrowing move from const is just emulated CONSTANT_DEMOTION_ENABLE so
we can permit it.  But not the inverse.

Cc: mesa-stable
Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30835>
 2024-10-27 14:04:41 +00:00
Rob Clark e89e89caeb freedreno/computerator: Make shader show up in devcore/etc 
Previously we were hitting the BO heap which isn't dumped because the
buffer was mappable.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30835>
 2024-10-27 14:04:41 +00:00
Rob Clark f58c1aebff ir3/ra: Better CL/kernel support 
With CL we do not know the local wg size at compile time.  Assuming the
worst-case (max) size limits the register footprint, leading to excess
spilling.  OTOH with CL the app queries the supported local size after
compiling the kernel.  So instead pick the largest warp size as the
target.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30835>
 2024-10-27 14:04:41 +00:00
Rob Clark f3211e243f freedreno/a6xx: Support variable wg size 
If local wg size isn't known at compile time, we need to move some of
the state emit out of the state object and into IB2 cmdstream.

This still doesn't account for the fact that RA currently must assume
the worst case, meaning limiting cl kernels to a miniumum number of regs
and spilling excessively.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30835>
 2024-10-27 14:04:41 +00:00
David Heidelberg 1569219f51 freedreno/ir3: Lower fisnormal op 
Avoid crash when running piglit test:
program@execute@builtin@builtin-float-isnormal-1.0.generated

Signed-off-by: David Heidelberg <david@ixit.cz>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30835>
 2024-10-27 14:04:40 +00:00
Dmitry Baryshkov e20f02f64a freedreno/ir3: Lower the hadd operations 
There do not seem to be instructions for the ihadd/uhadd NIR operations.
Lower them to simpler ops.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30835>
 2024-10-27 14:04:40 +00:00
Dmitry Baryshkov 8707c15b5b freedreno/ir3: Treat MESA_SHADER_KERNEL in the same way as compute 
In ir3_shader_descriptor_set() tread MESA_SHADER_KERNEL shaders in the
same way, as PIPE_SHADER_COMPUTE shaders, return 0.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30835>
 2024-10-27 14:04:40 +00:00
Iván Briano 13db5fad27 brw: fix task/mesh push constant loading 
The InlineData passed to the shader is a fixed size unrelated to the
register size. It happens to match pre-Xe2, but by considering it the
same in Xe2, we ended up reading pushed constants from the wrong place
when they didn't fit in the InlineData.

Fixes: 97b17aa0b1 ("brw/nir: rework inline_data_intel to work with compute")

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31856>
 2024-10-26 18:12:41 +00:00
Jordan Justen b7560fa048 anv: Build for Xe3 
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31838>
 2024-10-26 07:39:30 +00:00
Jordan Justen 35ace9d4e2 intel/compiler: Xe2 and Xe3 use the same compaction tables 
Ref: bspec 56709
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31838>
 2024-10-26 07:39:30 +00:00
Jordan Justen 688a673c5a intel/brw: Allow Xe3 in brw_stage_has_packed_dispatch() 
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31838>
 2024-10-26 07:39:30 +00:00
Jordan Justen efa7aa4e47 intel/dev: Add PTL PCI IDs (with FORCE_PROBE set) 
Ref: bspec 72574
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31838>
 2024-10-26 07:39:30 +00:00
Jordan Justen bd52bef69e intel/dev: Add PTL device info 
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31838>
 2024-10-26 07:39:30 +00:00
Jordan Justen 6242b70354 intel/dev: Add INTEL_PLATFORM_PTL platform enum 
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31838>
 2024-10-26 07:39:30 +00:00
Jordan Justen cd33b7766a intel/compiler: Add compiler enum for Xe3 
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31838>
 2024-10-26 07:39:30 +00:00
Jordan Justen f59ae1ec10 intel/dev: Add Xe3 support to get_l3_list() 
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31838>
 2024-10-26 07:39:30 +00:00
Jordan Justen fa964dcadc iris: Build for Xe3 
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31838>
 2024-10-26 07:39:30 +00:00
Jordan Justen ae7619429e intel/shaders: Build for Xe3 
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31838>
 2024-10-26 07:39:30 +00:00
Jordan Justen 521d2299b8 intel/isl: Build for Xe3 
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31838>
 2024-10-26 07:39:29 +00:00
Jordan Justen acb1c45a8b intel/genxml: Start Xe3 support 
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31838>
 2024-10-26 07:39:29 +00:00
Jordan Justen 2d15c23e4a intel/dev: Add XE3_FEATURES macro 
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31838>
 2024-10-26 07:39:29 +00:00
Jordan Justen d476badb48 intel/dev: Support Xe3 device init (for intel_device_info_test) 
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31838>
 2024-10-26 07:39:29 +00:00
Ian Romanick 04e1783278 brw: Call brw_fs_opt_algebraic less often 
No shader-db or fossil-db changes on any Intel platform.

Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31729>
 2024-10-25 23:39:36 +00:00
Ian Romanick ac64b78f1f brw/copy: Perform constant folding with constant propagation 
No shader-db or fossil-db changes on any Intel platform.

v2: Simlify the logic for when to try constant folding. Do
commute_immediates before constant folding. Both suggested by Ken.

Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31729>
 2024-10-25 23:39:36 +00:00
Ian Romanick 2cc1575a31 brw/algebraic: Refactor constant folding out of brw_fs_opt_algebraic 
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31729>
 2024-10-25 23:39:36 +00:00
Eric Engestrom 90ad5d3f06 ci: drop dead "load jwt in the environment just before exiting the job" code 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31855>
 2024-10-25 21:41:05 +00:00
Ian Romanick 5dcad54902 brw/sat: Convert nearly all tests to use new style builders 
v2: Use new style builder for second ADD in other_non_saturated_use
too.

Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31834>
 2024-10-25 20:31:45 +00:00
Ian Romanick 19ae7aceb5 brw/sat: Fix small typos, copy and paste, etc. 
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31834>
 2024-10-25 20:31:45 +00:00
Ian Romanick de45273307 brw/builder: Add new style ALU3 builder 
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31834>
 2024-10-25 20:31:45 +00:00
Ian Romanick 8329c04521 brw/copy: Don't remove instructions w/ conditional modifier 
Fixes: 9e750f00c3 ("intel/brw: Make opt_copy_propagation_defs clean up its own trash")
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31834>
 2024-10-25 20:31:44 +00:00