AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
166,547 Commits 1 Branch 0 Tags
7efabfbbe4f5ae442e62803a7e173bd2bf20001a
Commit Graph

166547 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Hans-Kristian Arntzen 7efabfbbe4 radv: Fix missing VK_ACCESS_2_SHADER_SAMPLED_READ_BIT. 
Cannot be used for SSBO, so ignore SCACHE invalidation.

Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Fixes: 8df17163c7 ("radv: implement vkCmdWaitEvents2KHR")
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21271>
 2023-02-12 15:45:52 +00:00
Hans-Kristian Arntzen 97aa8d9547 radv: Fix invalid 64-bit shift. 
For sync2 bits, overflow can happen.
Use BITFIELD64_BIT to align with ANV.

Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Fixes: 8df17163c7 ("radv: implement vkCmdWaitEvents2KHR")
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21271>
 2023-02-12 15:45:52 +00:00
Michel Dänzer 49a6bdde8e glsl/standalone: Do not pass memory allocated with ralloc_size to free 
Pointed out by GCC:

In function ‘load_text_file’,
    inlined from ‘standalone_compile_shader’ at ../src/compiler/glsl/standalone.cpp:491:38,
    inlined from ‘main’ at ../src/compiler/glsl/main.cpp:98:45:
../src/compiler/glsl/standalone.cpp:358:17: error: ‘free’ called on pointer ‘block_195’ with nonzero offset 48 [-Werror=free-nonheap-object]
  358 |             free(text);
      |                 ^
In function ‘ralloc_size’,
    inlined from ‘load_text_file’ at ../src/compiler/glsl/standalone.cpp:352:31,
    inlined from ‘standalone_compile_shader’ at ../src/compiler/glsl/standalone.cpp:491:38,
    inlined from ‘main’ at ../src/compiler/glsl/main.cpp:98:45:
../src/util/ralloc.c:117:18: note: returned from ‘malloc’
  117 |    void *block = malloc(align64(size + sizeof(ralloc_header),
      |                  ^

Fixes: a9696e79fb ("main: Close memory leak of shader string from load_text_file.")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21215>
 2023-02-12 15:13:04 +00:00
Michel Dänzer bf67f32d4b glsl/standalone: Fix up _mesa_reference_shader_program_data signature 
Drop the unused ctx parameter, to match the main Mesa code.

Fixes ODR violation flagged by -Wodr with LTO enabled:

../src/mesa/main/shaderobj.h:74:1: error: ‘_mesa_reference_shader_program_data’ violates the C++ One Definition Rule [-Werror=odr]
   74 | _mesa_reference_shader_program_data(struct gl_shader_program_data **ptr,
      | ^
../src/compiler/glsl/standalone_scaffolding.cpp:76:1: note: type mismatch in parameter 1
   76 | _mesa_reference_shader_program_data(struct gl_context *ctx,
      | ^
../src/compiler/glsl/standalone_scaffolding.cpp:76:1: note: ‘_mesa_reference_shader_program_data’ was previously declared here
../src/compiler/glsl/standalone_scaffolding.cpp:76:1: note: code may be misoptimized unless ‘-fno-strict-aliasing’ is used

Fixes: 717a720e9c ("mesa: drop unused context parameter to shader program data reference.")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21215>
 2023-02-12 15:13:04 +00:00
Rob Clark c0bc0ecf9e freedreno: Avoid screen lock when no rsc tracking needed 
In case there is no dirty state that requires resource tracking we
can skip taking the screen lock.  Indirect draw and index buffer are
a special case, but we can inexpensively check if they are already
referenced by the batch.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21202>
 2023-02-11 16:36:38 +00:00
Rob Clark b70ea03302 freedreno: Add FD_DIRTY_QUERY 
Replace update_active_queries, which was really just a dirty-bit in
disguise.  This also lets us associate it with FD_DIRTY_RESOURCE so
we can skip the associated resource tracking when it isn't dirty.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21202>
 2023-02-11 16:36:37 +00:00
Rob Clark 3a98822cc7 freedreno: Remove impossible NULL check 
All gens implement query support now.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21202>
 2023-02-11 16:36:37 +00:00
Rob Clark 918caaad59 freedreno: Move num_vertices calc to backend 
Only used by a2xx and a3xx backends, so move it there.

Also make it more clear that fd6_emit::draw is only used in the
driver-params case.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21202>
 2023-02-11 16:36:37 +00:00
Rob Clark b15aaea1d5 freedreno/a6xx: Move num_driver_params to program state 
No need to re-calculate this at draw time.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21202>
 2023-02-11 16:36:37 +00:00
Bas Nieuwenhuizen 0a17c3afc5 nir: Apply a maximum stack depth to avoid stack overflows. 
A stackless (or at least using allocated memory for stack) version
might be nice but for now this works around some games compiling
large shaders and hitting stack overflows.

CC: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21231>
 2023-02-11 15:01:42 +01:00
Jesse Natalie 7ead717393 dzn: Enable 16bit types when supported 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>
 2023-02-11 06:12:23 +00:00
Jesse Natalie d7f9e2db59 dzn: Get options4 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>
 2023-02-11 06:12:23 +00:00
Jesse Natalie 08fc7315c5 dzn: Delete unused extensions table 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>
 2023-02-11 06:12:23 +00:00
Jesse Natalie cc906c0eed dzn: Enable get_surface_capabilities2 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>
 2023-02-11 06:12:23 +00:00
Jesse Natalie a7d4309234 spirv2dxil: Support 16bit types 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>
 2023-02-11 06:12:23 +00:00
Jesse Natalie 536ab16bc1 spirv2dxil: Move shader model into runtime conf struct 
We'll want to use it to control the shape of the nir that we generate

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>
 2023-02-11 06:12:23 +00:00
Jesse Natalie 4c527f4fc0 spirv2dxil: Lower unaligned loads and stores 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>
 2023-02-11 06:12:23 +00:00
Jesse Natalie 9e2683c6f0 spirv2dxil: Set min UBO/SSBO alignments 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>
 2023-02-11 06:12:23 +00:00
Jesse Natalie 58e7acb0e2 microsoft/compiler: Support lowering SSBO accesses to 16bit vectors 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>
 2023-02-11 06:12:23 +00:00
Jesse Natalie 0f56fc09d9 microsoft/compiler: Support raw buffer load/store intrinsics with 16bit alignment 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>
 2023-02-11 06:12:23 +00:00
Jesse Natalie 196dc72838 microsoft/compiler: Handle 48-bit stores to SSBO/shared 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>
 2023-02-11 06:12:23 +00:00
Jesse Natalie c994c8b3fd microsoft/compiler: Pass an alignment to constant buffer load lowering 
This means we can stop doing conditionals and shifts if we know the
alignment of a load for a small amount of data.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>
 2023-02-11 06:12:23 +00:00
Jesse Natalie 7fcb60be37 microsoft/compiler: Simplify bitpacking for load/store lowering with nir_extract_bits 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>
 2023-02-11 06:12:23 +00:00
Jesse Natalie 7830901751 microsoft/compiler: Pass deref modes to unaligned pass and handle push const 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>
 2023-02-11 06:12:23 +00:00
Jesse Natalie facd2e4fdb microsoft/compiler: Move unaligned load/store pass from CL 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>
 2023-02-11 06:12:23 +00:00
Jesse Natalie f50843fcdb microsoft/compiler: Handle undef-rounding f2f16 as rtz 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>
 2023-02-11 06:12:23 +00:00
Jesse Natalie 8782a0b8df microsoft/compiler: Ensure native_low_precision is set for 16-bit bitcasts/stores 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>
 2023-02-11 06:12:23 +00:00
Jesse Natalie 4d76d46c13 microsoft/compiler: Handle frcp for float16/float64 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>
 2023-02-11 06:12:23 +00:00
Jesse Natalie ed13c2261c microsoft/compiler: Handle struct consts in DXIL module dumper 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>
 2023-02-11 06:12:23 +00:00
Jesse Natalie 25ee07373c nir_lower_fp16_casts: Allow opting out of lowering certain rounding modes 
Reviewed-by: Giancarlo Devich <gdevich@microsoft.com>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>
 2023-02-11 06:12:23 +00:00
Jesse Natalie c0c2b60f1d nir: Add alignment to load_push_constant 
Reviewed-by: Giancarlo Devich <gdevich@microsoft.com>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21029>
 2023-02-11 06:12:23 +00:00
Jesse Natalie 42267588d7 ci/windows: Update LLVM to 15 
Reviewed-by: Karol Herbst <kherbst@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21168>
 2023-02-11 05:24:08 +00:00
Jesse Natalie e9ab33c9a1 microsoft/clc: Set features that are used by CL tests 
Reviewed-by: Karol Herbst <kherbst@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21168>
 2023-02-11 05:24:08 +00:00
Jesse Natalie b27d8ee2e9 clc: Include opencl-c-base.h with LLVM 15 (using builtins) 
Reviewed-by: Karol Herbst <kherbst@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21168>
 2023-02-11 05:24:08 +00:00
Jonathan Marek dda35e616b turnip: fix use of align() instead of util_align_npot() with tile_align_w 
tile_align_w isn't always a power of two.

Fixes: aae679e221

Signed-off-by: Jonathan Marek <jonathan@marek.ca>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21251>
 2023-02-11 04:56:52 +00:00
Karol Herbst cb611b207d rusticl/icd: Make it work in case Rustc shuffles struct around 
Nothing guarentees fields are in order or anything like that. So do proper offset math

Signed-off-by: Karol Herbst <kherbst@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21242>
 2023-02-11 04:13:57 +00:00
Karol Herbst f6c5cd33b0 rusticl/util: extract offset_of macro 
Signed-off-by: Karol Herbst <kherbst@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21242>
 2023-02-11 04:13:57 +00:00
Faith Ekstrand af9212dd82 nir/deref: Preserve alignments in opt_remove_cast_cast() 
This also removes the loop so opt_remove_cast_cast() will only optimize
cast(cast(x)) and not cast(cast(cast(x))).  However, since nir_opt_deref
walks instructions top-down, there will almost never be a tripple cast
because the parent cast will have opt_remove_cast_cast() run on it.

Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21252>
 2023-02-10 23:08:19 +00:00
Sviatoslav Peleshko 9b2ddd2c5e anv: Handle VkAccelerationStructureBuildRangeInfoKHR::transformOffset 
Previously it was not actually handled. This meant that all geometries
with the same transform buffer were using the same (first) transformation
matrix.

Fixes: f3ddfd81 ("anv: Build BVHs on the GPU with GRL")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7575
Signed-off-by: Sviatoslav Peleshko <sviatoslav.peleshko@globallogic.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21227>
 2023-02-10 21:27:14 +00:00
Marcin Ślusarz 465c241266 intel/compiler/mesh: use U888X packed index format 
Reviewed-by: Caio Oliveira <caio.oliveira@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20910>
 2023-02-10 21:03:33 +00:00
Danylo Piliaiev 2d20564a6a turnip: Disable draw states after dyn renderpass in all cases 
Draw states were not disabled after a dynamic renderpass which
spans several command buffers, the next renderpass if started in
the same command buffer wouldn't emit the full draw state,
since TU_CMD_DIRTY_DRAW_STATE was not set by previous renderpass.

The issue could be observed when corrupting all regs at cmdbuf start in:
 dEQP-VK.dynamic_rendering.primary_cmd_buff.random.seed7_geometry

Fixes: cb0f414b2a
("tu: Add support for suspending and resuming renderpasses")

Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21148>
 2023-02-10 20:29:40 +00:00
Danylo Piliaiev 855fa78866 turnip: Ensure that there is no renderpass rotation in binning 
It appears that A6XX_GRAS_SC_CNTL::rotation applies to the binning,
so we should ensure there is no unexpected rotations and apply with
A6XX_GRAS_SC_CNTL during the binning pass.

Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21148>
 2023-02-10 20:29:40 +00:00
Danylo Piliaiev 43ea1f2dfb freedreno: Document A6XX_GRAS_SC_CNTL::rotation field 
Likely used for VK_QCOM_render_pass_transform.

Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21148>
 2023-02-10 20:29:40 +00:00
Danylo Piliaiev 388e4ea733 tu: Prevent using stale value of GRAS_SC_CNTL in sysmem clear 
cc: mesa-stable

Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21148>
 2023-02-10 20:29:40 +00:00
Danylo Piliaiev 981f1d88a1 tu: Prevent using stale value of RB_UNKNOWN_88D0 on BLIT 
Fixes: def56b531c
("tu: Support GMEM with layered rendering and multiview")

Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21148>
 2023-02-10 20:29:40 +00:00
Amber 99fb770c45 freedreno: use blendcoherent to set FLUSH_PER_OVERLAP 
FLUSH_PER_OVERLAP is only necessary for gmem if coherent blending is
enabled.

Signed-off-by: Amber Amber <amber@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21161>
 2023-02-10 20:01:43 +00:00
Amber 527a74cb5d gallium: make BlendCoherent usable from gallium drivers 
Signed-off-by: Amber Amber <amber@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21161>
 2023-02-10 20:01:43 +00:00
Amber 40bdd2bbf7 freedreno: use A6XX_GRAS_SC_CNTL_SINGLE_PRIM_MODE with fb readback 
fixes:
dEQP-GLES31.functional.blend_equation_advanced.msaa.*

Signed-off-by: Amber Amber <amber@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21161>
 2023-02-10 20:01:43 +00:00
Mike Blumenkrantz cd446b87e1 zink: add newlines to some debug printfs 
cc: mesa-stable

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21239>
 2023-02-10 19:42:53 +00:00
Väinö Mäkelä 13f68bcce1 hasvk: Tell spirv_to_nir float controls are always supported 
This gets rid of the "Unsupported SPIR-V capability" warnings when
compiling shaders using float controls on gfx7.

Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20232>
 2023-02-10 16:34:01 +00:00