Marek Olšák
7a25521f92
radeonsi/gfx10: separate code for getting edgeflags from the gs_invocation_id VGPR
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
2020-01-15 15:06:33 -05:00
Marek Olšák
cf65c6f0d2
radeonsi: move VS_STATE.LS_OUT_PATCH_SIZE a few bits higher to make space there
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
2020-01-15 15:06:31 -05:00
Marek Olšák
34ef0c5083
radeonsi: make si_insert_input_* functions non-static
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
2020-01-15 15:06:29 -05:00
Marek Olšák
eeb4a11c11
ac/cull: don't read Position.Z if it's not needed for culling
...
It could be NULL.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
2020-01-15 15:06:20 -05:00
Marek Olšák
8070402a30
radeonsi: separate code computing info for small primitive culling
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
2020-01-15 14:59:11 -05:00
Kenneth Graunke
0a1c47074b
intel/compiler: Fix illegal mutation in get_nir_image_intrinsic_image
...
get_nir_image_intrinsic_image() was incorrectly mutating the value held
by the register which holds the intrinsic's first source (image index).
If this happened to be the register for an SSA def which is also used
elsewhere in the program, this meant that we would clobber that value
in subsequent uses.
Note that this only affects i965, because neither anv nor iris use the
binding table start sections, so nothing is ever added here.
Fixes KHR-GL46.compute_shader.resources-max on i965 with Eric Anholt's
MR !3240 applied. That MR reorders SSBOs and ABOs, so that test uses
image 0 and SSBO 0, causing this code to brilliantly add binding table
index 45 to both the image (correct) and the SSBO (bzzt, wrong!).
Fixes: 09f1de97a7 ("anv,i965: Lower away image derefs in the driver")
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Eric Anholt <eric@anholt.net >
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3404 >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3404 >
2020-01-15 19:25:35 +00:00
Rob Clark
b706a157c5
gitlab-ci: fix missing caselist.css/xsl
...
My best guess is that this was broken by d62dd8b0
Signed-off-by: Rob Clark <robdclark@chromium.org >
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3413 >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3413 >
2020-01-15 19:03:56 +00:00
Jason Ekstrand
af6c2f4193
relnotes: Add Vulkan 1.2
2020-01-15 09:25:51 -06:00
Samuel Pitoiset
7f5462e349
radv: enable Vulkan 1.2
...
This bumps the Vulkan version to 1.2.128.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
2020-01-15 08:42:25 -06:00
Samuel Pitoiset
68d6bead78
radv: implement Vulkan 1.2 features and properties
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
2020-01-15 08:42:25 -06:00
Samuel Pitoiset
b3033198a8
radv: implement Vulkan 1.1 features and properties
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
2020-01-15 08:42:25 -06:00
Samuel Pitoiset
a09ab76828
radv: update VK_KHR_timeline_semaphore for Vulkan 1.2
...
Promoted to Vulkan 1.2 with the KHR suffix omitted.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
2020-01-15 08:42:25 -06:00
Samuel Pitoiset
fab0aa9182
radv: update VK_KHR_uniform_buffer_standard_layout for Vulkan 1.2
...
Promoted to Vulkan 1.2 with the KHR suffix omitted.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
2020-01-15 08:42:25 -06:00
Samuel Pitoiset
3ff8d12458
radv: update VK_KHR_shader_subgroup_extended_types for Vulkan 1.2
...
Promoted to Vulkan 1.2 with the KHR suffix omitted.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
2020-01-15 08:42:25 -06:00
Samuel Pitoiset
af25c8d57b
radv: update VK_KHR_shader_float_controls for Vulkan 1.2
...
Promoted to Vulkan 1.2 with the KHR suffix omitted.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
2020-01-15 08:42:25 -06:00
Samuel Pitoiset
5335bb6c39
radv: update VK_KHR_shader_float16_int8 for Vulkan 1.2
...
Promoted to Vulkan 1.2 with the KHR suffix omitted.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
2020-01-15 08:42:25 -06:00
Samuel Pitoiset
a73d01b1db
radv: update VK_KHR_shader_atomic_int64 for Vulkan 1.2
...
Promoted to Vulkan 1.2 with the KHR suffix omitted.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
2020-01-15 08:42:25 -06:00
Samuel Pitoiset
83d1773a57
radv: update VK_KHR_imageless_framebuffer for Vulkan 1.2
...
Promoted to Vulkan 1.2 with the KHR suffix omitted.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
2020-01-15 08:42:25 -06:00
Samuel Pitoiset
b3bdb4e6ff
radv: update VK_KHR_image_format_list for Vulkan 1.2
...
Promoted to Vulkan 1.2 with the KHR suffix omitted.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
2020-01-15 08:42:25 -06:00
Samuel Pitoiset
a80229941f
radv: update VK_KHR_driver_properties for Vulkan 1.2
...
Promoted to Vulkan 1.2 with the KHR suffix omitted.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
2020-01-15 08:42:25 -06:00
Samuel Pitoiset
af883bf3dc
radv: update VK_KHR_draw_indirect_count for Vulkan 1.2
...
Promoted to Vulkan 1.2 with the KHR suffix omitted.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
2020-01-15 08:42:25 -06:00
Samuel Pitoiset
b537be4368
radv: update VK_KHR_depth_stencil_resolve for Vulkan 1.2
...
Promoted to Vulkan 1.2 with the KHR suffix omitted.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
2020-01-15 08:42:25 -06:00
Samuel Pitoiset
5993f13b27
radv: update VK_KHR_create_renderpass2 for Vulkan 1.2
...
Promoted to Vulkan 1.2 with the KHR suffix omitted.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
2020-01-15 08:42:25 -06:00
Samuel Pitoiset
b2be00fbc1
radv: update VK_KHR_buffer_device_address for Vulkan 1.2
...
Promoted to Vulkan 1.2 with the KHR suffix omitted.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
2020-01-15 08:42:25 -06:00
Samuel Pitoiset
0eb26aae1c
radv: update VK_KHR_8bit_storage for Vulkan 1.2
...
Promoted to Vulkan 1.2 with the KHR suffix omitted.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
2020-01-15 08:42:25 -06:00
Samuel Pitoiset
b4eed4e548
radv: update VK_EXT_scalar_block_layout for Vulkan 1.2
...
Promoted to Vulkan 1.2 with the EXT suffix omitted.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
2020-01-15 08:42:25 -06:00
Samuel Pitoiset
efdf9d8969
radv: update VK_EXT_sampler_filter_minmax for Vulkan 1.2
...
Promoted to Vulkan 1.2 with the EXT suffix omitted.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
2020-01-15 08:42:25 -06:00
Samuel Pitoiset
65e215e6f3
radv: update VK_EXT_host_query_reset for Vulkan 1.2
...
Promoted to Vulkan 1.2 with the EXT suffix omitted.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
2020-01-15 08:42:25 -06:00
Samuel Pitoiset
95ec0c050b
radv: update VK_EXT_descriptor_indexing for Vulkan 1.2
...
Promoted to Vulkan 1.2 with the EXT suffix omitted.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
2020-01-15 08:42:25 -06:00
Iván Briano
4ef3f7e3d3
anv: Enable Vulkan 1.2 support
...
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
2020-01-15 08:34:57 -06:00
Jason Ekstrand
c616627f63
anv: Implement the new core version property queries
...
Vulkan 1.2 introduces some new structures to get the properties and
features of a device from extensions that were promoted to core in 1.1
and 1.2. This commit implements the new property queries and makes all
of the corresponding extension queries map to them.
Reviewed-by: Iván Briano <ivan.briano@intel.com >
2020-01-15 08:34:57 -06:00
Jason Ekstrand
a47152c622
anv: Implement the new core version feature queries
...
Vulkan 1.2 introduces some new structures to get the properties and
features of a device from extensions that were promoted to core in 1.1
and 1.2. This commit implements the new feature queries and makes all
of the corresponding extension queries map to them.
Reviewed-by: Iván Briano <ivan.briano@intel.com >
2020-01-15 08:34:57 -06:00
Jason Ekstrand
721666e52a
anv,nir: Lower quad_broadcast with dynamic index in NIR
...
This is required for the subgroupBroadcastDynamicId feature that was
added in Vulkan 1.2.
Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com >
2020-01-15 08:34:57 -06:00
Jason Ekstrand
7e3e2ce702
anv: Bump the patch version to 131
2020-01-15 08:34:57 -06:00
Samuel Pitoiset
f33a68af63
vulkan/overlay: Fix for Vulkan 1.2
...
v2 (Jason Ekstrand):
- Add duplicate hooks for both the 1.2 and KHR versions of
vkCmdDraw[Indexed]IndirectCount.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
2020-01-15 08:34:57 -06:00
Jason Ekstrand
75755e0eba
turnip: Pretend to support Vulkan 1.2
...
It doesn't really support any Vulkan properly yet so why not claim 1.2?
This was an easier way of fixing the build than trying to roll it
forward to a later version of ANV's entrypoint generator scripts.
2020-01-15 08:34:57 -06:00
Jason Ekstrand
ac0c7ad2c2
vulkan: Update the XML and headers to 1.2.131
...
Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Acked-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
2020-01-15 08:07:04 -06:00
Michel Dänzer
8775b742ea
gitlab-ci: Stop using manual jobs for merge requests
...
They were causing trouble with Marge Bot: The project settings require
that the pipeline succeeds before a merge request (MR) can be merged,
otherwise Marge doesn't wait for the pipeline to succeed before merging
an MR assigned to her. But Marge can't start manual jobs, so she would
always time out waiting for pipelines with manual jobs.
To avoid this, use these rules:
* Run the pipeline by default for MRs and main project branches changing
any files affecting it.
* For other MRs, run a single dummy job which always succeeds.
* Don't run any jobs for main project branch changes (e.g. from an MR
having been merged) not affecting the pipeline.
* Allow jobs to be started manually on branches of forked projects, as
before.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Acked-by: Daniel Stone <daniels@collabora.com >
Reviewed-by: Eric Engestrom <eric@engestrom.ch >
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3361 >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3361 >
2020-01-15 10:31:01 +00:00
Pierre-Eric Pelloux-Prayer
7b0b085c94
radeonsi: drop the negation from fmask_is_not_identity
...
This change eases code reading ("fmask_is_identity = true" is clearer than
"fmask_is_not_identity = false").
Initialization is not changed so fmask_is_identity is false when a texture is
created.
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3174 >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3174 >
2020-01-15 10:10:15 +00:00
Pierre-Eric Pelloux-Prayer
3a527eda7c
radeonsi: unbind image before compute clear
...
It's not used and avoid infinite recursion when used from si_compute_expand_fmask
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3174 >
2020-01-15 10:10:15 +00:00
Pierre-Eric Pelloux-Prayer
c2df5389bb
radeonsi: make sure fmask expand is done if needed
...
Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2248
Fixes: 095a58204d ("radeonsi: expand FMASK before MSAA image stores are used")
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3174 >
2020-01-15 10:10:15 +00:00
Pierre-Eric Pelloux-Prayer
b5e748b49b
radeonsi: fix fmask expand compute shader
...
'coord' variable was using TGSI_WRITEMASK_XYZ so subsequent uses of
TGSI_WRITEMASK_W were dropped.
The result for a 2 samples program was:
0: UMAD TEMP[0].xy, SV[1].xyyy, IMM[0].xxxx, SV[0].xyyy
1: STORE IMAGE[0], TEMP[0], TEMP[1], RESTRICT, 2D_MSAA
2: STORE IMAGE[0], TEMP[0], TEMP[2], RESTRICT, 2D_MSAA
3: END
instead of the expected:
0: UMAD TEMP[0].xy, SV[1].xyyy, IMM[0].xxxx, SV[0].xyyy
1: MOV TEMP[0].w, IMM[0].yyyy
2: LOAD TEMP[1], IMAGE[0], TEMP[0], RESTRICT, 2D_MSAA
3: MOV TEMP[0].w, IMM[0].zzzz
4: LOAD TEMP[2], IMAGE[0], TEMP[0], RESTRICT, 2D_MSAA
5: MOV TEMP[0].w, IMM[0].yyyy
6: STORE IMAGE[0], TEMP[0], TEMP[1], RESTRICT, 2D_MSAA
7: MOV TEMP[0].w, IMM[0].zzzz
8: STORE IMAGE[0], TEMP[0], TEMP[2], RESTRICT, 2D_MSAA
9: END
This fixes half of https://gitlab.freedesktop.org/mesa/mesa/issues/2248
Fixes: 095a58204d ("radeonsi: expand FMASK before MSAA image stores are used")
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3174 >
2020-01-15 10:10:15 +00:00
Nataraj Deshpande
be08e6a449
egl/android: Restrict minimum triple buffering for android color_buffers
...
The patch restricts triple buffering as minimum at driver for android
color_buffers in order to fix onscreen performance hit for T-Rex and
Manhattan.
v2: Update min_buffer check condition (Tapani Pälli)
v3: further code cleanup (Eric Engestrom)
Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2332
Fixes: 0661c357c6 ("egl/android: Update color_buffers querying for buffer age")
Signed-off-by: Nataraj Deshpande <nataraj.deshpande@intel.com >
Reviewed-by: Tapani Pälli <tapani.palli@intel.com >
Reviewed-by: Eric Engestrom <eric@engestrom.ch >
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3384 >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3384 >
2020-01-15 09:42:08 +00:00
Lionel Landwerlin
a014105498
anv: fix pipeline switch back for non pipelined states
...
Setting state base address can happen even before pipeline is
selected. Also we must ensure it is set to 3D for Gen12, we can't
switch back to an invalid pipeline value (UINT32_MAX).
v2: Reuse helpers (Jason)
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Fixes: b34422db5e ("anv: Implement Gen12 workaround for non pipelined state")
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3396 >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3396 >
2020-01-15 11:14:43 +02:00
Samuel Pitoiset
fce28a7341
radv/gfx10: simplify some duplicated NGG GS code
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3382 >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3382 >
2020-01-15 07:45:29 +00:00
Samuel Pitoiset
53b50be35c
radv/gfx10: enable all CUs if NGG is never used
...
Ported from RadeonSI.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3382 >
2020-01-15 07:45:29 +00:00
Samuel Pitoiset
5ff12322c9
radv: only use VkSamplerCreateInfo::compareOp if enabled
...
Cc: <mesa-stable@lists.freedesktop.org >
Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2350
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3392 >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3392 >
2020-01-15 08:16:15 +01:00
Iago Toral Quiroga
3f3ec07be5
v3d: fix bug when checking result of syncobj fence import
...
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com >
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3383 >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3383 >
2020-01-15 07:53:58 +01:00
Jonathan Marek
222e127e39
st/mesa: run st_nir_lower_tex_src_plane for lowered xyuv/ayuv
...
Has the effect of removing the nir_tex_src_plane for these formats too.
Signed-off-by: Jonathan Marek <jonathan@marek.ca >
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com >
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1896 >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1896 >
2020-01-15 02:20:00 +00:00
Jonathan Marek
a554b45d73
st/mesa: don't lower YUV when driver supports it natively
...
This fixes YUYV support on etnaviv.
Fixes: 7404833c "gallium: add handling for YUV planar surfaces"
Signed-off-by: Jonathan Marek <jonathan@marek.ca >
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1896 >
2020-01-15 02:20:00 +00:00