Tapani Pälli
7dcea9dd7b
docs/features: add VK_EXT_legacy_dithering
...
Signed-off-by: Tapani Pälli <tapani.palli@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19414 >
2024-05-15 04:45:55 +00:00
Tapani Pälli
2ac5e70fae
anv: VK_EXT_legacy_dithering support
...
Toggle on dithering if it has been enabled on device and is set on the
rendering flags used.
Signed-off-by: Tapani Pälli <tapani.palli@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19414 >
2024-05-15 04:45:55 +00:00
Tapani Pälli
e7ce48557a
vulkan/runtime: add a subpass bit for legacy dithering
...
v2: use bit only when dithering enabled on device
Signed-off-by: Tapani Pälli <tapani.palli@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19414 >
2024-05-15 04:45:55 +00:00
Valentine Burley
826d467e40
tu: Change commas to semicolons in VK_EXT_map_memory_placed features
...
Semicolons should be used for device features.
Fixes: 220dae5870 ("tu: Implement VK_EXT_map_memory_placed")
Signed-off-by: Valentine Burley <valentine.burley@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29206 >
2024-05-15 02:08:29 +00:00
Valentine Burley
03d8620c4c
tu: Add missing VK_EXT_legacy_vertex_attributes feature
...
This was missed during enablement.
Fixes: 660a47ecbf ("tu: support VK_EXT_legacy_vertex_attributes")
Signed-off-by: Valentine Burley <valentine.burley@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29206 >
2024-05-15 02:08:29 +00:00
Chia-I Wu
59babe9fa0
radv: make radv_pipeline_has_ngg static
...
radv_pipeline_has_ngg has no external user anymore. Also remove the
unused radv_pipeline_has_gs_copy_shader.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29200 >
2024-05-14 23:42:25 +00:00
Chia-I Wu
be391fdb33
radv: check gs_copy_shader directly for executable props
...
The pipeline could be a graphics pipeline library and
radv_pipeline_to_graphics would assert on debug builds.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29200 >
2024-05-14 23:42:25 +00:00
Iván Briano
a9f24fb5f1
intel/brw: fix subgroup size of geometry stages for lnl+
...
Fixes dEQP-VK.subgroups.size_control.*allow_varying_subgroup_size* and
maybe others checking subgroup size.
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29177 >
2024-05-14 23:13:37 +00:00
David Heidelberg
a28a289374
ci/freedreno: update expectations from the nightly run
...
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28323 >
2024-05-14 21:16:55 +00:00
David Heidelberg
96ad012878
freedreno/ci: Implement nightly piglit job for Adreno 630 and 618
...
Signed-off-by: David Heidelberg <david@ixit.cz >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28323 >
2024-05-14 21:16:55 +00:00
David Heidelberg
0e5a567523
freedreno/ci: Drop duplicated include and add missing stages
...
The .collabora-freedreno-rules are overriten by
.collabora-freedreno-turnip-rules which already includes these rules.
Signed-off-by: David Heidelberg <david@ixit.cz >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28323 >
2024-05-14 21:16:55 +00:00
Rob Clark
926865580e
freedreno/ci: Increase a630/a618 piglit fraction
...
After dropping obsolete skips, the piglit jobs take too long to run, so
switch to 1-in-3 fractional runs.
TODO we need nightly full runs
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28323 >
2024-05-14 21:16:55 +00:00
Rob Clark
da212113f8
freedreno/ci: Skip some slow tests
...
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28323 >
2024-05-14 21:16:55 +00:00
Rob Clark
4e1be72dd4
freedreno/ci: Skip built-in-functions VS/GS tests
...
They don't really add any additional coverage compared to the same
built-ins in FS, so we can just skip them to trim runtime.
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28323 >
2024-05-14 21:16:55 +00:00
Rob Clark
6cb8c5dad0
freedreno/ci: Add a common skips file to a618_piglit.
...
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28323 >
2024-05-14 21:16:55 +00:00
Rob Clark
b92c6e16ab
freedreno/ci: Skip max-texture-size
...
It is just an OoM test
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28323 >
2024-05-14 21:16:55 +00:00
Rob Clark
242a591d4c
freedreno/ci: Skip unsupported legacy gl stuff
...
Don't bother even trying to test legacy gl features that the hw does not
support and cannot be emulated (or at least not reasonably).
Some of this could in theory be emulated with GS shader on a6xx+, at the
cost of extra draw time overhead. But unless someone shows up with a
real world need for these features (ie. something other than piglit/cts)
I don't think we should penalize every other gl app with the extra
overhead. If you want a slow-but-implements-gl-rusty-sharp-edges driver,
zink already exists to fill that niche. (And if someone does find some
app that needs these features, the right answer is probably driconf to
trigger a transparent fallback to zink.)
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8850
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28323 >
2024-05-14 21:16:55 +00:00
Rob Clark
2e7970b067
freedreno/ci: Refactor out common a6xx skips list
...
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28323 >
2024-05-14 21:16:55 +00:00
Rob Clark
6d260752b8
freedreno/ci: Remove some obsolete skips
...
These should have been in xfails, so we'd have noticed to remove them
when corresponding fixes and piglit fixes (uprevs) landed.
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28323 >
2024-05-14 21:16:55 +00:00
Rob Clark
a42db02808
freedreno/ci: Remove some skips
...
We originally skipped these before they were supported, but forgot to
remove them from the skips list once gl46 and related extensions were
added.
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28323 >
2024-05-14 21:16:55 +00:00
Rhys Perry
4abe5b7927
aco/gfx12: disable s_cmpk optimization
...
These opcodes were removed.
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com >
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com >
Acked-by: Daniel Schürmann <daniel@schuermann.dev >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29162 >
2024-05-14 20:50:28 +00:00
Rhys Perry
2c4f561708
aco: don't change prefetch mode on GFX11.5+
...
This instruction was effectively removed:
https://github.com/llvm/llvm-project/commit/ba131b7017ce
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com >
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com >
Acked-by: Daniel Schürmann <daniel@schuermann.dev >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29162 >
2024-05-14 20:50:27 +00:00
Rhys Perry
5e58e32832
aco/tests: add GFX12 assembler tests
...
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com >
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com >
Acked-by: Daniel Schürmann <daniel@schuermann.dev >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29162 >
2024-05-14 20:50:27 +00:00
Rhys Perry
e1e5bc0dd0
aco: support GFX12 in assembler
...
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com >
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com >
Acked-by: Daniel Schürmann <daniel@schuermann.dev >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29162 >
2024-05-14 20:50:27 +00:00
Rhys Perry
74aa6437d6
aco: add GFX11.5+ opcodes
...
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com >
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com >
Acked-by: Daniel Schürmann <daniel@schuermann.dev >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29162 >
2024-05-14 20:50:27 +00:00
Rhys Perry
97698e564a
aco: add SFPU/ValuPseudoScalarTrans instr class
...
The latency is from LLVM's SISchedule.td
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com >
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com >
Acked-by: Daniel Schürmann <daniel@schuermann.dev >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29162 >
2024-05-14 20:50:27 +00:00
Rhys Perry
e9a25151fa
aco/tests: support GFX12
...
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com >
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com >
Acked-by: Daniel Schürmann <daniel@schuermann.dev >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29162 >
2024-05-14 20:50:27 +00:00
Yiwei Zhang
43bb989070
turnip: virtio: fix racy gem close for re-imported dma-buf
...
Similar to the prior fix for msm. On the dmabuf import path, tu_bo_init
can be outside of the vma lock, but left inside for code simplicity.
Fixes: f17c5297d7 ("tu: Add virtgpu support")
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29093 >
2024-05-14 19:11:12 +00:00
Yiwei Zhang
6ca192f586
turnip: virtio: fix iova leak upon found already imported dmabuf
...
There's a success path on found dmabuf while the iova won't be cleaned
up. This change defers iova alloc till lookup miss and also to prepare
for later racy dmabuf re-import fix.
Also documented a potential leak on error path due to unable to tell
whether a gem handle should be closed or not without refcounting.
Fixes: f17c5297d7 ("tu: Add virtgpu support")
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29093 >
2024-05-14 19:11:12 +00:00
Yiwei Zhang
585a87ae53
turnip: virtio: fix error path in virtio_bo_init
...
Fixes: f17c5297d7 ("tu: Add virtgpu support")
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29093 >
2024-05-14 19:11:11 +00:00
David Rosca
b33bb4077d
frontends/va: Only increment slice offset after first slice parameters
...
Fixes slice offset if app submits exactly one data buffer followed by
parameter buffers.
Fixes: 6746d4df6e ("frontends/va: Fix AV1 slice_data_offset with multiple slice data buffers")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11133
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11138
Tested-by: Marcus Seyfarth <m.seyfarth@gmail.com >
Reviewed-by: Boyuan Zhang <Boyuan.Zhang@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29124 >
2024-05-14 18:51:03 +00:00
Mike Blumenkrantz
1240fbba21
ci: bump VVL to v1.3.285
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29198 >
2024-05-14 18:09:28 +00:00
Mike Blumenkrantz
f4a66eadf9
zink: set all spirv caps for the vvl vtn pass
...
this avoids internal warnings/errors from caps
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29195 >
2024-05-14 17:47:01 +00:00
Karol Herbst
48c752d3e0
event: break long dependency chains on drop
...
This prevents stack overflows on drop without making it expensive to read
from dependencies (e.g. my attempt to use Weak instead).
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29190 >
2024-05-14 17:26:39 +00:00
Karol Herbst
2f1f98e846
Revert "rusticl/event: use Weak refs for dependencies"
...
I didn't like the solution and I _think_ it even introduced a potential
regressions involving releasing failed events and that causing dependents
to run and succeed regardless.
This reverts commit a45f199086 .
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29190 >
2024-05-14 17:26:38 +00:00
Nanley Chery
3bdfe0e2a3
intel/isl: Update quote for XeHP's CCS halign rule
...
Clarify that the depth/stencil rules take precedence over the CCS rules.
From Bspec 43862 (r52666).
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29167 >
2024-05-14 16:56:04 +00:00
Nanley Chery
c31d59f078
intel/isl: Reduce halign for disabled CCS on XeHP
...
Reduce the space consumption of mipmapped images which don't use
compression.
Based on Bspec 43862 (r52666).
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29167 >
2024-05-14 16:56:04 +00:00
Nanley Chery
0f41ffe230
intel/isl: Add and use _isl_surf_info_supports_ccs
...
Replace a lot of open-coded checks which determine if CCS might be
enabled during surface layout.
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29167 >
2024-05-14 16:56:04 +00:00
Samuel Pitoiset
6c8224c693
radv: simplify radv_emit_ps_inputs() slightly
...
Also remove useless check about ps_offset being zero because memcmp
return false in this case.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28983 >
2024-05-14 15:32:08 +00:00
Samuel Pitoiset
c63ac0521a
radv: track all graphics shaders context registers
...
This should be similar to the previous ctx_cs logic that was
implemented in order to reduce context rolls but this also applies
to shader objects.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28983 >
2024-05-14 15:32:08 +00:00
Samuel Pitoiset
db597d274b
radv: add more radeon_opt_set_xxx variants
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28983 >
2024-05-14 15:32:08 +00:00
Samuel Pitoiset
d5af67ea2c
radv: add graphics shaders context registers that need to be tracked
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28983 >
2024-05-14 15:32:07 +00:00
Samuel Pitoiset
9532b0f1b2
radv: emit graphics pipelines directly from the cmdbuf
...
This allows us to unify emitting monolithic graphics pipelines and
shader objects.
Though, this temporarily reduces performance in some games due to more
context rolls. But this will be fixed in the following commits by
using the recent mechanism to track context register writes.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28983 >
2024-05-14 15:32:07 +00:00
Samuel Pitoiset
fca40bcce3
radv: make radv_conv_gl_prim_to_gs_out() a non-static function
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28983 >
2024-05-14 15:32:07 +00:00
Rob Clark
d516721cd0
tu: Support VkExternalFormatANDROID
...
Signed-off-by: Rob Clark <robdclark@chromium.org >
Reviewed-by: Roman Stratiienko <r.stratiienko@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29090 >
2024-05-14 14:53:45 +00:00
Rob Clark
29f5a78d16
tu: Skip YUV conversion for RGB formats
...
Signed-off-by: Rob Clark <robdclark@chromium.org >
Reviewed-by: Roman Stratiienko <r.stratiienko@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29090 >
2024-05-14 14:53:45 +00:00
tarsin
99753001f3
turnip: Support AHardwareBuffer
...
Signed-off-by: tarsin <yuanqingxiang233@163.com >
[rob: various fixes for android-cts failures]
Signed-off-by: Rob Clark <robdclark@chromium.org >
Reviewed-by: Roman Stratiienko <r.stratiienko@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29090 >
2024-05-14 14:53:45 +00:00
tarsin
4b024a15f2
turnip: Split tu_image_init to use layout setting logic separately
...
Signed-off-by: tarsin <yuanqingxiang233@163.com >
[rob: improve comments about modifier taking precedence over image
create flags, and fix bogus assert]
Signed-off-by: Rob Clark <robdclark@chromium.org >
Reviewed-by: Roman Stratiienko <r.stratiienko@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29090 >
2024-05-14 14:53:45 +00:00
tarsin
ecd9ece9c1
turnip: Convert tu_device_memory to use vk_device_memory
...
Signed-off-by: Rob Clark <robdclark@chromium.org >
Reviewed-by: Roman Stratiienko <r.stratiienko@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29090 >
2024-05-14 14:53:45 +00:00
Roman Stratiienko
1373b0966c
turnip/android: Migrate to common ANB code
...
Signed-off-by: Roman Stratiienko <r.stratiienko@gmail.com >
Tested-by: tarsin <yuanqingxiang233@163.com >
Signed-off-by: Rob Clark <robdclark@chromium.org >
Reviewed-by: Roman Stratiienko <r.stratiienko@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29090 >
2024-05-14 14:53:45 +00:00