Mike Blumenkrantz
61c236bc31
zink: delete unused barrier api
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22027 >
2023-03-21 01:39:39 +00:00
Mike Blumenkrantz
30d59c469a
zink: simplify resource_check_defer_buffer_barrier()
...
this is a remnant of when the function was used for both images
and buffers
no functional changes
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22027 >
2023-03-21 01:39:39 +00:00
Mike Blumenkrantz
ca43ecefa4
zink: handle swapchain creation failure less lazily
...
this is a real scenario
cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22027 >
2023-03-21 01:39:39 +00:00
Emma Anholt
5873dcb32f
nir/lower_mediump: Fix assertion about copy_deref lowering matching.
...
Copy and paste typo. We shouldn't have copy_derefs during this pass,
anyway, but caught a failure with my upcoming unit testing.
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21666 >
2023-03-21 00:51:24 +00:00
Emma Anholt
1fff562929
glsl/lower_precision: Add actual spec quotes for "check_parameters"
...
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21666 >
2023-03-21 00:51:24 +00:00
Emma Anholt
4a51944639
glsl: Fix the precision of atomic counter builtin function args.
...
More special-casing dropped from GLSL lower_precision.
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21666 >
2023-03-21 00:51:24 +00:00
Emma Anholt
b251f94e15
glsl/lower_precision: Drop most special-casing of builtin arg precision.
...
bitCount is still special in that our lowering would try to demote its arg
based on the precision of its output, and it shouldn't do that. But the
other special cases now have appropriate qualifiers on them at the IR
level.
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21666 >
2023-03-21 00:51:24 +00:00
Emma Anholt
18e096769c
glsl: Set the precision of function return value temporaries.
...
The signature should dictate the precision of the temp we store into.
This ends up ignored by lower_precision for now, which always rewrites it
so as to handle custom lowering of builtin precision..
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21666 >
2023-03-21 00:51:24 +00:00
Emma Anholt
b1d228e9d5
glsl: Handle highp promotion of builtin function args in the builtins.
...
It's what the spec says to do. This will may help us avoid special-casing
these functions if we ever lower precision after builtin inlining.
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21666 >
2023-03-21 00:51:24 +00:00
Emma Anholt
be2731f445
glsl: Set the precisions of builtin function arguments and returns.
...
These have precision qualifiers defined in the spec, in which case we
should emit them them while generating builtin signatures and code. We've
been special-casing them in GLSL lower_precision, but now we can just rely
on the precision qualifier of the builtin if non-NONE.
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21666 >
2023-03-21 00:51:24 +00:00
Emma Anholt
2e85c9a422
glsl/lower_precision: Add a cut-down testcase for #8124
...
This pattern is the core of the webgl conformance failure, I think. And,
I think actually lower_precision was doing the right thing, just the
conformance test going through ANGLE was screwing up.
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21666 >
2023-03-21 00:51:24 +00:00
Emma Anholt
41be2caa6d
glsl/lower_precision: Add a unit test that I thought we might fail at.
...
If you lowered precision too late, it would be easy to break this.
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21666 >
2023-03-21 00:51:24 +00:00
Emma Anholt
9a2d66f5a5
glsl: Simplify vector constructors from scalars.
...
No need to generate a temp in this case. Cleanup I noticed while looking
at lower_precision behavior (and I've included a testcase to sanity check
that things work out).
This causes a tiny amount of scheduling change on freedreno:
total instructions in shared programs: 11010012 -> 11010012 (0.00%)
instructions in affected programs: 147 -> 147 (0.00%)
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21666 >
2023-03-21 00:51:24 +00:00
Faith Ekstrand
92ea49edcb
anv: Implement VK_KHR_map_memory2
...
Reviewed-by: Iván Briano <ivan.briano@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22031 >
2023-03-20 23:11:09 +00:00
Faith Ekstrand
f4a5b2d59e
anv: Limit memory maps to the client-allocated size
...
No need to expose extra padding or CCS data to the client map. Now that
we have the data, we can also make the BindBufferMemory asserts a bit
more accurate.
Reviewed-by: Iván Briano <ivan.briano@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22031 >
2023-03-20 23:11:09 +00:00
Faith Ekstrand
b4497e54be
vulkan: Provide wrappers for VK_EXT_map_memory2 functions
...
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Iván Briano <ivan.briano@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22031 >
2023-03-20 23:11:09 +00:00
Faith Ekstrand
8af4fa3d4b
vulkan: Update XML and headers to 1.3.244
...
Acked-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Acked-by: Iván Briano <ivan.briano@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22031 >
2023-03-20 23:11:09 +00:00
Mike Blumenkrantz
efa6387a09
zink: convert luminance/alpha clear colors in dynamic texture clear
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22025 >
2023-03-20 22:19:09 +00:00
Mike Blumenkrantz
600b8ba75c
zink: split out luminance/alpha clear conversion code for reuse
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22025 >
2023-03-20 22:19:08 +00:00
Patrick Lerda
84762bb1cf
glx: fix memory leak related to __glXCloseDisplay()
...
Indeed, the unbind function is not called which could lead
to an unbalanced refcount state for the "drawable" object.
For instance, with "piglit/bin/glx-fbo-binding -auto"
while setting GALLIUM_REFCNT_LOG=refcnt.log.
Signed-off-by: Patrick Lerda <patrick9876@free.fr >
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22024 >
2023-03-20 21:12:54 +00:00
Lang Yu
19b89c8077
amd/common: fix a typo
...
Fixes: 35f053ba8c ("radv: Fix corrupted mipmap copies on GFX9+")
Signed-off-by: Lang Yu <lang.yu@amd.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22000 >
2023-03-20 20:30:32 +00:00
Konstantin Seurer
deb537de3c
radv/rt: Handle load_constant instructions when inlining shaders
...
Fixes the following tests:
dEQP-VK.ray_query.builtin.rayqueryterminate.ahit.aabbs,Fail
dEQP-VK.ray_query.builtin.rayqueryterminate.ahit.triangles,Fail
dEQP-VK.ray_query.builtin.rayqueryterminate.call.aabbs,Fail
dEQP-VK.ray_query.builtin.rayqueryterminate.call.triangles,Fail
dEQP-VK.ray_query.builtin.rayqueryterminate.chit.aabbs,Fail
dEQP-VK.ray_query.builtin.rayqueryterminate.chit.triangles,Fail
dEQP-VK.ray_query.builtin.rayqueryterminate.miss.aabbs,Fail
dEQP-VK.ray_query.builtin.rayqueryterminate.miss.triangles,Fail
dEQP-VK.ray_query.builtin.rayqueryterminate.rgen.aabbs,Fail
dEQP-VK.ray_query.builtin.rayqueryterminate.rgen.triangles,Fail
dEQP-VK.ray_query.builtin.rayqueryterminate.sect.aabbs,Fail
dEQP-VK.ray_query.builtin.rayqueryterminate.sect.triangles,Fail
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8647
Fixes: fda262f ("radv/rt: move Ray Tracing shader creation into separate file")
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22002 >
2023-03-20 19:04:34 +00:00
Mike Blumenkrantz
23cd81686c
zink: further eliminate zs implicit feedback loops for read-only access
...
if all access is read-only then there is no feedback loop
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21988 >
2023-03-20 18:24:07 +00:00
Mike Blumenkrantz
a702e5038c
zink: explicitly eliminate feedback loops for unused zsbufs
...
this avoids a GENERAL/FEEDBACK_LOOP layout transition where possible
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21988 >
2023-03-20 18:24:07 +00:00
Mike Blumenkrantz
618c3651ff
zink: rename add_implicit_color_feedback_loop()
...
this is used for zs too
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21988 >
2023-03-20 18:24:07 +00:00
Mike Blumenkrantz
2d099c46cc
zink: allow zink_is_zsbuf_used() without tc / rp optimizing
...
this info should be up-to-date and usable now in all cases
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21988 >
2023-03-20 18:24:07 +00:00
Mike Blumenkrantz
c900b9e35f
zink: don't flag rp layout check on next draw when rp optimizing
...
this will always be a no-op, so save the cpu cycles
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21988 >
2023-03-20 18:24:07 +00:00
Mike Blumenkrantz
d6e40b7d54
zink: improve no-oping of write -> readonly zsbuf layouts
...
if descriptor binds exist this will have to change layouts anyway,
so allow readonly since it might be a more compatible layout
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21988 >
2023-03-20 18:24:07 +00:00
Mike Blumenkrantz
93d7bde9dc
zink: add a fixup case for readonly zsbuf clears
...
this shouldn't currently be possible to hit, but in the future it may
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21988 >
2023-03-20 18:24:07 +00:00
Mike Blumenkrantz
e2e079eef4
zink: track whether the fb zsbuf is readonly
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21988 >
2023-03-20 18:24:07 +00:00
Mike Blumenkrantz
1b9e9a54ab
zink: fix dsa state parsing for tc info
...
stencil test implies zs write
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21988 >
2023-03-20 18:24:07 +00:00
Mike Blumenkrantz
d8bb8af4f5
zink: track zsbuf info even when rp optimizing is disabled
...
this should allow zsbuf elimination in some cases
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21988 >
2023-03-20 18:24:07 +00:00
Samuel Pitoiset
d750ad19fd
radv: fix NGG streamout with VS and GPL on GFX11
...
With GPL it's not possible to know the primitive topology when
compiling the pre-rasterization stages. For NGG, we use the maximum
number of vertices per prim and rely on the hardware to ignore the
extra bits for points/lines.
Though, this can't work for NGG streamout because the number of
vertices per prim is used to compute a streamout offset. The only
way to solve this is to pass the number of vertices per prim through
a new user SGPR.
This fixes a bunch of streamout tests with Zink/RADV on GFX11.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21833 >
2023-03-20 17:47:03 +00:00
José Roberto de Souza
491887c9f2
intel: Add TODO about removal of 2Mb alignment in i915
...
Xe kmd don't suffer this yet because it still lacks MTL support.
Signed-off-by: José Roberto de Souza <jose.souza@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21972 >
2023-03-20 17:18:04 +00:00
José Roberto de Souza
96302900aa
anv: Apply memory alignment requirements in Xe kmd
...
Without alignment vm bind will fail and during gem buffer creation
size also need to be aligned otherwise the range in vm bind can be
bigger than allocated size for smem.
Signed-off-by: José Roberto de Souza <jose.souza@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21972 >
2023-03-20 17:18:04 +00:00
José Roberto de Souza
7dc8474c3b
intel: Set mem_alignment in Xe kmd
...
Signed-off-by: José Roberto de Souza <jose.souza@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21972 >
2023-03-20 17:18:04 +00:00
José Roberto de Souza
bfc1782ad6
anv: Use intel_device_info memory alignment
...
It was also necessary to initialize mem_alignment in the tests
otherwise vma allocation would fail with stubs.
Signed-off-by: José Roberto de Souza <jose.souza@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21972 >
2023-03-20 17:18:04 +00:00
José Roberto de Souza
2ab3d5f436
intel: Move memory aligment information to intel_device_info
...
This same information is also used in ANV, so intel_device_info is
a better place to have it.
Signed-off-by: José Roberto de Souza <jose.souza@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21972 >
2023-03-20 17:18:03 +00:00
Eric Engestrom
12cf314dd8
v3d/ci: add another depthstencil-default_fb-drawpixels-* to the flakes
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22026 >
2023-03-20 16:51:18 +00:00
Erik Faye-Lund
859bcd605d
ci: move docs-stuff out of root .gitlab-ci.yml
...
Unlike most other cases, we don't put the YAML-file in a ci-folder,
because we already have one for the CI-specific docs. So let's just
leave the YAML file directly in the docs-folder.
This should fix the problem that any docs-changes that touches the
CI-rules needs a full CI run just because of touching the root
.gitlab-ci.yml file. This causes needless friction and wastes CI
resources.
Reviewed-by: Eric Engestrom <eric@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21953 >
2023-03-20 15:27:37 +00:00
Jarred Davies
220356e083
pvr: Add initial support for VK_FORMAT_S8_UINT
...
Signed-off-by: Jarred Davies <jarred.davies@imgtec.com >
Reviewed-by: Frank Binns <frank.binns@imgtec.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21594 >
2023-03-20 14:47:34 +00:00
Jarred Davies
317a3fe49b
pvr: Select a single aspect format for the texture state of DS image views
...
This change also means the texture state words will be based off of the
image view's format instead of the image's format.
Signed-off-by: Jarred Davies <jarred.davies@imgtec.com >
Reviewed-by: Frank Binns <frank.binns@imgtec.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21594 >
2023-03-20 14:47:34 +00:00
Jarred Davies
26671b5d63
pvr: Add support for multiple emits from EOT program
...
Co-authored-by: Simon Perretta <simon.perretta@imgtec.com >
Signed-off-by: Jarred Davies <jarred.davies@imgtec.com >
Signed-off-by: Simon Perretta <simon.perretta@imgtec.com >
Reviewed-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21596 >
2023-03-20 14:35:19 +00:00
Jarred Davies
4162c37d57
pvr: Generate dummy emit for renders without any emits
...
Signed-off-by: Jarred Davies <jarred.davies@imgtec.com >
Reviewed-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21596 >
2023-03-20 14:35:19 +00:00
Jarred Davies
de5258ae2b
pvr: Generate EOT program at runtime
...
Also removes hardcoded EOT program.
Signed-off-by: Jarred Davies <jarred.davies@imgtec.com >
Reviewed-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21596 >
2023-03-20 14:35:19 +00:00
Samuel Pitoiset
0badfd8b20
radv: add helpers for destroying various pipeline types
...
Much cleaner than having a single function for everything.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21894 >
2023-03-20 13:56:32 +00:00
Samuel Pitoiset
abfdc06b01
radv: rename RADV_PIPELINE_LIBRARY to RADV_PIPELINE_RAY_TRACING_LIB
...
This seems more consistent with graphics pipeline libraries and it
avoids any confusion.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21894 >
2023-03-20 13:56:32 +00:00
Collabora's Gfx CI Team
10622ccc73
Uprev Piglit to 60e7f0586bac0cfcfcb5871046e31ca2057a5117
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21640 >
2023-03-20 12:17:20 +00:00
Eric Engestrom
20ba9b9faa
v3dv: use vk_get_physical_device_features
...
Signed-off-by: Eric Engestrom <eric@igalia.com >
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21959 >
2023-03-20 12:00:10 +00:00
Eric Engestrom
d94625d110
v3dv: reorder features as 1.0, 1.1, 1.2, 1.3
...
Easier to follow than 1.0, 1.3, 1.2, 1.1 :)
Signed-off-by: Eric Engestrom <eric@igalia.com >
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21959 >
2023-03-20 12:00:09 +00:00