Emma Anholt
4dc6cd5933
tgsi/exec: Simplify indirects now that they always use the ADDR file.
...
This was a lot of extra code in the hot path of getting though
fetch_src_file_channel(). No significant perf difference in softpipe,
though.
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14360 >
2022-01-04 23:05:41 +00:00
Emma Anholt
c00db99e0e
gallium: Delete PIPE_CAP_TGSI_ANY_REG_AS_ADDRESS
...
Softpipe was the only driver still using this feature. I had enabled it
in ba22f014f9 ("softpipe: Enable PIPE_CAP_TGSI_ANY_REG_AS_ADDRESS;") for
an instr count win, but it's really not important to that driver and it's
not worth keeping the knob around just for that.
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14360 >
2022-01-04 23:05:41 +00:00
Emma Anholt
4bb9c0a28a
nir_to_tgsi: Use the same address reg mappings as GLSL-to-TGSI did.
...
It turns out r600 has a bunch of expectations about the Dimension being in
ADDR[1].x, and sampler or atomic indirects being in ADDR[2].x. It's
simpler to just use this static assignment than our dynamic one, anyway.
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14360 >
2022-01-04 23:05:41 +00:00
Biju Das
daf59694ac
kmsro: Add 'rcar-du' driver support
...
rcar-du is used by Renesas R-Car and RZ/G SOCs.
Driver is available in the mainline kernel [1]
[1] https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/rcar-du
Suggested-by: Daniel Stone <daniels@collabora.com >
Signed-off-by: Show Liu <show.liu.yj@renesas.com >
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com >
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com >
Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14393 >
2022-01-04 21:59:16 +00:00
Adam Jackson
69678d50d1
mesa: Remove unused _mesa_get_linear_format_srgb
...
Reviewed-by: Emma Anholt <emma@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14220 >
2022-01-04 19:45:55 +00:00
Adam Jackson
267f28e384
mesa: Remove unused _mesa_format_fallback_rgbx_to_rgba
...
Reviewed-by: Emma Anholt <emma@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14220 >
2022-01-04 19:45:55 +00:00
Adam Jackson
07d23c207a
mesa: Remove unused _mesa_bind_texture
...
Reviewed-by: Emma Anholt <emma@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14220 >
2022-01-04 19:45:55 +00:00
Adam Jackson
e44ce092be
mesa: Remove unused _mesa_AllocTextureStorage_sw
...
Reviewed-by: Emma Anholt <emma@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14220 >
2022-01-04 19:45:54 +00:00
Adam Jackson
c77da4de4b
mesa: Remove unused _mesa_allow_light_in_model
...
ctx::_ForceEyeCoords is now never not false, so remove and simplify to
match.
Reviewed-by: Emma Anholt <emma@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14220 >
2022-01-04 19:45:54 +00:00
Timur Kristóf
d34d0f38e1
radv: Support VRS for mesh shaders.
...
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14193 >
2022-01-04 17:46:02 +00:00
Timur Kristóf
bc94c2718a
aco: Emit VRS rate when it's per-primitive.
...
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14193 >
2022-01-04 17:46:02 +00:00
Timur Kristóf
811c001049
radv: Lower primitive shading rate for mesh shaders.
...
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14193 >
2022-01-04 17:46:02 +00:00
Timur Kristóf
c6becb9574
radv: Note when a mesh shader writes the primitive shading rate.
...
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14193 >
2022-01-04 17:46:02 +00:00
Rob Clark
94f465856c
clover: Move min image support check
...
If the gallium driver supports images, but not the minimum image
requirements for CL, then simply don't claim to support images. This
is better than not claiming to support CL at all.
Signed-off-by: Rob Clark <robdclark@chromium.org >
Reviewed-by: Karol Herbst <kherbst@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14310 >
2022-01-04 16:56:25 +00:00
Samuel Pitoiset
12ac44378d
radv: add UMR markers for the vertex prolog
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13376 >
2022-01-04 07:50:07 +00:00
Samuel Pitoiset
14622b8bcc
radv: dump the VS prolog disassembly to the hang report
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13376 >
2022-01-04 07:50:07 +00:00
Samuel Pitoiset
d659c2ef9c
radv: save the vertex prolog to the trace BO for debugging
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13376 >
2022-01-04 07:50:07 +00:00
Samuel Pitoiset
2bf25e6f6e
radv,aco: keep track of the prolog disassembly if necessary
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13376 >
2022-01-04 07:50:07 +00:00
Samuel Pitoiset
e836174077
aco: do not print prologs disassembly if no disassembler
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13376 >
2022-01-04 07:50:07 +00:00
Samuel Pitoiset
3ef736c94e
aco: fix a dynamic-stack-buffer-overflow when printing instructions
...
Detected by ASAN.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14329 >
2022-01-04 08:04:50 +01:00
Dave Airlie
ad2902cbbe
mapi: generate correct dispatch for EXT_draw_instanced
...
These APIs can be exposed in GLES2.0 via EXT_draw_instanced,
they were incorrectly being stuck on GLES 3.0 only.
Fixes piglit ext_draw_instanced-drawarrays
Reviewed-by: Tapani Pälli <tapani.palli@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14338 >
2022-01-03 21:37:34 +00:00
Pavel Ondračka
96ad4f6437
r300: Remove broken optimization in rc_transform_KILL
...
The logic was reversed so this was not only not working but it was
also removing random instructions around. The special IF-KILP-ENDIF
case this optimization was targeting is already transformed to
KILL_IF in the TGSI, so just remove this altogether.
This fixes piglit glsl-fs-discard-04
v2: Update the comment as well
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/343
Signed-off-by: Pavel Ondračka <pavel.ondracka@gmail.com >
Reviewed-by: Filip Gawin <filip.gawin@zoho.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Reviewed-by: Emma Anholt <emma@anholt.net >
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14378 >
2022-01-03 20:45:32 +00:00
Thomas H.P. Andersen
496947d0d4
ci: debian-clang: drop -Wno-error=absolute-value
...
Reviewed-by: Emma Anholt <emma@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14302 >
2022-01-03 20:20:37 +00:00
Thomas H.P. Andersen
c32c9014f5
broadcom/compiler: fix compile warning -Wabsolute-value
...
fixes a compile warning with clang
Reviewed-by: Juan A. Suarez <jasuarez@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14302 >
2022-01-03 20:20:37 +00:00
Thomas H.P. Andersen
574c4466f8
xa: fix compile warning for -Wabsolute-value
...
fixes a compile warning with clang
Reviewed-by: Emma Anholt <emma@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14302 >
2022-01-03 20:20:37 +00:00
Lionel Landwerlin
8092d58e2e
util/u_trace: protect against reentrant calls
...
With the Iris driver, the first tracepoint triggers the tracepoint for
"begin of command buffer" which leads to 2 tracepoints using the same
idx.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Danylo Piliaiev <dpiliaiev@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14254 >
2022-01-03 18:15:08 +00:00
Marek Olšák
13bdd8da5e
driconf: enable glthread for Minecraft-FTB, Stellaris, Battletech
...
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14368 >
2022-01-03 17:45:59 +00:00
M Henning
d28677cfd9
nouveau/nir: Lower 64-bit phis
...
Fixes arb_gpu_shader_fp64-fs-non-uniform-control-flow-ubo
on kepler with NV50_PROG_USE_NIR=1
Reviewed-by: Emma Anholt <emma@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14343 >
2022-01-03 17:35:05 +00:00
Marek Olšák
ce72395008
radeonsi: add a debug option that disables DCC for all exported buffers
...
requested internally
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14283 >
2022-01-03 17:19:56 +00:00
Thomas H.P. Andersen
4cc0548046
zink: malloc/sizeof mismatch
...
buffer_infos is VkBufferView* but malloc is using the
size of VkImageView. The size is the same but this
fixes a warning
Reviewed-by: Hoe Hao Cheng <haochengho12907@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14335 >
2022-01-03 17:00:55 +00:00
Thomas H.P. Andersen
495b2c537b
ci: debian-clang: -Wno-error for sometimes-uninitialized
...
The last of this kind of warning is gone for CPP
Reviewed-by: Emma Anholt <emma@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14296 >
2022-01-03 14:34:22 +00:00
Thomas H.P. Andersen
9e2f1f05c6
r600/sb: silence a sometimes-uninitialized warning
...
Fixes a warning from clang
Reviewed-by: Emma Anholt <emma@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14296 >
2022-01-03 14:34:22 +00:00
Mike Blumenkrantz
2a4c56e4e3
mesa/vbo: be more comprehensive for degenerate primitive conversion in dlists
...
these shouldn't result in any sort of draw, and passing the unsupported primtype
to the driver is invalid
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13845 >
2022-01-03 13:59:48 +00:00
Alyssa Rosenzweig
29d319c767
pan/bi: Fix load_const of 1-bit booleans
...
For historical reasons, we ingest 1-bit booleans in NIR but expand them
to 16/32-bit booleans in the backend IR. We need to handle this case
when loading boolean constants, extending from 1-bit to 16/32-bit as
required. This issue is masked by effective constant folding for
booleans, but is visible in a shader from Firefox WebRender.
Fixes: 646e03c451 ("pan/bi: Temporarily switch back to 0/~0 bools")
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com >
Reported-by: Icecream95
Closes : #5797
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14371 >
2022-01-02 20:26:15 +00:00
Uday Kiran Pichika
78ef08a061
anv: enable adaptive sync for ANV
...
Signed-off-by: Uday Kiran Pichika <pichika.uday.kiran@intel.com >
Reviewed-by: Tapani Pälli <tapani.palli@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6420 >
2022-01-02 18:53:29 +00:00
Uday Kiran Pichika
89b54626fe
iris: enable adaptive sync for IRIS
...
Signed-off-by: Uday Kiran Pichika <pichika.uday.kiran@intel.com >
Reviewed-by: Tapani Pälli <tapani.palli@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6420 >
2022-01-02 18:53:29 +00:00
Alyssa Rosenzweig
795638767d
pan/bi: Use fused dual source blending
...
Instead of emitting a pile of moves to fixed registers at codegen time
and hoping everything works out, add a second staging source to the
BLEND instruction in the intermediate representation containing the dual
source colour, and modify register allocation appropriately. This better
models the operation of blending render target #0 with two sources.
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13714 >
2022-01-02 01:12:05 +00:00
Alyssa Rosenzweig
af3863c658
pan/bi: Allow an extra staging source
...
Useful for dual source blending.
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13714 >
2022-01-02 01:12:05 +00:00
Alyssa Rosenzweig
251b1c1753
pan/bi: Use is_staging_src helper
...
This will allow us to have a separate set of staging sources, which will
be useful for dual-source blending.
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13714 >
2022-01-02 01:12:05 +00:00
Alyssa Rosenzweig
c4da1b84d3
panfrost: Remove pan_nir_reorder_writeout
...
Now that dual source stores are fused, there's no ordering hazard so we
can remove this tricky code.
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13714 >
2022-01-02 01:12:05 +00:00
Alyssa Rosenzweig
d3fb341b4a
panfrost: Combine dual source blends
...
Reuse the store_combined_output_pan infrastructure for dual source
blending as well. This simplifies ordering.
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13714 >
2022-01-02 01:12:05 +00:00
Alyssa Rosenzweig
24ea7cbb06
nir: Extend store_combined_output_pan
...
Extend store_combined_output_pan to take a dual source blend input in
addition to colour, depth, and stencil inputs. Use the last source for
this, and represent the type with the DEST_TYPE index. This is a hack
but there is no SRC2_TYPE and NIR doesn't seem to mind as long as we
know what we mean. This allows the backend to emit a combined "blend
render target #0 " instruction taking two sources.
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13714 >
2022-01-02 01:12:05 +00:00
Alyssa Rosenzweig
e42133aa2f
panfrost: Simplify blend lowering pass
...
Combine depth/stencil writeout redundancy. This simplifies the code and
will allow us to add dual source blend handling without duplicating even
more code.
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13714 >
2022-01-02 01:12:05 +00:00
Alyssa Rosenzweig
5c168f09eb
nir: Eliminate store_combined_output_pan BASE
...
It's meaningless for this intrinsic and is just adding noise to the
lowering pass.
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13714 >
2022-01-02 01:12:05 +00:00
Alyssa Rosenzweig
b3d7272753
pan/mdg: Don't read base for combined stores
...
`base` is meaningless for combined stores, so don't read it. This allows
us to remove the base index from the intrinsic and simplify the lowering
code generating the combined store intrinsic.
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13714 >
2022-01-02 01:12:05 +00:00
Alyssa Rosenzweig
996645e479
pan/bi: Don't read base for combined stores
...
`base` is meaningless for combined stores, so don't read it. This allows
us to remove the base index from the intrinsic and simplify the lowering
code generating the combined store intrinsic.
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13714 >
2022-01-02 01:12:05 +00:00
Tatsuyuki Ishi
31d839aacc
aco: lower masked swizzle to DPP8
...
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13971 >
2021-12-31 20:56:39 +00:00
Tatsuyuki Ishi
da0412e55b
aco: support DPP8
...
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13971 >
2021-12-31 20:56:39 +00:00
Jesse Natalie
5c3dfb4ef5
gallium/aux: Move index offsetting from prim restart to primconvert
...
Fixes: b34fed64 ("u_prim_restart: Fix index scanning with start offset")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5799
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14346 >
2021-12-31 17:29:46 +00:00
Bas Nieuwenhuizen
46c59e8fd6
radv: Remove dependencies on vk_common entrypoints.
...
Fixes: 91fe0b5629 ("radv: Delete lots of sync code.")
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14366 >
2021-12-31 17:49:10 +01:00