Rhys Perry
46e94fd854
aco: skip NIR in unreachable merge blocks
...
NIR removes most of this but undef instructions for loop header phis can
remain. These were harmless because ACO would DCE them itself.
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com >
CC: <mesa-stable@lists.freedesktop.org >
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3658 >
2020-03-23 15:55:12 +00:00
Rhys Perry
638cbc21a1
aco: handle when ACO adds new continue edges
...
Usually a loop ends with a uniform continue. If it doesn't and we end up
adding our own continue edges (because of continue_or_break or divergent
breaks at the end), we have to add extra operands to the loop header phis.
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com >
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3658 >
2020-03-23 15:55:12 +00:00
Rhys Perry
f2c4878de9
aco: handle missing second predecessors at merge block phis
...
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com >
CC: <mesa-stable@lists.freedesktop.org >
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3658 >
2020-03-23 15:55:12 +00:00
Rhys Perry
f1a2e1df78
aco: set has_divergent_branch for discards in loops
...
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com >
CC: <mesa-stable@lists.freedesktop.org >
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3658 >
2020-03-23 15:55:12 +00:00
Andres Gomez
8bc3d6574c
gitlab-ci: add python3-requests to the test-vk container
...
After 90a39af5f6 ("ci: Drop the git dependency in tracie"), we have
this error in the radv-polaris10-traces job:
"
...
+ /builds/tanty/mesa/artifacts/tracie/tests/test.sh
tracie_succeeds_if_all_images_match: Fail
Traceback (most recent call last):
File "/tmp/tracie.test.glY0O23HJo/tracie.py", line 6, in <module>
import requests
ModuleNotFoundError: No module named 'requests'
...
"
v2:
- Updated commit log to be more descriptive (Michel).
Fixes: 90a39af5f6 ("ci: Drop the git dependency in tracie")
Signed-off-by: Andres Gomez <agomez@igalia.com >
Reviewed-by: Alexandros Frantzis <alexandros.frantzis@collabora.com >
Reviewed-by: Michel Dänzer <mdaenzer@redhat.com >
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4237 >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4237 >
2020-03-23 17:17:56 +02:00
Samuel Pitoiset
7ac8bb33cd
radv/llvm: fix subgroup shuffle for chips without bpermute
...
bpermute only exists on GFX8+ and only with Wave32 on GFX10. Instead
we have to use readlane with a waterfall loop to defeat the LLVM
backend.
This fixes DOOM Eternal which requires subgroup shuffle.
Cc: <mesa-stable@lists.freedesktop.org >
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4284 >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4284 >
2020-03-23 14:19:03 +00:00
Roman Stratiienko
2a70a1d69d
panfrost: Align Android makefiles with recent changes
...
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Signed-off-by: Roman Stratiienko <roman.stratiienko@nure.ua >
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4280 >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4280 >
2020-03-23 14:03:22 +00:00
Samuel Pitoiset
6c8ccbe41b
gitlab-ci: add a bunch of new fossils from the Sascha Vulkan demos
...
The whole fossils-db is only 448KB of data which is pretty small.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4082 >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4082 >
2020-03-23 12:16:02 +00:00
Samuel Pitoiset
48e920315c
gitlab-ci: add a new stage for RADV CI
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Michel Dänzer <mdaenzer@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4082 >
2020-03-23 12:16:02 +00:00
Samuel Pitoiset
e22d562c17
gitlab-ci: compile fossils with more ASICs
...
I think we want to cover these 3 generations at the barely minimum.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Michel Dänzer <mdaenzer@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4082 >
2020-03-23 12:16:02 +00:00
Samuel Pitoiset
1517e58c1b
gitlab-ci: compile fossils with both RADV compiler backends (LLVM/ACO)
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Michel Dänzer <mdaenzer@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4082 >
2020-03-23 12:16:02 +00:00
Jan Zielinski
8b3b07afc0
gallium/gallivm: Remove workaround disabling AVX code for newer CPUs
...
The change enables using full 256-bit AVX and AVX2 instructions
on newer platforms.
Reviewed-by: Alok Hota <alok.hota@intel.com >
Reviewed-by: Adam Jackson <ajax@redhat.com >
Reviewed-by: Jose Fonseca <jfonseca@vmware.com >
Reviewed-by: Roland Scheidegger <sroland@vmware.com >
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4225 >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4225 >
2020-03-23 09:20:51 +00:00
Samuel Pitoiset
de550805c5
radv/winsys: spoof some values for num_render_backends in the null winsys
...
To avoid crashes when RADV_FORCE_FAMILY is set to GFX9+ because
num_render_backends is used to compute binning state.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4282 >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4282 >
2020-03-23 09:50:53 +01:00
Samuel Pitoiset
b911af06cd
radv/winsys: fix wrong PCI ID for Vega10 in the null winsys
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4282 >
2020-03-23 09:50:51 +01:00
Eric Anholt
050ec8ff53
glsl: Restore the IsES flag on the shader when reading from cache.
...
I found that when trying to MESA_SHADER_CAPTURE_PATH a trace, I was
getting "GLSL >= 3.00" for the ES shaders I was trying to capture.
Keeping this metadata in the cached shader program lets us capture
correctly.
Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com >
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4219 >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4219 >
2020-03-22 20:49:37 -07:00
Dave Airlie
9e3efa4294
gallivm: add support for rgtc/latc fetches.
...
Annoyingly heaven uses rgtc2 snorm but this at least avoids
the function call overheads to the util fetch functions.
Reviewed-by: Roland Scheidegger <sroland@vmware.com >
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3924 >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3924 >
2020-03-23 11:02:03 +10:00
Dave Airlie
b3894e52c2
gallivm/s3tc: split out dxt5 alpha code
...
Reviewed-by: Roland Scheidegger <sroland@vmware.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3924 >
2020-03-23 11:02:00 +10:00
Jordan Justen
f02ae69867
intel: Add TGL PCI ID
...
Ref: Bspec 44455
Cc: <mesa-stable@lists.freedesktop.org >
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
2020-03-21 23:49:38 -07:00
Jordan Justen
1c6ef0165f
intel: Update TGL PCI strings
...
Ref: Bspec 44455
Cc: <mesa-stable@lists.freedesktop.org >
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
2020-03-21 23:49:34 -07:00
Alyssa Rosenzweig
d9d549ff88
pan/bi: Pack csel4 opcodes
...
These are pretty straightforward but there's a lot of details to keep
straight. In the IR, we keep a general logical comparator and types
separately; in the hardware, the type gets fused with a (much more)
limited number of comparators. So there's a fair bit of code here to
account for these differences, fusing in the type information, and
changing up argument order as necessary to make it actually correct.
Anything to save a bit!
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4276 >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4276 >
2020-03-22 03:32:35 +00:00
Alyssa Rosenzweig
5cdc31abd6
pan/bi: Default csel to "!= 0" mode
...
This way we always have regular csel conditions instead of a weird
.always special case for 3-src CSEL mode.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4276 >
2020-03-22 03:32:35 +00:00
Alyssa Rosenzweig
46f526eb1e
pan/bi: Use bi_lookup_immediate when packing
...
This gets us part of the way there to packing lo/hi separately. A little
more work is needed to do this "properly", but hey.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4276 >
2020-03-22 03:32:35 +00:00
Alyssa Rosenzweig
11bccb0564
pan/bi: Respect shift when printing immediates
...
We allow packing multiple immediates in, but we were missing this in the
print.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4276 >
2020-03-22 03:32:35 +00:00
Alyssa Rosenzweig
3f786ed10b
pan/bi: Implement csel fusing
...
When generating csel instructions, we can peak to see what condition is
being used. If we're using a "nice" condition, we can fuse it in with
the csel itself, ideally letting the condition itself be DCE'd away.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4276 >
2020-03-22 03:32:35 +00:00
Alyssa Rosenzweig
5a02c871f2
pan/bi: Add soft NIR->BIR condition translation
...
We would like to use this routine opportunistically when fusing
conditions into csels and branches, so let's add a mode where we don't
abort.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4276 >
2020-03-22 03:32:35 +00:00
Alyssa Rosenzweig
cd7fec782e
pan/bi: Remove hacks for 1-bit booleans in IR
...
Now that we lower them away, a bunch of special cases disappear.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4276 >
2020-03-22 03:32:35 +00:00
Alyssa Rosenzweig
12299dead7
pan/bi: Lower bool to ints
...
Currently we lower to int32, but once mediump lands we'll be ready for
that too.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4276 >
2020-03-22 03:32:35 +00:00
Alyssa Rosenzweig
1097c69087
pan/bi: Pack LD_ATTR
...
Also requires the usual R61/62 games.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4276 >
2020-03-22 03:32:35 +00:00
Alyssa Rosenzweig
0be1116b81
pan/bi: Pack st_vary
...
This should let varying writes go through finally.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4276 >
2020-03-22 03:32:35 +00:00
Alyssa Rosenzweig
9213b2520c
pan/bi: Add store_channels property
...
It can't be inferred from the usual writemask since stores don't write
to a register destination.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4276 >
2020-03-22 03:32:35 +00:00
Alyssa Rosenzweig
c57ac9d136
pan/bi: Generalize data register setting
...
So we can use it for stores too.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4276 >
2020-03-22 03:32:35 +00:00
Alyssa Rosenzweig
9458b017a9
pan/bi: Flesh out st_vary IR
...
We need to make the semantics of BI_VECTOR a bit more precise -
vectorize only the first argument, not all of them. This is enough for
current and future users, as far as I know.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4276 >
2020-03-22 03:32:35 +00:00
Alyssa Rosenzweig
409e4f8a49
pan/bi: Pack ld_var_addr
...
Choo choo.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4276 >
2020-03-22 03:32:35 +00:00
Alyssa Rosenzweig
7321a17c6a
pan/bi: Pack ld_ubo ops
...
Routes some infrastructure to do so at least slightly generically but
we'll see.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4276 >
2020-03-22 03:32:35 +00:00
Alyssa Rosenzweig
908341ea3f
pan/bi: Add bi_load32_components helper
...
Pattern seems to crop up a lot.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4276 >
2020-03-22 03:32:35 +00:00
Alyssa Rosenzweig
8bb16138b6
pan/bi: Include UBO index for sysval reads
...
Trivially zero.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4276 >
2020-03-22 03:32:35 +00:00
Alyssa Rosenzweig
fc0b49bb2c
pan/bi: Index out constants in instructions
...
We rewrite BIR_INDEX_CONSTANT (and _ZERO) to preassigned constant ports
when assign uniform_const for the bundle. There are a lot of issues
raised here, unfortunately, and the implementation here is woefully
incomplete with a nasty hack for loads... nevertheless, it's somewhere
to start.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4276 >
2020-03-22 03:32:35 +00:00
Alyssa Rosenzweig
d2d0de962e
pan/bi: Document constant related errata(?)
...
We're not totally sure what's up with this but Connor says if you
violate it Bad Things happen in your shader. I think this might be an
issue affecting early Bifrost (G71, ..?); when we know more we can look
into patching in a fix.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4276 >
2020-03-22 03:32:35 +00:00
Alyssa Rosenzweig
eb590a98d2
pan/bi: Pack a constant quadword
...
The piping isn't there to make use of it yet, but this stubs out
constant support at the clause level.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4276 >
2020-03-22 03:32:35 +00:00
Alyssa Rosenzweig
50d3f4df45
pan/bi: Add move lowering pass
...
We need ALU mostly scalarized, but we get vector moves created from
lower_vec_to_mov so let's scalarize that ourselves rather than bother
NIR.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4276 >
2020-03-22 03:32:35 +00:00
Alyssa Rosenzweig
58a51c49bb
pan/bi: Add bi_emit_before helper
...
For BIR lowering passes.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4276 >
2020-03-22 03:32:34 +00:00
Alyssa Rosenzweig
6b7077efda
pan/bi: Implement FMA/MOV without modifiers
...
We split off MOV from FMOV since the canonical move on Bifrost doesn't
accept modifiers. (We can still do fmov, but with something like add-0.)
This will also make copyprop a little nicer, I think. Anyway, the
non-modifier version we can implement as-is for FMA.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4276 >
2020-03-22 03:32:34 +00:00
Jonathan Marek
f8bbf44ca4
etnaviv: nir: add compile_check_limits
...
To match TGSI compiler behaviour in glmark terrain scene for example.
Signed-off-by: Jonathan Marek <jonathan@marek.ca >
Reviewed-by: Lucas Stach <l.stach@pengutronix.de >
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com >
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4199 >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4199 >
2020-03-22 00:29:36 +00:00
Marek Olšák
303842b2db
ac: fix fast division
...
This stopped working with LLVM 11 and might occasionally have been broken
on older LLVM, because the metadata was set on the mul, not on the rcp.
Cc: 19.3 20.0 <mesa-stable@lists.freedesktop.org >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4268 >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4268 >
2020-03-21 22:34:17 +00:00
Eduardo Lima Mitev
55b0a676fd
turnip: Instance can be NULL resolving 'GetInstanceProcAddr' entry point
...
Using turnip driver without a vulkan loader is currently broken because
the entry point resolver is expecting a valid instance when resolving
'vkGetInstanceProcAddr' through vk_icdGetInstanceProcAddr().
Reviewed-by: Jonathan Marek <jonathan@marek.ca >
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4257 >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4257 >
2020-03-21 18:56:07 +01:00
Marek Olšák
5cc3ab0ba0
vbo,gallium: make glBegin/End buffer size configurable by drivers
...
The default is 512 KB, but radeonsi wants 4 MB.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4154 >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4154 >
2020-03-21 03:39:51 +00:00
Marek Olšák
11d3aa5e7b
glthread: remove the marshal_fail XML attribute
...
Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com >
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4124 >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4124 >
2020-03-20 23:01:13 -04:00
Marek Olšák
c02a1347e5
glthread: ignore vertex arrays with user pointers if they're disabled
...
Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4124 >
2020-03-20 23:01:13 -04:00
Marek Olšák
0b1dd18591
glthread: track which vertex array attribs are enabled
...
Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4124 >
2020-03-20 23:01:13 -04:00
Marek Olšák
c571dda1e0
glthread: rename non_vbo helper functions
...
Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4124 >
2020-03-20 23:01:13 -04:00