Danylo Piliaiev
a0d426370d
ir3: Fix FS quad ops returning wrong values from helper invocations
...
Without SP_FS_CTRL_REG0.LODPIXMASK quad ops don't get values from
helper invocations, but from the current one.
Fixes:
dEQP-VK.glsl.derivate.dfdxsubgroup.*
dEQP-VK.glsl.derivate.dfdysubgroup.*
Cc: mesa-stable
Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24211 >
2023-07-19 19:41:51 +00:00
Danylo Piliaiev
696f37f5c3
freedreno/regs: Rename SP_FS_CTRL_REG0.DIFF_FINE into LODPIXMASK
...
That's the "real" name of the field.
It enables ALL helper invocations in a quad, which is necessary for
fine derivatives and quad subgroup ops.
While PIXLODENABLE by itself enables only 3 out 4 fragments in a quad.
Cc: mesa-stable
Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24211 >
2023-07-19 19:41:51 +00:00
Gert Wollny
59087003c4
r600/sfn: remove debug output leftovers
...
Fixes: ae7d904a73
r600/sfn: Implement source mod optimization in backend
Signed-off-by: Gert Wollny <gert.wollny@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24239 >
2023-07-19 19:12:31 +00:00
David Rosca
7a4e3b2788
radeonsi/vcn: Fix setting color range in AV1 bitstream
...
As per spec color_range and chroma_sample_position parameters
are always set, not conditional on color_description_present_flag.
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24179 >
2023-07-19 18:51:48 +00:00
José Roberto de Souza
2661e975dc
intel/aux_map: Add function and macro to return l2 and l1 table masks
...
Signed-off-by: José Roberto de Souza <jose.souza@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24077 >
2023-07-19 16:53:59 +00:00
José Roberto de Souza
c50008903b
intel/aux_map: Drop magic sub table size number
...
Each entry is a uint64_t, L2 and L1 maps 12 bits so:
(1 << 12) = 4096
sizeof(uint64_t) = 8
4096 * 8 = 32768 = 32K
Same value but easier to understand.
Signed-off-by: José Roberto de Souza <jose.souza@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24077 >
2023-07-19 16:53:59 +00:00
José Roberto de Souza
b9a38a1661
intel/aux_map: Convert l1_entry_addr_out to canonical
...
The expression 'l1_gpu_addr + l1_index * sizeof(*l1_map)' could cause
bit 47 to be set so it needs to be converted to canonical.
Signed-off-by: José Roberto de Souza <jose.souza@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24077 >
2023-07-19 16:53:59 +00:00
José Roberto de Souza
4f44c47db8
intel/aux_map: Mask out bits above index 47 in intel_aux_get_meta_address_mask()
...
The bits above index 47 in l1 entry are used to define format,
depth and luminance.
aux_address is formated as canonical, so bits above 47 could all be
set to 1 causing wrong values being set to format, depth and luminance.
intel_aux_get_meta_address_mask() was previously using 2 shifts to
mask out bits above index 47, what is not so obvious and are 2
operations, so here doing a AND with VALID_ADDRESS_MASK to make it
easier to understand.
Signed-off-by: José Roberto de Souza <jose.souza@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24077 >
2023-07-19 16:53:59 +00:00
José Roberto de Souza
47792b3642
intel/aux_map: Rename some variables to improve readability
...
No changes in behavior here, mostly doing this types of renames:
- address to main_address, to know that addresses refers to main
surface address or aux surface address
- gpu to addr
- main_map_addr to main_inc_addr
- aux_dest_addr to aux_inc_addr
Signed-off-by: José Roberto de Souza <jose.souza@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24077 >
2023-07-19 16:53:59 +00:00
José Roberto de Souza
14ae2c58b8
intel/aux_map: Replace magic number by INTEL_AUX_MAP_ENTRY_VALID_BIT
...
Signed-off-by: José Roberto de Souza <jose.souza@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24077 >
2023-07-19 16:53:59 +00:00
José Roberto de Souza
4fc38aa99b
intel/aux_map: Use get_aux_entry() in remove_mapping()
...
remove_mapping() duplicated almost half of get_aux_entry(), it is
only dropping the cases were entries are not alocated but during
removal it is expected that entries were already alocated so we can
reuse get_aux_entry() and drop duplicated code.
Signed-off-by: José Roberto de Souza <jose.souza@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24077 >
2023-07-19 16:53:59 +00:00
José Roberto de Souza
872b4247ad
intel/aux_map: Nuke format_enum
...
The only user of format_enum is intel_aux_map_get_alignment() that
can easily use information in format->main_page_size.
This allow us to nuke format_enum and remove duplicated information
in intel_aux_map_get_alignment().
Signed-off-by: José Roberto de Souza <jose.souza@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24077 >
2023-07-19 16:53:59 +00:00
Lucas Stach
db4b365f2b
etnaviv: initialize VIVS_GL_BUG_FIXES
...
Same as the blob, always initialize this state when feature
BUG_FIXES18 is present.
Fixes spec@!opengl 2.0@occlusion-query-discard on GC3000.
Signed-off-by: Lucas Stach <l.stach@pengutronix.de >
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24166 >
2023-07-19 16:35:04 +00:00
Samuel Pitoiset
af38b1acd5
zink/ci: update list of expected failures for NAVI10
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24232 >
2023-07-19 16:08:39 +00:00
Robert Mader
74451ed3f0
egl/wayland: wait for compositor to release shm buffers
...
Some Wayland compositors, notably Exo, do not always release buffers
fast enough, and not in sync with their frame callbacks, to guarantee
that a free buffer is available the next time a client calls
`eglSwapBuffers()`.
This currently leads to a crash in `dri2_wl_swrast_get_backbuffer_data()`
with the swrast backend. To avoid this, simply block until the
compositor releases a buffer eventually.
While arguably compositors should release buffers they don't need any
more for the next frame, this can be quite complex depending on
the architecture - notably multi-process/IPC in case of Exo.
cc: mesa-stable
Signed-off-by: Robert Mader <robert.mader@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24091 >
2023-07-19 15:11:46 +00:00
José Roberto de Souza
2a6fc690c1
anv: Use workaround framework to Wa_14016118574
...
Wa_14016118574 is not the lineage number for this workaround so
it was updated to Wa_22014412737.
Wa_22014412737 is not applicable for MTL B0 steppings and newer
so using the workaround framework eliminates this pipe_control
instruction for not affected revisions.
Signed-off-by: José Roberto de Souza <jose.souza@intel.com >
Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24221 >
2023-07-19 14:43:44 +00:00
Thomas H.P. Andersen
58febefa9a
tgsi: remove unused tgsi_shader_info.max_depth
...
Reviewed-by: Charmaine Lee <charmainel@vmware.com >
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24100 >
2023-07-19 12:41:28 +00:00
Thomas H.P. Andersen
0335976fb2
tgsi: remove unused tgsi_shader_info.const_buffers_indirect
...
Reviewed-by: Charmaine Lee <charmainel@vmware.com >
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24100 >
2023-07-19 12:41:28 +00:00
Thomas H.P. Andersen
674fbed75d
tgsi: remove unused tgsi_shader_info.indirect_files_written
...
Reviewed-by: Charmaine Lee <charmainel@vmware.com >
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24100 >
2023-07-19 12:41:28 +00:00
Thomas H.P. Andersen
bfb7f85461
tgsi: remove unused tgsi_shader_info.indirect_files_read
...
Reviewed-by: Charmaine Lee <charmainel@vmware.com >
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24100 >
2023-07-19 12:41:28 +00:00
Thomas H.P. Andersen
606db8cc40
tgsi: remove unused tgsi_shader_info.uses_bindless_image_atomic
...
Reviewed-by: Charmaine Lee <charmainel@vmware.com >
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24100 >
2023-07-19 12:41:28 +00:00
Thomas H.P. Andersen
67f85d3f45
tgsi: remove unused tgsi_shader_info.uses_bindless_image_store
...
Reviewed-by: Charmaine Lee <charmainel@vmware.com >
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24100 >
2023-07-19 12:41:28 +00:00
Thomas H.P. Andersen
70d8408666
tgsi: remove unused tgsi_shader_info.uses_bindless_image_load
...
Reviewed-by: Charmaine Lee <charmainel@vmware.com >
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24100 >
2023-07-19 12:41:28 +00:00
Thomas H.P. Andersen
aa6a3faf75
tgsi: remove unused tgsi_shader_info.uses_bindless_buffer_atomic
...
Reviewed-by: Charmaine Lee <charmainel@vmware.com >
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24100 >
2023-07-19 12:41:28 +00:00
Thomas H.P. Andersen
33e9189aa1
tgsi: remove unused tgsi_shader_info.uses_bindless_buffer_store
...
Reviewed-by: Charmaine Lee <charmainel@vmware.com >
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24100 >
2023-07-19 12:41:28 +00:00
Thomas H.P. Andersen
98b157bd9c
tgsi: remove unused tgsi_shader_info.uses_bindless_buffer_load
...
Reviewed-by: Charmaine Lee <charmainel@vmware.com >
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24100 >
2023-07-19 12:41:28 +00:00
Thomas H.P. Andersen
b2c6f21f10
tgsi: remove unused tgsi_shader_info.images_atomic
...
Reviewed-by: Charmaine Lee <charmainel@vmware.com >
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24100 >
2023-07-19 12:41:27 +00:00
Thomas H.P. Andersen
4b9b6a0711
tgsi: remove unused tgsi_shader_info.images_store
...
Reviewed-by: Charmaine Lee <charmainel@vmware.com >
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24100 >
2023-07-19 12:41:27 +00:00
Thomas H.P. Andersen
8c227964f3
tgsi: remove unused tgsi_shader_info.images_load
...
Reviewed-by: Charmaine Lee <charmainel@vmware.com >
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24100 >
2023-07-19 12:41:27 +00:00
Thomas H.P. Andersen
eeb0d979f3
tgsi: remove unused tgsi_shader_info.culldist_writemask
...
Reviewed-by: Charmaine Lee <charmainel@vmware.com >
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24100 >
2023-07-19 12:41:27 +00:00
Thomas H.P. Andersen
14454e20ea
tgsi: remove unused tgsi_shader_info.clipdist_writemask
...
Reviewed-by: Charmaine Lee <charmainel@vmware.com >
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24100 >
2023-07-19 12:41:27 +00:00
Thomas H.P. Andersen
a481db8f3e
tgsi: remove unused tgsi_shader_info.uses_bindless_images
...
Reviewed-by: Charmaine Lee <charmainel@vmware.com >
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24100 >
2023-07-19 12:41:27 +00:00
Thomas H.P. Andersen
7d21d1317f
tgsi: remove unused tgsi_shader_info.uses_bindless_samplers
...
Reviewed-by: Charmaine Lee <charmainel@vmware.com >
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24100 >
2023-07-19 12:41:27 +00:00
Thomas H.P. Andersen
395a2409cb
tgsi: remove unused tgsi_shader_info.uses_derivatives
...
Reviewed-by: Charmaine Lee <charmainel@vmware.com >
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24100 >
2023-07-19 12:41:27 +00:00
Thomas H.P. Andersen
908441e0ee
tgsi: remove unused tgsi_shader_info.uses_doubles
...
Reviewed-by: Charmaine Lee <charmainel@vmware.com >
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24100 >
2023-07-19 12:41:27 +00:00
Thomas H.P. Andersen
87d1dde7f9
tgsi: remove unused tgsi_shader_info.writes_primid
...
Reviewed-by: Charmaine Lee <charmainel@vmware.com >
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24100 >
2023-07-19 12:41:27 +00:00
Thomas H.P. Andersen
9c207d4f89
tgsi: remove unused tgsi_shader_info.uses_subgroup_info
...
Reviewed-by: Charmaine Lee <charmainel@vmware.com >
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24100 >
2023-07-19 12:41:27 +00:00
Thomas H.P. Andersen
68d0c847bb
tgsi: remove unused tgsi_shader_info fields
...
uses_thread_id
uses_block_id
uses_block_size
Reviewed-by: Charmaine Lee <charmainel@vmware.com >
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24100 >
2023-07-19 12:41:27 +00:00
Thomas H.P. Andersen
402f5c5407
tgsi: remove unused tgsi_shader_info.uses_drawid
...
Reviewed-by: Charmaine Lee <charmainel@vmware.com >
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24100 >
2023-07-19 12:41:27 +00:00
Thomas H.P. Andersen
436e59e3d9
tgsi: remove unused tgsi_shader_info fields
...
Removes:
uses_persp_opcode_interp_centroid
uses_persp_opcode_interp_offset
uses_persp_opcode_interp_sample
uses_linear_opcode_interp_centroid
uses_linear_opcode_interp_offset
uses_linear_opcode_interp_sample
Reviewed-by: Charmaine Lee <charmainel@vmware.com >
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24100 >
2023-07-19 12:41:27 +00:00
Thomas H.P. Andersen
6c513ef4fd
tgsi: remove unused tgsi_shader_info fields
...
Removes:
uses_persp_center
uses_persp_centroid
uses_persp_sample
uses_linear_center
uses_linear_centroid
uses_linear_sample
Reviewed-by: Charmaine Lee <charmainel@vmware.com >
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24100 >
2023-07-19 12:41:27 +00:00
Thomas H.P. Andersen
76b0e7b25c
tgsi: remove unused tgsi_shader_info.reads_tess_factors
...
Reviewed-by: Charmaine Lee <charmainel@vmware.com >
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24100 >
2023-07-19 12:41:27 +00:00
Thomas H.P. Andersen
9050b10627
svga: remove unused struct field
...
This will allow further cleanup in tgsi_shader_info
Reviewed-by: Charmaine Lee <charmainel@vmware.com >
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24100 >
2023-07-19 12:41:27 +00:00
Thomas H.P. Andersen
29673ac8d0
tgsi: remove unused tgsi_shader_info.reads_samplemask
...
Reviewed-by: Charmaine Lee <charmainel@vmware.com >
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24100 >
2023-07-19 12:41:27 +00:00
Thomas H.P. Andersen
ad2c811884
tgsi: remove unused tgsi_shader_info.reads_position
...
Reviewed-by: Charmaine Lee <charmainel@vmware.com >
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24100 >
2023-07-19 12:41:27 +00:00
Thomas H.P. Andersen
1f1ffd5b1d
tgsi: remove unused tgsi_shader_info.colors_written
...
Reviewed-by: Charmaine Lee <charmainel@vmware.com >
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24100 >
2023-07-19 12:41:27 +00:00
Thomas H.P. Andersen
9684fbc87d
tgsi: remove unused tgsi_shader_info.colors_read
...
Reviewed-by: Charmaine Lee <charmainel@vmware.com >
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24100 >
2023-07-19 12:41:27 +00:00
Thomas H.P. Andersen
849065b9f3
tgsi: remove unused tgsi_shader_info.num_memory_instructions
...
Reviewed-by: Charmaine Lee <charmainel@vmware.com >
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24100 >
2023-07-19 12:41:27 +00:00
Thomas H.P. Andersen
64ce4669a3
tgsi: remove unused tgsi_shader_info.array_max
...
Reviewed-by: Charmaine Lee <charmainel@vmware.com >
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24100 >
2023-07-19 12:41:27 +00:00
Thomas H.P. Andersen
8807f0ec3e
tgsi: remove unused tgsi_shader_info.num_tokens
...
Reviewed-by: Charmaine Lee <charmainel@vmware.com >
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24100 >
2023-07-19 12:41:26 +00:00