Iago Toral Quiroga
597b448967
v3dv: implement VK_KHR_dedicated_allocation
...
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11002 >
2021-05-27 08:23:55 +02:00
Iago Toral Quiroga
e60b009271
v3dv: keep track of whether an image may be backed by external memory
...
Such images will always require dedicated allocations.
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11002 >
2021-05-27 08:21:15 +02:00
Iago Toral Quiroga
d87afc1acc
v3dv: implement VK_KHR_get_memory_requirements2
...
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11002 >
2021-05-27 08:21:15 +02:00
Timothy Arceri
82bd970a0c
Revert "util: disable glthread in CSGO"
...
This reverts commit 40c93e2f45 .
The trust factor issue has now been resolved [1]
[1] https://github.com/ValveSoftware/csgo-osx-linux/issues/2630
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10948 >
2021-05-27 05:05:16 +00:00
cheyang
4a3c715bb4
virgl:Fix the leak of hw_res used as fence
...
Fence destroy hw_res not dec reference.Lead leak.
Call virgl_drm_resource_reference() to release hw_res
instead of calling virgl_hw_res_destroy() directly.
Fixes: c54fb6ef3d ("virgl: Don't destroy resource while it's in use.")
Signed-off-by: cheyang <cheyang@bytedance.com >
Reviewed-by: Chia-I Wu <olvaffe@gmail.com >
Reviewed-by: Lepton Wu <lepton@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11008 >
2021-05-27 04:30:13 +00:00
Marek Olšák
b8d59e68be
gallium/u_vbuf: add a fast path to skip refcounting for uploaded user buffers
...
This improves performance by 23% with radeonsi and Ryzen 3900X running
the game torcs.
All vertex buffers must be user buffers to get this.
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10992 >
2021-05-27 01:52:13 +00:00
Mike Blumenkrantz
bbbcf14311
radeonsi: clamp clear_buffer values using new util helper
...
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10822 >
2021-05-27 00:23:04 +00:00
Mike Blumenkrantz
c4d3d21024
zink: clamp clear_buffer values
...
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10822 >
2021-05-27 00:23:04 +00:00
Mike Blumenkrantz
fb2fb0d4fe
gallium/aux: add helper for pre-clamping clear_buffer value to dword
...
copied from radeonsi
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10822 >
2021-05-27 00:23:04 +00:00
Mike Blumenkrantz
8418334efe
lavapipe: also ignore multiple pipeline barriers in succession
...
this just flushes repeatedly, which is pointless
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10762 >
2021-05-27 00:12:48 +00:00
Mike Blumenkrantz
df47ed074d
lavapipe: skip "pipeline barriers" if they're first or last in a cmdbuf
...
barriers just trigger a full flush, which is unnecessary if it's:
* the first cmd in a cmdbuf, as the previous cmdbuf will have already
flushed and so this is flushing nothing
* the last cmd in a cmdbuf, as there will be a flush immediately after
returning from this function
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10762 >
2021-05-27 00:12:48 +00:00
Mike Blumenkrantz
08a7cfce5e
llvmpipe: stop accessing pipe_resource::screen internally
...
this breaks driver tracing
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11017 >
2021-05-26 23:58:59 +00:00
Mike Blumenkrantz
09019fb456
llvmpipe: store a screen pointer in resource struct
...
directly accessing the pipe_resource::screen pointer crashes trace,
so it's necessary to have an unwrapped pointer available if such things
are needed
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11017 >
2021-05-26 23:58:59 +00:00
Mike Blumenkrantz
621b8788bb
llvmpipe: only dump tgsi shaders if they're actually tgsi shaders
...
this crashes otherwise
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11016 >
2021-05-26 23:44:10 +00:00
Mike Blumenkrantz
9f5e4ccdb9
llvmpipe: split out scene surface init into separate function
...
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11015 >
2021-05-26 23:32:12 +00:00
Mike Blumenkrantz
a2d1b6d14f
llvmpipe: split out scene surface info into separate struct
...
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11015 >
2021-05-26 23:32:12 +00:00
Mike Blumenkrantz
614fcdc8c7
lavapipe: moar @optimize
...
without enough nir optimizing, some shaders fail to reduce as they should,
resulting in the wrong output
fixes dEQP-VK.graphicsfuzz.spv-stable-mergesort-flatten-selection-dead-continues
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11019 >
2021-05-26 23:21:07 +00:00
Mike Blumenkrantz
5925f2ea39
llvmpipe: remove clamping to [0,1] for tri offset
...
this was added in 315f8daab1 without much detail, then refactored
a bunch of times, and there's even now been a comment added questioning
whether it's correct: it does not appear to be.
fixes lavapipe cts cases:
dEQP-VK.draw.inverted_depth_ranges.depthclamp_deltaone_bias_clamp_neg
dEQP-VK.draw.inverted_depth_ranges.nodepthclamp_deltaone_bias_clamp_neg
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11012 >
2021-05-26 23:06:48 +00:00
Emma Anholt
26677008b9
ci/freedreno: Turn off default a530 quick_gl testing, do full quick_shader.
...
The quick_gl set is too unstable -- even when I switched to a consistent
set of tests, and added lots of flakes, I keep getting new ones as some
test (unclear which, but it's like 7-8 minutes into the run) kills other
innocent ones. Until we get per process pagetables, disable this testing
by default.
However, now that we've freed up a board that was doing quick_gl, we have
time to do all of quick_shader so that piglit uprevs don't reshuffle the
test list and expose new failures.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11018 >
2021-05-26 20:49:47 +00:00
Yiwei Zhang
7adb9c42e0
venus: advertise VK_ANDROID_external_memory_android_hardware_buffer
...
Besides advertising AHB support, for Android, we do not advertise
KHR_external_memory_fd, EXT_external_memory_dma_buf or
EXT_image_drm_format_modifier so that AHB remains the sole channel for
external resource sharing.
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org >
Reviewed-by: Chia-I Wu <olvaffe@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10960 >
2021-05-26 20:26:19 +00:00
Yiwei Zhang
47bf8be024
venus: support AHB external format for sampler YCbCr conversion
...
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org >
Reviewed-by: Chia-I Wu <olvaffe@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10960 >
2021-05-26 20:26:19 +00:00
Yiwei Zhang
78b30a0696
venus: implement vn_GetMemoryAndroidHardwareBufferANDROID
...
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org >
Reviewed-by: Chia-I Wu <olvaffe@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10960 >
2021-05-26 20:26:19 +00:00
Yiwei Zhang
7370f33953
venus: implement AHB allocation and import (part 2/2)
...
TODO left to fix plane count > 1 case for external memory.
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org >
Reviewed-by: Chia-I Wu <olvaffe@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10960 >
2021-05-26 20:26:19 +00:00
Yiwei Zhang
1743892f24
venus: implement AHB allocation and import (part 1/2)
...
This patch refactors the struct look up logic for memory allocation, and
it prepares the necessary info for ahb allocation and import.
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org >
Reviewed-by: Chia-I Wu <olvaffe@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10960 >
2021-05-26 20:26:19 +00:00
Yiwei Zhang
4958ce582c
venus: refactor device memory fd import
...
This patch wraps up fd import logic, which will be used later by ahb
import. This patch also removes a redundant check in need_bo.
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org >
Reviewed-by: Chia-I Wu <olvaffe@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10960 >
2021-05-26 20:26:19 +00:00
Yiwei Zhang
910c0602c4
venus: implement image creation for ahb handle type
...
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org >
Reviewed-by: Chia-I Wu <olvaffe@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10960 >
2021-05-26 20:26:18 +00:00
Yiwei Zhang
19b7b09885
venus: prepare image creation helpers for AHB
...
Store image create info for deferred creation of AHB image.
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org >
Reviewed-by: Chia-I Wu <olvaffe@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10960 >
2021-05-26 20:26:18 +00:00
Yiwei Zhang
53e35f716e
venus: fix AHB image format properties query
...
1. bail early if there's no compatiable AHB format
2. check against the corresponding drm format modifier
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org >
Reviewed-by: Chia-I Wu <olvaffe@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10960 >
2021-05-26 20:26:18 +00:00
Yiwei Zhang
7f52544f6f
venus: fix vn_GetAndroidHardwareBufferPropertiesANDROID
...
Append a VK_FORMAT_FEATURE_MIDPOINT_CHROMA_SAMPLES_BIT bit to pass cts.
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org >
Reviewed-by: Chia-I Wu <olvaffe@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10960 >
2021-05-26 20:26:18 +00:00
Yiwei Zhang
8c06f018a4
venus: complete the format conversion between AHB and Vulkan
...
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org >
Reviewed-by: Chia-I Wu <olvaffe@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10960 >
2021-05-26 20:26:18 +00:00
Yiwei Zhang
c82e836490
venus: tiny refactor of vn_android_get_gralloc_buffer_info
...
Return false if the queried drm format modifier is invalid.
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org >
Reviewed-by: Chia-I Wu <olvaffe@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10960 >
2021-05-26 20:26:18 +00:00
Samuel Pitoiset
b9ff51f750
radv: move all game workarounds to drirc
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10978 >
2021-05-26 18:48:04 +00:00
Samuel Pitoiset
25a6c35bbc
util/drirc: use application_name_match for the SotTR RADV workaround
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10978 >
2021-05-26 18:48:04 +00:00
Samuel Pitoiset
8aa735e856
radv: add few new drirc options
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10978 >
2021-05-26 18:48:04 +00:00
Samuel Pitoiset
34f5407b8e
util/drirc: make engine_versions an optional field
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10978 >
2021-05-26 18:48:04 +00:00
Tomeu Vizoso
81d132504b
ci/freedreno: Add spec@arb_copy_buffer@dlist flake on a530
...
Crashes occasionally, probably due to the same cause as
spec@arb_copy_buffer@intra-buffer-copy.
Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7987 >
2021-05-26 18:20:19 +00:00
Tomeu Vizoso
412d279fbc
ci/freedreno: Add new flake after "ci: Configure DUTs for max performance"
...
Probably was made more probable since the cpufreq or devfreq changes. Or
maybe due to the lack of runtime PM?
Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7987 >
2021-05-26 18:20:19 +00:00
Tomeu Vizoso
1ccc6e7ce4
ci/freedreno: Fix name of flake
...
Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7987 >
2021-05-26 18:20:19 +00:00
Tomeu Vizoso
e1f75d17da
ci/zink: Add nearest_linear_mirror_l8_pot flake
...
Crashed once at https://gitlab.freedesktop.org/mesa/mesa/-/jobs/10116149
Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7987 >
2021-05-26 18:20:19 +00:00
Tomeu Vizoso
26079868a7
ci/freedreno: Add depth32f_stencil8 flakes
...
Started happening after disabling cpufreq, devfreq and runtime PM.
At least one of these fail in each run, so it's blocking MRs.
Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7987 >
2021-05-26 18:20:19 +00:00
Tomeu Vizoso
a15cf1ecab
radeonsi/ci: Add new Piglit failures
...
These appeared after the execution order of tests changed after a Piglit
upgrade.
Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7987 >
2021-05-26 18:20:19 +00:00
Antonio Caggiano
8e470457de
ci: Add a manual job for tracking the performance of Freedreno
...
Use Piglit's replay profile to measure and store the time that frames
take to render in the GPU.
This job won't run automatically in regular pipelines, but will be
triggered automatically by a script for every successful pre-merge
pipeline.
This is because we want to generate performance data for every relevant
commit merged in main, but we don't want to keep a device busy during
the pre-merge run.
Signed-off-by: Antonio Caggiano <antonio.caggiano@collabora.com >
Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com >
Reviewed-By: Rohan Garg <rohan.garg@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7987 >
2021-05-26 18:20:19 +00:00
Tomeu Vizoso
93138ef122
ci: Uprev apitrace to 170424754bb4 "retrace: Get --loop to work without rewinding"
...
Needed to be able to replay traces for performance tracking.
Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com >
Reviewed-By: Rohan Garg <rohan.garg@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7987 >
2021-05-26 18:20:19 +00:00
Tomeu Vizoso
cea379549e
ci: Uprev piglit to eee7d89611cf "tests: Replay profile frame times"
...
So we can measure GPU times when replaying traces.
Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com >
Reviewed-By: Rohan Garg <rohan.garg@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7987 >
2021-05-26 18:20:19 +00:00
Tomeu Vizoso
eef5409df4
ci: Configure DUTs for max performance
...
Lock CPU and GPU frequency scaling on devices so to speed up test
execution and lower the variation of frame times from performance replay
jobs.
Also disable autosuspend of the GPU device.
Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com >
Reviewed-By: Rohan Garg <rohan.garg@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7987 >
2021-05-26 18:20:19 +00:00
Alyssa Rosenzweig
8fc913fde2
panfrost: Expose PIPE_CAP_SHAREABLE_SHADERS
...
Now that the compile entrypoints don't touch the context, it's clear
that we can support this. Note, even though the pools for shaders and
descriptors are referenced from particular contexts, they are unowned
pools -- once uploaded, any thread can use the results.
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10976 >
2021-05-26 18:05:47 +00:00
Alyssa Rosenzweig
4b984c494c
panfrost: Don't take ctx in panfrost_shader_compile
...
Complicates validation of PIPE_CAP_SHAREABLE_SHADERS.
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10976 >
2021-05-26 18:05:47 +00:00
Alyssa Rosenzweig
7b4a76f493
panfrost: Inline pan_prepare_shader_descriptor
...
Complicates the next patch.
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10976 >
2021-05-26 18:05:47 +00:00
Anuj Phogat
6bb66b78a9
intel/gfx12+: Add Wa_14013840143
...
Cc: mesa-stable
Signed-off-by: Anuj Phogat <anuj.phogat@gmail.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10984 >
2021-05-26 17:42:21 +00:00
Samuel Pitoiset
69ae02151d
radv: remove DFSM
...
DFSM has never been enabled by default because it was slower.
RadeonSI is also dropping support for this because they discovered
that's actually not efficient in practice.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10968 >
2021-05-26 17:22:14 +00:00