AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
166,074 Commits 1 Branch 0 Tags
383269238df5fb8b32f3f4cc06bc00b6cdca52a9
Commit Graph

166074 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Marek Olšák 383269238d radeonsi/gfx11: fix blend->cb_target_mask dependency for shader keys 
Shader keys only use cb_target_enabled_4bit. This may cause shaders to be
updated less often, but otherwise no change in behavior.

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>š
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21041>
 2023-02-03 00:18:01 +00:00
Marek Olšák d5ff270e0b radeonsi/gfx11: adjust ACCUM_* fields for tessellation 
based on PAL

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21041>
 2023-02-03 00:18:01 +00:00
Marek Olšák 0b4b309fc6 radeonsi/gfx11: add a comment why we use PRIM_GRP_SIZE <= 252 
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21041>
 2023-02-03 00:18:01 +00:00
Marek Olšák d21850f753 radeonsi/gfx11: remove the INST_PREF_SIZE workaround 
The hw does the right thing automatically. (i.e. enables or disables
the feature)

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21041>
 2023-02-03 00:18:01 +00:00
Marek Olšák f6c30af00c radeonsi: implement RB+ depth-only rendering for better perf 
The explanation is in the last change of this commit.

Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21041>
 2023-02-03 00:18:01 +00:00
Marek Olšák 2fc03e479b amd: improve RB+ blending precision 
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21041>
 2023-02-03 00:18:01 +00:00
Marek Olšák a9e9c4650d amd: update shadowed register tables for gfx11 
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21041>
 2023-02-03 00:18:01 +00:00
Marek Olšák b6f6465264 amd: update SX_BLEND_OPT_EPSILON.MRT0_EPSILON enum definitions 
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21041>
 2023-02-03 00:18:01 +00:00
Marek Olšák 47f598a183 amd: fix tile_swizzle on gfx11 - should be shifted by 10 bits, not 8 
This reverts the radv_adjust_tile_swizzle change to unify the code.

Fixes: 529eb739fc - radeonsi/gfx11: add CB deltas

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21041>
 2023-02-03 00:18:01 +00:00
Marek Olšák 84d59cdb59 amd: split GFX1103 into GFX1103_R1 and GFX1103_R2 
Fixes: caa09f66ae - amd: add chip identification for gfx1100-1103

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21041>
 2023-02-03 00:18:01 +00:00
Marek Olšák 66d11391f7 radeonsi/gfx11: unset SAMPLE_MASK_TRACKER_WATERMARK to fix hangs 
Same as PAL.

Fixes: 529eb739fc - radeonsi/gfx11: add CB deltas

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21041>
 2023-02-03 00:18:01 +00:00
Marek Olšák 8556b3db71 radeonsi: fix RB+ blending with sRGB formats 
The epsilon for 8bpc is for the linear colorspace. There is no epsilon
for sRGB.

Fixes: 17021efc74 - radeonsi: adjust RB+ blend optimization settings

Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21041>
 2023-02-03 00:18:01 +00:00
Marek Olšák dacb111607 radeonsi/ci: add gfx1100 results 
There are also a lot of flakes.

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21041>
 2023-02-03 00:18:01 +00:00
Marek Olšák 6445d2eca9 radeonsi/ci: update gfx10.3 results 
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21041>
 2023-02-03 00:18:01 +00:00
Emma Anholt fd28452631 turnip: Make the tiling-impossible case have an impossible tile layout. 
This helped me catch inappropriate tiling work being done in this case.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21004>
 2023-02-02 14:56:15 -08:00
Emma Anholt 3c3bd12af7 tu: Only emit the conditional gmem subpass resolves when gmem is possible. 
No sense emitting this work when the subpass deps or attachment size
prevents gmem.  Noticed when I had uninit values in the tiling layout.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21004>
 2023-02-02 14:56:15 -08:00
Emma Anholt aae679e221 turnip: Optimize tile sizes to reduce the number of bins. 
We were aiming for very square tiles, but it's actually better for us to
reduce the number of different bins so you take fewer trips through the
geometry and keep the caches hotter.  Example changes to aztec ruins on
angle:

    3x3 tiles of 352x352 to 4x2 tiles of 256x512
    4x5 tiles of 256x224 to 5x4 tiles of 224x256
    17x11 tiles of 160x128 to 14x11 tiles of 192x128
    12x7 tiles of 224x224 to 7x11 tiles of 384x128
    12x8 tiles of 224x192 to 7x11 tiles of 384x128
    11x6 tiles of 256x256 to 12x5 tiles of 224x288
    11x7 tiles of 256x224 to 7x9 tiles of 384x160
    8x4 tiles of 352x352 to 6x5 tiles of 448x288

and minecraft:

    3x3 tiles of 352x352 to 4x2 tiles of 256x512
    12x6 tiles of 256x256 to 3x23 tiles of 1024x64
    12x7 tiles of 256x224 to 8x9 tiles of 384x160

FPS changes:
VK aztec ruins normal: 1.12478% +/- 0.213393% (n=67)
ANGLE manhattan_31:    +1.42813% +/- 0.893332% (n=7).
ANGLE minecraft:       no change (n=21)
ANGLE google_maps:     +6.80618% +/- 2.40857% (n=4)
ANGLE trex_200:        no change (n=11)
ANGLE pubg:            no change (n=21)

Fixes: #8160
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21004>
 2023-02-02 14:56:13 -08:00
Emma Anholt e27f84c56e tu: Mark tiling impossible if we couldn't lay out gmem in the first place. 
We were leaving the field undefined, which tripped me up later.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21004>
 2023-02-02 14:55:59 -08:00
Sagar Ghuge 0ec3522163 nir: Handle other variants of image_samples properly while lowering 
while lowering image_samples to one, we need to take
nir_intrinsic_image_deref_samples and
nir_intrinsic_bindless_image_samples intrinsic into account.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8211

Fixes: ab4c2990ed ("intel/compiler: use lower_image_samples_to_one")
Signed-off-by: Sagar Ghuge <sagar.ghuge@intel.com>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21053>
 2023-02-02 21:40:45 +00:00
Juston Li 6f4b375c94 anv: check initial cmd_buffer is chainable 
Submitting a batch with the first command buffer with the simultaneous
bit set followed by a command buffer without the bit set gets past the
check and triggers this assert attempting to chain them:
../src/intel/vulkan/anv_batch_chain.c:1147: anv_cmd_buffer_chain_command_buffers: Assertion `num_cmd_buffers == 1' failed.

Signed-off-by: Juston Li <justonli@google.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21056>
 2023-02-02 21:17:33 +00:00
Jesse Natalie 9c5df90ae5 wsi/win32: We don't need a window DC for DXGI 
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21049>
 2023-02-02 19:48:00 +00:00
Jesse Natalie 192e7e0cef wsi/win32: Don't require buffer blits for software drivers 
Lavapipe can directly render to a linear CPU image and then BitBlit
straight from there.

Fixes: 2f462105 ("vulkan/wsi: Hook-up DXGI swapchains and DComp")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8085
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21049>
 2023-02-02 19:48:00 +00:00
Erik Faye-Lund c8994256a6 anv, hasvk: remove stale TODO-files 
This file hasn't really been updated since 2016, apart from a single
search-replace two years ago.

That's an eternity in ANV-land, so let's just remove these.

While we're at it, also remove the duplicate in hasvk.

Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Acked-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21044>
 2023-02-02 19:25:15 +00:00
Lucas Stach 175732bb51 etnaviv: fix double scanout import of multiplanar resources 
etna_resource_from_handle() is called for each plane of a multiplanar
resource, so there is no point in looping over all planes to do the
renderonly scanout import. In fact that will cause us to lose track
of the scanout imports from later planes when the earlier planes are
redoing the import, overwriting the pointer to the allocated
renderonly_scanout struct.

Drop the loop and just do the import for the current plane.

Fixes: 826f95778a ("etnaviv: always try to create KMS side handles for imported resources")
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20993>
 2023-02-02 19:08:29 +00:00
Emma Anholt 8839baee57 ci: Drop the itoral-gl-terrain demo from traces. 
There's an app bug in the CSM rendering that causes undefined results.

Fixes: #8212
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21055>
 2023-02-02 18:42:45 +00:00
Georg Lehmann 3c25edfdb7 aco: Improve wave64 cycle estimates. 
Reviewed-By: Tatsuyuki Ishi <ishitatsuyuki@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20507>
 2023-02-02 17:59:23 +01:00
Mike Blumenkrantz 5a40190f04 Revert "zink: fix zink_mem_type_idx_from_bits()" 
This reverts commit f7796997964bb462bcbfa6b9faca5dcf04b64e1b.

I was doing too much F2F and not enough thinking with this one

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21076>
 2023-02-02 16:27:38 +00:00
Rose Hudson 0d4e375a58 asahi: wire up shader disk cache support 
Note: I (Alyssa) have squashed in some minor changes squashed in pre merge. The
rest is Rose's work :-)

Closes: #8091
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20835>
 2023-02-02 16:12:33 +00:00
Samuel Pitoiset 3ad9a6e7c2 radv: simplify an assertion after considering RADV_FORCE_VRS 
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21068>
 2023-02-02 15:06:07 +00:00
Samuel Pitoiset 3eb97b9d33 radv: skip compilation when possible with GPL fast-linking 
When all shader stages have already been imported it's possible to
skip radv_graphics_pipeline_compile() entirely. This makes GPL
fast-linking VERY fast.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21068>
 2023-02-02 15:06:07 +00:00
Samuel Pitoiset 6b513a9c6a radv: determine the last VGT API stage earlier 
It can be computed right after the active stages are known. While we
are at it, simplify the code.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21068>
 2023-02-02 15:06:07 +00:00
Samuel Pitoiset 031bbdfbe6 radv: stop using the graphics pipeline key after compilation 
Only the blend state was relying on the graphics pipeline key. This
will allow us to skip generating it when there is no compilation at
all (for fast-linking with GPL).

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21068>
 2023-02-02 15:06:07 +00:00
Samuel Pitoiset aebe65e88a radv: return a boolean value in radv_pipeline_needs_dynamic_ps_epilog() 
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21068>
 2023-02-02 15:06:07 +00:00
Samuel Pitoiset 6ddf1fd9ad radv: pass the lib flags for generating the pipeline key 
No functional change.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21068>
 2023-02-02 15:06:07 +00:00
Eric Engestrom 04fefec70f v3dv: mark dEQP-VK.api.command_buffers.record_many_draws_secondary_2 as flaky 
Signed-off-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21070>
 2023-02-02 14:44:05 +00:00
Samuel Pitoiset 863bc08136 radv: remove one unused variable in radv_graphics_lib_pipeline_init() 
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21042>
 2023-02-02 14:01:12 +00:00
Samuel Pitoiset c9e032be7f radv: allow to create a noop FS in a library with GPL 
Otherwise, a noop FS will be always compiled during linking if not
provided by the application and that is too slow for fast-linking.

This should be improved to use a global noop FS but it's really tricky
because NIR linking doesn't do anything when the next stage is unknown,
and hence doesn't remove unused varyings.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21042>
 2023-02-02 14:01:12 +00:00
Mike Blumenkrantz 68e914a4ca zink: rework descriptor buffer templating to use offsets 
compute programs can be reused across contexts, which means storing any
pointers directly like this is going to lead to desync and crash

instead, make this like regular descriptor templates and calculate the offset
from the current context to ensure that everything works as it should

fixes #8201

Fixes: 7ab5c5d36d ("zink: use EXT_descriptor_buffer with ZINK_DESCRIPTORS=db")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21020>
 2023-02-02 12:59:15 +00:00
Asahi Lina ed6edc07e4 asahi: Split off macOS support into its own file 
All the ifdef __APPLE__ is getting really silly. Let's split off the
macOS UAPI abstraction into its own file, so we can have parallel
implementations.

Signed-off-by: Asahi Lina <lina@asahilina.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21058>
 2023-02-02 11:45:52 +00:00
Asahi Lina 2e51ccac82 asahi: Split off common BO code into its own file 
In preparation for splitting off the macOS backend implementation into
its own file, pull out the shared BO code from agx_device.c into
agx_bo.c.

Signed-off-by: Asahi Lina <lina@asahilina.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21058>
 2023-02-02 11:45:52 +00:00
Alyssa Rosenzweig ea285aea8d asahi: Use non-UAPI specific BO create flags 
So we're not tied to the macOS or Linux UAPIs and are not translating awkwardly
from one to the other when creating BOs. They're not quite equivalent -- macOS
doesn't include writeback information in this flag field, and Linux doesn't have
a executable flag. (Maybe we should add one, though? Then we can enforce W^X.)

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21058>
 2023-02-02 11:45:52 +00:00
Martin Roukala (né Peres) 9e2365708b zink/ci: allow running manual jobs again on RADV 
Fixes: f6c06ef2f6 ("ci: Add manual rules variations to disable.")
Reviewed-by: Emma Anholt <emma@anholt.net>
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21036>
 2023-02-02 12:18:33 +02:00
Martin Roukala (né Peres) 0c54f261ea ci/core-manual-rules: enclose the whole condition in quotes 
Quoting a condition is apparently an effective way of working around
YAML parsing weirdness. However, the quotes need to surround the whole
expression, not just parts of it.

Fixes: f6c06ef2f6 ("ci: Add manual rules variations to disable.")
Suggested-by: Michel Dänzer <mdaenzer@redhat.com>
Reviewed-by: Eric Engestrom <eric@igalia.com>
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21036>
 2023-02-02 12:18:33 +02:00
Alyssa Rosenzweig 5e14792200 agx: Centralize texture lowering 
Lowering buffer textures will interact with multiple of our existing lowerings,
and it's convenient to have it all in one place. This also keeps the pass
ordering dependencies centralized.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21060>
 2023-02-02 06:39:42 +00:00
Erico Nunes 7258f6bafd Revert "CI: Lima farm is offline" 
This reverts commit 0733aafa22.

Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
Acked-by: Vasily Khoruzhick <anarsoul@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21035>
 2023-02-02 06:10:28 +00:00
Mike Blumenkrantz d23b3a1394 zink: fix zink_mem_type_idx_from_bits() 
at some point this used to work, but it no longer does what it's supposed
to do, which is return a memtype from a heap+flags

Fixes: d702a503ad ("zink: support multiple heaps per memory type")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21025>
 2023-02-02 05:04:17 +00:00
Mike Blumenkrantz ff5a761232 zink: only set VkPipelineColorBlendStateCreateInfo::attachmentCount without full ds3 
this should be ignored by drivers/layers, but it isn't, and the crashing is immense

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21025>
 2023-02-02 05:04:17 +00:00
Mike Blumenkrantz fd0562693d lavapipe: try harder to reuse pipeline layouts during merge 
the original code was quite conservative and always created a new layout,
but many times this is unnecessary, and the original layout can just be refcounted
since it doesn't need to be merged

Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21051>
 2023-02-02 04:49:42 +00:00
Mike Blumenkrantz a1a859328b lavapipe: delete lvp_pipeline::mem_ctx 
this is no longer used

Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21051>
 2023-02-02 04:49:42 +00:00
Mike Blumenkrantz 59af3b4ad4 lavapipe: delete unused pipelines immediately 
deferring these can cause memory ballooning and oom

Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21051>
 2023-02-02 04:49:42 +00:00