AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
169,325 Commits 1 Branch 0 Tags
3658fd68237c4ed3eb2bd2b50f3e4f4dc759e810
Commit Graph

169325 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Brian Paul 3658fd6823 llvmpipe: rename some vars related to occlusion query and ps invocations 
More consistent naming.

Signed-off-by: Brian Paul <brianp@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22281>
 2023-04-05 03:49:16 +00:00
Brian Paul 43773fdda7 llvmpipe: fix ps invocations query bug 
We were not initializing the PS invocation count to zero before
computing the sum of the per-thread results.

This fixes an issue where querying the result of the query more
than once would cause the result to grow larger each time.

Signed-off-by: Brian Paul <brianp@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22281>
 2023-04-05 03:49:16 +00:00
Felix DeGrood 840e98f19e iris: report draw count for perfetto 
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22296>
 2023-04-05 02:13:49 +00:00
Erik Faye-Lund 72cd7e0079 ci: remove unused rules 
These are no longer used.

Reviewed-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Eric Engestrom <eric@igalia.com>
Acked-by: Guilherme Gallo <guilherme.gallo@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22263>
 2023-04-04 23:49:53 +00:00
Erik Faye-Lund 1b7a4029d0 virgl/ci: clean up manual rules for virgl 
In f6c06ef2f6 ("ci: Add manual rules variations to disable irrelevant
driver jobs."), we fixed this for *most* driver. This fixes up the last
driver, hopefully removing an annoying needless button in the UI for
some MRs.

Reviewed-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Eric Engestrom <eric@igalia.com>
Acked-by: Guilherme Gallo <guilherme.gallo@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22263>
 2023-04-04 23:49:53 +00:00
Erik Faye-Lund 67750f138b ci: move virgl-rules after intel-rules 
We're about to add a dependency on stuff from the intel-rules, and
moving virgl down here allows us to depend on them without having to
move the definition out of the intel-section.

Reviewed-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Eric Engestrom <eric@igalia.com>
Acked-by: Guilherme Gallo <guilherme.gallo@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22263>
 2023-04-04 23:49:53 +00:00
Mike Blumenkrantz 61451af5a2 zink: rework choose_pdev (again) 
there are two cases to be handled here:
* normal
* software

the latter case requires env vars based on the frontend, and if a sw
device isn't found then init should fail

the former case should (in theory) just yolo the first device and assume
that's what the user wanted based on whatever env vars and layers are
in use

fixes #7508, #7132

maybe also affects #8152

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22184>
 2023-04-04 23:32:46 +00:00
Pedro J. Estébanez 32e3c77a11 Revert "microsoft/compiler: Use SRVs for read-only images" 
This reverts commit 54c32aeba6.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22289>
 2023-04-04 22:50:05 +00:00
Pedro J. Estébanez 88acbcadbb spirv: Assume input attachments are read-only 
Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22289>
 2023-04-04 22:50:05 +00:00
Pedro J. Estébanez e59fdcb93c spirv2dxil: Split read-only image as SRV logic into declared and inferred 
Fixes: e0a090ad ("spirv2dxil: Only lower readonly images to SRVs when the option is set")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22289>
 2023-04-04 22:50:05 +00:00
Jesse Natalie 9663546cf4 dzn: Claim fillModeNonSolid 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22277>
 2023-04-04 21:48:19 +00:00
Jesse Natalie 69a9a3ea3c dzn: Handle polygon point mode 
Note: The meaning of clockwise vs counter-clockwise changes after the
yz flip, therefore the determination of winding needs to be done before
the yz flip logic. Therefore the yz flip is moved to the GS and applied
as a lowering on top of the base GS.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22277>
 2023-04-04 21:48:19 +00:00
Jesse Natalie bcf50b7532 dzn: Add a helper to generate triangle->point GS 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22277>
 2023-04-04 21:48:19 +00:00
Jesse Natalie 83fd7e9460 spirv2dxil: Expose yz flip pass to external callers 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22277>
 2023-04-04 21:48:19 +00:00
Jesse Natalie b723962418 d3d12: Move forward-front-face pass to common DXIL code 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22277>
 2023-04-04 21:48:19 +00:00
Patrick Lerda e0ed2b29f4 r600: fix typo that could lead to a possible crash 
For instance, with "piglit/bin/arb_shader_image_load_store-host-mem-barrier --quick -auto -fbo":
==18549==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x61200000a059 at pc 0x7f65d8937b80 bp 0x7fff6ed19a00 sp 0x7fff6ed199f8
READ of size 1 at 0x61200000a059 thread T0
    #0 0x7f65d8937b7f in evergreen_set_shader_images ../src/gallium/drivers/r600/evergreen_state.c:4277
    #1 0x7f65d6b471b8 in st_bind_images ../src/mesa/state_tracker/st_atom_image.c:172
    #2 0x7f65d6b76b26 in st_validate_state ../src/mesa/state_tracker/st_util.h:129
    #3 0x7f65d6b76b26 in prepare_draw ../src/mesa/state_tracker/st_draw.c:88
    #4 0x7f65d6b77c8a in st_draw_gallium ../src/mesa/state_tracker/st_draw.c:141
    #5 0x7f65d72698a2 in _mesa_draw_arrays ../src/mesa/main/draw.c:1202

Fixes: a6b3792843 ("r600: add core pieces of image support.")
Signed-off-by: Patrick Lerda <patrick9876@free.fr>
Reviewed-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22273>
 2023-04-04 21:35:05 +00:00
Eric Engestrom db0c4a8965 vc4/ci: add arm64 failure to flakes as it works on armhf 
Signed-off-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22297>
 2023-04-04 21:00:06 +00:00
Sonny Jiang 7360aa020c gallium/pipe: change PIPE_DEFAULT_DECODER_FEEDBACK_TIMEOUT_NS to 1 second 
Fixes: 5e1bd07a ("radeonsi: vcn: implement the get_decoder_fence vfunc")
The commit [5e1bd07a] puts a timeout on fence_wait which causes a 8k AV1
decoding regression on gfx940. By adding DECODER_FEEDBACK_TIMEOUT to
add fence wait time.

Signed-off-by: Sonny Jiang <sonny.jiang@amd.com>
Reviewed-by: Boyuan Zhang <Boyuan.Zhang@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22268>
 2023-04-04 20:05:26 +00:00
Emma Anholt 3ede37f8a6 docs: Claim less functionality for glsl_compiler. 
It doesn't generate GPU code, just GLSL IR code.  Also, clarify where to
find the built tool, and what the options do.

Closes: #8674
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22271>
 2023-04-04 20:00:17 +00:00
Emma Anholt c346413d9c ci: Add missing dependency on doxygen sources for docs-generation jobs. 
!22191 broke docs generation and marge didn't notice because of missing
 deps.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22271>
 2023-04-04 20:00:17 +00:00
Emma Anholt 6fc9540176 docs: Update Vulkan renderpass docs for !22191 
Fixes: 6ad5f885af ("vulkan: Drop VkRenderingSelfDependencyInfoMESA")
Closes: #8773
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22271>
 2023-04-04 20:00:17 +00:00
Ryan Neph 59a5340f74 i915: hook new get_fd proc for drm winsys 
Fixes: 853b4801f2 ("i915: Add support for `get_screen_fd`")
Signed-off-by: Ryan Neph <ryanneph@google.com>
Reviewed-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22294>
 2023-04-04 19:39:02 +00:00
Ryan Neph 94b3a7e3ff virgl: hook new get_fd proc for drm winsys 
Fixes: 2ade6917da ("virgl: Add support for `get_screen_fd`")
Signed-off-by: Ryan Neph <ryanneph@google.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22292>
 2023-04-04 19:21:59 +00:00
Daniel Schürmann 5c362cde33 radv: update PS num_vgprs in case of epilogs rather than overallocating VGPRs 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22267>
 2023-04-04 18:35:43 +00:00
Daniel Schürmann 4c7a5b1e51 aco: don't use shared VGPRs for shaders consisting of multiple binaries 
When using multiple binaries, we don't know the required number of VGPRs beforehand,
which means we either have to over-allocate VGPRs or avoid shared VGPRs.
As bpermute is the only instructions needing shared VGPRs, we decide for the latter.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22267>
 2023-04-04 18:35:43 +00:00
Daniel Schürmann 37df8edf34 aco/ra: adjust_max_used_regs() for fixed Operands 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22267>
 2023-04-04 18:35:43 +00:00
Daniel Schürmann 8c68aba678 aco: split ps_epilog args before exporting them 
This avoids some unnecessary copies from extracting from the input vectors.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22267>
 2023-04-04 18:35:42 +00:00
Sagar Ghuge 10fc12fd17 anv: Drop dead code that sets the L3BypassDisable field 
These helper functions will only get invoked for GFX < 11 and the
L3BypassDisable field is present starting from GFX12+.

Signed-off-by: Sagar Ghuge <sagar.ghuge@intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22275>
 2023-04-04 17:39:20 +00:00
Sagar Ghuge e3b172d75d anv: Drop unused param from add_surface_reloc 
Signed-off-by: Sagar Ghuge <sagar.ghuge@intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22275>
 2023-04-04 17:39:20 +00:00
Emma Anholt a1277b89a1 ci/zink: Disable godot-tps-gles3 on a630. 
This trace used too much memory to be run in parallel with our other
traces.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22279>
 2023-04-04 15:37:14 +00:00
Collabora's Gfx CI Team 91b06ea8b2 Uprev Piglit to 2391a83d1639a7ab7bbea02853b922878687b0e5 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22279>
 2023-04-04 15:37:14 +00:00
Samuel Pitoiset c5b7efa293 radv: enable shaders cache for libraries with GPL 
This was the last missing feature for GPL. The main problem is that
the on-disk shaders cache size will increase a lot because we don't
deduplicate shaders but there is on-going work to improve that.

We also can't use the shaders cache for libraries created with the
RETAIN_LINK_TIME_OPTIMIZATION flag and module identifiers because we
don't know the SPIR-V and thus can't retain NIR shaders for linking.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22264>
 2023-04-04 14:47:39 +00:00
Samuel Pitoiset 03d2bd6042 radv: ensure to retain NIR shaders for GPL libs found in the cache 
Even if we are able to get the assembly from the shaders cache for
graphics pipeline libraries, we still need to retain NIR shaders in
case the LTO pipelines won't be find in the cache.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22264>
 2023-04-04 14:47:39 +00:00
Samuel Pitoiset 5e62d8d1bd radv: add VkGraphicsPipelineLibraryFlag to the graphics pipeline key 
This is to generate a different key for a library created with
FRAGMENT_SHADER_BIT and no FS (ie. it would generate a noop FS) and
a library created with FRAGMENT_OUTPUT_INTERFACE with no CB attachments.

Otherwise, the same key would be generated and this would corrupt
the cache.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22264>
 2023-04-04 14:47:39 +00:00
Samuel Pitoiset 47c0820dc7 radv: remove dead code in radv_pipeline_get_nir() 
We either import the NIR or the assembly, so this was never reached.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22264>
 2023-04-04 14:47:39 +00:00
Samuel Pitoiset a9529d9644 radv: allow to create/insert PS epilogs from/to the cache for libs 
To cache PS epilogs compiled inside graphics pipeline libraries.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22264>
 2023-04-04 14:47:39 +00:00
Samuel Pitoiset ba967e1a28 radv: rely on non-NULL binaries when inserting shaders to the cache 
With GPL, a stage can be imported from a library which means that the
binary is NULL (it's freed right after compilation) but the shader is
non-NULL. To avoid crashing, rely on non-NULL binaries because this
implies that the shader is non-NULL as well.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22264>
 2023-04-04 14:47:39 +00:00
Samuel Pitoiset 1239fcab4d radv: only copy non-NULL shaders when loaded from the cache 
With GPL, we don't necessarily load all stages from the same cache
entry and other stages might have been imported from libraries, so
don't overwrite them.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22264>
 2023-04-04 14:47:39 +00:00
Connor Abbott 0977925c53 nir, spirv: Add support for VK_EXT_fragment_density_map 
This involves two new system values.

Reviewed-by: Faith Ekstrand <faith@gfxstrand.net>
Reviewed-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20303>
 2023-04-04 13:14:35 +00:00
Emma Anholt 6c0a8a7f06 ci/zink: Drop validation exception for leaks at device destroy. 
Between the recent glthread and zink fixes, we should be good to go.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22237>
 2023-04-04 11:50:58 +00:00
Pierre-Eric Pelloux-Prayer 4c3e1f6529 radeonsi: update test results 
This test was fixed by bf910c94e0 ("glsl: fix gl_CullDistance lowering
from float[8] to vec4[2]").

Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22237>
 2023-04-04 11:50:58 +00:00
Pierre-Eric Pelloux-Prayer c1368685c3 util/vbuf: fix index_bo leak 
When indices are unrolled we still have to release the index_bo
references passed to us.

Cc: mesa-stable
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8272
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22237>
 2023-04-04 11:50:58 +00:00
Pierre-Eric Pelloux-Prayer c19a3a6ddf util/vbuf: clarify indirect draws handling 
It wasn't obvious from the u_vbuf code alone that num_draws
is guaranteed to be 1 in the indirect case.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22237>
 2023-04-04 11:50:58 +00:00
Pierre-Eric Pelloux-Prayer 2b717f01f7 mesa: fix invalid index_bo refcounting 
If take_index_buffer_ownership is true, then we should reserve
enough references of index_bo or we'll get an underflow later.

Fixes: 819627041e ("mesa: set pipe_draw_info::index::resource directly and remove gl_bo")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8747
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22237>
 2023-04-04 11:50:58 +00:00
Mike Blumenkrantz 09320705f0 zink: be explicit about separate shader dsl indexing during creation 
this fixes a minor issue where a fs without a vs dsl would have the wrong
index

Fixes: e3b746e3a3 ("zink: use GPL to handle (simple) separate shader objects")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22269>
 2023-04-04 11:29:01 +00:00
Tapani Pälli b0cdd5a1d2 anv: check for MESA_SHADER_TESS_CTRL with get_tcs_prog_data 
Fixes: 86d931724d ("anv: Implement Wa_14015297576")
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22282>
 2023-04-04 10:42:12 +03:00
Tapani Pälli 98c6db3fc8 anv: take primitive ID override to account Wa_14015297576 
Commit ca4ec49b0e took primitive ID override fields in to use, this
has to be checked as part of Wa_14015297576.

Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22282>
 2023-04-04 10:41:58 +03:00
Mike Blumenkrantz e84cf80fe1 zink: always store nir serialized 
this saves a ton of memory and has minimal, if any cpu impact

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22266>
 2023-04-04 01:37:41 +00:00
Mike Blumenkrantz 4e1668384d zink: store num_inlinable_uniforms separately for cs programs 
compute is a special case because the zink_shader itself is created
in a thread, which means it cannot be accessed directly at bind time
since it may not have finished creating itself yet

to avoid prematurely waiting on an async fence, the one value needed
at bind time can instead be stored separately

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22266>
 2023-04-04 01:37:41 +00:00
Mike Blumenkrantz 517146f540 zink: move nir cloning out to callers of zink_shader_compile 
this will make more sense with future changes

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22266>
 2023-04-04 01:37:41 +00:00