Mike Blumenkrantz
3488dc7dd0
zink: improve zink_clear_depth_stencil check for current attachment
...
this is technically more correct since it accounts for multi-context usage
Acked-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17366 >
2022-07-18 03:40:37 +00:00
Mike Blumenkrantz
c1cc2bd48e
zink: stop using u_blitter for texture clears
...
this was really stupid: instead of just binding a new fb and firing off
a clear, the code was calling u_blitter to bind a new fb and do actual
draws
Acked-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17366 >
2022-07-18 03:40:37 +00:00
Mike Blumenkrantz
04a5471b5e
zink: fix coverage check for texture clears
...
this wasn't actively harmful, but it was potentially differently-performant
Acked-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17366 >
2022-07-18 03:40:37 +00:00
Mike Blumenkrantz
b33f041810
zink: remove format check from clear texture
...
this is going to be a render target no matter what
Acked-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17366 >
2022-07-18 03:40:37 +00:00
Mike Blumenkrantz
8bb5a11503
zink: fix transient attachment rp assert
...
cc: mesa-stable
Acked-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17366 >
2022-07-18 03:40:37 +00:00
Mike Blumenkrantz
d1db078619
zink: remove bogus range tracking from texture clear
...
too much copy/paste
Acked-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17366 >
2022-07-18 03:40:37 +00:00
Dave Airlie
af2e4a23c9
lavapipe: enable variablePointers
...
This passes the CTS with no regressions.
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17587 >
2022-07-17 23:16:40 +00:00
Dave Airlie
dbd9caae5e
lavapipe: drop unreachable pNext checks.
...
These are reachable, and
dEQP-VK.api.smoke.triangle_ext_structs,Crash is why.
Signed-off-by: Dave Airlie <airlied@redhat.com >
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17586 >
2022-07-17 23:02:19 +00:00
Mihai Preda
bc78b861ca
gallium: LLVM-15 contexts use non-opaque pointers
...
LLVM-15 enables opaque pointers by default. We temporarilly request
non-opaque pointers while we migrate our code to support non-opaque pointers.
This workaround needs to be removed before LLVM-16.
See #6615
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Acked-by: Kai Wasserbäch <kai@dev.carbon-project.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17514 >
2022-07-17 21:44:37 +00:00
Rob Clark
81d85be9a5
freedreno/gmem: Reverse order of alternative tile rows
...
Similar motivation as c426e21ff1 ("turnip: Reverse the order of walking
pipes or tiles on odd rows."), but instead we just swap the order of
alternate rows of fd_tile the the gmem stateobj.
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17303 >
2022-07-16 15:37:34 +00:00
Daniel Stone
cdb7a3b0e2
Revert "CI: Disable Collabora lab"
...
This reverts commit 7a336c97ef692ed96cc93394596a7d0650983874.
Signed-off-by: Daniel Stone <daniels@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17563 >
2022-07-16 11:44:26 +00:00
Arvind Yadav
1fbc7337a1
radeonsi: Enable nir_lower_point_smooth lowering pass for point smoothing
...
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15117 >
2022-07-16 07:08:33 -04:00
Arvind Yadav
8adbd2a964
ac/llvm: Implement nir_intrinsic_load_point_coord_maybe_flipped opcodes
...
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15117 >
2022-07-16 07:08:10 -04:00
Arvind Yadav
689559d10f
ac/llvm : Adding Number of all interpolated inputs in ac_shader_abi
...
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15117 >
2022-07-16 07:08:10 -04:00
Arvind Yadav
30865756db
nir: Add a lowering pass for point smoothing
...
When point smoothing is enabled then this lowering pass will
modifies the alpha component of every write to fragment output.
Anti-aliased points get rounded with respect to their radius instead
of square.
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15117 >
2022-07-16 07:08:09 -04:00
Arvind Yadav
cad4908fa0
nir: add load_point_coord_maybe_flipped intrinsics for point smoothing
...
gl_PointCoord can be flipped upside down via a state.
To avoid this adding new load_point_coord_maybe_flipped intrinsics.
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15117 >
2022-07-16 07:07:32 -04:00
Arvind Yadav
25204d89a6
radeonsi: Add nir_lower_poly_line_smooth pass for polygon and line smoothing
...
Added a new NIR pass for handling polygon and line smoothing and
Removed previous smoothing changes.
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16245 >
2022-07-16 10:15:22 +00:00
Arvind Yadav
2709786bde
nir: Add a lowering pass for polygon and line smoothing
...
When poly_line smoothing is enabled then this lowering pass will
modify the alpha component of every write to fragment output
using sample coverage mask.
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16245 >
2022-07-16 10:15:22 +00:00
Emma Anholt
a43b96ab1a
ci/crocus: Drop xfails for the recent image external fix.
...
Fixes: 8856379a03 ("mesa/st: don't guess the internal format if it's known")
Acked-by: David Heidelberg <david.heidelberg@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17572 >
2022-07-16 04:31:56 +00:00
Emma Anholt
c0930b552d
ci/crocus: Disable the blender trace.
...
It gives inconsistent sha1s.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17572 >
2022-07-16 04:31:56 +00:00
Emma Anholt
f96688fec2
ci/crocus: Update portal 2 trace shas for the recent fix.
...
they render correctly now.
Fixes: 4e797ac530 ("st/glsl: fix broken vertex attrib mapping")
Acked-by: David Heidelberg <david.heidelberg@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17572 >
2022-07-16 04:31:56 +00:00
Emma Anholt
c7c265892a
mesa/arbprog: Stop doing optimization in the ARB program IR.
...
You'll get all this and more anyway once you're in NIR. This lets us GC a
bunch more ARB program transformation code.
No effect in shader-db on softpipe.
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17528 >
2022-07-16 04:08:32 +00:00
Emma Anholt
c13dbf6ae9
mesa/arbprog: Use nir_lower_io_to_temporaries.
...
This replaces our mesa_remove_output_reads(), which in turn GCs some other
ARB program transformation code.
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17528 >
2022-07-16 04:08:32 +00:00
Emma Anholt
153f7b8852
mesa/arbprog: Move the GLSLFragCoordIsSysVal handling to prog_to_nir.
...
We don't need to go grubbing around in the ARB program when we can use the
right variable type at prog_to_nir time. This does leave
fp->system_values_read/inputs_read as they were, but I don't see anywhere
that that matters (the NIR will have its info gathered appropriately, and
other lowering may also cause mismatch between the gl_program and the
NIR).
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17528 >
2022-07-16 04:08:32 +00:00
Jesse Natalie
c002bbeb2f
util: Add a Win32 futex impl
...
This uses APIs that are not available on Win7. Since this is a build-time
configuration, and since we can't use the SDK version as an indicator
(since you can support Win7 via new SDKs), a new option is added to allow
disabling it, to maintain Win7 support if desired.
Reviewed-by: Jose Fonseca <jfonseca@vmware.com >
Reviewed-by: Yonggang Luo <luoyonggang@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17431 >
2022-07-15 21:31:51 +00:00
Yiwei Zhang
62f79f9ec1
venus: add more tracepoints for perf analysis
...
This change adds the tracepoints that can help understand app behavior
for debugging and performance optimization purposes.
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org >
Reviewed-by: Ryan Neph <ryanneph@google.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17497 >
2022-07-15 20:57:41 +00:00
Yiwei Zhang
f96e25ae05
venus: suballocate more for layering
...
Previously we suballocate only for host visible memory type to reduce
the kvm mem slot usage. That is no longer an issue given the limit has
been raised. However, we should still suballocate to make layering
clients performant. So we just suballocate regardless of mem type.
This change also increases the allowed suballocation size request from
64K to 128K, which makes layering clients happier.
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org >
Reviewed-by: Ryan Neph <ryanneph@google.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17497 >
2022-07-15 20:57:41 +00:00
naveen
1eea424a7e
github/ci: Set permissions for GitHub actions
...
Restrict the GitHub token permissions only to the required ones; this way, even if the attackers will succeed in compromising your workflow, they won’t be able to do much.
- Included permissions for the action. https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions
https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs
[Keeping your GitHub Actions and workflows secure Part 1: Preventing pwn requests](https://securitylab.github.com/research/github-actions-preventing-pwn-requests/ )
Signed-off-by: naveen <172697+naveensrinivasan@users.noreply.github.com >
Reviewed-by: Eric Engestrom <eric@engestrom.ch >
Reviewed-by: David Heidelberg <david@ixit.cz >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17562 >
2022-07-15 20:56:16 +00:00
Mike Blumenkrantz
3ff058ed0b
mesa: update GL_CLAMP emulation when binding/unbinding textures
...
binding/unbinding a texture affects the previously specified parameters,
so ensure the driver flag for clamp emulation is also set to perform
updates as needed
Fixes: e8f71f6ac4 ("mesa/st: add PIPE_CAP_GL_CLAMP")
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17459 >
2022-07-15 18:58:15 +00:00
Mike Blumenkrantz
068239dad0
mesa: track which sampler wrap params use GL_CLAMP
...
this adds a bitmask to sampler objects for tracking whether GL_CLAMP
is active
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17459 >
2022-07-15 18:58:15 +00:00
Mike Blumenkrantz
c17bfc5309
mesa: move is_wrap_gl_clamp() to samplerobj.h and deduplicate
...
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17459 >
2022-07-15 18:58:15 +00:00
Mike Blumenkrantz
56e5eaeba1
zink: fix xfb emit check in compiler
...
nir->info.has_transform_feedback_varyings is set for all stages in the
pipeline when xfb is present, so it can't be used for this
harmless, but this is more correct
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17404 >
2022-07-15 17:32:27 +00:00
Mike Blumenkrantz
bd2eaaeb7d
zink: add a compiler pass to split xfb block outputs
...
this splits all the members of a struct into separate variables to
improve xfb inlining and reduce the number of locations consumed by
xfb outputs, reducing the chances of running out of shader outputs
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17404 >
2022-07-15 17:32:27 +00:00
Mike Blumenkrantz
924145c7b5
zink: bitcast extracted streamout components to uint before creating uvec
...
spirv can't create a uvec from float components, so pre-cast here
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17404 >
2022-07-15 17:32:27 +00:00
Mike Blumenkrantz
c189b7f585
zink: use right glsl length getter for ntv partial stores
...
why does glsl_get_length exist if it returns 0 for the most common cases?
Fixes: 31ba19ff68 ("zink: fix ntv partial stores")
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17404 >
2022-07-15 17:32:27 +00:00
Mike Blumenkrantz
5245290565
zink: fix xfb array inlining
...
get_slot_components() returns the total number of output components
for arrays for initial evaluation phase, but during the packed->inlined
conversion the arrayed size must be normalized to the slot's component count
in order to effectively catch and inline the array
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17404 >
2022-07-15 17:32:27 +00:00
Mike Blumenkrantz
042cc6e6e6
zink: split xfb block emission from array/matrix handling
...
these are not necessarily the same case even if in glsl they are the same,
and by splitting it out a bunch of redundant array[scalar] code can be deleted
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17404 >
2022-07-15 17:32:27 +00:00
Mike Blumenkrantz
76cc519866
zink: handle bare matrix types in xfb emission
...
these have no inherent slot index since they aren't block members
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17404 >
2022-07-15 17:32:27 +00:00
Mike Blumenkrantz
a0771cd4ab
zink: always use 32bit floats for so output types
...
doubles may be the output variable type, but the xfb output will always
be 32bit
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17404 >
2022-07-15 17:32:27 +00:00
David Heidelberg
c5ebd44850
ci: Allow disabling the whole of the Igalia farm
...
Add a global-level variable that allows disabling all jobs that would
have gone to the Igalia lab, to be used in case of outages or failures.
Reviewed-by: Eric Engestrom <eric@igalia.com >
Reviewed-by: Andres Gomez <agomez@igalia.com >
Reviewed-by: Daniel Stone <daniels@collabora.com >
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17178 >
2022-07-15 16:56:03 +00:00
Jesse Natalie
f4a5e95ad2
CI: Update DirectX-Headers dependency for MinGW/Debian
...
Reviewed-by: Bill Kristiansen <billkris@microsoft.com >
Reviewed-by: Sil Vilerino <sivileri@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17548 >
2022-07-15 16:27:11 +00:00
Jesse Natalie
1e59bc7a74
subprojects: Point DirectX-Headers at a specific tag
...
Reviewed-by: Bill Kristiansen <billkris@microsoft.com >
Reviewed-by: Sil Vilerino <sivileri@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17548 >
2022-07-15 16:27:11 +00:00
Jesse Natalie
f4f1914cd2
microsoft/clc: Add helpers to build with correct ABI for MinGW
...
Reviewed-by: Bill Kristiansen <billkris@microsoft.com >
Reviewed-by: Sil Vilerino <sivileri@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17548 >
2022-07-15 16:27:11 +00:00
Jesse Natalie
e14beaf05b
d3d12: Add helpers to build with correct ABI for MinGW
...
Reviewed-by: Bill Kristiansen <billkris@microsoft.com >
Reviewed-by: Sil Vilerino <sivileri@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17548 >
2022-07-15 16:27:11 +00:00
Jesse Natalie
489ab1aa3b
dzn: Remove the cast when the SDK version is high enough
...
Reviewed-by: Bill Kristiansen <billkris@microsoft.com >
Reviewed-by: Sil Vilerino <sivileri@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17548 >
2022-07-15 16:27:11 +00:00
Jesse Natalie
b9fb14da06
dzn: Missed ABI fixes for GetCustomHeapProperties
...
Reviewed-by: Bill Kristiansen <billkris@microsoft.com >
Reviewed-by: Sil Vilerino <sivileri@microsoft.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17548 >
2022-07-15 16:27:11 +00:00
Eric Engestrom
8317de8ed3
docs/isl: fix typos & formatting
...
Signed-off-by: Eric Engestrom <eric@igalia.com >
Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17522 >
2022-07-15 15:17:45 +00:00
Tatsuyuki Ishi
648731e2bd
radv: Only set pstate for the first hw_ctx.
...
We used to do it for every queue, which was duplicate work as pstate is
per-device. It could also cause trouble when multiple hw_ctx are created as
the call will succeed for only one of them and the rest will return -EBUSY.
Simplify and fix this by only setting for the first non-null hw_ctx.
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17541 >
2022-07-15 15:08:07 +00:00
Bas Nieuwenhuizen
2d2591bbb7
radv: Expose VK_NV_device_generated_commands.
...
Closes : #6736
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17269 >
2022-07-15 14:45:13 +00:00
Bas Nieuwenhuizen
05bf39238b
radv: Add stub for vkCmdBindPipelineShaderGroupNV.
...
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17269 >
2022-07-15 14:45:13 +00:00