AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
158,089 Commits 1 Branch 0 Tags
2e9044766ebc5dcbfcb6a1060deb5a2993c48a60
Commit Graph

158089 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
David Heidelberg 2e9044766e ci: do not install i386 sub-architecture in VK images 
Not required by apitrace.

debian/x86_test-vk image size:
previous: 1.8G
after:    1.0G

v2: added back winehq-stable (missing symlinks)

Acked-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17834>
 2022-08-15 12:18:41 +00:00
David Heidelberg cdd508dddd ci: use apt-get in x86_test-vk instead of apt 
apt shouldn't be used in CI, see:
https://unix.stackexchange.com/questions/590699/should-i-use-apt-or-apt-get-in-shell-scripting

Acked-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17834>
 2022-08-15 12:18:41 +00:00
Tomeu Vizoso ba518a31ac ci: Report failures to GitLab for LAVA jobs 
We were uploading the junit.xml to the artifacts, but weren't telling
GitLab about it.

Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18028>
 2022-08-15 11:40:19 +02:00
Tomeu Vizoso 477412f303 iris/ci: Set FDO_CI_CONCURRENT for all Chromebook jobs 
For some reason we were missing these and that was causing some CPUs to
remain idle, and some boards to have too high load and some tests timing
out occasionally.

Set FDO_CI_CONCURRENT for the number of cores, plus one to account for
GPU and I/O waits.

Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18028>
 2022-08-15 11:40:16 +02:00
Tomeu Vizoso 1bdcf5c099 iris/ci: Test on Jasper Lake Chromebooks 
8 such boards have been added to Collabora's lab, let's run all tests
from the selected set.

Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18028>
 2022-08-15 11:40:12 +02:00
Qiang Yu 84956286a8 nir/lower_gs_intrinsics: fix primitive count for points 
When primitive is points, EndPrimitive can't be used to count
primitive. Need to use vertex count instead. And it's also not
needed to do vertex per primitive count and overwrite incomplete
primitive work for points.

Fixes: 2be99012e9 ("nir: Add ability to count emitted GS primitives.")
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17805>
 2022-08-15 01:39:28 +00:00
Mike Blumenkrantz b88c3d5bd3 zink: fix program cache comparisons 
I missed this when pipe shader types were merged with mesa types

Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18051>
 2022-08-14 20:11:48 -04:00
Mike Blumenkrantz 6ac64fcb6b zink: delete zink_shader_stage() 
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18051>
 2022-08-14 18:38:05 -04:00
Mike Blumenkrantz b988b8c84b zink: remove all pipe_shader_type usage 
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18051>
 2022-08-14 18:38:05 -04:00
Mike Blumenkrantz 2792d2bd4a zink: PIPE_SHADER_TYPES -> MESA_SHADER_STAGES 
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18051>
 2022-08-14 18:38:05 -04:00
Mike Blumenkrantz fc657f8c07 zink: explicitly define ZINK_GFX_SHADER_COUNT 
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18051>
 2022-08-14 18:38:04 -04:00
Mike Blumenkrantz 7040745060 zink: ZINK_SHADER_COUNT -> ZINK_GFX_SHADER_COUNT 
more descriptive

Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18051>
 2022-08-14 18:38:04 -04:00
Mike Blumenkrantz 89daf988bc zink: use statically sized array for descriptor allocation 
this will never be more than 100

Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18051>
 2022-08-14 18:38:04 -04:00
Mike Blumenkrantz 2ca46b66c3 zink: rename _lazy descriptor stuff 
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18051>
 2022-08-14 18:38:04 -04:00
Mike Blumenkrantz 48cb86d487 zink: reorder some descriptor structs 
should yield slightly better packing

Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18051>
 2022-08-14 18:38:04 -04:00
Mike Blumenkrantz e373f97804 zink: merge batch descriptor data onto batch state 
also clean up some related descriptor code

Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18051>
 2022-08-14 18:38:04 -04:00
Mike Blumenkrantz 2c281b7ccd zink: merge program descriptor data onto program struct 
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18051>
 2022-08-14 18:38:04 -04:00
Mike Blumenkrantz f24c7bdef8 zink: merge context descriptor data onto context struct 
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18051>
 2022-08-14 18:38:04 -04:00
Mike Blumenkrantz 5512b15863 zink: merge batch descriptor data structs 
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18051>
 2022-08-14 18:38:04 -04:00
Mike Blumenkrantz 9938067287 zink: merge context descriptor data structs 
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18051>
 2022-08-14 18:38:04 -04:00
Mike Blumenkrantz b25d8850f0 zink: remove descriptor dummy_set 
while well-intentioned, this didn't actually do anything

Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18051>
 2022-08-14 18:38:04 -04:00
Mike Blumenkrantz 8c8fb47f6b zink: delete some unused descriptor struct members 
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18051>
 2022-08-14 18:38:04 -04:00
Mike Blumenkrantz ca1d643eab zink: move lazy descriptor data types into zink_types.h 
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18051>
 2022-08-14 18:38:04 -04:00
Mike Blumenkrantz 30c51abd0b zink: move all types/enums into zink_types.h 
this significantly untangles all the header includes and fixes an issue
where zink_descriptors.h couldn't be included by certain files due to
type conflicts

Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18051>
 2022-08-14 18:38:04 -04:00
Mike Blumenkrantz bcbd3b297d zink: delete unused struct types 
so old

Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18051>
 2022-08-14 18:38:04 -04:00
Mike Blumenkrantz 8b6ab4dec4 zink: move lazy descriptor functions into zink_descriptors.c 
the merginating continues

Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18051>
 2022-08-14 18:38:04 -04:00
Mike Blumenkrantz 8b0447eec7 zink: delete a lot of descriptor code 
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18051>
 2022-08-14 18:38:04 -04:00
Mike Blumenkrantz 58e6480ee0 zink: remove descriptor vtable 
no longer used

Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18051>
 2022-08-14 18:38:04 -04:00
Mike Blumenkrantz dc3c1206be zink: remove checks for lazy descriptor mode + templates ext 
these are always true

Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18051>
 2022-08-14 18:38:04 -04:00
Mike Blumenkrantz 24acb19268 zink: remove cached descriptor mode 
this just removes the enum(s) for it, making it functionally inaccessible

Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18051>
 2022-08-14 18:38:03 -04:00
Alyssa Rosenzweig 5fd8ae1541 asahi: Identify depth clip mode bit 
Setting this bit (at the batch level, not the draw level!) switches to
[-1, 1] clipping instead of Metal's preferred [0, 1] clipping. Using
this bit allows us to drop the clip_halfz lowering we had before, saving
2 instructions in every vertex shader.

Fixes dEQP-GLES2.functional.depth_range.*

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17948>
 2022-08-14 19:59:19 +00:00
Alyssa Rosenzweig a6f88863f6 asahi: Don't advertise ARB_clip_control yet 
Our depth handling is pretty busted as it is. Adding clip control into
the mix will only make things more complicated. Best not worry about
that yet. Implementing this ext "properly" has some wrinkles: explain
them.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17948>
 2022-08-14 19:59:19 +00:00
Timur Kristóf 5ead973824 aco: Add faster code path to store_lds for consecutive write mask. 
This makes it more likely to hit the fast path for count == 1
in the split_store_data function.

Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17923>
 2022-08-14 15:09:07 +00:00
Eric Engestrom 4588453815 vk/device-select-layer: fix .sType of VkPhysicalDeviceGroupProperties 
The validation layers complained:
> Validation Error: [ VUID-VkPhysicalDeviceGroupProperties-sType-sType ] Object 0: VK_NULL_HANDLE, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0xc9edee8b | vkEnumeratePhysicalDeviceGroups: parameter pPhysicalDeviceGroupProperties[0].sType must be VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_GROUP_PROPERTIES The Vulkan spec states: sType must be VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_GROUP_PROPERTIES (https://www.khronos.org/registry/vulkan/specs/1.3-extensions/html/vkspec.html#VUID-VkPhysicalDeviceGroupProperties-sType-sType)

Signed-off-by: Eric Engestrom <eric@igalia.com>
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Fixes: c196ffaca6 ("vk-device-select: add device group support")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18037>
 2022-08-14 14:18:11 +00:00
Lucas Stach d08bd9a8d8 etnaviv: don't expose array and 3D texture support on pre-halti GPUs 
3D and array texture support is a halti0 GPU feature and
gpu_supports_texture_target() already prevents such textures from being
constructed on older GPUs. Set the screen caps correctly to avoid
exposing EXT_texture_array and OES_texture_3D on those GPUs.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17996>
 2022-08-13 13:13:34 +00:00
Lucas Stach 2b0f77bde5 etnaviv: allow 3D textures with TS in transfer 
The resolve operation to the temporary resource properly iterates
over all layers of the 3D texture, so there is no need to fail the
transfer if we encounter a 3D texture that has a TS BO allocated
due to previous rendering.

Fixes piglit spec@arb_framebuffer_object@fbo-generatemipmap-3d

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17996>
 2022-08-13 13:13:34 +00:00
Lucas Stach 9496b7a2fa etnaviv: fix TS buffer allocation for 3D textures 
For 3D textures the number of layers is the resource depth. As the TS buffer
allocation only looked at the array size it does not allocate enough TS
storage for 3D textures.

Fixes piglit spec@!opengl 1.2@copyteximage 3d

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17996>
 2022-08-13 13:13:34 +00:00
Lucas Stach 2d93327cc4 etnaviv: properly check number of layers in surface creation 
3D textures store their number of layers in the resource depth. As the
assert only checks the array_size, it fails on perfectly valid surface
creation requests. Use the proper helper to get the number of layers.

Fixes piglit spec@arb_framebuffer_object@fbo-incomplete

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17996>
 2022-08-13 13:13:34 +00:00
Pavel Ondračka 88fd397c74 r300: fix variables detection for paired ALU and TEX instructions in different branches 
TEX instrutions can't write xyz and w to separate registers so we
need to create variables from them first, otherwise we can create
two variables from ALU writing the same register xyz and w in other
branch (this usually works when TEX is not present as the xyz and
w can read/write from different registers).

This fixes regalloc because the variables are later used as a
graph nodes.

The variable order should not matter but it slightly does (leading
to approx 0.3% shader-db temps increase as compared to previous
state), so just sort the variables list afterwards to be as close
to the previous behavior as possible and prevent the regression.

CC: mesa-stable
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6936
Signed-off-by: Pavel Ondračka <pavel.ondracka@gmail.com>
Reviewed-by: Filip Gawin <filip@gawin.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17987>
 2022-08-13 00:08:31 +00:00
Axel Davy b5df20568a frontend/nine: Fix ff position_t fallback when w = 0 
For post-transformed vertices, w = 0 is similar to
w = 1. Replace the value to fix rcp(w).

It is common for apps to pass w = 0 for
position_t.

cc: mesa-stable

Signed-off-by: Axel Davy <davyaxel0@gmail.com>
Acked-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18021>
 2022-08-12 21:53:11 +02:00
Axel Davy 93da6e9f34 frontend/nine: Fix shader multi-use crash 
Due to the driver live shader cache, it's possible
two different d3d9 shaders get the same cso.

As it's disallowed to destroy a shader cso being
bound, nine checks for this scenario. However it
was not taking into account the cso might be from
a different shader.

cc: mesa-stable

Signed-off-by: Axel Davy <davyaxel0@gmail.com>
Acked-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18021>
 2022-08-12 21:53:11 +02:00
Axel Davy 4c65ccab6d frontend/nine: Fix cso restore bug 
Invalidating all state groups is not sufficient, as
some states check for actual changes.
The correct way is to invalidate the
commit mask.

Found with a wine test.

cc: mesa-stable

Signed-off-by: Axel Davy <davyaxel0@gmail.com>
Acked-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18021>
 2022-08-12 21:53:11 +02:00
Axel Davy 4f953ad512 frontend/nine: Fix ATOC handling 
The previous code was incorrectly checking the previous
value of alphatestenable.
In addition, remove an optimization that cannot hit (as we
filter out redundant state settings).

cc: mesa-stable

Fixes: 1272640d5 ("st/nine: Fix alpha to coverage states")
Signed-off-by: Axel Davy <davyaxel0@gmail.com>
Acked-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18021>
 2022-08-12 21:53:11 +02:00
Axel Davy e5124e83ba frontend/nine: Fix buffer tracking out of bounds 
Fixes a crash in a ffxi trace, which draws out of bounds.
This was previously resulting in trying to fill a buffer
resource not big enough.

cc: mesa-stable
Fixes: 380c2bf ("st/nine: Optimize dynamic systemmem buffers")

Signed-off-by: Axel Davy <davyaxel0@gmail.com>
Acked-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18021>
 2022-08-12 21:53:11 +02:00
Axel Davy b74febffe6 frontend/nine: Skip invalid swvp calls 
Without this it may crash running wine tests.
According to the test themselves, the correct
behaviour is a bit more complicated, but
that's a first step.

cc: mesa-stable

Signed-off-by: Axel Davy <davyaxel0@gmail.com>
Acked-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18021>
 2022-08-12 21:53:11 +02:00
Yonggang Luo 0d0d245e7e ci: Enable llvmpipe on MacOS 
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17879>
 2022-08-12 19:04:35 +00:00
Yonggang Luo e04d4f881e ci: Improve MacOS github ci 
GALLIUM_DUMP_CPU=true to see dump result
Save the testing log artifacts

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17879>
 2022-08-12 19:04:35 +00:00
Yonggang Luo 1f05b23b4f util: Disable usage of __attribute__((__const__)) when the compiler is clang 
Clang didn't implement __attribute__((__const__)) properly for release build.
The issue tracker is: https://github.com/llvm/llvm-project/issues/56993

Closes #6781
Closes #6782

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18039>
 2022-08-12 18:33:24 +00:00
Yonggang Luo 075b72ea06 util: Fixes invalid assumption that return non null by function util_format_fetch_rgba_func 
Fixes: e342081c ("util/format: Assert that formats are valid")
Closes #7020

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Konstantin Seurer <konstantin.seurer@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18024>
 2022-08-12 18:06:36 +00:00
Yonggang Luo a1b7682d10 util: Fixes memory leak in u_printf_test.cpp 
That's Fixes: bdc0a862 ("printf: add some unit tests")

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18024>
 2022-08-12 18:06:36 +00:00