Iago Toral Quiroga
2897a83ff8
broadcom/compiler: drop the destination for unused ldunifa
...
We can't remove unused ldunifa that are not the first or last
in a sequence, but we can still ignore their destination
to reduce register pressure.
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9384 >
2021-03-04 09:00:15 +01:00
Timothy Arceri
9d1ef1595c
util/disk_cache: make MESA_DISK_CACHE_READ_ONLY_FOZ_DBS a relative path
...
Rather than passing in full paths this changes things so that we can
just pass in filenames relative to the current cache directory.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9279 >
2021-03-04 04:07:46 +00:00
Eric Anholt
a8423eb732
ci/turnip: Mark a flaky WSI test.
...
This one has flaked many times at this point, and I've even seen it flake
locally. No luck debugging it yet.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9397 >
2021-03-03 23:03:48 +00:00
Rob Clark
f8714b2852
freedreno: Remove dead-cells MBR workaround
...
With threaded-context we won't have a chance to apply the workaround in
the backend driver. But the previous commit moves it to a driconf
configured workaround in mesa/st, so we can drop this now.
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9316 >
2021-03-03 22:47:59 +00:00
Rob Clark
e6f2e8b3fc
driconf: Add ignore_map_unsynchronized option
...
Add an option to workaround incorrect unsynchronized VBO updates in
Dead-Cells.
See: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4337
Signed-off-by: Rob Clark <robdclark@chromium.org >
Reviewed-by: Eric Anholt <eric@anholt.net >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9316 >
2021-03-03 22:47:59 +00:00
Mike Blumenkrantz
3c20b698e2
zink: rewrite macro for getting KHR device functions
...
we have the technology. we can improve our our lives with better macros.
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9398 >
2021-03-03 17:27:22 -05:00
Rob Clark
910a2464cf
freedreno/a6xx: Fix compile warning
...
Fixes: 79921b81bc ("freedreno/a6xx: Document threadsize-related fields")
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9394 >
2021-03-03 22:09:22 +00:00
Rob Clark
8642456472
freedreno: Deduplicate fixup_shader_state()
...
All the ir3 gens had the same thing, time to move it out into a shared
helper.
The keeping the storage in fdN_context is to avoid namespace clashes
between ir3 and ir2.
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9394 >
2021-03-03 22:09:22 +00:00
Rob Clark
1611693977
freedreno/ir3: Add comments about shader key/gen
...
I had forgotton on which gens these where used on (which is important if
you need to know which shader stages use these).. expand the comments a
bit.
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9394 >
2021-03-03 22:09:22 +00:00
Dave Airlie
bc02fc4823
clover: fix array images view creation
...
Found this on top of Karol's patches but it seems like it can just be
applied to master.
Helps with some cases of
kernel_image_methods/test_kernel_image_methods 2Darray
Reviewed-by: Karol Herbst <kherbst@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9381 >
2021-03-03 21:59:22 +00:00
Eric Anholt
18be15ad16
ci/zink: Add another primitive restart flake.
...
This one flaked all the way to a run failure in a recent MR of mine.
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9396 >
2021-03-03 21:49:41 +00:00
Eric Anholt
283a05ddc9
ci/a5xx: Update piglit expectations.
...
The mesa/st shader variants change fixed some fails for us.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9314 >
2021-03-03 21:05:39 +00:00
Eric Anholt
957132294f
ci/a5xx: Increase the gles3/31 coverage.
...
Now that there's more time available in our budget per board, we can run
all of gles31, and half of gles3, instead of 10%.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9314 >
2021-03-03 21:05:39 +00:00
Eric Anholt
1087bf16af
ci/a3xx: Run all of GLES3 dEQP.
...
We're not spending half our time booting any more, so run the other half.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9314 >
2021-03-03 21:05:39 +00:00
Eric Anholt
bb82efa792
ci/a5xx: Run all of gles2 in one job.
...
Now that we're not spending so much time on boot overhead, no need to
parallelize.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9314 >
2021-03-03 21:05:39 +00:00
Eric Anholt
bcdfee3bcd
ci/freedreno: Switch the fastboot boards to using nfsroot.
...
This saves time in packing the rootfs, allows for larger rootfses, and
avoids the need for webdav.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9314 >
2021-03-03 21:05:39 +00:00
Eric Anholt
5c89f6ed17
ci/freedreno: Also retest when only CI configuration changes.
...
Fixes: dab845d457 ("ci: Move specific driver testing to separate files in separate dirs.")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9314 >
2021-03-03 21:05:39 +00:00
Eric Anholt
e2aff7425d
tgsi_exec: Jump over entirely non-taken THEN or ELSE branches.
...
TGSI has these nice labels for us for where to jump in this case, let's
use them. Improves piglit arb_shader_image_load_store-shader-mem-barrier
runtime massively, though not enough to make the test really reasonable to
run.
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9347 >
2021-03-03 20:47:08 +00:00
Eric Anholt
3429c83f87
tgsi_exec: Roll the loops for condmask handling.
...
No need to hand-unroll this, the compiler will do it.
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9347 >
2021-03-03 20:47:08 +00:00
Ilia Mirkin
ac6aad3d59
i965: support GL_EXT_color_buffer_half_float
...
FP16 rendering is supported on all gen4 hardware.
Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu >
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com >
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9379 >
2021-03-03 20:37:03 +00:00
Antonio Caggiano
810c39b067
ci: Use lock file to build deqp-runner
...
Build deqp-runner with the `--locked` option to use dependencies
versions specified in `Cargo.lock`.
v2: Bump image tags.
Signed-off-by: Antonio Caggiano <antonio.caggiano@collabora.com >
Suggested-by: Tomeu Vizoso <tomeu.vizoso@collabora.com >
Reviewed-by: Eric Anholt <eric@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9368 >
2021-03-03 20:21:16 +00:00
Marek Olšák
a0cc0b3a15
ac/llvm: open code fpow on LLVM 12 using fmul.legacy
...
A quick look at the asm shows that this enables source modifiers
(neg, abs) for v_mul_legacy_f32.
Totals from affected shaders:
SGPRS: 110104 -> 110400 (0.27 %)
VGPRS: 57632 -> 57636 (0.01 %)
Spilled SGPRs: 66 -> 63 (-4.55 %)
Spilled VGPRs: 0 -> 0 (0.00 %)
Private memory VGPRs: 0 -> 0 (0.00 %)
Scratch size: 0 -> 0 (0.00 %) dwords per thread
Code Size: 3290412 -> 3283068 (-0.22 %) bytes
Max Waves: 32141 -> 32141 (0.00 %)
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9395 >
2021-03-03 20:06:09 +00:00
Marek Olšák
18c1c1404d
ac/llvm: add type parameter into ac_build_buffer_load to fix 16-bit TES inputs
...
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9395 >
2021-03-03 20:06:09 +00:00
Marek Olšák
ed351b9a71
ac/llvm: fix visit_load_ubo_buffer to use SMEM for 16 bits instead of VMEM
...
This has 3 advantages:
- It's SMEM.
- Multiple single component loads are merged into 1 multi-dword load by LLVM.
- The result is always packed for packed instructions.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9395 >
2021-03-03 20:06:09 +00:00
Marek Olšák
46ce67a331
ac/llvm: implement 16-bit and 64-bit fpow correctly
...
LLVM converts to 32 bits and back for llvm.pow, so we can't use it.
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9395 >
2021-03-03 20:06:09 +00:00
Marek Olšák
3475c79328
ac/llvm: add support for 16-bit source operands for samplers
...
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9395 >
2021-03-03 20:06:09 +00:00
Ian Romanick
c393ae9d84
nir/search: Constify instruction parameter to search helpers
...
The search helps must *never* modify the instruction passed in, so let
the compiler enforce this.
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Reviewed-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9378 >
2021-03-03 18:32:14 +00:00
Lionel Landwerlin
0f437e49c6
anv: fix missing general state pool in validation list
...
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Fixes: 83fee30e85 ("anv: allow multiple command buffers in anv_queue_submit")
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9388 >
2021-03-03 18:24:16 +00:00
Eric Anholt
f3f4a24549
ci/lava: Move the driver expectation files to the per-driver CI dir.
...
This will cause less retesting of other drivers when changing the dEQP
results for a driver.
Reviewed-by: Michel Dänzer <mdaenzer@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9353 >
2021-03-03 18:08:11 +00:00
Eric Anholt
9f03ee7773
ci/lava: Move the per-driver gitlab-ci.yml to each driver.
...
Follow-up to !9139 , will cause less testing of other drivers when changing
the CI configuration for a single driver.
Reviewed-by: Michel Dänzer <mdaenzer@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9353 >
2021-03-03 18:08:11 +00:00
Eric Anholt
27e0181523
ci: Move deqp-default-skips.txt back to .gitlab-ci/
...
Since we don't manually enumerate the drivers using it, we have to retest
all drivers when changing it (which basically never happens, anyway).
Reviewed-by: Michel Dänzer <mdaenzer@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9353 >
2021-03-03 18:08:11 +00:00
Samuel Pitoiset
578fc7dbbc
radv: fix RGP barrier layout transition for TC-compatible CMASK images
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9390 >
2021-03-03 16:49:29 +00:00
Adam Jackson
69f3d3a29f
zink: Enable GL_EXT_depth_bounds_test
...
Available since Vulkan 1.0, and in fact already wired up, just not
advertised. It looks like we could make this dynamic state but this
works for now.
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9371 >
2021-03-03 16:17:11 +00:00
Rhys Perry
21697082ec
radv: don't shrink image stores for The Surge 2
...
The game seems to declare the wrong format.
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Fixes: e4d75c22 ("nir/opt_shrink_vectors: shrink image stores using the format")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4347
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9229 >
2021-03-03 14:18:37 +00:00
Rhys Perry
cbb5ed476c
nir/opt_shrink_vectors: add option to skip shrinking image stores
...
Some games declare the wrong format, so we might want to disable this
optimization in that case.
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Fixes: e4d75c22 ("nir/opt_shrink_vectors: shrink image stores using the format")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9229 >
2021-03-03 14:18:37 +00:00
Danylo Piliaiev
4600dbc6cc
turnip: fix leak of tu_shader object during compute pipeline creation
...
tu_shader should be freed after pipeline is successfully created.
Fixes tests:
dEQP-VK.api.object_management.alloc_callback_fail.compute_pipeline
dEQP-VK.api.object_management.alloc_callback_fail_multiple.compute_pipeline
Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9364 >
2021-03-03 10:41:29 +00:00
Samuel Pitoiset
b33792b794
radv: bump the initial SQTT buffer size to 32MB per SE
...
Most of the games need 32MB or more, but rarely less.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9367 >
2021-03-03 08:40:32 +01:00
Samuel Pitoiset
6813b52290
radv: trigger a new SQTT capture automatically after resizing the buffer
...
It's way better.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9367 >
2021-03-03 08:40:32 +01:00
Samuel Pitoiset
0a1e3cc1cb
radv: double the SQTT buffer size when it is resized
...
Computing the expected buffer size isn't reliable on GFX10+ because
DROPPED_CNTR returns weird results.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9367 >
2021-03-03 08:40:32 +01:00
Samuel Pitoiset
c0608bb083
ac/sqtt: fix determining if the trace is complete on GFX10+
...
DROPPED_CNTR isn't reliable and might still report non-zero if the
SQTT buffer isn't full. Checking if the number of written bytes by
the hw is equal to the SQTT buffer size seems reliable.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9367 >
2021-03-03 08:40:32 +01:00
Samuel Pitoiset
f4c4c0f207
radv: do not trace inactive shader engines with SQTT
...
This fixes a GPU hang on my Sienna because the number of SE is
less than the maximum, and SE #1 is disabled.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9370 >
2021-03-03 08:16:42 +01:00
Mike Blumenkrantz
bc5dcf1527
zink: ci updates
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9291 >
2021-03-03 01:37:02 +00:00
Mike Blumenkrantz
587d15ca6c
zink: use staging resource for write transfer_map in order to not stall
...
we can just give the user a staging resource and then flush the data back
later
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9291 >
2021-03-03 01:37:02 +00:00
Marek Olšák
db67d9c0d1
radeonsi: don't crash on NULL images in si_check_needs_implicit_sync
...
This fixes CTS test: KHR-GL46.arrays_of_arrays_gl.AtomicUsage
Fixes: bddc0e023c "radeonsi: fix read from compute / write from draw sync"
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Reviewed-by: Zoltán Böszörményi <zboszor@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9361 >
2021-03-03 01:19:24 +00:00
Marek Olšák
f9e6c7a220
ac/llvm: fix ac_build_atomic_rmw with LLVM 13
...
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4383
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Reviewed-by: Zoltán Böszörményi <zboszor@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9361 >
2021-03-03 01:19:24 +00:00
Eric Anholt
8bd0cc1a5a
nir/vec_to_movs: Don't generate MOVs for undef channels.
...
This appeared in softpipe's image operations, since NIR always uses
4-component values for the coords, while the GLSL IR only has 2 components
for a 2D image (for example).
arb_shader_image_load_store-shader-mem-barrier (which times out in CI and
spends its time inside of tgsi_exec) was spending 4/51 of its instructions
on moving these undefs around.
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9345 >
2021-03-03 00:51:44 +00:00
Eric Anholt
1e5ef4c60c
nir: Add a nir_src_is_undef() helper, like nir_src_is_const().
...
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9345 >
2021-03-03 00:51:44 +00:00
Mike Blumenkrantz
c77df59c9e
zink: export PIPE_CAP_TGSI_VS_LAYER_VIEWPORT
...
Acked-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9283 >
2021-03-02 17:42:00 -05:00
Mike Blumenkrantz
ffd046cf32
zink: enable PIPE_CAP_CLEAR_SCISSORED
...
Acked-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9283 >
2021-03-02 17:42:00 -05:00
Dave Airlie
abc724e440
lavapipe: sort bindings before creating descriptor set
...
This ensures the dynamic offsets are correct
Fixes: b38879f8c5 ("vallium: initial import of the vulkan frontend")
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9359 >
2021-03-03 08:06:02 +10:00