Matt Turner
205d6e582c
tu: Provide a toggle to avoid warnings about unsupported devices
...
In the CI, we have such devices, and this message is printed many
hundreds of times. This results in a useless spam which makes it
difficult to see real issues.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11543 >
2021-06-23 07:07:42 +00:00
Dave Airlie
17a1cc6163
meson/crocus: add prefer-crocus option.
...
This just allows picking crocus without having to set the env var.
Acked-by: Alyssa Rosenzweig <alyssa@collabora.com >
Acked-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11353 >
2021-06-23 06:42:24 +00:00
Marek Olšák
ec7e262349
mesa: unreference zombie buffers when creating buffers to lower memory usage
...
This fixes an issue where one context only creates buffers while another
context only destroys buffers. Only the creating context can release its
buffers and the destroying context only turns them into zombie buffers.
This fix makes the creating context release its zombie buffers.
It's not a plot from an apocalyptic movie.
Fixes: e014e3b6be "mesa: don't count buffer references for the context that created them"
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4840
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11514 >
2021-06-23 06:06:04 +00:00
Dave Airlie
29d272f144
crocus: fix batch state bo leak
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11547 >
2021-06-23 05:31:59 +00:00
Dave Airlie
9027aae546
crocus: fix vertex buffer leak on screen end.
...
this was stopping the screen from being cleaned up as well
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11547 >
2021-06-23 05:31:59 +00:00
Dave Airlie
6036121a55
crocus: free context state properly.
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11547 >
2021-06-23 05:31:59 +00:00
Mike Blumenkrantz
c9bc5e3a86
zink: ci updates
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10973 >
2021-06-23 03:13:42 +00:00
Mike Blumenkrantz
a784713080
zink: remove primconvert
...
this is no longer used
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10973 >
2021-06-23 03:13:42 +00:00
Mike Blumenkrantz
c032c9e32d
zink: export supported primitive restart types
...
this is now handled by gallium, so the codepath can be dropped
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10973 >
2021-06-23 03:13:42 +00:00
Mike Blumenkrantz
2953d70994
zink: export supported prim types
...
this is now handled by gallium, so the related codepaths can be dropped
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10973 >
2021-06-23 03:13:42 +00:00
Mike Blumenkrantz
8ac4be916e
zink: export 8bit index buffer support based on extension presence
...
this is now handled by gallium, so the codepath can be dropped
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10973 >
2021-06-23 03:13:42 +00:00
Mike Blumenkrantz
09c28a35a5
zink: export PIPE_CAP_EMULATE_NONFIXED_PRIMITIVE_RESTART
...
gallium will now handle unsupported restart index rewriting, so
this codepath can be removed
Reviewed-by: Dave Airlie <airlied@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10973 >
2021-06-23 03:13:41 +00:00
Mike Blumenkrantz
3fc651110c
gallium: add a pipe cap for determining driver support for prim type in restarts
...
this is another prim type bitmask which will trigger automatic draw rewriting
to a direct draw any time a prim-restart draw occurs with a prim type that is
not supported by the driver for prim restart, even if that prim type is supported
for normal drawing
the default is set to all prim types to preserve existing functionality, and PrimitiveRestartForPatches
is now explicitly set to false because no driver supports it
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Reviewed-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10973 >
2021-06-23 03:13:41 +00:00
Mike Blumenkrantz
f8ff6eb78b
gallium: add a pipe cap for performing automatic prim type conversion
...
drivers can now export a bitmask of the primitive types they support,
and all others will be automatically be rewritten
the default value is set to all primitive types supported to preserve
existing behavior
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Reviewed-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10973 >
2021-06-23 03:13:41 +00:00
Mike Blumenkrantz
c8e674d4e3
gallium: handle automatic 8bit -> 16bit index buffer rewrites
...
this is based on PIPE_FORMAT_R8_UINT format support
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Reviewed-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10973 >
2021-06-23 03:13:41 +00:00
Mike Blumenkrantz
c9a65e5f77
gallium: add a pipe cap to rewrite index buffers for draws using a non-fixed restart index
...
for drivers that set it, this now automatically handles restart index rewriting
by running draws through primconvert when necessary
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Reviewed-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10973 >
2021-06-23 03:13:41 +00:00
Mike Blumenkrantz
99a60ed378
util/primconvert: handle multidraws in primconvert
...
once a draw reaches primconvert, it should never be able to reach the driver
until all draw operations have been converted as necessary
Reviewed-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10973 >
2021-06-23 03:13:41 +00:00
Mike Blumenkrantz
583070748c
util/primconvert: handle rewriting of prim-restart draws with unsupported primtype
...
this is a bit more work, as the primitive restart needs to be rewritten into a multidraw,
then the multidraw converted to the new primitive type and serialized back into a
single draw
detection is handled using a new primconvert config member, which is set to the full
primtype mask by default for compatibility with existing drivers
Reviewed-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10973 >
2021-06-23 03:13:41 +00:00
Mike Blumenkrantz
f3fe70f10e
util/primconvert: map index buffer before getting index translator function
...
also set other local values on init using new util functions
no functional changes
Reviewed-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10973 >
2021-06-23 03:13:41 +00:00
Mike Blumenkrantz
26e718fb37
util/primconvert: handle indirect draws
...
this avoids ping-ponging to the driver, which would have to call back
to here anyway with the unwrapped indirect draw
Reviewed-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10973 >
2021-06-23 03:13:41 +00:00
Mike Blumenkrantz
4673febf91
util/prim_restart: break out draw rewriting into separate function
...
this enables doing the draw rewrites without calling draw_vbo
Reviewed-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10973 >
2021-06-23 03:13:41 +00:00
Mike Blumenkrantz
3eb9932317
aux/draw: add a util function for reading back indirect draw params
...
the return type of this is a bit clunky because instance values can change,
but it's simpler to just return the full draw info struct than to force the
caller to keep pulling from arrays or whatever
Reviewed-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10973 >
2021-06-23 03:13:41 +00:00
Mike Blumenkrantz
854d93f73d
ci: disable panfrost t760 jobs
...
these are timing out
Acked-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11548 >
2021-06-22 22:58:02 -04:00
Dave Airlie
fd09727a7d
crocus: Explicitly cast value to uint64_t
...
Ports 565a80450d from iris.
Acked-by: Jason Ekstrand <jason@jlekstrand.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11546 >
2021-06-23 02:22:40 +00:00
Simon Ser
17f0d7ef83
amd/addrlib: remove Meson debug message()
...
This message pops up in the Meson build logs, but has no context
and doesn't seem to be directed at end-users. Sounds like a leftover
from a debugging session.
Signed-off-by: Simon Ser <contact@emersion.fr >
Fixes: d0767fc045 ("amd/addrlib: use cpp.has_argument() to filter compiler arguments")
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11524 >
2021-06-22 23:47:19 +00:00
Thong Thai
d977e7fbe1
radeon/vcn/enc: Add missing line to HEVC SPS header code
...
Add previously missing line in HEVC SPS header generation on VCN 1.0
devices, for when an image does not need to be cropped.
Fixes: e62c7e7c6c ("radeon: Add cropping to encoded H.265 when padding is used")
Signed-off-by: Thong Thai <thong.thai@amd.com >
Reviewed-by: Leo Liu <leo.liu@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11535 >
2021-06-22 23:36:29 +00:00
Marek Olšák
d3fddf63ec
ac/llvm: don't set skip-uniform-regions to fix atomic.cmpswap
...
This fixes SSBO atomic cmpswap tests and transform feedback order piglit tests.
Fixes: 3bb65c0670 - ac: force enable -structurizecfg-skip-uniform-regions for LLVM 11
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3884
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Acked-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11517 >
2021-06-22 22:13:07 +00:00
Paul Gofman
bdd8646306
util: add force_gl_names_reuse for SWKOTOR.
...
SWKOTOR is expecting texture names generated by glGenTextures() to
be small enough and crashes otherwise.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11527 >
2021-06-22 21:43:33 +00:00
Emma Anholt
a9e3ddfc63
i915g: Fix GL_ARB_copy_buffer assertion fails.
...
The i915_texture() asserts that the resource is not a buffer, so check for
the buffer fallback first.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11540 >
2021-06-22 21:32:36 +00:00
Lionel Landwerlin
7ed0aaced7
nir: use a more fitting index for btd_stack_push_intel
...
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8637 >
2021-06-22 21:09:25 +00:00
Lionel Landwerlin
423c47de99
nir: drop the btd_resume_intel intrinsic
...
This is now 100% equivalent to the new rt_resume intrinsic.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8637 >
2021-06-22 21:09:25 +00:00
Lionel Landwerlin
4d9fcf2799
intel/rt: switch to common pass for shader calls lowering
...
v2: rename for new indices
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8637 >
2021-06-22 21:09:25 +00:00
Lionel Landwerlin
1dacea10f3
anv: implement caching for ray tracing pipelines
...
v2: Turn a bunch of pointer checks into checks against NULL (Jason)
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8637 >
2021-06-22 21:09:25 +00:00
Lionel Landwerlin
fed7ac932f
anv: move trivial return shader to device
...
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8637 >
2021-06-22 21:09:25 +00:00
Lionel Landwerlin
7c852f78c4
anv: store more RT shader data in pipeline_stage object
...
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8637 >
2021-06-22 21:09:25 +00:00
Lionel Landwerlin
045f4600b1
anv: cache raytracing trampoline shader
...
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8637 >
2021-06-22 21:09:25 +00:00
Lionel Landwerlin
ab77aeb488
blorp: add blorp string in shader keys
...
Upon looking at caching the raytracing shader (in particular the
trampoline one) I kind of got afraid that some of the keys used for
blorp would end up matching other keys. This is because blorp keys are
fairly simple. There is no SPIRV module hash included.
This change includes a "blorp" string at the beginning of the queue to
ensure we don't collide with other keys.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8637 >
2021-06-22 21:09:25 +00:00
Jason Ekstrand
7479fe6ae0
anv: Implement vkCmdTraceRays and vkCmdTraceRaysIndirect
...
v2: Fix anv_cmd_state::binding_tables array size (Lionel)
v2: Fix anv_cmd_state::samplers array size (Lionel)
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8637 >
2021-06-22 21:09:25 +00:00
Jason Ekstrand
ac6d7a1758
anv: Make anv_address::offset 64-bit
...
This allows us to convert a 64-bit address to an anv_address which is
useful for working with device addresses.
v2: switch to int64_t to keep state pool relative relocation working
on non-softpin platforms
v3: Update assert to reflect relative offsets (Jason)
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8637 >
2021-06-22 21:09:25 +00:00
Jason Ekstrand
a67d7c9dee
anv: Allow _anv_combine_address with a NULL batch
...
This is required in order to be able to use GenXML pack functions for
structs with addresses when you're not packing into a batch.
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8637 >
2021-06-22 21:09:25 +00:00
Jason Ekstrand
f68d64dac0
anv: Add support for vkCmdSetRayTracingPipelineStackSizeKHR
...
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8637 >
2021-06-22 21:09:25 +00:00
Jason Ekstrand
02f7964a13
anv: Compute scratch sizes for ray-tracing pipelines and shader groups
...
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8637 >
2021-06-22 21:09:25 +00:00
Jason Ekstrand
c3ac9afca3
anv: Create and return ray-tracing pipeline SBT handles
...
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8637 >
2021-06-22 21:09:25 +00:00
Jason Ekstrand
b66d3e627a
intel/fs: Don't pull CS push constants if uses_inline_data
...
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8637 >
2021-06-22 21:09:25 +00:00
Jason Ekstrand
79dc25d867
anv: Compile trivial return and trampoline shaders
...
These don't necessarily go in any group but are required for dispatch to
work properly. The trampoline is a compute shader that is the initial
start point for the trace. It's in charge of invoking the actual
ray-gen shader. The trivial return shader is used whenever another
shader is missing and it does no work except the minimum required to do
a stack return.
v2: Rebase on upstream changes (Lionel)
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8637 >
2021-06-22 21:09:25 +00:00
Jason Ekstrand
e104555851
anv: Compile ray-tracing shaders
...
This doesn't look too different from other compile functions we have in
anv_pipeline.c. The primary difference is that ray-tracing pipelines
have this weird two-stage thing where you have "stages" which are
individual shaders and "groups" which are sort of mini pipelines that
are used to handle hits. For any given ray intersection, only the hit
and intersection shaders from the same group get used together. You
can't have an intersection shader from group A used with an any-hit from
group B. This results in a weird two-step compile.
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8637 >
2021-06-22 21:09:25 +00:00
Jason Ekstrand
379b9bb7b0
anv: Support fetching descriptor addresses from push constants
...
Bindless shaders don't have binding tables so they have to get at the
descriptor sets via a different mechanism.
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8637 >
2021-06-22 21:09:25 +00:00
Jason Ekstrand
937ffb1af0
nir/apply_pipeline_layout: Handle bindless shaders
...
They don't have binding tables so they have to use A64 descriptor set
access and everything has to be bindless all the time.
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8637 >
2021-06-22 21:09:25 +00:00
Jason Ekstrand
770d331285
anv: Disallow UBO pushing for bindless shaders
...
They don't really have push constants.
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8637 >
2021-06-22 21:09:25 +00:00
Jason Ekstrand
c92fd35848
intel/rt: Use reloc constants for the resume SBT
...
It's going to be attached to the end of the shader binary, not an
arbitrary table somewhere in memory.
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8637 >
2021-06-22 21:09:25 +00:00