Samuel Pitoiset
553eb1a3fd
radv: fix alpha-to-coverage with alpha-to-one when MRTZ is also exported
...
On AMD hardware, it's possible to export a separate alpha channel for
applying alpha-to-one after alpha-to-coverage and not before.
On GFX11+, it's already mostly supported but alpha needs to be exported
to MRTZ.a and one to MRT0.a. The hw always uses alpha for
alpha-to-coverage from MRTZ.a.
On older generations, the driver needs the same separate alpha export
but it also needs to configure the hardware with COVERAGE_TO_MASK_ENABLE
which selects alpha from MRTZ.a.
This should fix alpha-to-coverage with alpha-to-one when either
depth, stencil or samplemask are exported but it still needs a slightly
different solution without MRTZ. I will fix that later.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32523 >
2024-12-11 10:50:31 +00:00
Samuel Pitoiset
70047e6bd6
aco: export alpha to MRTZ.a and one to MRT0.a for alpha-to-one on GFX11
...
For FS epilogs.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32523 >
2024-12-11 10:50:31 +00:00
Samuel Pitoiset
1037830098
ac/nir: export alpha to MRTZ.a and one to MRT0.a for alpha-to-one on GFX11
...
When alpha-to-coverage and alpha-to-one are both enabled in the
fragment shader, the alpha value should be exported through MRTZ and
one to MRT0.a. Otherwise, alpha-to-one will be performed before
alpha-to-coverage.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32523 >
2024-12-11 10:50:31 +00:00
Samuel Pitoiset
3b010a9e60
radv: disable alphaToOne except for Zink
...
It's just completely broken if alpha-to-coverage is also used. Given
this is a requirement for Zink and no known GL apps are affected, let's
disable for everything except Zink. This is going to be fixed but the
fixes aren't small enough for backporting.
This fixes a rendering issue with XPlane 12.
Cc: mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32576 >
2024-12-11 08:28:25 +00:00
Samuel Pitoiset
310e03c8d3
radv/meta: move vk_meta_device_init() to radv_device_init_meta()
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32571 >
2024-12-11 07:25:29 +00:00
Samuel Pitoiset
cad6e1ea09
radv/meta: add missing vk_meta_device_finish()
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32571 >
2024-12-11 07:25:29 +00:00
Martin Roukala (né Peres)
b8054556a0
radv/ci: update the vkcts expectations
...
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32541 >
2024-12-11 04:24:35 +00:00
Martin Roukala (né Peres)
df5fb64f48
zink/ci: update the radv expectations
...
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32541 >
2024-12-11 04:24:35 +00:00
Martin Roukala (né Peres)
fe900be2b6
zink/ci: update the nvk-ga106 expectations
...
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Reviewed-by: Mary Guillemard <mary.guillemard@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32541 >
2024-12-11 04:24:35 +00:00
Martin Roukala (né Peres)
427f36ced9
nvk/ci: update the ga106 expectations
...
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Reviewed-by: Mary Guillemard <mary.guillemard@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32541 >
2024-12-11 04:24:35 +00:00
Martin Roukala (né Peres)
16e364e7d9
turnip/ci: skip a vkd3d test that causes a GPU hang on a750
...
This will hopefully allow the whole test suite to run.
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32541 >
2024-12-11 04:24:35 +00:00
Martin Roukala (né Peres)
56b72144e5
turnip/ci: bump the vkcts a750 timeout by 15 minutes
...
This fixes spurious fails due to exceeding the timeout seconds ahead of
finishing the job :s
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32541 >
2024-12-11 04:24:35 +00:00
Martin Roukala (né Peres)
c4012f9adc
turnip/ci: document the a750-vkcts expectations
...
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32541 >
2024-12-11 04:24:35 +00:00
Martin Roukala (né Peres)
8dc307cdc2
freedreno-ci: document a a750-gl flake
...
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32541 >
2024-12-11 04:24:35 +00:00
Martin Roukala (né Peres)
654d5049d4
freedreno-ci: document more a618-gl flakes
...
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32541 >
2024-12-11 04:24:35 +00:00
David Heidelberg
da69369382
ci/freedreno: increase Adreno 618 timeout to 1h
...
Signed-off-by: David Heidelberg <david@ixit.cz >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32541 >
2024-12-11 04:24:35 +00:00
David Heidelberg
4cb139cc6a
ci/freedreno: update Adreno 306 expectations
...
Signed-off-by: David Heidelberg <david@ixit.cz >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32541 >
2024-12-11 04:24:35 +00:00
Dave Airlie
699afb88ec
radv/video: set max slice counts to 1 for h264/5 encode
...
Right now the driver doesn't support multi-slice encodes, so
report the correct value.
Acked-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Acked-by: Autumn Ashton
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32580 >
2024-12-11 01:11:32 +00:00
Simon Ser
34e6932eaa
llvmpipe: handle llvmpipe_resource_map() errors
...
llvmpipe_resource_map() may fail, e.g. when the DMA-BUF cannot be
mmap'ed. Handle the error, either by returning NULL or by asserting.
Asserting is done in places where there is no good way to bubble up
the error (and is done in other places already, e.g. in
init_scene_texture).
Signed-off-by: Simon Ser <contact@emersion.fr >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32537 >
2024-12-10 22:05:19 +00:00
Sil Vilerino
ce1aad4505
vl/vl_winsys: Add missing include for function declaration
...
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/12150
Fixes: 2548471ca1 ("vl/vl_win32_screen_create_from_d3d12_device: Allow winsys to be injected")
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32559 >
2024-12-10 21:29:15 +00:00
Georg Lehmann
e8b29abb25
nir: add unsigned upper bound support for fsat
...
Foz-DB Navi21:
Totals from 89 (0.11% of 79395) affected shaders:
Instrs: 97018 -> 96995 (-0.02%)
CodeSize: 492996 -> 492488 (-0.10%)
Latency: 504649 -> 504555 (-0.02%)
InvThroughput: 121968 -> 121875 (-0.08%)
VALU: 67427 -> 67404 (-0.03%)
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com >
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32565 >
2024-12-10 20:53:53 +00:00
Georg Lehmann
e78e63e3fe
nir: add unsigned upper bound support for f2i32
...
Foz-DB Navi21:
Totals from 649 (0.82% of 79395) affected shaders:
CodeSize: 2330592 -> 2314112 (-0.71%)
Latency: 2068161 -> 2053370 (-0.72%)
InvThroughput: 346583 -> 329425 (-4.95%)
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com >
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32565 >
2024-12-10 20:53:53 +00:00
Georg Lehmann
0b366a7ab2
nir/uub: properly limit float support to 32bit
...
Cc: mesa-stable
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com >
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32565 >
2024-12-10 20:53:53 +00:00
Caio Oliveira
638802d68f
intel/brw: Dump errors when brw_assemble() fails EU validation
...
This will allow executor to show proper inline errors.
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32490 >
2024-12-10 20:23:25 +00:00
Job Noorman
9052ad449b
ir3/isa: fix conflict between stib.b and stsc
...
stsc was using don't care bits in a position position that is
significant for stib.b.
Signed-off-by: Job Noorman <jnoorman@igalia.com >
Fixes: 11b2c54a9a ("ir3/a7xx: Add STSC definition")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32575 >
2024-12-10 19:48:45 +00:00
Jesse Natalie
727c5a531e
microsoft/clc: Initialize printf buffer for tests
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32564 >
2024-12-10 19:13:07 +00:00
Alyssa Rosenzweig
83dd4889a7
nir/lower_point_size: skip non-var derefs
...
these can happen depending on pass order, otherwise we crash on the null
pointer.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32564 >
2024-12-10 19:13:07 +00:00
Alyssa Rosenzweig
a667a5a5d6
vulkan: add vk_check_printf_status helper
...
to integrate debug printf/abort, vulkan drivers need to implement a device
status. we would need to thicken the runtime to do that entirely in common code,
but we can at least add a helper to make it easier for vk drivers to wire.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Reviewed-by: Konstantin Seurer <konstantin.seurer@gmail.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32564 >
2024-12-10 19:13:07 +00:00
Alyssa Rosenzweig
33d839a72a
util/printf: add context-ful helpers
...
drivers wishing to integrate driver CL printf/abort have to do some delicate
dances to maintain the data structure with the buffer size and abort flag. wrap
it all up in common helpers -- the driver just supplies the memory allocation
and calls in periodically.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Reviewed-by: Konstantin Seurer <konstantin.seurer@gmail.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32564 >
2024-12-10 19:13:07 +00:00
Alyssa Rosenzweig
85e06f5a55
util/printf: be robust against truncated buffers
...
this can happen with shader aborts. don't blow up with theatrics.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Reviewed-by: Konstantin Seurer <konstantin.seurer@gmail.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32564 >
2024-12-10 19:13:07 +00:00
Alyssa Rosenzweig
69a0962c70
nir/lower_printf: use 64-bit math
...
this lets load_store_vectorize vectorize the stores we produce. it also matches
actual OpenCL kernel code looks, so drivers need to have an optimized path for
these 64+32 patterns regardless.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Reviewed-by: Konstantin Seurer <konstantin.seurer@gmail.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32564 >
2024-12-10 19:13:07 +00:00
Alyssa Rosenzweig
da967416db
nir/lower_printf: use unsigned math
...
negative offsets/sizes don't make sense, and zero-extension is often easier
to optimize/lower than sign-extension.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Reviewed-by: Konstantin Seurer <konstantin.seurer@gmail.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32564 >
2024-12-10 19:13:07 +00:00
Alyssa Rosenzweig
8db0751eb8
nir/lower_printf: lower aborts
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Reviewed-by: Konstantin Seurer <konstantin.seurer@gmail.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32564 >
2024-12-10 19:13:07 +00:00
Alyssa Rosenzweig
0b9072e2e5
nir/lower_printf: allow fixed address
...
fixed address printf buffers can avoid a lot of complexity, especially with the
general case of (e.g.) DGC-enqueued precompiled kernels. so add a knob for that
and save the driver the need to write a lowering pass.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Reviewed-by: Konstantin Seurer <konstantin.seurer@gmail.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32564 >
2024-12-10 19:13:07 +00:00
Alyssa Rosenzweig
816c14d33d
nir: add printf_abort intrinsic
...
abort() for the gpu, implemented with the printf infrastructure since they go
together.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Reviewed-by: Konstantin Seurer <konstantin.seurer@gmail.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32564 >
2024-12-10 19:13:07 +00:00
Tapani Pälli
03c9f164e8
drirc/anv: force_vk_vendor=-1 for Marvel Rivals
...
Cc: mesa-stable
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/12280
Signed-off-by: Tapani Pälli <tapani.palli@intel.com >
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32555 >
2024-12-10 18:30:48 +00:00
Alyssa Rosenzweig
f2f5e634bb
vulkan: bump layer api versions
...
these need to be kept in sync to avoid loader splat.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32557 >
2024-12-10 17:17:12 +00:00
Georg Lehmann
7bb3f93fa9
radv: use nir_opt_clip_cull_const
...
This reduces the fixed function hardware bottleneck in vertex shading
heavy sections with d3d9 DXVK.
DXVK always declares 6 clip distances, and with
https://github.com/doitsujin/dxvk/pull/4508
it writes 0 for disabled clip planes.
But while working on this, I also discovered that other games also write
constant clip/cull distances:
Foz-DB Navi21:
Totals from 442 (0.56% of 79206) affected shaders:
MaxWaves: 10880 -> 10900 (+0.18%)
Instrs: 283569 -> 282493 (-0.38%); split: -0.38%, +0.01%
CodeSize: 1497596 -> 1491948 (-0.38%); split: -0.38%, +0.00%
VGPRs: 18928 -> 18888 (-0.21%)
Outputs: 3026 -> 2970 (-1.85%)
Latency: 1051990 -> 1048878 (-0.30%); split: -0.47%, +0.18%
InvThroughput: 184190 -> 183366 (-0.45%); split: -0.45%, +0.01%
VClause: 6071 -> 6077 (+0.10%); split: -0.38%, +0.48%
SClause: 6724 -> 6725 (+0.01%); split: -0.12%, +0.13%
Copies: 19624 -> 19160 (-2.36%); split: -2.44%, +0.08%
PreSGPRs: 18634 -> 18526 (-0.58%)
PreVGPRs: 15522 -> 15465 (-0.37%)
VALU: 156964 -> 156330 (-0.40%); split: -0.41%, +0.01%
SALU: 41802 -> 41748 (-0.13%); split: -0.13%, +0.00%
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32518 >
2024-12-10 16:35:01 +00:00
Georg Lehmann
c5c22fc3a3
nir: add constant clip/cull distance optimization
...
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32518 >
2024-12-10 16:35:01 +00:00
Georg Lehmann
4f88dbffa4
radv: track holes in the clip/cull masks
...
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32518 >
2024-12-10 16:35:01 +00:00
Erik Faye-Lund
5a06e75d4d
panvk/ci: update g610 results
...
Seems like the multiview feature unlocked some tests that triggers a
previously unknown bug. This results in an assert triggering, but that
reveals a real, underlying issue.
A few of these doesn't trigger the assert, but still fails due to a GPU
hang.
Let's mark all of these as failures, to avoid holding back other MRs in
the mean time.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32574 >
2024-12-10 13:08:27 +00:00
Erik Faye-Lund
fc580a7b6e
panvk/ci: update g52 results
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32574 >
2024-12-10 13:08:27 +00:00
Georg Lehmann
4a977ea24f
aco/gfx11+: use v_and_b32 to extract local id 0
...
Foz-DB Navi31:
Totals from 2561 (3.23% of 79206) affected shaders:
CodeSize: 10399004 -> 10389120 (-0.10%)
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32532 >
2024-12-10 11:58:21 +00:00
Jordan Justen
1027b071f9
intel/dev: Add intel_check_hwconfig_items()
...
Rather than checking hwconfig items when using them, wait until after
devinfo has been fully initialized. This includes having workarounds
implemented.
We can then check if the hwconfig data and final Mesa initialization
agree. If the match fails, we need to investigate if Mesa or the
hwconfig data is wrong.
This code becomes a no-op when not on a release build.
Fixes: a4c5bfd34c ("intel/dev: Use hwconfig for urb min/max entry values")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/12141
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com >
Reviewed-by: José Roberto de Souza <jose.souza@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32359 >
2024-12-10 09:01:45 +00:00
Jordan Justen
4eb10bc25e
intel/dev: Don't process hwconfig table to apply items when not required
...
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com >
Reviewed-by: José Roberto de Souza <jose.souza@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32359 >
2024-12-10 09:01:45 +00:00
Jordan Justen
5a8107cef4
intel/dev: Split apply and check paths for hwconfig
...
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com >
Reviewed-by: José Roberto de Souza <jose.souza@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32359 >
2024-12-10 09:01:45 +00:00
Jordan Justen
832de579e1
intel/dev: Split hwconfig warning check into hwconfig_item_warning()
...
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com >
Reviewed-by: José Roberto de Souza <jose.souza@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32359 >
2024-12-10 09:01:45 +00:00
Karmjit Mahil
3f18c91a0b
util/idalloc: Minor refactor of util_idalloc_foreach()
...
Changes the `for` loop code to be similar to
`util_idalloc_forach_no_zero_safe()` for cohesion.
Signed-off-by: Karmjit Mahil <karmjit.mahil@igalia.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32546 >
2024-12-10 08:29:00 +00:00
Karmjit Mahil
af346cd77f
util/idalloc: Fix util_idalloc_foreach() build issue
...
Currently `util_idalloc_foreach()` isn't being used in the codebase
but if used it causes a build error as `num_used` doesn't exist.
Fix that by using `num_set_elements`.
Fixes: 0589dfe4e2 ("util/idalloc: optimize foreach by tracking the greatest non-zero element")
Signed-off-by: Karmjit Mahil <karmjit.mahil@igalia.com >
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32546 >
2024-12-10 08:29:00 +00:00
Erik Faye-Lund
03fc483813
panvk: expose EXT_4444_formats
...
We already have all the bits wired up to support both
VK_FORMAT_A4R4G4B4_UNORM_PACK16 and VK_FORMAT_A4B4G4R4_UNORM_PACK16_EXT
from VK_EXT_4444_formats, and were already setting the feature-flags for
them.
Let's also expose the extension, which should just work.
Reviewed-by: Lars-Ivar Hesselberg Simonsen <lars-ivar.simonsen@arm.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32083 >
2024-12-09 21:16:04 +00:00