AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
201,327 Commits 1 Branch 0 Tags
09b5de379cd47a025662459d03aed970da170676
Commit Graph

186467 Commits

Author SHA1 Message Date
Georg Lehmann a3054499ba aco/insert_exec: don't pretend WQMState is a bit mask 
It's a simple enum.

Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31560>
 2024-10-22 17:03:26 +00:00
José Roberto de Souza 3ed020031c iris: Program async compute registers of STATE_COMPUTE_MODE in compute engine 
Iris also makes use of compute engine in paralel with render engine,
so here also programing the async compute registers like it is done
in ANV.
This should improve performance when render and compute engine
are running in parallel.

It was also necessary to copy 2 workarounds that are needed before
programing STATE_COMPUTE_MODE.

Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30796>
 2024-10-22 15:24:32 +00:00
José Roberto de Souza aa5b2c4165 anv: Set recommended values for gfx20 async compute registers in STATE_COMPUTE_MODE 
This recommended values should improve the performance of async
compute in gfx20, we may want to tweek this for Linux but at least
this values should give us a better baseline than default values.

Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30796>
 2024-10-22 15:24:32 +00:00
José Roberto de Souza 2483f8f7cd intel/genxml: Do small fixes in gfx20 definition of STATE_COMPUTE_MODE 
Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30796>
 2024-10-22 15:24:32 +00:00
José Roberto de Souza 3efba707bf anv: Set all async compute registers in STATE_COMPUTE_MODE 
Setting the missing registers to specification recommended values that
is also the default value, so it is not expected any changes in
behavior or performance here.

Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30796>
 2024-10-22 15:24:32 +00:00
José Roberto de Souza 86ed5ec78e intel/genxml: Append 'Z Async Throttle settings' to gfx125 definition of STATE_COMPUTE_MODE 
DG2 has the 'Force Non-Coherent' fields but MTL and ARL has
'Z Async Throttle settings', so here adding the missing one.

Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30796>
 2024-10-22 15:24:32 +00:00
David Rosca 4adb652392 frontends/va: Don't relock mutex in vlVaEndPicture 
While this should not cause any real issues, there is no reason
to unlock the mutex just to lock it again couple lines below.

Fixes coverity issue 1559431 Value not atomically updated

Acked-by: Leo Liu <leo.liu@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31622>
 2024-10-22 14:48:29 +00:00
David Rosca 2cb3c2e8d5 frontends/va: Fix parsing leb128 when using more than 4 bytes 
Bit shift would go over 32 bits. Also add assert for maximum
value as allowed by spec.

Fixes coverity issue 1469252 Bad bit shift operation

Fixes: 5edbecb856 ("frontends/va: adding va av1 encoding functions")
Acked-by: Leo Liu <leo.liu@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31622>
 2024-10-22 14:48:29 +00:00
David Rosca 91222671f1 frontends/va: Fix NULL check in intra refresh params 
Return early when p_intra_refresh is NULL.

Fixes coverity issue 1553113 Dereference after null check

Acked-by: Leo Liu <leo.liu@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31622>
 2024-10-22 14:48:28 +00:00
David Rosca f9d1a50d8d frontends/va: Fix some small coverity issues 
* 1547216 Operands don't affect result
  - PRESET_MODE_HIGH_QUALITY is maximum value
* 1255678 Dereference after null check
  - no need to check against NULL because the data can
    only be NULL when the array is empty (size == 0)
* 1619397 Unsigned compared against 0
  - check >= 0 is always true in vlVaAddRawHeader
*  1468885 Dereference null return value
  - add NULL check for buffers in vlVaRenderPicture

Acked-by: Leo Liu <leo.liu@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31622>
 2024-10-22 14:48:28 +00:00
Daniel Stone 64ba87b68f ci/fdno: Add flake seen in the wild 
Signed-off-by: Daniel Stone <daniels@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31754>
 2024-10-22 14:12:32 +00:00
Daniel Stone 2ed84534d2 ci/rpi: Add flakes seen in the wild 
Signed-off-by: Daniel Stone <daniels@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31754>
 2024-10-22 14:12:32 +00:00
Samuel Pitoiset 7cd7631554 ci: uprev vkd3d-proton to 65b81403435576d882d9141ae3eb4a29373fba0e 
For EXT DGC implementation.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31754>
 2024-10-22 14:12:32 +00:00
Daniel Schürmann ef47cce51c aco/ra: always block register file for precolored operands 
so that they don't accidentally get renamed.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31387>
 2024-10-22 12:29:18 +00:00
Daniel Schürmann 18e7e8d8f0 aco/ra: make use of Precolored flag 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31387>
 2024-10-22 12:29:18 +00:00
Daniel Schürmann bb5eace0dc aco/live_var_analysis: check for isPrecolored flag rather than isFixed 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31387>
 2024-10-22 12:29:18 +00:00
Daniel Schürmann e2705a9d85 aco: set Precolored flag before register allocation 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31387>
 2024-10-22 12:29:18 +00:00
Daniel Schürmann c2ed4b474a aco: introduce 'isPrecolored' flag for Operand and Definition 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31387>
 2024-10-22 12:29:18 +00:00
Samuel Pitoiset b33f47b498 radv: regroup and emit all DS related states in the same function 
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31662>
 2024-10-22 11:52:10 +00:00
Samuel Pitoiset 8791e56b62 radv: track more redundant DB related registers 
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31662>
 2024-10-22 11:52:10 +00:00
Vignesh Raman a9e11c2f09 ci: build KERNEL_IMAGE_BASE in before_script 
When a job modifies the KERNEL_TAG variable, the url shall be rebuilt. So,
instead of building it in the variables section, do right before the script
when all the environment is set.

But, as we still have the FORCE_KERNEL_TAG that then defines the
KERNEL_IMAGE_BASE in the old style, for backwards compatibility it is not
overwriting the KERNEL_IMAGE_BASE.

The last two rules are now redundant and can be dropped.

Signed-off-by: Sergi Blanch Torne <sergi.blanch.torne@collabora.com>
Signed-off-by: Vignesh Raman <vignesh.raman@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31561>
 2024-10-22 09:54:59 +00:00
Marek Olšák 0bffe8ec05 mesa_interface: rename __DRIimage to struct dri_image 
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31752>
 2024-10-22 06:48:02 +00:00
Marek Olšák ee54fe9f69 mesa_interface: rename __DRIconfig to struct dri_config 
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31752>
 2024-10-22 06:48:02 +00:00
Marek Olšák 872b5c70d1 mesa_interface: remove redundant __DRI*Rec types 
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31752>
 2024-10-22 06:48:02 +00:00
Marek Olšák 186a3b6dad mesa_interface: replace opaque __DRIdrawable with struct dri_drawable everywhere 
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31752>
 2024-10-22 06:48:02 +00:00
Marek Olšák 329e03535b mesa_interface: replace opaque __DRIcontext with struct dri_context everywhere 
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31752>
 2024-10-22 06:48:02 +00:00
Marek Olšák 1ce9aa3d65 mesa_interface: replace opaque __DRIscreen with struct dri_screen everywhere 
it's always struct dri_screen

Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31752>
 2024-10-22 06:48:02 +00:00
Marek Olšák 3b603d1646 mesa_interface: remove unused stuff 
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31752>
 2024-10-22 06:48:01 +00:00
Louis-Francis Ratté-Boulianne 7af000a6ec panfrost: initialize all UBO and vertex buffer descriptors 
When tracing the command stream with PAN_MESA_DEBUG=trace, all
descriptors are read and decoded. Trying to read an invalid or old
descriptor might cause confusion or (more importantly) a crash.

Signed-off-by: Louis-Francis Ratté-Boulianne <lfrb@collabora.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31768>
 2024-10-22 05:01:27 +00:00
Kenneth Graunke 834b919f6a brw: Optimize 16-bit texture fetches later 
At the point we were calling this, we hadn't necessarily cleaned up
derefs via nir_lower_vars_to_ssa, nor movs/vecs via copy propagation,
so it wasn't necessarily easy for this pass to see the actual usage of
the destination.

Moving this later allows us to detect f2f32(txf(...)) and avoid
converting it to a 16-bit txf (why convert with ALU instructions
when the sampler could do it for us?).

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Sushma Venkatesh Reddy <sushma.venkatesh.reddy@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31750>
 2024-10-22 01:15:10 +00:00
Chia-I Wu ea478efa2e panvk: advertise VK_EXT_image_drm_format_modifier 
The extension is supported despite we only support
DRM_FORMAT_MOD_LINEAR.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31719>
 2024-10-22 00:47:47 +00:00
Chia-I Wu b7bc7852d7 panvk: advertise VK_KHR_image_format_list 
Since panvk does not treat VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT specially,
we can just advertise the extension.  When AFBC is supported in the
future, we will want to check the list to see if we can keep AFBC even
when VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT is set.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31719>
 2024-10-22 00:47:47 +00:00
Chia-I Wu cb7ce6a934 panvk: check VkPhysicalDeviceImageDrmFormatModifierInfoEXT 
Make sure VK_ERROR_FORMAT_NOT_SUPPORTED is returned when
VkPhysicalDeviceImageDrmFormatModifierInfoEXT specifies an unsupported
modifier.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31719>
 2024-10-22 00:47:47 +00:00
Chia-I Wu 252ddaf51b panvk: fix VkDrmFormatModifierPropertiesListEXT query 
Do not advertise unsupported formats.  Fix the array type and init
drmFormatModifierTilingFeatures.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31719>
 2024-10-22 00:47:47 +00:00
Chia-I Wu b3266db918 panvk: remove panvk_GetImageDrmFormatModifierPropertiesEXT 
Init vk_image::drm_format_mod and let
vk_common_GetImageDrmFormatModifierPropertiesEXT handle it.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31719>
 2024-10-22 00:47:47 +00:00
Adam Jackson 514ba16d95 rusticl: Enable out-of-order execution 
Ought to work, let's find out.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/12029
Reviewed-by: Karol Herbst <kherbst@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31672>
 2024-10-22 00:03:48 +00:00
Karol Herbst 1798597637 radeonsi: move si_compute::global_buffers to si_context 
si_set_global_binding is a context function, but it touches the bound
compute program. As radeonsi also advertizes PIPE_CAP_SHAREABLE_SHADERS
this function is supposed to be safe when the same compute state object is
bound to multiple contexts at once.

In order to fix this data race global_buffers is moved to si_context so it
becomes context private data instead.

Cc: mesa-stable
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31672>
 2024-10-22 00:03:48 +00:00
Christian Gmeiner fad599a619 etnaviv: Enable ARB_framebuffer_no_attachments 
There is not much needed to pass the supported tests.

Signed-off-by: Christian Gmeiner <cgmeiner@igalia.com>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31578>
 2024-10-21 23:27:30 +00:00
Amber 9ace01edbe tu, ir3: Implement VK_KHR_shader_atomic_int64 for a7xx. 
Passes dEQP-VK.glsl.atomic_operations.*64bit*

Signed-off-by: Amber Harmonia <amber@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27776>
 2024-10-21 21:47:44 +00:00
Amber a3afe22dc9 nir: add pass to lower atomic arithmetic to a loop with cmpxchg. 
Signed-off-by: Amber Harmonia <amber@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27776>
 2024-10-21 21:47:44 +00:00
Amber 7d0870e5d5 ir3: add support for 64 bit atomics 
Signed-off-by: Amber Harmonia <amber@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27776>
 2024-10-21 21:47:44 +00:00
Amber 5628a01523 ir3: add encoding support for 64-bit atomics introduced in a7xx. 
Signed-off-by: Amber Harmonia <amber@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27776>
 2024-10-21 21:47:44 +00:00
Mary Guillemard 84d57e1fb1 nir: Move atomic_op_to_alu to common code 
Signed-off-by: Mary Guillemard <mary.guillemard@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27776>
 2024-10-21 21:47:44 +00:00
quic_lkondred 334af37697 freedreno: Add support for Adreno 663 GPU 
Add support to enable basic functionality of Adreno 663 GPU.

Signed-off-by: quic_lkondred <quic_lkondred@quicinc.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31211>
 2024-10-21 21:05:57 +00:00
Rebecca Mckeever c2299b6642 panvk/csf: Implement vkCmdExecuteCommands 
Signed-off-by: Rebecca Mckeever <rebecca.mckeever@collabora.com>
Reviewed-by: Lars-Ivar Hesselberg Simonsen <lars-ivar.simonsen@arm.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31159>
 2024-10-21 19:39:07 +00:00
Rebecca Mckeever 3513960fe6 panvk: Move rendering info to panvk_rendering_state struct 
Signed-off-by: Rebecca Mckeever <rebecca.mckeever@collabora.com>
Reviewed-by: Lars-Ivar Hesselberg Simonsen <lars-ivar.simonsen@arm.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31159>
 2024-10-21 19:39:07 +00:00
Rebecca Mckeever ddb2f6f1fa panvk: Track VkFormats for depth and stencil attachments 
These can be used directly in vk_meta_rendering_info.

Signed-off-by: Rebecca Mckeever <rebecca.mckeever@collabora.com>
Reviewed-by: Lars-Ivar Hesselberg Simonsen <lars-ivar.simonsen@arm.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31159>
 2024-10-21 19:39:07 +00:00
Rebecca Mckeever 26a03222ef panvk/csf: Split tiler flags initialization into two steps 
The first step conditionally updates the tiler flags based on dirty bits,
and the second step is the override flags, which are unconditionally
updated at draw time.

Use pan_pack_nodefaults() to avoid default initialized fields.

Signed-off-by: Rebecca Mckeever <rebecca.mckeever@collabora.com>
Reviewed-by: Lars-Ivar Hesselberg Simonsen <lars-ivar.simonsen@arm.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31159>
 2024-10-21 19:39:07 +00:00
Rebecca Mckeever 07346ea1e6 panvk/csf: Set and clear vb.dirty flag 
Fixes: 5544d39f44 ("panvk: Add a CSF backend for panvk_queue/cmd_buffer")

Signed-off-by: Rebecca Mckeever <rebecca.mckeever@collabora.com>
Reviewed-by: Lars-Ivar Hesselberg Simonsen <lars-ivar.simonsen@arm.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31159>
 2024-10-21 19:39:07 +00:00
Marek Olšák fb6184f89c nir: add shader_info::tess::tcs_same_invocation_inputs_read(_indirect) 
We need both the same-invocation usage mask and cross-invocation usage
mask. The AMD reason is below.

Cross-invocation TCS input access doesn't prevent the same-invocation
fast path in AMD hw because it's just a different way to load the same
data, and we want to use both paths for the same TCS input based on
the load instruction. The fast path can't be used for indirect access,
which is gathered separately for same-invocation access.

Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31645>
 2024-10-21 18:53:51 +00:00