020bd86d30
vulkan: Remove the vk_ir_triangle_node::id field
...
Reviewed-by: Natalie Vock <natalie.vock@gmx.de >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36965 >
2025-10-21 19:32:55 +00:00
82728380a2
vulkan/bvh: Add some debug helpers
...
Reviewed-by: Natalie Vock <natalie.vock@gmx.de >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36965 >
2025-10-21 19:32:54 +00:00
639cc4d937
vulkan: Bump MAX_ENCODE_PASSES to 4
...
Triangle compression will be performed in two extra passes.
Reviewed-by: Natalie Vock <natalie.vock@gmx.de >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36965 >
2025-10-21 19:32:54 +00:00
6a53aae6b2
vulkan: Add vk_ir_header::driver_internal
...
Reviewed-by: Natalie Vock <natalie.vock@gmx.de >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36965 >
2025-10-21 19:32:54 +00:00
654bd74c60
treewide: use nir_store_global alias of nir_build_store_global
...
Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37959 >
2025-10-21 12:37:58 +02:00
2306cba65b
nir: remove manual nir_store_global
...
Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37959 >
2025-10-21 12:37:58 +02:00
9e41a7c139
treewide: use nir_load_global alias of nir_build_load_global
...
Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37959 >
2025-10-21 12:37:58 +02:00
84d8e6824b
treewide: don't check before free
...
This was something that came up in the slop MR. Not sure it's actually a
good idea or not but kind of curious what people think, given we have a
sound tool (Coccinelle) to do the transform. Saves a redundant branch
but means extra noninlined function calls.. likely no actual perf impact
but saves some code.
Via Coccinelle patches:
@@
expression ptr;
@@
-if (ptr) {
-free(ptr);
-}
+free(ptr);
@@
expression ptr;
@@
-if (ptr) {
-FREE(ptr);
-}
+FREE(ptr);
@@
expression ptr;
@@
-if (ptr) {
-ralloc_free(ptr);
-}
+ralloc_free(ptr);
@@
expression ptr;
@@
-if (ptr != NULL) {
-free(ptr);
-}
-
+free(ptr);
@@
expression ptr;
@@
-if (ptr != NULL) {
-FREE(ptr);
-}
-
+FREE(ptr);
@@
expression ptr;
@@
-if (ptr != NULL) {
-ralloc_free(ptr);
-}
-
+ralloc_free(ptr);
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@intel.com >
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com > [v3d]
Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org > [venus]
Reviewed-by: Frank Binns <frank.binns@imgtec.com > [powervr]
Reviewed-by: Janne Grunau <j@jannau.net > [asahi]
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com > [radv]
Reviewed-by: Job Noorman <jnoorman@igalia.com > [ir3]
Acked-by: Marek Olšák <maraeo@gmail.com >
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Acked-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Acked-by: Job Noorman <jnoorman@igalia.com >
Acked-by: Yonggang Luo <luoyonggang@gmail.com >
Acked-by: Christian Gmeiner <cgmeiner@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37892 >
2025-10-15 23:01:33 +00:00
c17dfcd745
vulkan/query_pool: Store video encode feedback
...
Drivers need to track which feedback bits were set at creation time to
output the correct things in vkGetQueryPoolResults().
Cc: mesa-stable
Reviewed-by: David Rosca <david.rosca@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37774 >
2025-10-14 09:11:25 +00:00
ddef2c1559
vulkan/runtime: fix memleak when creating ETC pipelines
...
NIR must be freed.
Found with ASAN.
Cc: mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37844 >
2025-10-14 06:54:02 +00:00
0e3781df7f
vulkan: Drop vk_pipeline_stage_flags2_has_*_shader
...
These are no longer used anywhere. Moreover, it's not clear that they
can be used for a correct implementation of pipeline barriers since a
correct implementation cannot ignore execution deps in non-shader
stages.
Reviewed-by: Mary Guillemard <mary@mary.zone >
Reviewed-by: Mohamed Ahmed <mohamedahmedegypt2001@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37671 >
2025-10-11 16:58:24 +00:00
48b63ee90d
vulkan/runtime: Add logic to set external format resolve mode
...
Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37177 >
2025-10-09 18:42:13 +00:00
131f4ca7cc
vulkan/android: Add rp_attachment_has_external_format helper
...
Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37177 >
2025-10-09 18:42:13 +00:00
9493f7781d
vulkan/runtime: Error if ahb has more than one layer
...
Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37177 >
2025-10-09 18:42:13 +00:00
f8cbc558db
vulkan/render_pass: fixup renderpasses barriers for 2D views of 3D images
...
With maintenance9 enabled
Spec clarification : https://gitlab.khronos.org/vulkan/vulkan/-/merge_requests/7629
Fixes: 595889018ahttps://gitlab.freedesktop.org/mesa/mesa/-/issues/13669
Reviewed-by: Alyssa Anne Rosenzweig <alyssa.rosenzweig@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36624 >
2025-10-06 22:20:26 +00:00
5e297c7444
vulkan/video: Add vk_video_is_profile_supported()
...
This helper sanity-checks a VkVideoProfileInfoKHR to make sure it
represents a real profile corresponding to specific codec rules.
Reviewed-by: David Rosca <david.rosca@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37656 >
2025-10-06 21:27:47 +00:00
33099040a3
vulkan/bvh: Mark instances with NAN AABBs as inactive
...
They can never be hit, remove them from the BVH.
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37492 >
2025-10-01 14:27:15 +00:00
927f65caf3
vk: Fix MSVC warning C4189
...
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37638 >
2025-09-30 22:40:28 +00:00
095f13109f
panvk, vk/meta: Move D/S sanitizing to panvk
...
In reality, only panvk rely on this and this breaks HK.
Signed-off-by: Mary Guillemard <mary@mary.zone >
Fixes: 42abf00f2bhttps://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37631 >
2025-09-30 13:14:18 +00:00
27988e9848
vk/meta: Support DS <-> color copies
...
VK_KHR_maintenance8 allows such copies, but there are a few things we
need to fix to support the case where the destination and source aspects
don't match.
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Mary Guillemard <mary.guillemard@collabora.com >
Tested-by: Mary Guillemard <mary.guillemard@collabora.com >
Reviewed-by: Christoph Pillmayer <christoph.pillmayer@arm.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37473 >
2025-09-29 13:59:30 +02:00
84802cf325
vulkan/video: fix misuse of CLAMP in h265 slice parsing.
...
Fixes: 7998106355zzoon@igalia.com >
Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37412 >
2025-09-26 12:27:59 +00:00
23c98417ae
vulkan/video: fix h265 encoding with LT enabled.
...
Signed-off-by: Hyunjun Ko <zzoon@igalia.com >
Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37412 >
2025-09-26 12:27:59 +00:00
896f95a37e
vulkan/video: fix h265 decoding with LT enabled.
...
Signed-off-by: Hyunjun Ko <zzoon@igalia.com >
Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37412 >
2025-09-26 12:27:58 +00:00
0f7e0f79ad
vulkan/queue: Move shared binary semaphores to temps
...
If a client creates a semaphore, exports it, and then re-imports it back
into the device, this can trick our semaphore reset logic. When this
happens, we end up with two different vk_sync structs that have the same
underlying payload so if one is used as the signal and one is used as
the wait of the same submit, we'll end up resetting it because we think
they're different, causing us to lose the signal.
We already have the ability to handle this for the threaded case by
moving the semaphore payload into a new vk_sync which we then destroy
after we're done submitting to the driver. Use this path for shared
semaphores in the immediate case so we can just wait and signal without
worrying about the reset.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/13805
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37149 >
2025-09-24 20:38:13 +00:00
6e3573127c
vulkan/runtime: only set shader subgroup info if non-zero
...
Signed-off-by: Simon Perretta <simon.perretta@imgtec.com >
Fixes: 67c4b762a5dadschoorse@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37533 >
2025-09-24 09:14:38 +00:00
67c4b762a5
vulkan: setup max_subgroup_size for drivers without varying/max/min size support
...
Ensures max_subgroup_size is set to the subgroupSize physical device
property on drivers that don't support VK_EXT_shader_object,
VK_EXT_subgroup_size_control, or Vulkan 1.3.
Fixes: d807f5a351simon.perretta@imgtec.com >
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37477 >
2025-09-19 20:51:15 +00:00
bbb76517ee
meson: only require glslang >= 12.2 when anv/radv/turnip are built
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37444 >
2025-09-18 19:07:10 +00:00
ea51a67996
vulkan/bvh: Enable glsl extensions in meson
...
Having a list of all enabled/used extensions in meson allows us to get
rid of a lot of boilerplate in every bvh build shader.
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35326 >
2025-09-16 20:18:01 +00:00
2ac5641473
shader_info: remove gl_subgroup_size enum
...
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Acked-by: Timur Kristóf <timur.kristof@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37258 >
2025-09-12 21:05:17 +00:00
d807f5a351
vulkan: set nir subgroup size shader info
...
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37258 >
2025-09-12 21:05:17 +00:00
7c9e945460
radv,vulkan: Avoid a useless barrier in radv_update_bind_pipeline
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36982 >
2025-09-10 08:35:50 +00:00
850f339b89
vulkan: Add more detail to encode debug markers
...
Useful for radv because radv has quite a few different configurations.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36982 >
2025-09-10 08:35:50 +00:00
5c94e20abe
vulkan: Use a struct for debug markers
...
Improves u_trace integation with anv.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36982 >
2025-09-10 08:35:50 +00:00
febe90e109
vulkan: remove incorrect assert
...
You can have a group with 0 shaders in it.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Fixes: 69a04151dbhttps://gitlab.freedesktop.org/mesa/mesa/-/issues/13858
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37249 >
2025-09-09 13:34:05 +00:00
e6dae6ef5f
vulkan: Optimize implicit end_subpass barrier
...
Rather than adding an implicit barrier on the last subpass
unconditionally, track in what subpasses attachments are used for the
last time and only add dependencies if none exist and there might be an
image transition.
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36985 >
2025-09-08 16:54:06 +00:00
eccc198284
vulkan: Optimize implicit begin_subpass barrier
...
Rather than adding an implicit barrier on the first subpass
unconditionally, track in what subpasses attachments are used for the
first time and only add dependencies if none exist and there might be an
image transition.
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36985 >
2025-09-08 16:54:06 +00:00
c0def2cf27
vulkan: Add transition_view_mask calculation
...
Refactor out a function to calculate the view mask for required layout
transitions. This will be used in the following commits.
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36985 >
2025-09-08 16:54:06 +00:00
067305e4c6
vulkan: Find first_subpass when creating renderpass
...
Like last_subpass, add a per-view mask of what subpass first uses an
attachment. This is required for optimizing out some barriers later.
Note that this requires us to do another loop over the subpasses.
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36985 >
2025-09-08 16:54:06 +00:00
3bad2ae069
vulkan: Stop combining subpass dependencies
...
Rather than OR-ing all subpass dependencies together in the Vulkan layer,
pass an array of barriers down to the drivers and allow them to do the
OR-ing if needed.
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36985 >
2025-09-08 16:54:05 +00:00
446d5ef103
vulkan: Drop the driver_internal from vk_image_view_init/create()
...
It alwways comes in through the create flags now.
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36957 >
2025-09-05 23:34:14 +00:00
42abf00f2b
vulkan: Handle VK_IMAGE_VIEW_CREATE_DRIVER_INTERNAL_BIT_MESA automatically
...
This moves the bit into vk_image.h and handles it automatically in
vk_image_view_init() so drivers don't have to.
This also means that Meta is now hitting the driver_internal path for
all its images so we need to do the same format fixups there that we
sould normally do on the !driver_internal path. We don't want to do
them unconditionally because v3dv and other drivers override
depth/stencil color formats and we don't want to break that.
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36957 >
2025-09-05 23:34:11 +00:00
e7b0cbdf40
vulkan/meta: Always set VK_IMAGE_VIEW_CREATE_DRIVER_INTERNAL_BIT_MESA
...
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36957 >
2025-09-05 23:34:11 +00:00
5faa62f91e
vulkan/util: add vk_topology_to_mesa helper function
...
Something like this already exists in a few drivers, move it to common
code. This specific version was pulled from honeykrisp, which is the
only one that handles META_RECT_LIST_MESA.
Signed-off-by: Olivia Lee <olivia.lee@collabora.com >
Reviewed-by: Mary Guillemard <mary.guillemard@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37038 >
2025-09-03 22:04:14 -07:00
6e1c2e4d83
vulkan: handle wsi private data properly
...
On Android, Vulkan loader implements KHR_swapchain and owns both surface
and swapchain handles. On non-Android, common wsi implements the same and
owns the same. So for both cases, the drivers are unable to handle
vkGet/SetPrivateData call on either a surface or a swapchain.
Inspired by https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37043
Cc: mesa-stable
Acked-by: Yonggang Luo <luoyonggang@gmail.com >
Acked-by: Ryan Zhang <ryan.zhang@nxp.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37064 >
2025-09-01 05:44:40 +00:00
564b6fd7f4
vulkan: move internal vulkan pseudo-extensions to a common file
...
This makes it easier to see what all of the assigned values are to check
for collisions, and allows using them in vulkan/util.
Signed-off-by: Olivia Lee <olivia.lee@collabora.com >
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37045 >
2025-09-01 03:50:12 +00:00
c4e5661f29
vulkan/android: improve stage masks for semaphore ops
...
Strictly speaking, for an empty batch, there is no inherit/defined
ordering between the wait and signal operations within the batch. We
are relying on MESA impl defined behavior to transfer payloads of the
wait sempahores to the signal sempahore here.
Ideally we need a MESA internal hint to ensure transitivity, but since
this is on the legacy fallback path, it's not worth the effort. So here
we follow common wsi to use TRANSFER_BIT which avoids most unnecessary
stalls on the queue (an improvement over the previous ALL_COMMANDS_BIT).
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36855 >
2025-08-26 17:24:09 +00:00
d72d0e8580
vulkan/android: skip queue submit with copy_sync_payloads
...
Follows common wsi side for the same reason as explained in
https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36827
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com >
Reviewed-by: Lars-Ivar Hesselberg Simonsen <lars-ivar.simonsen@arm.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36855 >
2025-08-26 17:24:08 +00:00
9ce92584ed
vulkan/runtime: silence a -Wsometimes-uninitialized warning
...
../src/vulkan/runtime/vk_device.c:746:28: warning: variable
'was_signaled' is used uninitialized whenever 'for' loop exits
because its condition is false [-Wsometimes-uninitialized]
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com >
Reviewed-by: Lars-Ivar Hesselberg Simonsen <lars-ivar.simonsen@arm.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36855 >
2025-08-26 17:24:08 +00:00
5372fe7cc4
vulkan/android: switch to vkQueueSubmit2
...
This follows common wsi side as suggested, and simplifies the later
adoption of vk_device_copy_semaphore_payloads.
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com >
Reviewed-by: Lars-Ivar Hesselberg Simonsen <lars-ivar.simonsen@arm.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36855 >
2025-08-26 17:24:07 +00:00
3a5514febf
vulkan/android: add an early return when there's no wait semaphores
...
..and no need to give result a default.
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com >
Reviewed-by: Lars-Ivar Hesselberg Simonsen <lars-ivar.simonsen@arm.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36855 >
2025-08-26 17:24:07 +00:00
Konstantin Seurer