AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

broadcom/compiler: fix coverity warning (unitialized pointer read)

Browse Source 
Full coverity warning:

   CID 1558604: Uninitialized pointer read (UNINIT)12. uninit_use_in_call: Using uninitialized value *results when calling nir_vec.
236        return nir_vec(b, results, DIV_ROUND_UP(num_components, 2));

To fix it we initialize the variables, provide a unreachable on the
switch that sets the results values. As we are here we also move a
comment to make things more clear.

Reviewed-by: Juan A. Suarez <jasuarez@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26951>
This commit is contained in:
Alejandro Piñeiro
2024-01-09 13:04:19 +01:00
parent f2b7c4ce29
commit ffd0e3a7fe
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/broadcom/compiler/v3d_nir_lower_image_load_store.c
+9 -7
View File
@@ -199,13 +199,8 @@ pack_16bit(nir_builder *b, nir_def *color,
unsigned num_components,
enum hw_conversion conversion)
{
nir_def *results[2];
nir_def *channels[4];
/* Note that usually you should not use this method (that relies on
* custom packing) if we are not doing any conversion. But we support
* also that case, and let the caller decide which method to use.
*/
nir_def *results[2] = {0};
nir_def *channels[4] = {0};
for (unsigned i = 0; i < num_components; i++) {
channels[i] = nir_channel(b, color, i);
@@ -217,6 +212,11 @@ pack_16bit(nir_builder *b, nir_def *color,
channels[i] = nir_f2unorm_16_v3d(b, channels[i]);
break;
default:
/* Note that usually you should not use this method
* (that relies on custom packing) if we are not doing
* any conversion. But we support also that case, and
* let the caller decide which method to use.
*/
break;
}
}
@@ -231,6 +231,8 @@ pack_16bit(nir_builder *b, nir_def *color,
case 2:
results[0] = nir_pack_2x32_to_2x16_v3d(b, channels[0], channels[1]);
break;
default:
unreachable("Invalid number of components");
}
return nir_vec(b, results, DIV_ROUND_UP(num_components, 2));