AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

broadcom/qpu: fail packing on unhandled mul pack/unpack

Browse Source 
We are doing this for the ADD alu already and it may be helpful to
identify cases where we have QPU code with pack/unpack modifiers on
MUL opcodes that we then are not packing into the actual QPU
instructions.

Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25450>
This commit is contained in:
Iago Toral Quiroga
2021-10-06 12:01:10 +02:00
committed by Marge Bot
parent 5fc2b565a4
commit ff86147f91
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/broadcom/qpu/qpu_pack.c
+12
View File
@@ -2109,6 +2109,12 @@ v3d33_qpu_mul_pack(const struct v3d_device_info *devinfo,
}
default:
if (instr->alu.mul.op != V3D_QPU_M_NOP &&
(instr->alu.mul.output_pack != V3D_QPU_PACK_NONE ||
instr->alu.mul.a.unpack != V3D_QPU_UNPACK_NONE ||
instr->alu.mul.b.unpack != V3D_QPU_UNPACK_NONE)) {
return false;
}
break;
}
@@ -2228,6 +2234,12 @@ v3d71_qpu_mul_pack(const struct v3d_device_info *devinfo,
}
default:
if (instr->alu.mul.op != V3D_QPU_M_NOP &&
(instr->alu.mul.output_pack != V3D_QPU_PACK_NONE ||
instr->alu.mul.a.unpack != V3D_QPU_UNPACK_NONE ||
instr->alu.mul.b.unpack != V3D_QPU_UNPACK_NONE)) {
return false;
}
break;
}