AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

panfrost: Use an identity swizzle for RAW formats

Browse Source 
When the render target format is raw, the swizzle is ignored. Let's
set it to identity to avoid misleading the pandecode reader into
thinking the swizzle is applied.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Suggested-by: Alyssa Rosenzweig <alyssa@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12793>
This commit is contained in:
Boris Brezillon
2021-09-20 12:39:12 +02:00
committed by Marge Bot
parent ce8ea9e602
commit fbbe00c0b7
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/panfrost/lib/pan_cs.c
+6 -4
View File
@@ -373,10 +373,9 @@ pan_rt_init_format(const struct pan_image_view *rt,
/* The swizzle for rendering is inverted from texturing */
unsigned char swizzle[4];
panfrost_invert_swizzle(desc->swizzle, swizzle);
cfg->swizzle = panfrost_translate_swizzle_4(swizzle);
unsigned char swizzle[4] = {
PIPE_SWIZZLE_X, PIPE_SWIZZLE_Y, PIPE_SWIZZLE_Z, PIPE_SWIZZLE_W,
};
/* Fill in accordingly, defaulting to 8-bit UNORM */
@@ -388,6 +387,7 @@ pan_rt_init_format(const struct pan_image_view *rt,
if (fmt.internal) {
cfg->internal_format = fmt.internal;
cfg->writeback_format = fmt.writeback;
panfrost_invert_swizzle(desc->swizzle, swizzle);
} else {
/* Construct RAW internal/writeback, where internal is
* specified logarithmically (round to next power-of-two).
@@ -402,6 +402,8 @@ pan_rt_init_format(const struct pan_image_view *rt,
cfg->writeback_format = pan_mfbd_raw_format(bits);
}
cfg->swizzle = panfrost_translate_swizzle_4(swizzle);
}
static void