vc4: Fix leak in HW queries error path
Reported by Coverity: in the case where there exist hardware and
non-hardware queries, the code does not jump to err_free_query and leaks
the query.
CID: 1430194
Signed-off-by: Ernestas Kulik <ernestas.kulik@gmail.com>
Fixes: 9ea90ffb98 ("broadcom/vc4: Add support for HW perfmon")
This commit is contained in:
committed by
Eric Anholt
parent
6053c7bb43
commit
f6e49d5ad0
@@ -132,7 +132,7 @@ vc4_create_batch_query(struct pipe_context *pctx, unsigned num_queries,
|
||||
|
||||
/* We can't mix HW and non-HW queries. */
|
||||
if (nhwqueries && nhwqueries != num_queries)
|
||||
return NULL;
|
||||
goto err_free_query;
|
||||
|
||||
if (!nhwqueries)
|
||||
return (struct pipe_query *)query;
|
||||
|
||||
Reference in New Issue
Block a user