AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

aco: fix outdated label_vec from p_create_vector labelling

Browse Source 
Fixes random dEQP-VK.transform_feedback.fuzz.* crashes.

Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Fixes: 2dc550202e
    ('aco: copy-propagate p_create_vector copies of vectors')

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4730>
This commit is contained in:
Rhys Perry
2020-04-24 11:58:17 +01:00
committed by Marge Bot
parent fdf9b674ee
commit ede1c171c5
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/amd/compiler/aco_optimizer.cpp
+5 -3
View File
@@ -898,10 +898,9 @@ void label_instruction(opt_ctx &ctx, Block& block, aco_ptr<Instruction>& instr)
switch (instr->opcode) {
case aco_opcode::p_create_vector: {
if (instr->operands.size() == 1 && instr->operands[0].isTemp())
bool copy_prop = instr->operands.size() == 1 && instr->operands[0].isTemp();
if (copy_prop)
ctx.info[instr->definitions[0].tempId()].set_temp(instr->operands[0].getTemp());
else
ctx.info[instr->definitions[0].tempId()].set_vec(instr.get());
unsigned num_ops = instr->operands.size();
for (const Operand& op : instr->operands) {
@@ -928,6 +927,9 @@ void label_instruction(opt_ctx &ctx, Block& block, aco_ptr<Instruction>& instr)
}
assert(k == num_ops);
}
if (!copy_prop)
ctx.info[instr->definitions[0].tempId()].set_vec(instr.get());
break;
}
case aco_opcode::p_split_vector: {