glx: Generate fewer errors in MakeContextCurrent
For a few reasons. 1: In the (current) common case, these conditionals are never true. All we're doing by checking them is slowing down MakeCurrent. The server does these checks already anyway. 2: GLX >= 3.0 contexts may legally be made current without a bound framebuffer. This does not fix piglit/glx-create-context-current-no-framebuffer, but is a prerequisite for fixing it. Cc: "9.1 9.2" <mesa-stable@lists.freedesktop.org> Reviewed-by: Brian Paul <brianp@vmware.com> Signed-off-by: Adam Jackson <ajax@redhat.com>
This commit is contained in:
@@ -231,16 +231,6 @@ MakeContextCurrent(Display * dpy, GLXDrawable draw,
|
||||
return GL_FALSE;
|
||||
}
|
||||
|
||||
if (gc == NULL && (draw != None || read != None)) {
|
||||
__glXGenerateError(dpy, (draw != None) ? draw : read,
|
||||
BadMatch, X_GLXMakeContextCurrent);
|
||||
return False;
|
||||
}
|
||||
if (gc != NULL && (draw == None || read == None)) {
|
||||
__glXGenerateError(dpy, None, BadMatch, X_GLXMakeContextCurrent);
|
||||
return False;
|
||||
}
|
||||
|
||||
_glapi_check_multithread();
|
||||
|
||||
__glXLock();
|
||||
|
||||
Reference in New Issue
Block a user