AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

glsl: Fix the foreach_in_list_reverse macro.

Browse Source 
We clearly don't want to start at the head and walk backwards; we want
to start at the last real element before the tail sentinel.  If the list
is empty, tail_pred will be the head sentinel, and we'll stop.

Nothing uses this function, so I guess nobody noticed it was broken.

Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Matt Turner <mattst88@gmail.com>
This commit is contained in:
Kenneth Graunke
2014-07-05 22:04:45 -07:00
parent be536efe20
commit e13a6406c3
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/glsl/list.h
+3 -3
View File
@@ -565,9 +565,9 @@ inline void exec_node::insert_before(exec_list *before)
!(__inst)->is_tail_sentinel(); \
(__inst) = (__type *)(__inst)->next)
#define foreach_in_list_reverse(__type, __inst, __list) \
for (__type *(__inst) = (__type *)(__list)->head; \
!(__inst)->is_head_sentinel(); \
#define foreach_in_list_reverse(__type, __inst, __list) \
for (__type *(__inst) = (__type *)(__list)->tail_pred; \
!(__inst)->is_head_sentinel(); \
(__inst) = (__type *)(__inst)->prev)
/**