radv: remove useless check about number of samples in the HW resolve path
Although this can likely hang, this is invalid and should be caught by the validation layers. There is many ways to hang the GPU with VK, this check alone is useless. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12556>
This commit is contained in:
committed by
Marge Bot
parent
b05c2023cc
commit
df90bb3f88
@@ -451,11 +451,6 @@ radv_meta_resolve_hardware_image(struct radv_cmd_buffer *cmd_buffer, struct radv
|
||||
radv_meta_save(&saved_state, cmd_buffer, RADV_META_SAVE_GRAPHICS_PIPELINE);
|
||||
|
||||
assert(src_image->info.samples > 1);
|
||||
if (src_image->info.samples <= 1) {
|
||||
/* this causes GPU hangs if we get past here */
|
||||
fprintf(stderr, "radv: Illegal resolve operation (src not multisampled), will hang GPU.");
|
||||
return;
|
||||
}
|
||||
assert(dst_image->info.samples == 1);
|
||||
|
||||
unsigned fs_key = radv_format_meta_fs_key(device, dst_image->vk_format);
|
||||
|
||||
Reference in New Issue
Block a user