nak: Drop BasicBlock::new()

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29591>

src/nouveau/compiler/nak/from_nir.rs

@@ -3252,8 +3252,10 @@ impl<'a> ShaderFromNir<'a> {
             }
         }
 
-        let mut bb = BasicBlock::new(self.get_block_label(nb));
-        bb.instrs.append(&mut b.as_vec());
+        let bb = BasicBlock {
+            label: self.get_block_label(nb),
+            instrs: b.as_vec(),
+        };
         self.cfg.add_node(nb.index, bb);
     }
 

src/nouveau/compiler/nak/ir.rs

@@ -5906,13 +5906,6 @@ pub struct BasicBlock {
 }
 
 impl BasicBlock {
-    pub fn new(label: Label) -> BasicBlock {
-        BasicBlock {
-            label: label,
-            instrs: Vec::new(),
-        }
-    }
-
     pub fn map_instrs(
         &mut self,
         mut map: impl FnMut(Box<Instr>) -> MappedInstrs,