AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

panvk: Don't allow AFBC if the format format is mutable on v7-

Browse Source 
We can't create texture descriptors with a format that's different
from the image format, because the texture format encodes the
compression mode on Bifrost. So let's forbid AFBC when
VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT is set.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Christoph Pillmayer <christoph.pillmayer@arm.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37158>
This commit is contained in:
Boris Brezillon
2025-09-10 09:45:18 +02:00
committed by Marge Bot
parent cbe461c930
commit d47b016a84
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/panfrost/vulkan/panvk_image.c
+3 -3
View File
@@ -66,8 +66,8 @@ panvk_image_can_use_afbc(
* - tiling is set to linear
* - this is a 1D image
* - this is a 3D image on a pre-v7 GPU
* - this is a mutable format image on v7 (the BGR emulation we have with
* the texture swizzle gets in the way).
* - this is a mutable format image on v7- (format re-interpretation is
* not possible on Bifrost hardware).
*
* Some of these checks are redundant with tests provided by the AFBC mod
* handler when pan_image_test_props() is called, but we need them because
@@ -82,7 +82,7 @@ panvk_image_can_use_afbc(
pan_afbc_supports_format(arch, pfmt) &&
tiling == VK_IMAGE_TILING_OPTIMAL && type != VK_IMAGE_TYPE_1D &&
(type != VK_IMAGE_TYPE_3D || arch >= 7) &&
(!(flags & VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT) || arch != 7);
(!(flags & VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT) || arch >= 9);
}
static enum mali_texture_dimension