AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nir/print: Don't print sampler_index for txf

Browse Source 
NIR's docs for sampler_index say

    The following operations do not require a sampler and, as such, this
    field should be ignored:
       - nir_texop_txf
       - nir_texop_txf_ms
       - nir_texop_txs
       - nir_texop_query_levels
       - nir_texop_texture_samples
       - nir_texop_samples_identical

Contrary to this documentation, we were still printing the sampler_index anyway,
even though the value is formally undefined. This was helpful for
PIPE_CAP_TEXTURE_BUFFER_SAMPLER drivers that (despite the NIR docs) respected the
sampler_index anyway. There are no longer any such drivers, so we should stop
printing sampler_index for txf to avoid confusion (and noise).

Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22223>
This commit is contained in:
Alyssa Rosenzweig
2023-03-30 14:08:38 -04:00
committed by Marge Bot
parent a9f9953928
commit d1b569d26f
1 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/compiler/nir/nir_print.c
+5 -7
View File
@@ -1413,14 +1413,12 @@ print_tex_instr(nir_tex_instr *instr, print_state *state)
fprintf(fp, " } (offsets)");
}
if (instr->op != nir_texop_txf_ms_fb) {
if (!has_texture_deref) {
fprintf(fp, ", %u (texture)", instr->texture_index);
}
if (instr->op != nir_texop_txf_ms_fb && !has_texture_deref) {
fprintf(fp, ", %u (texture)", instr->texture_index);
}
if (!has_sampler_deref) {
fprintf(fp, ", %u (sampler)", instr->sampler_index);
}
if (nir_tex_instr_need_sampler(instr) && !has_sampler_deref) {
fprintf(fp, ", %u (sampler)", instr->sampler_index);
}
if (instr->texture_non_uniform) {