virgl: document potentially failing blit
This blit can fail, but this is not new; in the old version we didn't even try to blit in this case. So let's just document the limitation for now, and leave this for another day. Signed-off-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
This commit is contained in:
@@ -298,6 +298,12 @@ static void virgl_texture_transfer_unmap(struct pipe_context *ctx,
|
||||
flush_data(ctx, virgl_transfer(trans->resolve_transfer),
|
||||
&trans->resolve_transfer->box);
|
||||
|
||||
/* FINISHME: In case the destination format isn't renderable here, the
|
||||
* blit here will currently fail. This could for instance happen if the
|
||||
* mapped resource is of a compressed format, and it's mapped with both
|
||||
* read and write usage.
|
||||
*/
|
||||
|
||||
virgl_copy_region_with_blit(ctx,
|
||||
trans->base.resource, trans->base.level,
|
||||
&transfer->box,
|
||||
|
||||
Reference in New Issue
Block a user