AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

gbm/dri: Remove erroneous assert

Browse Source 
The user is allowed to pass a list of modifiers including
DRM_FORMAT_MOD_INVALID, meaning that the user is OK with implicit
modifiers. Since merging the DRI interfaces, this assert that we are
never returning an implicit modifier is unnecessary and also wrong. It
was originally added to be super-safe, but we now know that our drivers
work very well with modifiers, so don't need it.

Signed-off-by: Daniel Stone <daniels@collabora.com>
Fixes: 0b16d7ebb9 ("dri: Allow INVALID for modifier-less drivers")
Closes: mesa/mesa#11591
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30464>
This commit is contained in:
Daniel Stone
2024-08-01 11:18:34 +01:00
committed by Marge Bot
parent 78ff100a52
commit cd961a7e3f
1 changed files with 0 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/gbm/backends/dri/gbm_dri.c
-3
View File
@@ -1056,9 +1056,6 @@ gbm_dri_bo_create(struct gbm_device *gbm,
free(mods_filtered);
mods_filtered = NULL;
if (modifiers)
assert(gbm_dri_bo_get_modifier(&bo->base) != DRM_FORMAT_MOD_INVALID);
dri->image->queryImage(bo->image, __DRI_IMAGE_ATTRIB_HANDLE,
&bo->base.v0.handle.s32);
dri->image->queryImage(bo->image, __DRI_IMAGE_ATTRIB_STRIDE,