AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

anv: Call flush_pipeline_select_gpgpu() for compute engines in compute code paths

Browse Source 
These 2 compute code paths were checking for
anv_cmd_buffer_is_render_queue() before calling
flush_pipeline_select_gpgpu() causing cmd_buffer->state.current_pipeline
to never to be set to GPGPU, trigerring
assert(cmd_buffer->state.current_pipeline == GPGPU) when running in
the compute engine.

So here just dropping the anv_cmd_buffer_is_render_queue() check.

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28053>
This commit is contained in:
José Roberto de Souza
2024-03-07 07:52:07 -08:00
committed by Marge Bot
parent a13860e5df
commit cccb5e36f1
2 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/intel/vulkan/genX_acceleration_structure.c
+1 -2
View File
@@ -835,8 +835,7 @@ cmd_build_acceleration_structures(
&data, sizeof(data));
}
if (anv_cmd_buffer_is_render_queue(cmd_buffer))
genX(flush_pipeline_select_gpgpu)(cmd_buffer);
genX(flush_pipeline_select_gpgpu)(cmd_buffer);
/* Due to the nature of GRL and its heavy use of jumps/predication, we
* cannot tell exactly in what order the CFE_STATE we insert are going to
src/intel/vulkan/genX_cmd_compute.c
+1 -2
View File
@@ -587,8 +587,7 @@ genX(cmd_buffer_dispatch_kernel)(struct anv_cmd_buffer *cmd_buffer,
genX(cmd_buffer_config_l3)(cmd_buffer, kernel->l3_config);
if (anv_cmd_buffer_is_render_queue(cmd_buffer))
genX(flush_pipeline_select_gpgpu)(cmd_buffer);
genX(flush_pipeline_select_gpgpu)(cmd_buffer);
/* Apply any pending pipeline flushes we may have. We want to apply them
* now because, if any of those flushes are for things like push constants,