AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ir3: add validation for alias

Browse Source 
Signed-off-by: Job Noorman <jnoorman@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31222>
This commit is contained in:
Job Noorman
2025-01-22 15:33:48 +01:00
committed by Marge Bot
parent 84b93cf718
commit c5c95f8916
1 changed files with 41 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/freedreno/ir3/ir3_validate.c
+41
View File
@@ -69,6 +69,21 @@ validate_src(struct ir3_validate_ctx *ctx, struct ir3_instruction *instr,
if ((reg->flags & IR3_REG_IMMED) && !(reg->flags & IR3_REG_ALIAS))
validate_assert(ctx, ir3_valid_immediate(instr, reg->iim_val));
if (reg->flags & IR3_REG_FIRST_ALIAS)
validate_assert(ctx, reg->flags & IR3_REG_ALIAS);
if (reg->flags & IR3_REG_ALIAS) {
unsigned valid_flags = IR3_REG_ALIAS | IR3_REG_FIRST_ALIAS |
IR3_REG_HALF | IR3_REG_CONST | IR3_REG_IMMED |
IR3_REG_SSA | IR3_REG_KILL | IR3_REG_FIRST_KILL;
validate_assert(ctx, !(reg->flags & ~valid_flags));
}
if (instr->opc == OPC_ALIAS && instr->cat7.alias_scope == ALIAS_RT) {
unsigned valid_flags = IR3_REG_HALF | IR3_REG_CONST | IR3_REG_IMMED;
validate_assert(ctx, !(reg->flags & ~valid_flags));
}
if (!(reg->flags & IR3_REG_SSA) || !reg->def)
return;
@@ -134,6 +149,13 @@ static void
validate_dst(struct ir3_validate_ctx *ctx, struct ir3_instruction *instr,
struct ir3_register *reg)
{
if (reg->flags & IR3_REG_RT) {
validate_assert(ctx, instr->opc == OPC_ALIAS);
validate_assert(ctx, instr->cat7.alias_scope == ALIAS_RT);
validate_assert(ctx, !(reg->flags & ~IR3_REG_RT));
validate_assert(ctx, !reg->tied);
}
if (reg->tied) {
validate_assert(ctx, reg->tied->tied == reg);
validate_assert(ctx, reg_class_flags(reg->tied) == reg_class_flags(reg));
@@ -501,6 +523,25 @@ validate_instr(struct ir3_validate_ctx *ctx, struct ir3_instruction *instr)
validate_assert(ctx, !(instr->srcs[1]->flags & IR3_REG_HALF));
break;
}
break;
case 7:
switch (instr->opc) {
case OPC_ALIAS:
switch (instr->cat7.alias_scope) {
case ALIAS_RT:
validate_assert(ctx, instr->dsts[0]->flags & IR3_REG_RT);
validate_assert(ctx, instr->cat7.alias_table_size_minus_one == 0);
break;
case ALIAS_TEX:
validate_assert(ctx, instr->cat7.alias_table_size_minus_one < 16);
break;
case ALIAS_MEM:
break;
}
break;
default:
break;
}
}
if (instr->opc == OPC_META_PARALLEL_COPY) {