From c5c95f8916331d0fc2df8b5d3ddf6a1e0ec864f6 Mon Sep 17 00:00:00 2001
From: Job Noorman <jnoorman@igalia.com>
Date: Wed, 22 Jan 2025 15:33:48 +0100
Subject: [PATCH] ir3: add validation for alias

Signed-off-by: Job Noorman <jnoorman@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31222>
---
 src/freedreno/ir3/ir3_validate.c | 41 ++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/src/freedreno/ir3/ir3_validate.c b/src/freedreno/ir3/ir3_validate.c
index 2459f012383..4ed6723c760 100644
--- a/src/freedreno/ir3/ir3_validate.c
+++ b/src/freedreno/ir3/ir3_validate.c
@@ -69,6 +69,21 @@ validate_src(struct ir3_validate_ctx *ctx, struct ir3_instruction *instr,
    if ((reg->flags & IR3_REG_IMMED) && !(reg->flags & IR3_REG_ALIAS))
       validate_assert(ctx, ir3_valid_immediate(instr, reg->iim_val));
 
+   if (reg->flags & IR3_REG_FIRST_ALIAS)
+      validate_assert(ctx, reg->flags & IR3_REG_ALIAS);
+
+   if (reg->flags & IR3_REG_ALIAS) {
+      unsigned valid_flags = IR3_REG_ALIAS | IR3_REG_FIRST_ALIAS |
+                             IR3_REG_HALF | IR3_REG_CONST | IR3_REG_IMMED |
+                             IR3_REG_SSA | IR3_REG_KILL | IR3_REG_FIRST_KILL;
+      validate_assert(ctx, !(reg->flags & ~valid_flags));
+   }
+
+   if (instr->opc == OPC_ALIAS && instr->cat7.alias_scope == ALIAS_RT) {
+      unsigned valid_flags = IR3_REG_HALF | IR3_REG_CONST | IR3_REG_IMMED;
+      validate_assert(ctx, !(reg->flags & ~valid_flags));
+   }
+
    if (!(reg->flags & IR3_REG_SSA) || !reg->def)
       return;
 
@@ -134,6 +149,13 @@ static void
 validate_dst(struct ir3_validate_ctx *ctx, struct ir3_instruction *instr,
              struct ir3_register *reg)
 {
+   if (reg->flags & IR3_REG_RT) {
+      validate_assert(ctx, instr->opc == OPC_ALIAS);
+      validate_assert(ctx, instr->cat7.alias_scope == ALIAS_RT);
+      validate_assert(ctx, !(reg->flags & ~IR3_REG_RT));
+      validate_assert(ctx, !reg->tied);
+   }
+
    if (reg->tied) {
       validate_assert(ctx, reg->tied->tied == reg);
       validate_assert(ctx, reg_class_flags(reg->tied) == reg_class_flags(reg));
@@ -501,6 +523,25 @@ validate_instr(struct ir3_validate_ctx *ctx, struct ir3_instruction *instr)
             validate_assert(ctx, !(instr->srcs[1]->flags & IR3_REG_HALF));
          break;
       }
+      break;
+   case 7:
+      switch (instr->opc) {
+      case OPC_ALIAS:
+         switch (instr->cat7.alias_scope) {
+         case ALIAS_RT:
+            validate_assert(ctx, instr->dsts[0]->flags & IR3_REG_RT);
+            validate_assert(ctx, instr->cat7.alias_table_size_minus_one == 0);
+            break;
+         case ALIAS_TEX:
+            validate_assert(ctx, instr->cat7.alias_table_size_minus_one < 16);
+            break;
+         case ALIAS_MEM:
+            break;
+         }
+         break;
+      default:
+         break;
+      }
    }
 
    if (instr->opc == OPC_META_PARALLEL_COPY) {