AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

freedreno/a2xx: Fix redundant if statement

Browse Source 
We test the condition, declare a few variables, then test the exact
same condition again. Let's not do that.

Signed-off-by: Kristian H. Kristensen <hoegsberg@chromium.org>
This commit is contained in:
Kristian H. Kristensen
2019-04-10 13:08:00 -07:00
committed by Kristian H. Kristensen
parent 18ce6ac632
commit c34b285b38
1 changed files with 14 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/gallium/drivers/freedreno/a2xx/fd2_draw.c
+14 -16
View File
@@ -551,22 +551,20 @@ fd2_clear(struct fd_context *ctx, unsigned buffers,
if (buffers & (PIPE_CLEAR_DEPTH | PIPE_CLEAR_STENCIL)) {
uint32_t clear_mask, depth_clear;
if (buffers & (PIPE_CLEAR_DEPTH | PIPE_CLEAR_STENCIL)) {
switch (fd_pipe2depth(fb->zsbuf->format)) {
case DEPTHX_24_8:
clear_mask = ((buffers & PIPE_CLEAR_DEPTH) ? 0xe : 0) |
((buffers & PIPE_CLEAR_STENCIL) ? 0x1 : 0);
depth_clear = (((uint32_t)(0xffffff * depth)) << 8) |
(stencil & 0xff);
break;
case DEPTHX_16:
clear_mask = 0xf;
depth_clear = (uint32_t)(0xffffffff * depth);
break;
default:
debug_assert(0);
break;
}
switch (fd_pipe2depth(fb->zsbuf->format)) {
case DEPTHX_24_8:
clear_mask = ((buffers & PIPE_CLEAR_DEPTH) ? 0xe : 0) |
((buffers & PIPE_CLEAR_STENCIL) ? 0x1 : 0);
depth_clear = (((uint32_t)(0xffffff * depth)) << 8) |
(stencil & 0xff);
break;
case DEPTHX_16:
clear_mask = 0xf;
depth_clear = (uint32_t)(0xffffffff * depth);
break;
default:
unreachable("invalid depth");
break;
}
OUT_PKT3(ring, CP_SET_CONSTANT, 2);