AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

amd/vpelib: VPE Events

Browse Source 
[WHY]
For further debugging need to know about the build cmd variables.

[HOW]
Added these input and output paramaters to vpe events.

Acked-by: Chuanyu Tseng <Chuanyu.Tseng@amd.com>
Signed-off-by: Muhammad Ansari <Muhammad.Ansari@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36809>
This commit is contained in:
Ansari, Muhammad
2025-08-01 17:03:11 -04:00
committed by ChuanYu Tseng (Max)
parent a486404e4d
commit c26cf7f74d
2 changed files with 45 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/amd/vpelib/inc/vpe_types.h
+8 -7
View File
@@ -106,13 +106,14 @@ enum vpe_status {
* emitted must by synchronized with handler
*/
enum vpe_event_id {
VPE_EVENT_CHECK_SUPPORT, /**< Event emitted by vpe_check_support.
Params:
UInt32 num_streams,
UInt32 target_rect.width,
UInt32 target_rect.height,
UInt32 target_rect.height
*/
VPE_EVENT_CHECK_SUPPORT, /**< Event emitted by vpe_check_support.
Params:
UInt32 num_streams,
UInt32 target_rect.width,
UInt32 target_rect.height,
UInt32 target_rect.height */
VPE_EVENT_PLANE_DESC_INPUT, /**< Event emitted by vpe_plane_desc_input */
VPE_EVENT_PLANE_DESC_OUTPUT, /**< Event emitted by vpe_plane_desc_output */
VPE_EVENT_MAX_ID /**< Max ID represents the number of event IDs supported */
};
src/amd/vpelib/src/chip/vpe10/vpe10_cmd_builder.c
+37 -1
View File
@@ -29,6 +29,9 @@
#include "vpe10_plane_desc_writer.h"
#include "vpe10_cmd_builder.h"
#define LOG_INPUT_PLANE 1
#define LOG_OUTPUT_PLANE 0
/***** Internal helpers *****/
static void get_np_and_subop(struct vpe_priv *vpe_priv, struct vpe_cmd_info *cmd_info,
struct vpe10_plane_desc_header *header);
@@ -36,6 +39,10 @@ static void get_np_and_subop(struct vpe_priv *vpe_priv, struct vpe_cmd_info *cmd
static enum VPE_PLANE_CFG_ELEMENT_SIZE vpe_get_element_size(
enum vpe_surface_pixel_format format, int plane_idx);
static void log_plane_desc_event(struct vpe_priv *vpe_priv, struct vpe_cmd_info *cmd_info,
struct vpe10_plane_desc_header *header, struct vpe10_plane_desc_src *src,
struct vpe10_plane_desc_dst *dst, uint32_t cmd_idx, uint32_t plane_idx, bool input_flag);
void vpe10_construct_cmd_builder(struct vpe_priv *vpe_priv, struct cmd_builder *builder)
{
builder->build_noops = vpe10_build_noops;
@@ -259,6 +266,8 @@ enum vpe_status vpe10_build_plane_descriptor(
src.elem_size = (uint8_t)(vpe_get_element_size(surface_info->format, 0));
plane_desc_writer->add_source(&vpe_priv->plane_desc_writer, &src, true);
// log input event - plane0
log_plane_desc_event(vpe_priv, cmd_info, &header, &src, &dst, cmd_idx, 0, LOG_INPUT_PLANE);
if (vpe_is_dual_plane_format(surface_info->format)) {
addrloc = &surface_info->address.video_progressive.chroma_addr;
@@ -273,6 +282,9 @@ enum vpe_status vpe10_build_plane_descriptor(
src.elem_size = (uint8_t)(vpe_get_element_size(surface_info->format, 1));
plane_desc_writer->add_source(&vpe_priv->plane_desc_writer, &src, false);
// log input event - plane1
log_plane_desc_event(
vpe_priv, cmd_info, &header, &src, &dst, cmd_idx, 1, LOG_INPUT_PLANE);
}
} else {
addrloc = &surface_info->address.grph.addr;
@@ -287,8 +299,9 @@ enum vpe_status vpe10_build_plane_descriptor(
src.elem_size = (uint8_t)(vpe_get_element_size(surface_info->format, 0));
plane_desc_writer->add_source(&vpe_priv->plane_desc_writer, &src, true);
// log input event - plane0
log_plane_desc_event(vpe_priv, cmd_info, &header, &src, &dst, cmd_idx, 0, LOG_INPUT_PLANE);
}
surface_info = &vpe_priv->output_ctx.surface;
VPE_ASSERT(surface_info->address.type == VPE_PLN_ADDR_TYPE_GRAPHICS);
@@ -314,9 +327,32 @@ enum vpe_status vpe10_build_plane_descriptor(
plane_desc_writer->add_destination(&vpe_priv->plane_desc_writer, &dst, true);
// log output event - plane0
log_plane_desc_event(vpe_priv, cmd_info, &header, &src, &dst, cmd_idx, 0, LOG_OUTPUT_PLANE);
return vpe_priv->plane_desc_writer.status;
}
// Function logs plane descriptor information like number of planes, plane
// descriptor type, base address, pitch, viewport, swizzle, etc. to etw events
static void log_plane_desc_event(struct vpe_priv *vpe_priv, struct vpe_cmd_info *cmd_info,
struct vpe10_plane_desc_header *header, struct vpe10_plane_desc_src *src,
struct vpe10_plane_desc_dst *dst, uint32_t cmd_idx, uint32_t plane_idx, bool input_flag)
{
// check if event is for input or output plane
if (input_flag) {
vpe_event(VPE_EVENT_PLANE_DESC_INPUT, vpe_priv->pub.level,
vpe_priv->vpe_cmd_vector->num_elements, cmd_idx, cmd_info->num_inputs, 0,
(header->nps0 + 1), 0, 0, plane_idx, 0, 0, 0, src->base_addr_lo, src->base_addr_hi,
src->viewport_x, src->viewport_y, src->viewport_w, src->viewport_h, src->swizzle, 0, 0);
} else {
vpe_event(VPE_EVENT_PLANE_DESC_OUTPUT, vpe_priv->pub.level,
vpe_priv->vpe_cmd_vector->num_elements, cmd_idx, cmd_info->num_outputs, plane_idx,
(header->npd0 + 1), 0, 0, dst->base_addr_lo, dst->base_addr_hi, dst->viewport_x,
dst->viewport_y, dst->viewport_w, dst->viewport_h, dst->swizzle);
}
}
static void get_np_and_subop(struct vpe_priv *vpe_priv, struct vpe_cmd_info *cmd_info,
struct vpe10_plane_desc_header *header)
{