AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

svga: stop using pipe_surface::usage

Browse Source 
There are only 2 possible usages: render target and depth stencil.
Both can be derived from the surface format, so the flag is redundant.

And it's going away...

Reviewed-by: Brian Paul <brianp@vmware.com>
This commit is contained in:
Marek Olšák
2012-12-08 14:53:55 +01:00
parent 21b1ec69fc
commit c1f704073b
1 changed files with 7 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/gallium/drivers/svga/svga_surface.c
+7 -15
View File
@@ -191,9 +191,6 @@ svga_create_surface(struct pipe_context *pipe,
struct svga_screen *ss = svga_screen(screen);
struct svga_surface *s;
unsigned face, zslice;
/* XXX surfaces should only be used for rendering purposes nowadays */
boolean render = (surf_tmpl->usage & (PIPE_BIND_RENDER_TARGET |
PIPE_BIND_DEPTH_STENCIL)) ? TRUE : FALSE;
boolean view = FALSE;
SVGA3dSurfaceFlags flags;
SVGA3dSurfaceFormat format;
@@ -224,26 +221,21 @@ svga_create_surface(struct pipe_context *pipe,
s->base.u.tex.first_layer = surf_tmpl->u.tex.first_layer;
s->base.u.tex.last_layer = surf_tmpl->u.tex.last_layer;
if (!render) {
flags = SVGA3D_SURFACE_HINT_TEXTURE;
} else {
if (surf_tmpl->usage & PIPE_BIND_RENDER_TARGET) {
flags = SVGA3D_SURFACE_HINT_RENDERTARGET;
}
if (surf_tmpl->usage & PIPE_BIND_DEPTH_STENCIL) {
flags = SVGA3D_SURFACE_HINT_DEPTHSTENCIL;
}
if (util_format_is_depth_or_stencil(surf_tmpl->format)) {
flags = SVGA3D_SURFACE_HINT_DEPTHSTENCIL;
}
else {
flags = SVGA3D_SURFACE_HINT_RENDERTARGET;
}
format = svga_translate_format(ss, surf_tmpl->format, surf_tmpl->usage);
format = svga_translate_format(ss, surf_tmpl->format, 0);
assert(format != SVGA3D_FORMAT_INVALID);
if (svga_screen(screen)->debug.force_surface_view)
view = TRUE;
/* Currently only used for compressed textures */
if (render &&
format != svga_translate_format(ss, surf_tmpl->format, surf_tmpl->usage)) {
if (format != svga_translate_format(ss, surf_tmpl->format, 0)) {
view = TRUE;
}