AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

panfrost/job: avoid shadowing variable name

Browse Source 
Without this commit, panfrost_batch_update_access receives a parameter
called "batch", and then it uses the same name while iterating for all
batches on the current context. This can be confusing and error-prone,
so let's rename the latter.

Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38908>
This commit is contained in:
Alejandro Piñeiro
2025-12-09 18:10:20 +01:00
committed by Marge Bot
parent fecb9e0952
commit bb06af3f9b
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/gallium/drivers/panfrost/pan_job.c
View File

@@ -281,15 +281,15 @@ panfrost_batch_update_access(struct panfrost_batch *batch,
if (writes) {
unsigned i;
foreach_batch(ctx, i) {
struct panfrost_batch *batch = &ctx->batches.slots[i];
/* Skip the entry if this our batch. */
if (i == batch_idx)
continue;
struct panfrost_batch *other_batch = &ctx->batches.slots[i];
/* Submit if it's a user */
if (panfrost_batch_uses_resource(batch, rsrc))
panfrost_batch_submit(ctx, batch);
if (panfrost_batch_uses_resource(other_batch, rsrc))
panfrost_batch_submit(ctx, other_batch);
}
}
}