AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

radv/amdgpu: Remove cs_add_buffers because it's no longer necessary.

Browse Source 
This function was added because previously ACE and GFX work was
submitted separately and we needed to make sure they both use the
same BOs. Now they are part of the same submission so this
function is not necessary anymore.

Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20010>
This commit is contained in:
Timur Kristóf
2022-12-17 16:22:20 +01:00
committed by Marge Bot
parent 97d3377b56
commit b8e4cc73bf
3 changed files with 0 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/amd/vulkan/radv_cmd_buffer.c
-1
View File
@@ -754,7 +754,6 @@ radv_ace_internal_finalize(struct radv_cmd_buffer *cmd_buffer)
radeon_emit(cs, 0);
}
device->ws->cs_add_buffers(ace_cs, cmd_buffer->cs);
return device->ws->cs_finalize(ace_cs);
}
src/amd/vulkan/radv_radeon_winsys.h
-2
View File
@@ -290,8 +290,6 @@ struct radeon_winsys {
void (*cs_add_buffer)(struct radeon_cmdbuf *cs, struct radeon_winsys_bo *bo);
void (*cs_add_buffers)(struct radeon_cmdbuf *to, struct radeon_cmdbuf *from);
void (*cs_execute_secondary)(struct radeon_cmdbuf *parent, struct radeon_cmdbuf *child,
bool allow_ib2);
src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c
-17
View File
@@ -622,22 +622,6 @@ radv_amdgpu_cs_add_buffer(struct radeon_cmdbuf *_cs, struct radeon_winsys_bo *_b
radv_amdgpu_cs_add_buffer_internal(cs, bo->bo_handle, bo->priority);
}
static void
radv_amdgpu_cs_add_buffers(struct radeon_cmdbuf *_to, struct radeon_cmdbuf *_from)
{
struct radv_amdgpu_cs *from = radv_amdgpu_cs(_from);
struct radv_amdgpu_cs *to = radv_amdgpu_cs(_to);
for (unsigned i = 0; i < from->num_buffers; ++i) {
radv_amdgpu_cs_add_buffer_internal(to, from->handles[i].bo_handle,
from->handles[i].bo_priority);
}
for (unsigned i = 0; i < from->num_virtual_buffers; ++i) {
radv_amdgpu_cs_add_buffer(&to->base, from->virtual_buffers[i]);
}
}
static void
radv_amdgpu_cs_execute_secondary(struct radeon_cmdbuf *_parent, struct radeon_cmdbuf *_child,
bool allow_ib2)
@@ -1891,7 +1875,6 @@ radv_amdgpu_cs_init_functions(struct radv_amdgpu_winsys *ws)
ws->base.cs_finalize = radv_amdgpu_cs_finalize;
ws->base.cs_reset = radv_amdgpu_cs_reset;
ws->base.cs_add_buffer = radv_amdgpu_cs_add_buffer;
ws->base.cs_add_buffers = radv_amdgpu_cs_add_buffers;
ws->base.cs_execute_secondary = radv_amdgpu_cs_execute_secondary;
ws->base.cs_submit = radv_amdgpu_winsys_cs_submit;
ws->base.cs_dump = radv_amdgpu_winsys_cs_dump;